From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: Pavel Begunkov <asml.silence@gmail.com>, linux-block@vger.kernel.org
Subject: [PATCH 1/4] blk-mq: only flush requests from the plug in blk_mq_submit_bio
Date: Wed, 20 Oct 2021 16:41:16 +0200 [thread overview]
Message-ID: <20211020144119.142582-2-hch@lst.de> (raw)
In-Reply-To: <20211020144119.142582-1-hch@lst.de>
Replace the call to blk_flush_plug_list in blk_mq_submit_bio with a
direct call to blk_mq_flush_plug_list. This means we do not flush
plug callback from stackable devices, which doesn't really help with
the accumulated requests anyway, and it also means the cached requests
aren't freed here as they can still be used later on.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
block/blk-mq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/blk-mq.c b/block/blk-mq.c
index 31d9e612d2360..9bb6ece419a5b 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -2571,7 +2571,7 @@ void blk_mq_submit_bio(struct bio *bio)
}
if (request_count >= blk_plug_max_rq_count(plug) || last) {
- blk_flush_plug_list(plug, false);
+ blk_mq_flush_plug_list(plug, false);
trace_block_plug(q);
}
--
2.30.2
next prev parent reply other threads:[~2021-10-20 14:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-20 14:41 cleanup and optimize block plug handling Christoph Hellwig
2021-10-20 14:41 ` Christoph Hellwig [this message]
2021-10-20 14:41 ` [PATCH 2/4] blk-mq: move blk_mq_flush_plug_list to block/blk-mq.h Christoph Hellwig
2021-10-20 14:41 ` [PATCH 3/4] block: optimise blk_flush_plug_list Christoph Hellwig
2021-10-20 14:41 ` [PATCH 4/4] block: cleanup the flush plug helpers Christoph Hellwig
2021-10-22 20:09 ` Nathan Chancellor
2021-10-23 1:38 ` Jens Axboe
2021-10-20 16:10 ` cleanup and optimize block plug handling Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211020144119.142582-2-hch@lst.de \
--to=hch@lst.de \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.