All of lore.kernel.org
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org
Subject: [PATCH v0 04/42] clk: renesas: Check notifier registration return value
Date: Mon,  8 Nov 2021 11:11:19 +0100	[thread overview]
Message-ID: <20211108101157.15189-5-bp@alien8.de> (raw)
In-Reply-To: <20211108101157.15189-1-bp@alien8.de>

From: Borislav Petkov <bp@suse.de>

Avoid homegrown notifier registration checks.

No functional changes.

Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: linux-renesas-soc@vger.kernel.org
Cc: linux-clk@vger.kernel.org
---
 drivers/clk/renesas/clk-div6.c     | 4 +++-
 drivers/clk/renesas/rcar-cpg-lib.c | 4 +++-
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/renesas/clk-div6.c b/drivers/clk/renesas/clk-div6.c
index 3abd6e5400ad..7d89ca01889a 100644
--- a/drivers/clk/renesas/clk-div6.c
+++ b/drivers/clk/renesas/clk-div6.c
@@ -306,7 +306,9 @@ struct clk * __init cpg_div6_register(const char *name,
 
 	if (notifiers) {
 		clock->nb.notifier_call = cpg_div6_clock_notifier_call;
-		raw_notifier_chain_register(notifiers, &clock->nb);
+
+		if (raw_notifier_chain_register(notifiers, &clock->nb))
+			pr_warn("CPG DIV6 clock notifier already registered\n");
 	}
 
 	return clk;
diff --git a/drivers/clk/renesas/rcar-cpg-lib.c b/drivers/clk/renesas/rcar-cpg-lib.c
index e93f0011eb07..fbbb6f4a8148 100644
--- a/drivers/clk/renesas/rcar-cpg-lib.c
+++ b/drivers/clk/renesas/rcar-cpg-lib.c
@@ -59,7 +59,9 @@ void cpg_simple_notifier_register(struct raw_notifier_head *notifiers,
 				  struct cpg_simple_notifier *csn)
 {
 	csn->nb.notifier_call = cpg_simple_notifier_call;
-	raw_notifier_chain_register(notifiers, &csn->nb);
+
+	if (raw_notifier_chain_register(notifiers, &csn->nb))
+		pr_warn("CPG notifier already registered\n");
 }
 
 /*
-- 
2.29.2


  parent reply	other threads:[~2021-11-08 10:13 UTC|newest]

Thread overview: 151+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-08 10:11 [PATCH v0 00/42] notifiers: Return an error when callback is already registered Borislav Petkov
2021-11-08 10:11 ` [PATCH v0 01/42] x86: Check notifier registration return value Borislav Petkov
2021-11-08 10:11 ` [PATCH v0 02/42] xen/x86: " Borislav Petkov
2021-11-08 10:11 ` [PATCH v0 03/42] impi: " Borislav Petkov
2021-11-08 10:11 ` Borislav Petkov [this message]
2021-11-08 14:12   ` [PATCH v0 04/42] clk: renesas: " Geert Uytterhoeven
2021-11-08 10:11 ` [PATCH v0 05/42] dca: " Borislav Petkov
2021-11-08 10:11 ` [PATCH v0 06/42] firmware: " Borislav Petkov
2021-11-08 10:11   ` Borislav Petkov
2021-11-12 18:43   ` Cristian Marussi
2021-11-12 18:43     ` Cristian Marussi
2021-11-08 10:11 ` [PATCH v0 07/42] drm/i915: " Borislav Petkov
2021-11-08 10:11   ` [Intel-gfx] " Borislav Petkov
2021-11-08 10:11 ` [PATCH v0 08/42] Drivers: hv: vmbus: " Borislav Petkov
2021-11-08 11:16   ` Wei Liu
2021-11-08 11:39     ` Borislav Petkov
2021-11-08 11:45       ` Wei Liu
2021-11-08 12:08         ` Borislav Petkov
2021-11-08 10:11 ` [PATCH v0 09/42] iio: proximity: cros_ec: " Borislav Petkov
2021-11-08 10:11 ` [PATCH v0 10/42] leds: trigger: " Borislav Petkov
2021-11-08 10:11 ` [PATCH v0 11/42] misc: " Borislav Petkov
2021-11-08 10:11 ` [PATCH v0 12/42] ethernet: chelsio: " Borislav Petkov
2021-11-08 10:11 ` [PATCH v0 13/42] power: reset: " Borislav Petkov
2021-11-08 10:11 ` [PATCH v0 14/42] remoteproc: " Borislav Petkov
2021-11-08 10:11 ` [PATCH v0 15/42] scsi: target: " Borislav Petkov
2021-11-08 10:11 ` [PATCH v0 16/42] USB: " Borislav Petkov
2021-11-08 14:05   ` Alan Stern
2021-11-08 14:09     ` Borislav Petkov
2021-11-08 10:11 ` [PATCH v0 17/42] drivers: video: " Borislav Petkov
2021-11-08 11:16   ` Wei Liu
2021-11-08 10:11 ` [PATCH v0 18/42] drivers/xen: " Borislav Petkov
2021-11-08 10:11 ` [PATCH v0 19/42] kernel/hung_task: " Borislav Petkov
2021-11-08 10:11 ` [PATCH v0 20/42] rcu: " Borislav Petkov
2021-11-08 16:53   ` Paul E. McKenney
2021-11-08 10:11 ` [PATCH v0 21/42] tracing: " Borislav Petkov
2021-11-08 10:11 ` [PATCH v0 22/42] net: fib_notifier: " Borislav Petkov
2021-11-08 10:11 ` [PATCH v0 23/42] ASoC: soc-jack: " Borislav Petkov
2021-11-08 10:11 ` [PATCH v0 24/42] staging: olpc_dcon: " Borislav Petkov
2021-11-08 10:11 ` [PATCH v0 25/42] arch/um: " Borislav Petkov
2021-11-08 10:11   ` Borislav Petkov
2021-11-08 10:23   ` Johannes Berg
2021-11-08 10:23     ` Johannes Berg
2021-11-08 10:48     ` Borislav Petkov
2021-11-08 10:48       ` Borislav Petkov
2021-11-08 10:56       ` Johannes Berg
2021-11-08 10:56         ` Johannes Berg
2021-11-08 10:11 ` [PATCH v0 26/42] alpha: " Borislav Petkov
2021-11-08 10:11 ` [PATCH v0 27/42] bus: brcmstb_gisb: " Borislav Petkov
2021-11-08 10:11 ` [PATCH v0 28/42] soc: bcm: brcmstb: pm: pm-arm: " Borislav Petkov
2021-11-08 10:11 ` [PATCH v0 29/42] arm64: " Borislav Petkov
2021-11-08 10:11   ` Borislav Petkov
2021-11-08 10:11 ` [PATCH v0 30/42] soc/tegra: " Borislav Petkov
2021-11-08 10:11 ` [PATCH v0 31/42] parisc: " Borislav Petkov
2021-11-08 10:11 ` [PATCH v0 32/42] macintosh/adb: " Borislav Petkov
2021-11-08 10:11   ` Borislav Petkov
2021-11-08 10:11 ` [PATCH v0 33/42] mips: " Borislav Petkov
2021-11-08 10:11 ` [PATCH v0 34/42] powerpc: " Borislav Petkov
2021-11-08 10:11 ` [PATCH v0 35/42] sh: " Borislav Petkov
2021-11-08 13:31   ` Geert Uytterhoeven
2021-11-08 13:49     ` Borislav Petkov
2021-11-08 14:03       ` Geert Uytterhoeven
2021-11-08 14:48   ` Sergey Shtylyov
2021-11-08 10:11 ` [PATCH v0 36/42] s390: " Borislav Petkov
2021-11-08 10:11 ` [PATCH v0 37/42] sparc: " Borislav Petkov
2021-11-08 19:59   ` David Miller
2021-11-08 10:11 ` [PATCH v0 38/42] xtensa: " Borislav Petkov
2021-11-08 10:11 ` [PATCH v0 39/42] crypto: ccree - check " Borislav Petkov
2021-11-12 18:32   ` Cristian Marussi
2021-11-12 18:48     ` Borislav Petkov
2021-11-08 10:11 ` [PATCH v0 40/42] EDAC/altera: Check " Borislav Petkov
2021-11-08 10:11 ` [PATCH v0 41/42] power: supply: ab8500: " Borislav Petkov
2021-11-08 10:11 ` [PATCH v0 42/42] notifier: Return an error when callback is already registered Borislav Petkov
2021-11-08 10:11   ` Borislav Petkov
2021-11-08 10:11   ` Borislav Petkov
2021-11-08 10:11   ` Borislav Petkov
2021-11-08 10:11   ` [Intel-gfx] " Borislav Petkov
2021-11-08 10:11   ` Borislav Petkov
2021-11-08 14:07   ` Geert Uytterhoeven
2021-11-08 14:07     ` Geert Uytterhoeven
2021-11-08 14:07     ` Geert Uytterhoeven
2021-11-08 14:07     ` [Intel-gfx] " Geert Uytterhoeven
2021-11-08 14:07     ` Geert Uytterhoeven
2021-11-08 14:21     ` Borislav Petkov
2021-11-08 14:21       ` Borislav Petkov
2021-11-08 14:21       ` Borislav Petkov
2021-11-08 14:21       ` [Intel-gfx] " Borislav Petkov
2021-11-08 14:21       ` Borislav Petkov
2021-11-08 15:25       ` Geert Uytterhoeven
2021-11-08 15:25         ` Geert Uytterhoeven
2021-11-08 15:25         ` Geert Uytterhoeven
2021-11-08 15:25         ` Geert Uytterhoeven
2021-11-08 15:25         ` [Intel-gfx] " Geert Uytterhoeven
2021-11-08 15:58         ` Borislav Petkov
2021-11-08 15:58           ` Borislav Petkov
2021-11-08 15:58           ` Borislav Petkov
2021-11-08 15:58           ` [Intel-gfx] " Borislav Petkov
2021-11-08 15:58           ` Borislav Petkov
2021-11-08 16:12           ` Geert Uytterhoeven
2021-11-08 16:12             ` Geert Uytterhoeven
2021-11-08 16:12             ` Geert Uytterhoeven
2021-11-08 16:12             ` [Intel-gfx] " Geert Uytterhoeven
2021-11-08 16:12             ` Geert Uytterhoeven
2021-11-08 16:21             ` Borislav Petkov
2021-11-08 16:21               ` Borislav Petkov
2021-11-08 16:21               ` Borislav Petkov
2021-11-08 16:21               ` Borislav Petkov
2021-11-08 16:21               ` [Intel-gfx] " Borislav Petkov
2021-11-08 20:59               ` Alan Stern
2021-11-08 20:59                 ` Alan Stern
2021-11-08 20:59                 ` Alan Stern
2021-11-08 20:59                 ` Alan Stern
2021-11-08 20:59                 ` [Intel-gfx] " Alan Stern
2021-11-08 20:59                 ` Alan Stern
2021-11-08 21:18                 ` [Intel-gfx] " Borislav Petkov
2021-11-08 21:18                   ` Borislav Petkov
2021-11-08 21:18                   ` Borislav Petkov
2021-11-08 21:18                   ` Borislav Petkov
2021-11-08 21:18                   ` Borislav Petkov
2021-11-08 10:19 ` [PATCH v0 00/42] notifiers: " Borislav Petkov
2021-11-08 10:19   ` Borislav Petkov
2021-11-08 10:19   ` Borislav Petkov
2021-11-08 10:19   ` Borislav Petkov
2021-11-08 10:19   ` Borislav Petkov
2021-11-08 10:19   ` [Intel-gfx] " Borislav Petkov
2021-11-08 14:17   ` Alan Stern
2021-11-08 14:17     ` Alan Stern
2021-11-08 14:17     ` Alan Stern
2021-11-08 14:17     ` Alan Stern
2021-11-08 14:17     ` [Intel-gfx] " Alan Stern
2021-11-08 14:17     ` Alan Stern
2021-11-08 14:24     ` Borislav Petkov
2021-11-08 14:24       ` Borislav Petkov
2021-11-08 14:24       ` Borislav Petkov
2021-11-08 14:24       ` Borislav Petkov
2021-11-08 14:24       ` [Intel-gfx] " Borislav Petkov
2021-11-08 14:24       ` Borislav Petkov
2021-11-08 14:35       ` Borislav Petkov
2021-11-08 14:35         ` Borislav Petkov
2021-11-08 14:35         ` Borislav Petkov
2021-11-08 14:35         ` [Intel-gfx] " Borislav Petkov
2021-11-08 14:35         ` Borislav Petkov
2021-11-08 16:23         ` Steven Rostedt
2021-11-08 16:23           ` Steven Rostedt
2021-11-08 16:23           ` Steven Rostedt
2021-11-08 16:23           ` [Intel-gfx] " Steven Rostedt
2021-11-08 16:23           ` Steven Rostedt
2021-11-08 16:29           ` Borislav Petkov
2021-11-08 16:29             ` Borislav Petkov
2021-11-08 16:29             ` Borislav Petkov
2021-11-08 16:29             ` [Intel-gfx] " Borislav Petkov
2021-11-08 16:29             ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211108101157.15189-5-bp@alien8.de \
    --to=bp@alien8.de \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.