From: Mark Rutland <mark.rutland@arm.com> To: linux-arm-kernel@lists.infradead.org Cc: ardb@kernel.org, catalin.marinas@arm.com, frederic@kernel.org, juri.lelli@redhat.com, linux-kernel@vger.kernel.org, mark.rutland@arm.com, mingo@redhat.com, peterz@infradead.org, will@kernel.org Subject: [PATCH 0/6] arm64 / sched/preempt: support PREEMPT_DYNAMIC with static keys Date: Tue, 9 Nov 2021 17:24:02 +0000 [thread overview] Message-ID: <20211109172408.49641-1-mark.rutland@arm.com> (raw) This series enables PREEMPT_DYNAMIC on arm64, offering an alternative approach to other efforts which rely on enabling static_calls, e.g. as Ard is currently attempting: https://lore.kernel.org/linux-arm-kernel/20211105145917.2828911-1-ardb@kernel.org/ For a number of reasons (laid out in grauitous detail in patch 5), static calls are somewhat painful on arm64. For PREEMPT_DYNAMIC specifically where we're only enabling/disabling functions rather than targetting multiple distinct callees, (non-inline) static calls don't buy us much over placing early returns in the preemption functions, which this series implements using static keys. The first 4 patches are largely cleanup, and I think might make sense on their own. Patch 3 specifically change the behaviour on x86 where I believe there's simply an oversight, called out in the commit message. I think the diffstate can be reduced a bit by with some helper macros to reduce amount of boilerplate needed for the callees. There's also some room for cleanup of the existing preempt logic to require less arch code (other than where x86 has to override that today). I've given this very light build+boot testing so far. Thanks, Mark. Mark Rutland (6): sched/preempt: move PREEMPT_DYNAMIC logic later sched/preempt: refactor sched_dynamic_update() sched/preempt: simplify irqentry_exit_cond_resched() callers sched/preempt: decouple HAVE_PREEMPT_DYNAMIC from GENERIC_ENTRY sched/preempt: add PREEMPT_DYNAMIC using static keys arm64: support PREEMPT_DYNAMIC arch/Kconfig | 14 +- arch/arm64/Kconfig | 1 + arch/arm64/include/asm/preempt.h | 16 +- arch/arm64/kernel/entry-common.c | 9 + arch/x86/Kconfig | 2 +- arch/x86/include/asm/preempt.h | 10 +- include/linux/entry-common.h | 15 +- include/linux/kernel.h | 7 +- include/linux/sched.h | 10 +- kernel/entry/common.c | 22 ++- kernel/sched/core.c | 347 +++++++++++++++++++++++---------------- 11 files changed, 293 insertions(+), 160 deletions(-) -- 2.11.0
WARNING: multiple messages have this Message-ID (diff)
From: Mark Rutland <mark.rutland@arm.com> To: linux-arm-kernel@lists.infradead.org Cc: ardb@kernel.org, catalin.marinas@arm.com, frederic@kernel.org, juri.lelli@redhat.com, linux-kernel@vger.kernel.org, mark.rutland@arm.com, mingo@redhat.com, peterz@infradead.org, will@kernel.org Subject: [PATCH 0/6] arm64 / sched/preempt: support PREEMPT_DYNAMIC with static keys Date: Tue, 9 Nov 2021 17:24:02 +0000 [thread overview] Message-ID: <20211109172408.49641-1-mark.rutland@arm.com> (raw) This series enables PREEMPT_DYNAMIC on arm64, offering an alternative approach to other efforts which rely on enabling static_calls, e.g. as Ard is currently attempting: https://lore.kernel.org/linux-arm-kernel/20211105145917.2828911-1-ardb@kernel.org/ For a number of reasons (laid out in grauitous detail in patch 5), static calls are somewhat painful on arm64. For PREEMPT_DYNAMIC specifically where we're only enabling/disabling functions rather than targetting multiple distinct callees, (non-inline) static calls don't buy us much over placing early returns in the preemption functions, which this series implements using static keys. The first 4 patches are largely cleanup, and I think might make sense on their own. Patch 3 specifically change the behaviour on x86 where I believe there's simply an oversight, called out in the commit message. I think the diffstate can be reduced a bit by with some helper macros to reduce amount of boilerplate needed for the callees. There's also some room for cleanup of the existing preempt logic to require less arch code (other than where x86 has to override that today). I've given this very light build+boot testing so far. Thanks, Mark. Mark Rutland (6): sched/preempt: move PREEMPT_DYNAMIC logic later sched/preempt: refactor sched_dynamic_update() sched/preempt: simplify irqentry_exit_cond_resched() callers sched/preempt: decouple HAVE_PREEMPT_DYNAMIC from GENERIC_ENTRY sched/preempt: add PREEMPT_DYNAMIC using static keys arm64: support PREEMPT_DYNAMIC arch/Kconfig | 14 +- arch/arm64/Kconfig | 1 + arch/arm64/include/asm/preempt.h | 16 +- arch/arm64/kernel/entry-common.c | 9 + arch/x86/Kconfig | 2 +- arch/x86/include/asm/preempt.h | 10 +- include/linux/entry-common.h | 15 +- include/linux/kernel.h | 7 +- include/linux/sched.h | 10 +- kernel/entry/common.c | 22 ++- kernel/sched/core.c | 347 +++++++++++++++++++++++---------------- 11 files changed, 293 insertions(+), 160 deletions(-) -- 2.11.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2021-11-09 17:24 UTC|newest] Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-11-09 17:24 Mark Rutland [this message] 2021-11-09 17:24 ` [PATCH 0/6] arm64 / sched/preempt: support PREEMPT_DYNAMIC with static keys Mark Rutland 2021-11-09 17:24 ` [PATCH 1/6] sched/preempt: move PREEMPT_DYNAMIC logic later Mark Rutland 2021-11-09 17:24 ` Mark Rutland 2021-11-09 17:24 ` [PATCH 2/6] sched/preempt: refactor sched_dynamic_update() Mark Rutland 2021-11-09 17:24 ` Mark Rutland 2021-12-10 15:13 ` Frederic Weisbecker 2021-12-10 15:13 ` Frederic Weisbecker 2022-02-02 15:13 ` Mark Rutland 2022-02-02 15:13 ` Mark Rutland 2022-02-02 16:01 ` Frederic Weisbecker 2022-02-02 16:01 ` Frederic Weisbecker 2022-02-02 18:08 ` Mark Rutland 2022-02-02 18:08 ` Mark Rutland 2022-02-03 11:52 ` Frederic Weisbecker 2022-02-03 11:52 ` Frederic Weisbecker 2021-11-09 17:24 ` [PATCH 3/6] sched/preempt: simplify irqentry_exit_cond_resched() callers Mark Rutland 2021-11-09 17:24 ` Mark Rutland 2021-11-09 17:24 ` [PATCH 4/6] sched/preempt: decouple HAVE_PREEMPT_DYNAMIC from GENERIC_ENTRY Mark Rutland 2021-11-09 17:24 ` Mark Rutland 2021-11-09 17:24 ` [PATCH 5/6] sched/preempt: add PREEMPT_DYNAMIC using static keys Mark Rutland 2021-11-09 17:24 ` Mark Rutland 2021-12-13 22:05 ` Frederic Weisbecker 2021-12-13 22:05 ` Frederic Weisbecker 2022-02-02 15:29 ` Mark Rutland 2022-02-02 15:29 ` Mark Rutland 2022-02-03 22:40 ` Peter Zijlstra 2022-02-03 22:40 ` Peter Zijlstra 2022-02-02 23:21 ` Frederic Weisbecker 2022-02-02 23:21 ` Frederic Weisbecker 2022-02-03 9:51 ` Mark Rutland 2022-02-03 9:51 ` Mark Rutland 2022-02-03 11:34 ` Frederic Weisbecker 2022-02-03 11:34 ` Frederic Weisbecker 2022-02-03 12:27 ` Mark Rutland 2022-02-03 12:27 ` Mark Rutland 2021-11-09 17:24 ` [PATCH 6/6] arm64: support PREEMPT_DYNAMIC Mark Rutland 2021-11-09 17:24 ` Mark Rutland
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211109172408.49641-1-mark.rutland@arm.com \ --to=mark.rutland@arm.com \ --cc=ardb@kernel.org \ --cc=catalin.marinas@arm.com \ --cc=frederic@kernel.org \ --cc=juri.lelli@redhat.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mingo@redhat.com \ --cc=peterz@infradead.org \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.