All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ameer Hamza <amhamza.mgc@gmail.com>
To: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz,
	tiwai@suse.com, kuninori.morimoto.gx@renesas.com,
	alsa-devel@alsa-project.org
Cc: linux-kernel@vger.kernel.org, amhamza.mgc@gmail.com
Subject: [PATCH] ASoC: test-component: fix null pointer dereference.
Date: Mon,  6 Dec 2021 01:42:00 +0500	[thread overview]
Message-ID: <20211205204200.7852-1-amhamza.mgc@gmail.com> (raw)

Dereferncing of_id pointer will result in exception in current
implementation since of_match_device() will assign it to NULL.
Adding NULL check for protection.

Signed-off-by: Ameer Hamza <amhamza.mgc@gmail.com>
---
 sound/soc/generic/test-component.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/sound/soc/generic/test-component.c b/sound/soc/generic/test-component.c
index 85385a771d80..8fc97d3ff011 100644
--- a/sound/soc/generic/test-component.c
+++ b/sound/soc/generic/test-component.c
@@ -532,13 +532,16 @@ static int test_driver_probe(struct platform_device *pdev)
 	struct device_node *node = dev->of_node;
 	struct device_node *ep;
 	const struct of_device_id *of_id = of_match_device(test_of_match, &pdev->dev);
-	const struct test_adata *adata = of_id->data;
+	const struct test_adata *adata;
 	struct snd_soc_component_driver *cdriv;
 	struct snd_soc_dai_driver *ddriv;
 	struct test_dai_name *dname;
 	struct test_priv *priv;
 	int num, ret, i;
 
+	if (!of_id)
+		return -EINVAL;
+	adata = of_id->data;
 	num = of_graph_get_endpoint_count(node);
 	if (!num) {
 		dev_err(dev, "no port exits\n");
-- 
2.25.1


WARNING: multiple messages have this Message-ID (diff)
From: Ameer Hamza <amhamza.mgc@gmail.com>
To: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz,
	tiwai@suse.com, kuninori.morimoto.gx@renesas.com,
	alsa-devel@alsa-project.org
Cc: amhamza.mgc@gmail.com, linux-kernel@vger.kernel.org
Subject: [PATCH] ASoC: test-component: fix null pointer dereference.
Date: Mon,  6 Dec 2021 01:42:00 +0500	[thread overview]
Message-ID: <20211205204200.7852-1-amhamza.mgc@gmail.com> (raw)

Dereferncing of_id pointer will result in exception in current
implementation since of_match_device() will assign it to NULL.
Adding NULL check for protection.

Signed-off-by: Ameer Hamza <amhamza.mgc@gmail.com>
---
 sound/soc/generic/test-component.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/sound/soc/generic/test-component.c b/sound/soc/generic/test-component.c
index 85385a771d80..8fc97d3ff011 100644
--- a/sound/soc/generic/test-component.c
+++ b/sound/soc/generic/test-component.c
@@ -532,13 +532,16 @@ static int test_driver_probe(struct platform_device *pdev)
 	struct device_node *node = dev->of_node;
 	struct device_node *ep;
 	const struct of_device_id *of_id = of_match_device(test_of_match, &pdev->dev);
-	const struct test_adata *adata = of_id->data;
+	const struct test_adata *adata;
 	struct snd_soc_component_driver *cdriv;
 	struct snd_soc_dai_driver *ddriv;
 	struct test_dai_name *dname;
 	struct test_priv *priv;
 	int num, ret, i;
 
+	if (!of_id)
+		return -EINVAL;
+	adata = of_id->data;
 	num = of_graph_get_endpoint_count(node);
 	if (!num) {
 		dev_err(dev, "no port exits\n");
-- 
2.25.1


             reply	other threads:[~2021-12-05 20:42 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-05 20:42 Ameer Hamza [this message]
2021-12-05 20:42 ` [PATCH] ASoC: test-component: fix null pointer dereference Ameer Hamza
2021-12-05 22:40 ` Kuninori Morimoto
2021-12-06  9:29   ` Ameer Hamza
2021-12-06  9:29     ` Ameer Hamza
2021-12-06 23:19     ` Kuninori Morimoto
2021-12-06 23:19       ` Kuninori Morimoto
2021-12-07  8:15       ` Ameer Hamza
2021-12-07  8:15         ` Ameer Hamza
2021-12-07 12:51         ` Mark Brown
2021-12-07 12:51           ` Mark Brown
2021-12-07 14:23           ` [PATCH v2] " Ameer Hamza
2021-12-07 14:23             ` Ameer Hamza
2021-12-08  0:05             ` Kuninori Morimoto
2021-12-08 12:05               ` Ameer Hamza
2021-12-08 12:05                 ` Ameer Hamza
2021-12-08 12:36                 ` [PATCH] ASoC: test-component: replace of_match_device() to of_device_get_match_data() Ameer Hamza
2021-12-08 12:36                   ` Ameer Hamza
2021-12-08 12:40                   ` Ameer Hamza
2021-12-08 12:40                     ` Ameer Hamza
2021-12-08 22:40                   ` Kuninori Morimoto
2021-12-08 22:40                     ` Kuninori Morimoto
2021-12-09 13:45             ` [PATCH v2] ASoC: test-component: fix null pointer dereference Mark Brown
2021-12-07 23:53           ` [PATCH] " Kuninori Morimoto
2021-12-07 23:53             ` Kuninori Morimoto
2021-12-06 18:00 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211205204200.7852-1-amhamza.mgc@gmail.com \
    --to=amhamza.mgc@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.