All of lore.kernel.org
 help / color / mirror / Atom feed
From: Liam Beguin <liambeguin@gmail.com>
To: liambeguin@gmail.com, peda@axentia.se, jic23@kernel.org,
	andy.shevchenko@gmail.com, lars@metafoo.de
Cc: linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
	devicetree@vger.kernel.org, robh+dt@kernel.org
Subject: [PATCH v11 02/15] iio: inkern: apply consumer scale when no channel scale is available
Date: Tue, 21 Dec 2021 22:46:33 -0500	[thread overview]
Message-ID: <20211222034646.222189-3-liambeguin@gmail.com> (raw)
In-Reply-To: <20211222034646.222189-1-liambeguin@gmail.com>

From: Liam Beguin <lvb@xiphos.com>

When a consumer calls iio_read_channel_processed() and no channel scale
is available, it's assumed that the scale is one and the raw value is
returned as expected.

On the other hand, if the consumer calls iio_convert_raw_to_processed()
the scaling factor requested by the consumer is not applied.

This for example causes the consumer to process mV when expecting uV.
Make sure to always apply the scaling factor requested by the consumer.

Fixes: adc8ec5ff183 ("iio: inkern: pass through raw values if no scaling")
Signed-off-by: Liam Beguin <lvb@xiphos.com>
Reviewed-by: Peter Rosin <peda@axentia.se>
---
 drivers/iio/inkern.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/iio/inkern.c b/drivers/iio/inkern.c
index 021e1397ffc5..dbe13fad3cbb 100644
--- a/drivers/iio/inkern.c
+++ b/drivers/iio/inkern.c
@@ -607,10 +607,10 @@ static int iio_convert_raw_to_processed_unlocked(struct iio_channel *chan,
 					IIO_CHAN_INFO_SCALE);
 	if (scale_type < 0) {
 		/*
-		 * Just pass raw values as processed if no scaling is
-		 * available.
+		 * If no channel scaling is available apply consumer scale to
+		 * raw value and return.
 		 */
-		*processed = raw;
+		*processed = raw * scale;
 		return 0;
 	}
 
-- 
2.34.0


  parent reply	other threads:[~2021-12-22  3:47 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-22  3:46 [PATCH v11 00/15] iio: afe: add temperature rescaling support Liam Beguin
2021-12-22  3:46 ` [PATCH v11 01/15] iio: inkern: apply consumer scale on IIO_VAL_INT cases Liam Beguin
2021-12-22  3:46 ` Liam Beguin [this message]
2021-12-22  3:46 ` [PATCH v11 03/15] iio: inkern: make a best effort on offset calculation Liam Beguin
2021-12-22  3:46 ` [PATCH v11 04/15] iio: afe: rescale: expose scale processing function Liam Beguin
2021-12-22 10:21   ` Andy Shevchenko
2021-12-22 18:20     ` Liam Beguin
2021-12-22 18:52       ` Andy Shevchenko
2021-12-22 19:42         ` Liam Beguin
2021-12-22 19:50           ` Andy Shevchenko
2021-12-22 20:04             ` Liam Beguin
2021-12-22  3:46 ` [PATCH v11 05/15] iio: afe: rescale: add INT_PLUS_{MICRO,NANO} support Liam Beguin
2021-12-22  3:46 ` [PATCH v11 06/15] iio: afe: rescale: add offset support Liam Beguin
2021-12-22  3:46 ` [PATCH v11 07/15] iio: afe: rescale: use s64 for temporary scale calculations Liam Beguin
2021-12-22 12:25   ` Andy Shevchenko
2021-12-22 18:21     ` Liam Beguin
2021-12-22  3:46 ` [PATCH v11 08/15] iio: afe: rescale: fix accuracy for small fractional scales Liam Beguin
2021-12-22 12:27   ` Andy Shevchenko
2021-12-22  3:46 ` [PATCH v11 09/15] iio: afe: rescale: reduce risk of integer overflow Liam Beguin
2021-12-22 12:29   ` Andy Shevchenko
2021-12-22 18:38     ` Liam Beguin
2021-12-22 18:56       ` Andy Shevchenko
2021-12-22 19:58         ` Liam Beguin
2021-12-22 21:32           ` Andy Shevchenko
2022-01-08 16:34             ` Liam Beguin
2022-01-08 17:55               ` Andy Shevchenko
2021-12-22  3:46 ` [PATCH v11 10/15] iio: afe: rescale: make use of units.h Liam Beguin
2021-12-22 12:33   ` Andy Shevchenko
2021-12-22 18:50     ` Liam Beguin
2021-12-22 18:59       ` Andy Shevchenko
2021-12-22  3:46 ` [PATCH v11 11/15] iio: test: add basic tests for the iio-rescale driver Liam Beguin
2021-12-22 12:38   ` Andy Shevchenko
2021-12-22 19:13     ` Liam Beguin
2021-12-22  3:46 ` [PATCH v11 12/15] iio: afe: rescale: add RTD temperature sensor support Liam Beguin
2021-12-22  3:46 ` [PATCH v11 13/15] iio: afe: rescale: add temperature transducers Liam Beguin
2021-12-22 12:40   ` Andy Shevchenko
2021-12-22  3:46 ` [PATCH v11 14/15] dt-bindings: iio: afe: add bindings for temperature-sense-rtd Liam Beguin
2021-12-22  3:46 ` [PATCH v11 15/15] dt-bindings: iio: afe: add bindings for temperature transducers Liam Beguin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211222034646.222189-3-liambeguin@gmail.com \
    --to=liambeguin@gmail.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peda@axentia.se \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.