All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anup Patel <anup@brainfault.org>
To: Peter Maydell <peter.maydell@linaro.org>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Alistair Francis <Alistair.Francis@wdc.com>,
	Sagar Karandikar <sagark@eecs.berkeley.edu>
Cc: qemu-riscv@nongnu.org, Frank Chang <frank.chang@sifive.com>,
	Anup Patel <anup@brainfault.org>,
	qemu-devel@nongnu.org,
	Alistair Francis <alistair.francis@wdc.com>,
	Atish Patra <atishp@atishpatra.org>,
	Bin Meng <bmeng.cn@gmail.com>
Subject: [PATCH v9 05/23] target/riscv: Allow setting CPU feature from machine/device emulation
Date: Fri,  4 Feb 2022 23:16:41 +0530	[thread overview]
Message-ID: <20220204174700.534953-6-anup@brainfault.org> (raw)
In-Reply-To: <20220204174700.534953-1-anup@brainfault.org>

From: Anup Patel <anup.patel@wdc.com>

The machine or device emulation should be able to force set certain
CPU features because:
1) We can have certain CPU features which are in-general optional
   but implemented by RISC-V CPUs on the machine.
2) We can have devices which require a certain CPU feature. For example,
   AIA IMSIC devices expect AIA CSRs implemented by RISC-V CPUs.

Signed-off-by: Anup Patel <anup.patel@wdc.com>
Signed-off-by: Anup Patel <anup@brainfault.org>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: Frank Chang <frank.chang@sifive.com>
---
 target/riscv/cpu.c | 11 +++--------
 target/riscv/cpu.h |  5 +++++
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c
index 3f9e2400bb..bf14d27bd1 100644
--- a/target/riscv/cpu.c
+++ b/target/riscv/cpu.c
@@ -135,11 +135,6 @@ static void set_vext_version(CPURISCVState *env, int vext_ver)
     env->vext_ver = vext_ver;
 }
 
-static void set_feature(CPURISCVState *env, int feature)
-{
-    env->features |= (1ULL << feature);
-}
-
 static void set_resetvec(CPURISCVState *env, target_ulong resetvec)
 {
 #ifndef CONFIG_USER_ONLY
@@ -508,18 +503,18 @@ static void riscv_cpu_realize(DeviceState *dev, Error **errp)
     }
 
     if (cpu->cfg.mmu) {
-        set_feature(env, RISCV_FEATURE_MMU);
+        riscv_set_feature(env, RISCV_FEATURE_MMU);
     }
 
     if (cpu->cfg.pmp) {
-        set_feature(env, RISCV_FEATURE_PMP);
+        riscv_set_feature(env, RISCV_FEATURE_PMP);
 
         /*
          * Enhanced PMP should only be available
          * on harts with PMP support
          */
         if (cpu->cfg.epmp) {
-            set_feature(env, RISCV_FEATURE_EPMP);
+            riscv_set_feature(env, RISCV_FEATURE_EPMP);
         }
     }
 
diff --git a/target/riscv/cpu.h b/target/riscv/cpu.h
index f030cb58b2..283a3cda4b 100644
--- a/target/riscv/cpu.h
+++ b/target/riscv/cpu.h
@@ -379,6 +379,11 @@ static inline bool riscv_feature(CPURISCVState *env, int feature)
     return env->features & (1ULL << feature);
 }
 
+static inline void riscv_set_feature(CPURISCVState *env, int feature)
+{
+    env->features |= (1ULL << feature);
+}
+
 #include "cpu_user.h"
 
 extern const char * const riscv_int_regnames[];
-- 
2.25.1



WARNING: multiple messages have this Message-ID (diff)
From: Anup Patel <anup@brainfault.org>
To: Peter Maydell <peter.maydell@linaro.org>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Alistair Francis <Alistair.Francis@wdc.com>,
	Sagar Karandikar <sagark@eecs.berkeley.edu>
Cc: Atish Patra <atishp@atishpatra.org>,
	Anup Patel <anup@brainfault.org>, Bin Meng <bmeng.cn@gmail.com>,
	qemu-riscv@nongnu.org, qemu-devel@nongnu.org,
	Alistair Francis <alistair.francis@wdc.com>,
	Frank Chang <frank.chang@sifive.com>
Subject: [PATCH v9 05/23] target/riscv: Allow setting CPU feature from machine/device emulation
Date: Fri,  4 Feb 2022 23:16:41 +0530	[thread overview]
Message-ID: <20220204174700.534953-6-anup@brainfault.org> (raw)
In-Reply-To: <20220204174700.534953-1-anup@brainfault.org>

From: Anup Patel <anup.patel@wdc.com>

The machine or device emulation should be able to force set certain
CPU features because:
1) We can have certain CPU features which are in-general optional
   but implemented by RISC-V CPUs on the machine.
2) We can have devices which require a certain CPU feature. For example,
   AIA IMSIC devices expect AIA CSRs implemented by RISC-V CPUs.

Signed-off-by: Anup Patel <anup.patel@wdc.com>
Signed-off-by: Anup Patel <anup@brainfault.org>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: Frank Chang <frank.chang@sifive.com>
---
 target/riscv/cpu.c | 11 +++--------
 target/riscv/cpu.h |  5 +++++
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c
index 3f9e2400bb..bf14d27bd1 100644
--- a/target/riscv/cpu.c
+++ b/target/riscv/cpu.c
@@ -135,11 +135,6 @@ static void set_vext_version(CPURISCVState *env, int vext_ver)
     env->vext_ver = vext_ver;
 }
 
-static void set_feature(CPURISCVState *env, int feature)
-{
-    env->features |= (1ULL << feature);
-}
-
 static void set_resetvec(CPURISCVState *env, target_ulong resetvec)
 {
 #ifndef CONFIG_USER_ONLY
@@ -508,18 +503,18 @@ static void riscv_cpu_realize(DeviceState *dev, Error **errp)
     }
 
     if (cpu->cfg.mmu) {
-        set_feature(env, RISCV_FEATURE_MMU);
+        riscv_set_feature(env, RISCV_FEATURE_MMU);
     }
 
     if (cpu->cfg.pmp) {
-        set_feature(env, RISCV_FEATURE_PMP);
+        riscv_set_feature(env, RISCV_FEATURE_PMP);
 
         /*
          * Enhanced PMP should only be available
          * on harts with PMP support
          */
         if (cpu->cfg.epmp) {
-            set_feature(env, RISCV_FEATURE_EPMP);
+            riscv_set_feature(env, RISCV_FEATURE_EPMP);
         }
     }
 
diff --git a/target/riscv/cpu.h b/target/riscv/cpu.h
index f030cb58b2..283a3cda4b 100644
--- a/target/riscv/cpu.h
+++ b/target/riscv/cpu.h
@@ -379,6 +379,11 @@ static inline bool riscv_feature(CPURISCVState *env, int feature)
     return env->features & (1ULL << feature);
 }
 
+static inline void riscv_set_feature(CPURISCVState *env, int feature)
+{
+    env->features |= (1ULL << feature);
+}
+
 #include "cpu_user.h"
 
 extern const char * const riscv_int_regnames[];
-- 
2.25.1



  parent reply	other threads:[~2022-02-04 18:02 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-04 17:46 [PATCH v9 00/23] QEMU RISC-V AIA support Anup Patel
2022-02-04 17:46 ` Anup Patel
2022-02-04 17:46 ` [PATCH v9 01/23] target/riscv: Fix trap cause for RV32 HS-mode CSR access from RV64 HS-mode Anup Patel
2022-02-04 17:46   ` Anup Patel
2022-02-04 17:46 ` [PATCH v9 02/23] target/riscv: Implement SGEIP bit in hip and hie CSRs Anup Patel
2022-02-04 17:46   ` Anup Patel
2022-02-04 17:46 ` [PATCH v9 03/23] target/riscv: Implement hgeie and hgeip CSRs Anup Patel
2022-02-04 17:46   ` Anup Patel
2022-02-04 17:46 ` [PATCH v9 04/23] target/riscv: Improve delivery of guest external interrupts Anup Patel
2022-02-04 17:46   ` Anup Patel
2022-02-04 17:46 ` Anup Patel [this message]
2022-02-04 17:46   ` [PATCH v9 05/23] target/riscv: Allow setting CPU feature from machine/device emulation Anup Patel
2022-02-04 17:46 ` [PATCH v9 06/23] target/riscv: Add AIA cpu feature Anup Patel
2022-02-04 17:46   ` Anup Patel
2022-02-04 17:46 ` [PATCH v9 07/23] target/riscv: Add defines for AIA CSRs Anup Patel
2022-02-04 17:46   ` Anup Patel
2022-02-04 17:46 ` [PATCH v9 08/23] target/riscv: Allow AIA device emulation to set ireg rmw callback Anup Patel
2022-02-04 17:46   ` Anup Patel
2022-02-04 17:46 ` [PATCH v9 09/23] target/riscv: Implement AIA local interrupt priorities Anup Patel
2022-02-04 17:46   ` Anup Patel
2022-02-04 17:46 ` [PATCH v9 10/23] target/riscv: Implement AIA CSRs for 64 local interrupts on RV32 Anup Patel
2022-02-04 17:46   ` Anup Patel
2022-02-04 17:46 ` [PATCH v9 11/23] target/riscv: Implement AIA hvictl and hviprioX CSRs Anup Patel
2022-02-04 17:46   ` Anup Patel
2022-02-04 17:46 ` [PATCH v9 12/23] target/riscv: Implement AIA interrupt filtering CSRs Anup Patel
2022-02-04 17:46   ` Anup Patel
2022-02-04 17:46 ` [PATCH v9 13/23] target/riscv: Implement AIA mtopi, stopi, and vstopi CSRs Anup Patel
2022-02-04 17:46   ` Anup Patel
2022-02-04 17:46 ` [PATCH v9 14/23] target/riscv: Implement AIA xiselect and xireg CSRs Anup Patel
2022-02-04 17:46   ` Anup Patel
2022-02-04 17:46 ` [PATCH v9 15/23] target/riscv: Implement AIA IMSIC interface CSRs Anup Patel
2022-02-04 17:46   ` Anup Patel
2022-02-04 17:46 ` [PATCH v9 16/23] hw/riscv: virt: Use AIA INTC compatible string when available Anup Patel
2022-02-04 17:46   ` Anup Patel
2022-02-04 17:46 ` [PATCH v9 17/23] target/riscv: Allow users to force enable AIA CSRs in HART Anup Patel
2022-02-04 17:46   ` Anup Patel
2022-02-04 17:46 ` [PATCH v9 18/23] hw/intc: Add RISC-V AIA APLIC device emulation Anup Patel
2022-02-04 17:46   ` Anup Patel
2022-02-04 17:46 ` [PATCH v9 19/23] hw/riscv: virt: Add optional AIA APLIC support to virt machine Anup Patel
2022-02-04 17:46   ` Anup Patel
2022-02-04 17:46 ` [PATCH v9 20/23] hw/intc: Add RISC-V AIA IMSIC device emulation Anup Patel
2022-02-04 17:46   ` Anup Patel
2022-02-04 17:46 ` [PATCH v9 21/23] hw/riscv: virt: Add optional AIA IMSIC support to virt machine Anup Patel
2022-02-04 17:46   ` Anup Patel
2022-02-04 17:46 ` [PATCH v9 22/23] docs/system: riscv: Document AIA options for " Anup Patel
2022-02-04 17:46   ` Anup Patel
2022-02-04 17:46 ` [PATCH v9 23/23] hw/riscv: virt: Increase maximum number of allowed CPUs Anup Patel
2022-02-04 17:46   ` Anup Patel
2022-02-08  4:16 ` [PATCH v9 00/23] QEMU RISC-V AIA support Alistair Francis
2022-02-08  4:16   ` Alistair Francis
2022-02-08  6:51   ` Alistair Francis
2022-02-08  6:51     ` Alistair Francis
2022-02-08  7:32     ` Anup Patel
2022-02-08  7:32       ` Anup Patel
2022-02-10  8:28     ` Atish Patra
2022-02-10  8:28       ` Atish Patra
2022-02-10 10:24       ` Anup Patel
2022-02-10 10:24         ` Anup Patel
2022-02-11  8:28         ` Alistair Francis
2022-02-11  8:28           ` Alistair Francis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220204174700.534953-6-anup@brainfault.org \
    --to=anup@brainfault.org \
    --cc=Alistair.Francis@wdc.com \
    --cc=atishp@atishpatra.org \
    --cc=bmeng.cn@gmail.com \
    --cc=frank.chang@sifive.com \
    --cc=palmer@dabbelt.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-riscv@nongnu.org \
    --cc=sagark@eecs.berkeley.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.