From: Lucas Tanure <tanureal@opensource.cirrus.com> To: Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>, Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com> Cc: <alsa-devel@alsa-project.org>, <patches@opensource.cirrus.com>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, David Rhodes <drhodes@opensource.cirrus.com> Subject: [PATCH 01/20] ASoC: cs35l41: Fix GPIO2 configuration Date: Thu, 3 Mar 2022 17:30:40 +0000 [thread overview] Message-ID: <20220303173059.269657-2-tanureal@opensource.cirrus.com> (raw) In-Reply-To: <20220303173059.269657-1-tanureal@opensource.cirrus.com> From: David Rhodes <drhodes@opensource.cirrus.com> Fix GPIO2 polarity and direction configuration Fixes: fe1024d50477b ("ASoC: cs35l41: Combine adjacent register writes") Signed-off-by: David Rhodes <drhodes@opensource.cirrus.com> --- sound/soc/codecs/cs35l41.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/cs35l41.c b/sound/soc/codecs/cs35l41.c index 77a017694645..90c91b00288b 100644 --- a/sound/soc/codecs/cs35l41.c +++ b/sound/soc/codecs/cs35l41.c @@ -1035,8 +1035,8 @@ static int cs35l41_irq_gpio_config(struct cs35l41_private *cs35l41) regmap_update_bits(cs35l41->regmap, CS35L41_GPIO2_CTRL1, CS35L41_GPIO_POL_MASK | CS35L41_GPIO_DIR_MASK, - irq_gpio_cfg1->irq_pol_inv << CS35L41_GPIO_POL_SHIFT | - !irq_gpio_cfg1->irq_out_en << CS35L41_GPIO_DIR_SHIFT); + irq_gpio_cfg2->irq_pol_inv << CS35L41_GPIO_POL_SHIFT | + !irq_gpio_cfg2->irq_out_en << CS35L41_GPIO_DIR_SHIFT); regmap_update_bits(cs35l41->regmap, CS35L41_GPIO_PAD_CONTROL, CS35L41_GPIO1_CTRL_MASK | CS35L41_GPIO2_CTRL_MASK, -- 2.35.1
WARNING: multiple messages have this Message-ID (diff)
From: Lucas Tanure <tanureal@opensource.cirrus.com> To: Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>, Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com> Cc: David Rhodes <drhodes@opensource.cirrus.com>, patches@opensource.cirrus.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH 01/20] ASoC: cs35l41: Fix GPIO2 configuration Date: Thu, 3 Mar 2022 17:30:40 +0000 [thread overview] Message-ID: <20220303173059.269657-2-tanureal@opensource.cirrus.com> (raw) In-Reply-To: <20220303173059.269657-1-tanureal@opensource.cirrus.com> From: David Rhodes <drhodes@opensource.cirrus.com> Fix GPIO2 polarity and direction configuration Fixes: fe1024d50477b ("ASoC: cs35l41: Combine adjacent register writes") Signed-off-by: David Rhodes <drhodes@opensource.cirrus.com> --- sound/soc/codecs/cs35l41.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/cs35l41.c b/sound/soc/codecs/cs35l41.c index 77a017694645..90c91b00288b 100644 --- a/sound/soc/codecs/cs35l41.c +++ b/sound/soc/codecs/cs35l41.c @@ -1035,8 +1035,8 @@ static int cs35l41_irq_gpio_config(struct cs35l41_private *cs35l41) regmap_update_bits(cs35l41->regmap, CS35L41_GPIO2_CTRL1, CS35L41_GPIO_POL_MASK | CS35L41_GPIO_DIR_MASK, - irq_gpio_cfg1->irq_pol_inv << CS35L41_GPIO_POL_SHIFT | - !irq_gpio_cfg1->irq_out_en << CS35L41_GPIO_DIR_SHIFT); + irq_gpio_cfg2->irq_pol_inv << CS35L41_GPIO_POL_SHIFT | + !irq_gpio_cfg2->irq_out_en << CS35L41_GPIO_DIR_SHIFT); regmap_update_bits(cs35l41->regmap, CS35L41_GPIO_PAD_CONTROL, CS35L41_GPIO1_CTRL_MASK | CS35L41_GPIO2_CTRL_MASK, -- 2.35.1
next prev parent reply other threads:[~2022-03-03 17:31 UTC|newest] Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-03-03 17:30 [PATCH 00/20] Support external boost at CS35l41 ASoC driver Lucas Tanure 2022-03-03 17:30 ` Lucas Tanure 2022-03-03 17:30 ` Lucas Tanure [this message] 2022-03-03 17:30 ` [PATCH 01/20] ASoC: cs35l41: Fix GPIO2 configuration Lucas Tanure 2022-03-04 10:01 ` Charles Keepax 2022-03-04 10:01 ` Charles Keepax 2022-03-03 17:30 ` [PATCH 02/20] ASoC: cs35l41: Fix max number of TX channels Lucas Tanure 2022-03-03 17:30 ` Lucas Tanure 2022-03-04 10:02 ` Charles Keepax 2022-03-04 10:02 ` Charles Keepax 2022-03-03 17:30 ` [PATCH 03/20] ASoC: cs35l41: Fix DSP mbox start command and global enable order Lucas Tanure 2022-03-03 17:30 ` Lucas Tanure 2022-03-04 10:02 ` Charles Keepax 2022-03-04 10:02 ` Charles Keepax 2022-03-03 17:30 ` [PATCH 04/20] ASoC: cs35l41: Remove unnecessary param Lucas Tanure 2022-03-03 17:30 ` Lucas Tanure 2022-03-04 10:02 ` Charles Keepax 2022-03-04 10:02 ` Charles Keepax 2022-03-03 17:30 ` [PATCH 05/20] sound: cs35l41: Unify hardware configuration Lucas Tanure 2022-03-03 17:30 ` Lucas Tanure 2022-03-04 10:15 ` Charles Keepax 2022-03-04 10:15 ` Charles Keepax 2022-03-03 17:30 ` [PATCH 06/20] sound: cs35l41: Check hw_config before using it Lucas Tanure 2022-03-03 17:30 ` Lucas Tanure 2022-03-04 10:17 ` Charles Keepax 2022-03-04 10:17 ` Charles Keepax 2022-03-03 17:30 ` [PATCH 07/20] sound: cs35l41: Move cs35l41_gpio_config to shared lib Lucas Tanure 2022-03-03 17:30 ` Lucas Tanure 2022-03-04 10:18 ` Charles Keepax 2022-03-04 10:18 ` Charles Keepax 2022-03-03 17:30 ` [PATCH 08/20] hda: cs35l41: Fix I2S params comments Lucas Tanure 2022-03-03 17:30 ` Lucas Tanure 2022-03-03 17:30 ` [PATCH 09/20] hda: cs35l41: Always configure the DAI Lucas Tanure 2022-03-03 17:30 ` Lucas Tanure 2022-03-03 17:30 ` [PATCH 10/20] hda: cs35l41: Add Boost type flag Lucas Tanure 2022-03-03 17:30 ` Lucas Tanure 2022-03-03 17:30 ` [PATCH 11/20] hda: cs35l41: Put the device into safe mode for external boost Lucas Tanure 2022-03-03 17:30 ` Lucas Tanure 2022-03-03 17:30 ` [PATCH 12/20] hda: cs35l41: Mute the device before shutdown Lucas Tanure 2022-03-03 17:30 ` Lucas Tanure 2022-03-03 17:30 ` [PATCH 13/20] sound: cs35l41: Enable Internal Boost in shared lib Lucas Tanure 2022-03-03 17:30 ` Lucas Tanure 2022-03-04 10:19 ` Charles Keepax 2022-03-04 10:19 ` Charles Keepax 2022-03-03 17:30 ` [PATCH 14/20] hda: cs35l41: Move boost config to initialization code Lucas Tanure 2022-03-03 17:30 ` Lucas Tanure 2022-03-03 17:30 ` [PATCH 15/20] hda: cs35l41: Remove unnecessary log Lucas Tanure 2022-03-03 17:30 ` Lucas Tanure 2022-03-03 17:50 ` Mark Brown 2022-03-03 17:50 ` Mark Brown 2022-03-04 15:05 ` Lucas tanure 2022-03-04 15:05 ` Lucas tanure 2022-03-03 17:30 ` [PATCH 16/20] hda: cs35l41: Remove cs35l41_hda_reg_sequence struct Lucas Tanure 2022-03-03 17:30 ` Lucas Tanure 2022-03-03 17:30 ` [PATCH 17/20] hda: cs35l41: Handle all external boost setups the same way Lucas Tanure 2022-03-03 17:30 ` Lucas Tanure 2022-03-03 17:30 ` [PATCH 18/20] hda: cs35l41: Move external boost handling to lib for ASoC use Lucas Tanure 2022-03-03 17:30 ` Lucas Tanure 2022-03-03 17:30 ` [PATCH 19/20] ASoC: cs35l41: Support external boost Lucas Tanure 2022-03-03 17:30 ` Lucas Tanure 2022-03-03 17:30 ` [PATCH 20/20] Documentation: devicetree: CS35l41 External Boost Lucas Tanure 2022-03-03 17:30 ` Lucas Tanure 2022-03-03 18:24 ` Mark Brown 2022-03-03 18:24 ` Mark Brown 2022-03-03 19:00 ` Rob Herring 2022-03-03 19:00 ` Rob Herring 2022-03-07 20:38 ` (subset) [PATCH 00/20] Support external boost at CS35l41 ASoC driver Mark Brown 2022-03-07 20:38 ` Mark Brown
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220303173059.269657-2-tanureal@opensource.cirrus.com \ --to=tanureal@opensource.cirrus.com \ --cc=alsa-devel@alsa-project.org \ --cc=broonie@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=drhodes@opensource.cirrus.com \ --cc=lgirdwood@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=patches@opensource.cirrus.com \ --cc=perex@perex.cz \ --cc=robh+dt@kernel.org \ --cc=tiwai@suse.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.