From: Tomas Henzl <thenzl@redhat.com>
To: linux-scsi@vger.kernel.org
Cc: hch@infradead.org
Subject: [PATCH] scsi_logging: fix a BUG
Date: Thu, 24 Mar 2022 14:46:03 +0100 [thread overview]
Message-ID: <20220324134603.28463-1-thenzl@redhat.com> (raw)
The request_queue may be NULL in a request, for example when it comes
from scsi_ioctl_reset.
Check it before before use.
Fixes: f3fa33acca9f ("block: remove the ->rq_disk field in struct request")
Reported-by: Changhui Zhong <czhong@redhat.com>
Signed-off-by: Tomas Henzl <thenzl@redhat.com>
---
drivers/scsi/scsi_logging.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/scsi_logging.c b/drivers/scsi/scsi_logging.c
index 1f8f80b2dbfc..a9f8de5e9639 100644
--- a/drivers/scsi/scsi_logging.c
+++ b/drivers/scsi/scsi_logging.c
@@ -30,7 +30,7 @@ static inline const char *scmd_name(const struct scsi_cmnd *scmd)
{
struct request *rq = scsi_cmd_to_rq((struct scsi_cmnd *)scmd);
- if (!rq->q->disk)
+ if (!rq->q || !rq->q->disk)
return NULL;
return rq->q->disk->disk_name;
}
--
2.35.1
next reply other threads:[~2022-03-24 13:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-24 13:46 Tomas Henzl [this message]
2022-03-24 14:13 ` [PATCH] scsi_logging: fix a BUG Christoph Hellwig
2022-03-30 3:29 ` Martin K. Petersen
2022-04-07 13:35 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220324134603.28463-1-thenzl@redhat.com \
--to=thenzl@redhat.com \
--cc=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.