From: Brian Norris <briannorris@chromium.org> To: Heiko Stuebner <heiko@sntech.de>, Arnd Bergmann <arnd@arndb.de> Cc: linux-kernel@vger.kernel.org, Guenter Roeck <linux@roeck-us.net>, linux-rockchip@lists.infradead.org, Brian Norris <briannorris@chromium.org> Subject: [PATCH v2 2/2] soc: rockchip: Fix compile-testing SoC drivers Date: Mon, 25 Apr 2022 10:17:37 -0700 [thread overview] Message-ID: <20220425101646.v2.2.Id5f16dec920f620120c0a143a97a12e16d401760@changeid> (raw) In-Reply-To: <20220425171737.321813-1-briannorris@chromium.org> Similar to commit 7f94b69ece51 ("ARM: ixp4xx: fix compile-testing soc drivers"). drivers/soc/rockchip/Kconfig makes plenty of provision for configuring drivers either for ARCH_ROCKCHIP or for COMPILE_TEST. But drivers/soc/Makefile pulls the rug out from under us, by refusing to build anything if we specified COMPILE_TEST but not ARCH_ROCKCHIP. Currently, I'm not aware of anything that breaks without this patch, but it certainly makes for confusing builds (CONFIG_ROCKCHIP_PM_DOMAINS=y, but we didn't actually compile the driver?) and leaves room for future error (I have pending patches that break confusingly with COMPILE_TEST=y even though their Kconfig dependencies seem correct [1]). Defer to drivers/soc/rockchip/{Makefile,Kconfig} to do the right thing. We also need to force ARM/ARM64 dependencies for ROCKCHIP_PM_DOMAINS, because it uses ARM-specific macros (dsb()). [1] e.g., https://lore.kernel.org/linux-rockchip/20220405184816.RFC.2.I2d73b403944f0b8b5871a77585b73f31ccc62999@changeid/ [RFC PATCH 2/2] PM / devfreq: rk3399_dmc: Block PMU during transitions Signed-off-by: Brian Norris <briannorris@chromium.org> --- Changes in v2: * Depend on ARM||ARM64 drivers/soc/Makefile | 2 +- drivers/soc/rockchip/Kconfig | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/soc/Makefile b/drivers/soc/Makefile index fd7717d597fc..4c91705a8bb3 100644 --- a/drivers/soc/Makefile +++ b/drivers/soc/Makefile @@ -23,7 +23,7 @@ obj-y += pxa/ obj-y += amlogic/ obj-y += qcom/ obj-y += renesas/ -obj-$(CONFIG_ARCH_ROCKCHIP) += rockchip/ +obj-y += rockchip/ obj-$(CONFIG_SOC_SAMSUNG) += samsung/ obj-$(CONFIG_SOC_SIFIVE) += sifive/ obj-y += sunxi/ diff --git a/drivers/soc/rockchip/Kconfig b/drivers/soc/rockchip/Kconfig index aff2f7e95237..785e1798d286 100644 --- a/drivers/soc/rockchip/Kconfig +++ b/drivers/soc/rockchip/Kconfig @@ -25,6 +25,7 @@ config ROCKCHIP_IODOMAIN config ROCKCHIP_PM_DOMAINS bool "Rockchip generic power domain" depends on PM + depends on ARM || ARM64 select PM_GENERIC_DOMAINS help Say y here to enable power domain support. -- 2.36.0.rc2.479.g8af0fa9b8e-goog
WARNING: multiple messages have this Message-ID (diff)
From: Brian Norris <briannorris@chromium.org> To: Heiko Stuebner <heiko@sntech.de>, Arnd Bergmann <arnd@arndb.de> Cc: linux-kernel@vger.kernel.org, Guenter Roeck <linux@roeck-us.net>, linux-rockchip@lists.infradead.org, Brian Norris <briannorris@chromium.org> Subject: [PATCH v2 2/2] soc: rockchip: Fix compile-testing SoC drivers Date: Mon, 25 Apr 2022 10:17:37 -0700 [thread overview] Message-ID: <20220425101646.v2.2.Id5f16dec920f620120c0a143a97a12e16d401760@changeid> (raw) In-Reply-To: <20220425171737.321813-1-briannorris@chromium.org> Similar to commit 7f94b69ece51 ("ARM: ixp4xx: fix compile-testing soc drivers"). drivers/soc/rockchip/Kconfig makes plenty of provision for configuring drivers either for ARCH_ROCKCHIP or for COMPILE_TEST. But drivers/soc/Makefile pulls the rug out from under us, by refusing to build anything if we specified COMPILE_TEST but not ARCH_ROCKCHIP. Currently, I'm not aware of anything that breaks without this patch, but it certainly makes for confusing builds (CONFIG_ROCKCHIP_PM_DOMAINS=y, but we didn't actually compile the driver?) and leaves room for future error (I have pending patches that break confusingly with COMPILE_TEST=y even though their Kconfig dependencies seem correct [1]). Defer to drivers/soc/rockchip/{Makefile,Kconfig} to do the right thing. We also need to force ARM/ARM64 dependencies for ROCKCHIP_PM_DOMAINS, because it uses ARM-specific macros (dsb()). [1] e.g., https://lore.kernel.org/linux-rockchip/20220405184816.RFC.2.I2d73b403944f0b8b5871a77585b73f31ccc62999@changeid/ [RFC PATCH 2/2] PM / devfreq: rk3399_dmc: Block PMU during transitions Signed-off-by: Brian Norris <briannorris@chromium.org> --- Changes in v2: * Depend on ARM||ARM64 drivers/soc/Makefile | 2 +- drivers/soc/rockchip/Kconfig | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/soc/Makefile b/drivers/soc/Makefile index fd7717d597fc..4c91705a8bb3 100644 --- a/drivers/soc/Makefile +++ b/drivers/soc/Makefile @@ -23,7 +23,7 @@ obj-y += pxa/ obj-y += amlogic/ obj-y += qcom/ obj-y += renesas/ -obj-$(CONFIG_ARCH_ROCKCHIP) += rockchip/ +obj-y += rockchip/ obj-$(CONFIG_SOC_SAMSUNG) += samsung/ obj-$(CONFIG_SOC_SIFIVE) += sifive/ obj-y += sunxi/ diff --git a/drivers/soc/rockchip/Kconfig b/drivers/soc/rockchip/Kconfig index aff2f7e95237..785e1798d286 100644 --- a/drivers/soc/rockchip/Kconfig +++ b/drivers/soc/rockchip/Kconfig @@ -25,6 +25,7 @@ config ROCKCHIP_IODOMAIN config ROCKCHIP_PM_DOMAINS bool "Rockchip generic power domain" depends on PM + depends on ARM || ARM64 select PM_GENERIC_DOMAINS help Say y here to enable power domain support. -- 2.36.0.rc2.479.g8af0fa9b8e-goog _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2022-04-25 17:17 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-04-25 17:17 [PATCH v2 1/2] soc: rockchip: Clean up Kconfig whitespace Brian Norris 2022-04-25 17:17 ` Brian Norris 2022-04-25 17:17 ` Brian Norris [this message] 2022-04-25 17:17 ` [PATCH v2 2/2] soc: rockchip: Fix compile-testing SoC drivers Brian Norris 2022-04-25 18:09 ` Robin Murphy 2022-04-25 18:09 ` Robin Murphy
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220425101646.v2.2.Id5f16dec920f620120c0a143a97a12e16d401760@changeid \ --to=briannorris@chromium.org \ --cc=arnd@arndb.de \ --cc=heiko@sntech.de \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-rockchip@lists.infradead.org \ --cc=linux@roeck-us.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.