All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maxime Ripard <maxime@cerno.tech>
To: linux-clk@vger.kernel.org,
	Mike Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>
Cc: Yassine Oudjana <y.oudjana@protonmail.com>,
	Naresh Kamboju <naresh.kamboju@linaro.org>,
	Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	Tony Lindgren <tony@atomide.com>,
	Neil Armstrong <narmstrong@baylibre.com>,
	Alexander Stein <alexander.stein@ew.tq-group.com>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Maxime Ripard <maxime@cerno.tech>
Subject: [PATCH v5 05/28] clk: Mention that .recalc_rate can return 0 on error
Date: Mon, 16 May 2022 15:25:04 +0200	[thread overview]
Message-ID: <20220516132527.328190-6-maxime@cerno.tech> (raw)
In-Reply-To: <20220516132527.328190-1-maxime@cerno.tech>

Multiple platforms (amlogic, imx8) return 0 when the clock rate cannot
be determined properly by the recalc_rate hook. Mention in the
documentation that the framework is ok with that.

Signed-off-by: Maxime Ripard <maxime@cerno.tech>
---
 include/linux/clk-provider.h | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/include/linux/clk-provider.h b/include/linux/clk-provider.h
index c10dc4c659e2..58e5baa49db0 100644
--- a/include/linux/clk-provider.h
+++ b/include/linux/clk-provider.h
@@ -118,8 +118,9 @@ struct clk_duty {
  *
  * @recalc_rate	Recalculate the rate of this clock, by querying hardware. The
  *		parent rate is an input parameter.  It is up to the caller to
- *		ensure that the prepare_mutex is held across this call.
- *		Returns the calculated rate.  Optional, but recommended - if
+ *		ensure that the prepare_mutex is held across this call. If the
+ *		driver cannot figure out a rate for this clock, it must return
+ *		0. Returns the calculated rate. Optional, but recommended - if
  *		this op is not set then clock rate will be initialized to 0.
  *
  * @round_rate:	Given a target rate as input, returns the closest rate actually
-- 
2.36.1


  parent reply	other threads:[~2022-05-16 13:26 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-16 13:24 [PATCH v5 00/28] clk: More clock rate fixes and tests Maxime Ripard
2022-05-16 13:25 ` [PATCH v5 01/28] clk: Drop the rate range on clk_put() Maxime Ripard
2022-05-16 13:25 ` [PATCH v5 02/28] clk: Skip clamping when rounding if there's no boundaries Maxime Ripard
2022-06-27 23:21   ` Stephen Boyd
2022-06-28  8:58     ` Maxime Ripard
2022-05-16 13:25 ` [PATCH v5 03/28] clk: Introduce clk_get_rate_range() Maxime Ripard
2022-06-27 23:23   ` Stephen Boyd
2022-05-16 13:25 ` [PATCH v5 04/28] drm/vc4: hdmi: Rework hdmi_enable_4kp60 detection Maxime Ripard
2022-06-27 23:31   ` Stephen Boyd
2022-06-28  9:47     ` Maxime Ripard
2022-06-29  8:48       ` Stephen Boyd
2022-06-29  9:29         ` Maxime Ripard
2022-05-16 13:25 ` Maxime Ripard [this message]
2022-05-16 13:25 ` [PATCH v5 06/28] clk: Clarify clk_get_rate() expectations Maxime Ripard
2022-05-16 13:25 ` [PATCH v5 07/28] clk: tests: Add test suites description Maxime Ripard
2022-05-16 13:25 ` [PATCH v5 08/28] clk: tests: Add reference to the orphan mux bug report Maxime Ripard
2022-05-16 13:25 ` [PATCH v5 09/28] clk: tests: Add tests for uncached clock Maxime Ripard
2022-05-16 13:25 ` [PATCH v5 10/28] clk: tests: Add tests for single parent mux Maxime Ripard
2022-05-16 13:25 ` [PATCH v5 11/28] clk: tests: Add tests for mux with multiple parents Maxime Ripard
2022-05-16 13:25 ` [PATCH v5 12/28] clk: tests: Add some tests for orphan " Maxime Ripard
2022-05-16 13:25 ` [PATCH v5 13/28] clk: Take into account uncached clocks in clk_set_rate_range() Maxime Ripard
2022-06-29  9:01   ` Stephen Boyd
2022-06-29 12:42     ` Maxime Ripard
2022-05-16 13:25 ` [PATCH v5 14/28] clk: Fix clk_get_parent() documentation Maxime Ripard
2022-06-29  9:05   ` Stephen Boyd
2022-06-29 13:12     ` Maxime Ripard
2022-05-16 13:25 ` [PATCH v5 15/28] clk: Set req_rate on reparenting Maxime Ripard
2022-05-16 13:25 ` [PATCH v5 16/28] clk: Change clk_core_init_rate_req prototype Maxime Ripard
2022-05-16 13:25 ` [PATCH v5 17/28] clk: Move clk_core_init_rate_req() from clk_core_round_rate_nolock() to its caller Maxime Ripard
2022-05-16 13:25 ` [PATCH v5 18/28] clk: Introduce clk_hw_init_rate_request() Maxime Ripard
2022-05-16 13:25 ` [PATCH v5 19/28] clk: Add our request boundaries in clk_core_init_rate_req Maxime Ripard
2022-05-16 13:25 ` [PATCH v5 20/28] clk: Switch from __clk_determine_rate to clk_core_round_rate_nolock Maxime Ripard
2022-05-16 13:25 ` [PATCH v5 21/28] clk: Introduce clk_core_has_parent() Maxime Ripard
2022-06-29  9:11   ` Stephen Boyd
2022-05-16 13:25 ` [PATCH v5 22/28] clk: Stop forwarding clk_rate_requests to the parent Maxime Ripard
2022-05-16 13:25 ` [PATCH v5 23/28] clk: Zero the clk_rate_request structure Maxime Ripard
2022-05-16 13:25 ` [PATCH v5 24/28] clk: Test the clock pointer in clk_hw_get_name() Maxime Ripard
2022-06-29  9:13   ` Stephen Boyd
2022-06-29  9:39     ` Maxime Ripard
2022-05-16 13:25 ` [PATCH v5 25/28] clk: Introduce the clk_hw_get_rate_range function Maxime Ripard
2022-05-16 13:25 ` [PATCH v5 26/28] clk: qcom: clk-rcg2: Take clock boundaries into consideration for gfx3d Maxime Ripard
2022-05-16 13:25 ` [PATCH v5 27/28] clk: tests: Add some tests for clk_get_rate_range() Maxime Ripard
2022-05-16 13:25 ` [PATCH v5 28/28] clk: tests: Add missing test case for ranges Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220516132527.328190-6-maxime@cerno.tech \
    --to=maxime@cerno.tech \
    --cc=alexander.stein@ew.tq-group.com \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=jbrunet@baylibre.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=mturquette@baylibre.com \
    --cc=naresh.kamboju@linaro.org \
    --cc=narmstrong@baylibre.com \
    --cc=sboyd@kernel.org \
    --cc=tony@atomide.com \
    --cc=y.oudjana@protonmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.