From: Eric Biggers <ebiggers@kernel.org> To: linux-fsdevel@vger.kernel.org Cc: linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-xfs@vger.kernel.org, linux-api@vger.kernel.org, linux-fscrypt@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Keith Busch <kbusch@kernel.org> Subject: [RFC PATCH v2 0/7] make statx() return I/O alignment information Date: Wed, 18 May 2022 16:50:04 -0700 [thread overview] Message-ID: <20220518235011.153058-1-ebiggers@kernel.org> (raw) This patchset makes the statx() system call return I/O alignment information, roughly following the design that was suggested at https://lore.kernel.org/linux-fsdevel/20220120071215.123274-1-ebiggers@kernel.org/T/#u This feature solves two problems: (a) it allows userspace to determine when a file supports direct I/O, and with what alignment restrictions; and (b) it allows userspace to determine the optimum I/O alignment for a file. For more details, see patch 1. This is an RFC. I'd greatly appreciate any feedback on the UAPI, as that obviously needs to be gotten right from the beginning. E.g., does the proposed set of fields make sense? Am I including the right information in stx_offset_align_optimal? Patch 1 adds the VFS support for STATX_IOALIGN. The remaining patches wire it up to ext4 and f2fs. Support for other filesystems can be added later. We could also support this on block device files; however, since block device nodes have different inodes from the block devices themselves, it wouldn't apply to statx("/dev/$foo") but rather just to 'fd = open("/dev/foo"); statx(fd)'. I'm unsure how useful that would be. Note, f2fs has one corner case where DIO reads are allowed but not DIO writes. The proposed statx fields can't represent this. My proposal (patch 5) is to just eliminate this case, as it seems much too weird. But I'd appreciate any feedback on that part. This patchset applies to v5.18-rc7. No changes since v1, which I sent a few months ago; I'm resending this because people seem interested in it again (https://lore.kernel.org/r/20220518171131.3525293-1-kbusch@fb.com). Eric Biggers (7): statx: add I/O alignment information fscrypt: change fscrypt_dio_supported() to prepare for STATX_IOALIGN ext4: support STATX_IOALIGN f2fs: move f2fs_force_buffered_io() into file.c f2fs: don't allow DIO reads but not DIO writes f2fs: simplify f2fs_force_buffered_io() f2fs: support STATX_IOALIGN fs/crypto/inline_crypt.c | 48 +++++++++++++++--------------- fs/ext4/ext4.h | 1 + fs/ext4/file.c | 10 +++---- fs/ext4/inode.c | 31 ++++++++++++++++++++ fs/f2fs/f2fs.h | 45 ----------------------------- fs/f2fs/file.c | 61 ++++++++++++++++++++++++++++++++++++++- fs/stat.c | 3 ++ include/linux/fscrypt.h | 7 ++--- include/linux/stat.h | 3 ++ include/uapi/linux/stat.h | 9 ++++-- 10 files changed, 136 insertions(+), 82 deletions(-) base-commit: 42226c989789d8da4af1de0c31070c96726d990c -- 2.36.1
WARNING: multiple messages have this Message-ID (diff)
From: Eric Biggers <ebiggers@kernel.org> To: linux-fsdevel@vger.kernel.org Cc: linux-block@vger.kernel.org, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-xfs@vger.kernel.org, linux-fscrypt@vger.kernel.org, Keith Busch <kbusch@kernel.org>, linux-ext4@vger.kernel.org Subject: [f2fs-dev] [RFC PATCH v2 0/7] make statx() return I/O alignment information Date: Wed, 18 May 2022 16:50:04 -0700 [thread overview] Message-ID: <20220518235011.153058-1-ebiggers@kernel.org> (raw) This patchset makes the statx() system call return I/O alignment information, roughly following the design that was suggested at https://lore.kernel.org/linux-fsdevel/20220120071215.123274-1-ebiggers@kernel.org/T/#u This feature solves two problems: (a) it allows userspace to determine when a file supports direct I/O, and with what alignment restrictions; and (b) it allows userspace to determine the optimum I/O alignment for a file. For more details, see patch 1. This is an RFC. I'd greatly appreciate any feedback on the UAPI, as that obviously needs to be gotten right from the beginning. E.g., does the proposed set of fields make sense? Am I including the right information in stx_offset_align_optimal? Patch 1 adds the VFS support for STATX_IOALIGN. The remaining patches wire it up to ext4 and f2fs. Support for other filesystems can be added later. We could also support this on block device files; however, since block device nodes have different inodes from the block devices themselves, it wouldn't apply to statx("/dev/$foo") but rather just to 'fd = open("/dev/foo"); statx(fd)'. I'm unsure how useful that would be. Note, f2fs has one corner case where DIO reads are allowed but not DIO writes. The proposed statx fields can't represent this. My proposal (patch 5) is to just eliminate this case, as it seems much too weird. But I'd appreciate any feedback on that part. This patchset applies to v5.18-rc7. No changes since v1, which I sent a few months ago; I'm resending this because people seem interested in it again (https://lore.kernel.org/r/20220518171131.3525293-1-kbusch@fb.com). Eric Biggers (7): statx: add I/O alignment information fscrypt: change fscrypt_dio_supported() to prepare for STATX_IOALIGN ext4: support STATX_IOALIGN f2fs: move f2fs_force_buffered_io() into file.c f2fs: don't allow DIO reads but not DIO writes f2fs: simplify f2fs_force_buffered_io() f2fs: support STATX_IOALIGN fs/crypto/inline_crypt.c | 48 +++++++++++++++--------------- fs/ext4/ext4.h | 1 + fs/ext4/file.c | 10 +++---- fs/ext4/inode.c | 31 ++++++++++++++++++++ fs/f2fs/f2fs.h | 45 ----------------------------- fs/f2fs/file.c | 61 ++++++++++++++++++++++++++++++++++++++- fs/stat.c | 3 ++ include/linux/fscrypt.h | 7 ++--- include/linux/stat.h | 3 ++ include/uapi/linux/stat.h | 9 ++++-- 10 files changed, 136 insertions(+), 82 deletions(-) base-commit: 42226c989789d8da4af1de0c31070c96726d990c -- 2.36.1 _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next reply other threads:[~2022-05-18 23:53 UTC|newest] Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-18 23:50 Eric Biggers [this message] 2022-05-18 23:50 ` [f2fs-dev] [RFC PATCH v2 0/7] make statx() return I/O alignment information Eric Biggers 2022-05-18 23:50 ` [RFC PATCH v2 1/7] statx: add " Eric Biggers 2022-05-18 23:50 ` [f2fs-dev] " Eric Biggers 2022-05-19 7:05 ` Christoph Hellwig 2022-05-19 7:05 ` [f2fs-dev] " Christoph Hellwig 2022-05-19 23:06 ` Darrick J. Wong 2022-05-19 23:06 ` [f2fs-dev] " Darrick J. Wong 2022-05-20 3:27 ` Dave Chinner 2022-05-20 3:27 ` [f2fs-dev] " Dave Chinner 2022-06-14 5:25 ` Eric Biggers 2022-06-14 5:25 ` [f2fs-dev] " Eric Biggers 2022-06-15 13:12 ` Christoph Hellwig 2022-06-15 13:12 ` [f2fs-dev] " Christoph Hellwig 2022-06-16 0:04 ` Eric Biggers 2022-06-16 0:04 ` [f2fs-dev] " Eric Biggers 2022-06-16 6:07 ` Christoph Hellwig 2022-06-16 6:07 ` [f2fs-dev] " Christoph Hellwig 2022-06-16 6:19 ` Eric Biggers 2022-06-16 6:19 ` [f2fs-dev] " Eric Biggers 2022-06-16 6:29 ` Christoph Hellwig 2022-06-16 6:29 ` [f2fs-dev] " Christoph Hellwig 2022-05-20 6:30 ` Eric Biggers 2022-05-20 6:30 ` [f2fs-dev] " Eric Biggers 2022-05-20 11:52 ` Christian Brauner 2022-05-20 11:52 ` [f2fs-dev] " Christian Brauner 2022-05-27 9:02 ` Florian Weimer 2022-05-27 9:02 ` Florian Weimer 2022-05-27 16:22 ` Darrick J. Wong 2022-05-27 16:22 ` [f2fs-dev] " Darrick J. Wong 2022-05-18 23:50 ` [RFC PATCH v2 2/7] fscrypt: change fscrypt_dio_supported() to prepare for STATX_IOALIGN Eric Biggers 2022-05-18 23:50 ` [f2fs-dev] " Eric Biggers 2022-05-18 23:50 ` [RFC PATCH v2 3/7] ext4: support STATX_IOALIGN Eric Biggers 2022-05-18 23:50 ` [f2fs-dev] " Eric Biggers 2022-05-18 23:50 ` [RFC PATCH v2 4/7] f2fs: move f2fs_force_buffered_io() into file.c Eric Biggers 2022-05-18 23:50 ` [f2fs-dev] " Eric Biggers 2022-05-18 23:50 ` [RFC PATCH v2 5/7] f2fs: don't allow DIO reads but not DIO writes Eric Biggers 2022-05-18 23:50 ` [f2fs-dev] " Eric Biggers 2022-05-18 23:50 ` [RFC PATCH v2 6/7] f2fs: simplify f2fs_force_buffered_io() Eric Biggers 2022-05-18 23:50 ` [f2fs-dev] " Eric Biggers 2022-05-18 23:50 ` [RFC PATCH v2 7/7] f2fs: support STATX_IOALIGN Eric Biggers 2022-05-18 23:50 ` [f2fs-dev] " Eric Biggers
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220518235011.153058-1-ebiggers@kernel.org \ --to=ebiggers@kernel.org \ --cc=kbusch@kernel.org \ --cc=linux-api@vger.kernel.org \ --cc=linux-block@vger.kernel.org \ --cc=linux-ext4@vger.kernel.org \ --cc=linux-f2fs-devel@lists.sourceforge.net \ --cc=linux-fscrypt@vger.kernel.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-xfs@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.