All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Morgan <macroalpha82@gmail.com>
To: dri-devel@lists.freedesktop.org
Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org,
	thierry.reding@gmail.com, sam@ravnborg.org, airlied@linux.ie,
	daniel@ffwll.ch, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, mchehab@kernel.org,
	emma@anholt.net, mripard@kernel.org,
	Chris Morgan <macromorgan@hotmail.com>,
	Dave Stevenson <dave.stevenson@raspberrypi.com>
Subject: [RESEND 6/6 v2] drm/vc4: dpi: Support DPI interface in mode3 for RGB565
Date: Thu, 19 May 2022 11:29:35 -0500	[thread overview]
Message-ID: <20220519162935.1585-7-macroalpha82@gmail.com> (raw)
In-Reply-To: <20220519162935.1585-1-macroalpha82@gmail.com>

From: Chris Morgan <macromorgan@hotmail.com>

Add support for the VC4 DPI driver to utilize DPI mode 3. This is
defined here as xxxRRRRRxxGGGGGGxxxBBBBB:
https://www.raspberrypi.com/documentation/computers/raspberry-pi.html#parallel-display-interface-dpi

This mode is required to use the Geekworm MZP280 DPI display.

Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
Reviewed-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
---
 drivers/gpu/drm/vc4/vc4_dpi.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/gpu/drm/vc4/vc4_dpi.c b/drivers/gpu/drm/vc4/vc4_dpi.c
index c180eb60b..3c58ade25 100644
--- a/drivers/gpu/drm/vc4/vc4_dpi.c
+++ b/drivers/gpu/drm/vc4/vc4_dpi.c
@@ -173,6 +173,10 @@ static void vc4_dpi_encoder_enable(struct drm_encoder *encoder)
 			dpi_c |= VC4_SET_FIELD(DPI_FORMAT_16BIT_565_RGB_3,
 					       DPI_FORMAT);
 			break;
+		case MEDIA_BUS_FMT_RGB565_1X24_CPADHI:
+			dpi_c |= VC4_SET_FIELD(DPI_FORMAT_16BIT_565_RGB_2,
+					       DPI_FORMAT);
+			break;
 		default:
 			DRM_ERROR("Unknown media bus format %d\n", bus_format);
 			break;
-- 
2.25.1


WARNING: multiple messages have this Message-ID (diff)
From: Chris Morgan <macroalpha82@gmail.com>
To: dri-devel@lists.freedesktop.org
Cc: devicetree@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org,
	emma@anholt.net, Dave Stevenson <dave.stevenson@raspberrypi.com>,
	airlied@linux.ie, Chris Morgan <macromorgan@hotmail.com>,
	robh+dt@kernel.org, thierry.reding@gmail.com, mchehab@kernel.org,
	sam@ravnborg.org, linux-media@vger.kernel.org
Subject: [RESEND 6/6 v2] drm/vc4: dpi: Support DPI interface in mode3 for RGB565
Date: Thu, 19 May 2022 11:29:35 -0500	[thread overview]
Message-ID: <20220519162935.1585-7-macroalpha82@gmail.com> (raw)
In-Reply-To: <20220519162935.1585-1-macroalpha82@gmail.com>

From: Chris Morgan <macromorgan@hotmail.com>

Add support for the VC4 DPI driver to utilize DPI mode 3. This is
defined here as xxxRRRRRxxGGGGGGxxxBBBBB:
https://www.raspberrypi.com/documentation/computers/raspberry-pi.html#parallel-display-interface-dpi

This mode is required to use the Geekworm MZP280 DPI display.

Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
Reviewed-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
---
 drivers/gpu/drm/vc4/vc4_dpi.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/gpu/drm/vc4/vc4_dpi.c b/drivers/gpu/drm/vc4/vc4_dpi.c
index c180eb60b..3c58ade25 100644
--- a/drivers/gpu/drm/vc4/vc4_dpi.c
+++ b/drivers/gpu/drm/vc4/vc4_dpi.c
@@ -173,6 +173,10 @@ static void vc4_dpi_encoder_enable(struct drm_encoder *encoder)
 			dpi_c |= VC4_SET_FIELD(DPI_FORMAT_16BIT_565_RGB_3,
 					       DPI_FORMAT);
 			break;
+		case MEDIA_BUS_FMT_RGB565_1X24_CPADHI:
+			dpi_c |= VC4_SET_FIELD(DPI_FORMAT_16BIT_565_RGB_2,
+					       DPI_FORMAT);
+			break;
 		default:
 			DRM_ERROR("Unknown media bus format %d\n", bus_format);
 			break;
-- 
2.25.1


  parent reply	other threads:[~2022-05-19 16:30 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-19 16:29 [RESEND 0/6 v2] Support Geekworm MZP280 Panel for Raspberry Pi Chris Morgan
2022-05-19 16:29 ` Chris Morgan
2022-05-19 16:29 ` [RESEND 1/6 v2] dt-bindings: vendor-prefixes: Add Geekworm Chris Morgan
2022-05-19 16:29   ` Chris Morgan
2022-05-20  7:44   ` Krzysztof Kozlowski
2022-05-20  7:44     ` Krzysztof Kozlowski
2022-05-19 16:29 ` [RESEND 2/6 v2] media: uapi: Document format MEDIA_BUS_FMT_RGB565_1X24_CPADHI Chris Morgan
2022-05-19 16:29   ` Chris Morgan
2022-11-24 15:11   ` Hans Verkuil
2022-11-24 15:11     ` Hans Verkuil
2022-05-19 16:29 ` [RESEND 3/6 v2] media: uapi: add MEDIA_BUS_FMT_RGB565_1X24_CPADHI Chris Morgan
2022-05-19 16:29   ` Chris Morgan
2022-11-24 15:11   ` Hans Verkuil
2022-11-24 15:11     ` Hans Verkuil
2022-05-19 16:29 ` [RESEND 4/6 v2] dt-bindings: display: simple: add Geekworm MZP280 Panel Chris Morgan
2022-05-19 16:29   ` Chris Morgan
2022-05-20  7:54   ` Krzysztof Kozlowski
2022-05-20  7:54     ` Krzysztof Kozlowski
2022-05-19 16:29 ` [RESEND 5/6 v2] drm/panel: " Chris Morgan
2022-05-19 16:29   ` Chris Morgan
2022-05-19 16:29 ` Chris Morgan [this message]
2022-05-19 16:29   ` [RESEND 6/6 v2] drm/vc4: dpi: Support DPI interface in mode3 for RGB565 Chris Morgan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220519162935.1585-7-macroalpha82@gmail.com \
    --to=macroalpha82@gmail.com \
    --cc=airlied@linux.ie \
    --cc=daniel@ffwll.ch \
    --cc=dave.stevenson@raspberrypi.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=emma@anholt.net \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-media@vger.kernel.org \
    --cc=macromorgan@hotmail.com \
    --cc=mchehab@kernel.org \
    --cc=mripard@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=sam@ravnborg.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.