All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hsin-Yi Wang <hsinyi@chromium.org>
To: Chun-Kuang Hu <chunkuang.hu@kernel.org>
Cc: Rob Clark <robdclark@chromium.org>,
	Rob Herring <robh+dt@kernel.org>, David Airlie <airlied@linux.ie>,
	linux-kernel@vger.kernel.org,
	Douglas Anderson <dianders@chromium.org>,
	Stephen Boyd <swboyd@chromium.org>,
	Hans de Goede <hdegoede@redhat.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	linux-mediatek@lists.infradead.org,
	dri-devel@lists.freedesktop.org,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Sam Ravnborg <sam@ravnborg.org>,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 4/8] drm/panel: lvds: Implement .get_orientation callback
Date: Mon,  6 Jun 2022 23:24:27 +0800	[thread overview]
Message-ID: <20220606152431.1889185-5-hsinyi@chromium.org> (raw)
In-Reply-To: <20220606152431.1889185-1-hsinyi@chromium.org>

To return the orientation property to drm/kms driver.

Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
---
v3->v4: rebase to latest linux-next to solve conflict.
---
 drivers/gpu/drm/panel/panel-lvds.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-lvds.c b/drivers/gpu/drm/panel/panel-lvds.c
index f11252fb00fe..491b64c2c8d6 100644
--- a/drivers/gpu/drm/panel/panel-lvds.c
+++ b/drivers/gpu/drm/panel/panel-lvds.c
@@ -99,15 +99,30 @@ static int panel_lvds_get_modes(struct drm_panel *panel,
 	drm_display_info_set_bus_formats(&connector->display_info,
 					 &lvds->bus_format, 1);
 	connector->display_info.bus_flags = lvds->bus_flags;
+
+	/*
+	 * drm drivers are expected to call drm_panel_get_orientation() to get
+	 * panel's orientation then drm_connector_set_panel_orientation() to
+	 * set the property before drm_dev_register(). Otherwise there will be
+	 * a WARN_ON if orientation is set after drm is registered.
+	 */
 	drm_connector_set_panel_orientation(connector, lvds->orientation);
 
 	return 1;
 }
 
+static enum drm_panel_orientation panel_lvds_get_orientation,(struct drm_panel *panel)
+{
+       struct panel_lvds *lvds = to_panel_lvds(panel);
+
+       return lvds->orientation;
+}
+
 static const struct drm_panel_funcs panel_lvds_funcs = {
 	.unprepare = panel_lvds_unprepare,
 	.prepare = panel_lvds_prepare,
 	.get_modes = panel_lvds_get_modes,
+	.get_orientation = panel_lvds_get_orientation,
 };
 
 static int panel_lvds_parse_dt(struct panel_lvds *lvds)
-- 
2.36.1.255.ge46751e96f-goog


WARNING: multiple messages have this Message-ID (diff)
From: Hsin-Yi Wang <hsinyi@chromium.org>
To: Chun-Kuang Hu <chunkuang.hu@kernel.org>
Cc: Hans de Goede <hdegoede@redhat.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	Sam Ravnborg <sam@ravnborg.org>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	dri-devel@lists.freedesktop.org,
	linux-mediatek@lists.infradead.org,
	Rob Clark <robdclark@chromium.org>,
	Stephen Boyd <swboyd@chromium.org>,
	Douglas Anderson <dianders@chromium.org>,
	Rob Herring <robh+dt@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH v4 4/8] drm/panel: lvds: Implement .get_orientation callback
Date: Mon,  6 Jun 2022 23:24:27 +0800	[thread overview]
Message-ID: <20220606152431.1889185-5-hsinyi@chromium.org> (raw)
In-Reply-To: <20220606152431.1889185-1-hsinyi@chromium.org>

To return the orientation property to drm/kms driver.

Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
---
v3->v4: rebase to latest linux-next to solve conflict.
---
 drivers/gpu/drm/panel/panel-lvds.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-lvds.c b/drivers/gpu/drm/panel/panel-lvds.c
index f11252fb00fe..491b64c2c8d6 100644
--- a/drivers/gpu/drm/panel/panel-lvds.c
+++ b/drivers/gpu/drm/panel/panel-lvds.c
@@ -99,15 +99,30 @@ static int panel_lvds_get_modes(struct drm_panel *panel,
 	drm_display_info_set_bus_formats(&connector->display_info,
 					 &lvds->bus_format, 1);
 	connector->display_info.bus_flags = lvds->bus_flags;
+
+	/*
+	 * drm drivers are expected to call drm_panel_get_orientation() to get
+	 * panel's orientation then drm_connector_set_panel_orientation() to
+	 * set the property before drm_dev_register(). Otherwise there will be
+	 * a WARN_ON if orientation is set after drm is registered.
+	 */
 	drm_connector_set_panel_orientation(connector, lvds->orientation);
 
 	return 1;
 }
 
+static enum drm_panel_orientation panel_lvds_get_orientation,(struct drm_panel *panel)
+{
+       struct panel_lvds *lvds = to_panel_lvds(panel);
+
+       return lvds->orientation;
+}
+
 static const struct drm_panel_funcs panel_lvds_funcs = {
 	.unprepare = panel_lvds_unprepare,
 	.prepare = panel_lvds_prepare,
 	.get_modes = panel_lvds_get_modes,
+	.get_orientation = panel_lvds_get_orientation,
 };
 
 static int panel_lvds_parse_dt(struct panel_lvds *lvds)
-- 
2.36.1.255.ge46751e96f-goog


WARNING: multiple messages have this Message-ID (diff)
From: Hsin-Yi Wang <hsinyi@chromium.org>
To: Chun-Kuang Hu <chunkuang.hu@kernel.org>
Cc: Hans de Goede <hdegoede@redhat.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	Sam Ravnborg <sam@ravnborg.org>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	dri-devel@lists.freedesktop.org,
	linux-mediatek@lists.infradead.org,
	Rob Clark <robdclark@chromium.org>,
	Stephen Boyd <swboyd@chromium.org>,
	Douglas Anderson <dianders@chromium.org>,
	Rob Herring <robh+dt@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH v4 4/8] drm/panel: lvds: Implement .get_orientation callback
Date: Mon,  6 Jun 2022 23:24:27 +0800	[thread overview]
Message-ID: <20220606152431.1889185-5-hsinyi@chromium.org> (raw)
In-Reply-To: <20220606152431.1889185-1-hsinyi@chromium.org>

To return the orientation property to drm/kms driver.

Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
---
v3->v4: rebase to latest linux-next to solve conflict.
---
 drivers/gpu/drm/panel/panel-lvds.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-lvds.c b/drivers/gpu/drm/panel/panel-lvds.c
index f11252fb00fe..491b64c2c8d6 100644
--- a/drivers/gpu/drm/panel/panel-lvds.c
+++ b/drivers/gpu/drm/panel/panel-lvds.c
@@ -99,15 +99,30 @@ static int panel_lvds_get_modes(struct drm_panel *panel,
 	drm_display_info_set_bus_formats(&connector->display_info,
 					 &lvds->bus_format, 1);
 	connector->display_info.bus_flags = lvds->bus_flags;
+
+	/*
+	 * drm drivers are expected to call drm_panel_get_orientation() to get
+	 * panel's orientation then drm_connector_set_panel_orientation() to
+	 * set the property before drm_dev_register(). Otherwise there will be
+	 * a WARN_ON if orientation is set after drm is registered.
+	 */
 	drm_connector_set_panel_orientation(connector, lvds->orientation);
 
 	return 1;
 }
 
+static enum drm_panel_orientation panel_lvds_get_orientation,(struct drm_panel *panel)
+{
+       struct panel_lvds *lvds = to_panel_lvds(panel);
+
+       return lvds->orientation;
+}
+
 static const struct drm_panel_funcs panel_lvds_funcs = {
 	.unprepare = panel_lvds_unprepare,
 	.prepare = panel_lvds_prepare,
 	.get_modes = panel_lvds_get_modes,
+	.get_orientation = panel_lvds_get_orientation,
 };
 
 static int panel_lvds_parse_dt(struct panel_lvds *lvds)
-- 
2.36.1.255.ge46751e96f-goog


_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: Hsin-Yi Wang <hsinyi@chromium.org>
To: Chun-Kuang Hu <chunkuang.hu@kernel.org>
Cc: Hans de Goede <hdegoede@redhat.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	Sam Ravnborg <sam@ravnborg.org>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	dri-devel@lists.freedesktop.org,
	linux-mediatek@lists.infradead.org,
	Rob Clark <robdclark@chromium.org>,
	Stephen Boyd <swboyd@chromium.org>,
	Douglas Anderson <dianders@chromium.org>,
	Rob Herring <robh+dt@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH v4 4/8] drm/panel: lvds: Implement .get_orientation callback
Date: Mon,  6 Jun 2022 23:24:27 +0800	[thread overview]
Message-ID: <20220606152431.1889185-5-hsinyi@chromium.org> (raw)
In-Reply-To: <20220606152431.1889185-1-hsinyi@chromium.org>

To return the orientation property to drm/kms driver.

Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
---
v3->v4: rebase to latest linux-next to solve conflict.
---
 drivers/gpu/drm/panel/panel-lvds.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-lvds.c b/drivers/gpu/drm/panel/panel-lvds.c
index f11252fb00fe..491b64c2c8d6 100644
--- a/drivers/gpu/drm/panel/panel-lvds.c
+++ b/drivers/gpu/drm/panel/panel-lvds.c
@@ -99,15 +99,30 @@ static int panel_lvds_get_modes(struct drm_panel *panel,
 	drm_display_info_set_bus_formats(&connector->display_info,
 					 &lvds->bus_format, 1);
 	connector->display_info.bus_flags = lvds->bus_flags;
+
+	/*
+	 * drm drivers are expected to call drm_panel_get_orientation() to get
+	 * panel's orientation then drm_connector_set_panel_orientation() to
+	 * set the property before drm_dev_register(). Otherwise there will be
+	 * a WARN_ON if orientation is set after drm is registered.
+	 */
 	drm_connector_set_panel_orientation(connector, lvds->orientation);
 
 	return 1;
 }
 
+static enum drm_panel_orientation panel_lvds_get_orientation,(struct drm_panel *panel)
+{
+       struct panel_lvds *lvds = to_panel_lvds(panel);
+
+       return lvds->orientation;
+}
+
 static const struct drm_panel_funcs panel_lvds_funcs = {
 	.unprepare = panel_lvds_unprepare,
 	.prepare = panel_lvds_prepare,
 	.get_modes = panel_lvds_get_modes,
+	.get_orientation = panel_lvds_get_orientation,
 };
 
 static int panel_lvds_parse_dt(struct panel_lvds *lvds)
-- 
2.36.1.255.ge46751e96f-goog


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2022-06-06 15:24 UTC|newest]

Thread overview: 88+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-06 15:24 [PATCH v4 0/8] Add a panel API to return panel orientation Hsin-Yi Wang
2022-06-06 15:24 ` Hsin-Yi Wang
2022-06-06 15:24 ` Hsin-Yi Wang
2022-06-06 15:24 ` Hsin-Yi Wang
2022-06-06 15:24 ` [PATCH v4 1/8] drm/panel: Add an API drm_panel_get_orientation() " Hsin-Yi Wang
2022-06-06 15:24   ` Hsin-Yi Wang
2022-06-06 15:24   ` Hsin-Yi Wang
2022-06-06 15:24   ` Hsin-Yi Wang
2022-06-06 19:06   ` Stephen Boyd
2022-06-06 19:06     ` Stephen Boyd
2022-06-06 19:06     ` Stephen Boyd
2022-06-06 19:06     ` Stephen Boyd
2022-06-07  7:53     ` Hsin-Yi Wang
2022-06-07  7:53       ` Hsin-Yi Wang
2022-06-07  7:53       ` Hsin-Yi Wang
2022-06-07  7:53       ` Hsin-Yi Wang
2022-06-06 19:20   ` Sam Ravnborg
2022-06-06 19:20     ` Sam Ravnborg
2022-06-06 19:20     ` Sam Ravnborg
2022-06-06 19:20     ` Sam Ravnborg
2022-06-06 20:15     ` Hans de Goede
2022-06-06 20:15       ` Hans de Goede
2022-06-06 20:15       ` Hans de Goede
2022-06-06 20:15       ` Hans de Goede
2022-06-06 20:50       ` Sam Ravnborg
2022-06-06 20:50         ` Sam Ravnborg
2022-06-06 20:50         ` Sam Ravnborg
2022-06-06 20:50         ` Sam Ravnborg
2022-06-06 15:24 ` [PATCH v4 2/8] drm/panel: boe-tv101wum-nl6: Implement .get_orientation callback Hsin-Yi Wang
2022-06-06 15:24   ` Hsin-Yi Wang
2022-06-06 15:24   ` Hsin-Yi Wang
2022-06-06 15:24   ` Hsin-Yi Wang
2022-06-06 15:24 ` [PATCH v4 3/8] drm/panel: panel-edp: " Hsin-Yi Wang
2022-06-06 15:24   ` Hsin-Yi Wang
2022-06-06 15:24   ` Hsin-Yi Wang
2022-06-06 15:24   ` Hsin-Yi Wang
2022-06-06 15:24 ` Hsin-Yi Wang [this message]
2022-06-06 15:24   ` [PATCH v4 4/8] drm/panel: lvds: " Hsin-Yi Wang
2022-06-06 15:24   ` Hsin-Yi Wang
2022-06-06 15:24   ` Hsin-Yi Wang
2022-06-06 19:08   ` Stephen Boyd
2022-06-06 19:08     ` Stephen Boyd
2022-06-06 19:08     ` Stephen Boyd
2022-06-06 19:08     ` Stephen Boyd
2022-06-06 15:24 ` [PATCH v4 5/8] drm/panel: panel-simple: " Hsin-Yi Wang
2022-06-06 15:24   ` Hsin-Yi Wang
2022-06-06 15:24   ` Hsin-Yi Wang
2022-06-06 15:24   ` Hsin-Yi Wang
2022-06-06 19:25   ` Sam Ravnborg
2022-06-06 19:25     ` Sam Ravnborg
2022-06-06 19:25     ` Sam Ravnborg
2022-06-06 19:25     ` Sam Ravnborg
2022-06-07  3:54     ` Hsin-Yi Wang
2022-06-07  3:54       ` Hsin-Yi Wang
2022-06-07  3:54       ` Hsin-Yi Wang
2022-06-07  3:54       ` Hsin-Yi Wang
2022-06-06 15:24 ` [PATCH v4 6/8] drm/panel: ili9881c: " Hsin-Yi Wang
2022-06-06 15:24   ` Hsin-Yi Wang
2022-06-06 15:24   ` Hsin-Yi Wang
2022-06-06 15:24   ` Hsin-Yi Wang
2022-06-06 15:24 ` [PATCH v4 7/8] drm/panel: elida-kd35t133: " Hsin-Yi Wang
2022-06-06 15:24   ` Hsin-Yi Wang
2022-06-06 15:24   ` Hsin-Yi Wang
2022-06-06 15:24   ` Hsin-Yi Wang
2022-06-06 15:24 ` [PATCH v4 8/8] drm/mediatek: Config orientation property if panel provides it Hsin-Yi Wang
2022-06-06 15:24   ` Hsin-Yi Wang
2022-06-06 15:24   ` Hsin-Yi Wang
2022-06-06 15:24   ` Hsin-Yi Wang
2022-06-06 19:16   ` Stephen Boyd
2022-06-06 19:16     ` Stephen Boyd
2022-06-06 19:16     ` Stephen Boyd
2022-06-06 19:16     ` Stephen Boyd
2022-06-07  3:46     ` Hsin-Yi Wang
2022-06-07  3:46       ` Hsin-Yi Wang
2022-06-07  3:46       ` Hsin-Yi Wang
2022-06-07  3:46       ` Hsin-Yi Wang
2022-06-06 19:31   ` Sam Ravnborg
2022-06-06 19:31     ` Sam Ravnborg
2022-06-06 19:31     ` Sam Ravnborg
2022-06-06 19:31     ` Sam Ravnborg
2022-06-07  3:53     ` Hsin-Yi Wang
2022-06-07  3:53       ` Hsin-Yi Wang
2022-06-07  3:53       ` Hsin-Yi Wang
2022-06-07  3:53       ` Hsin-Yi Wang
2022-06-06 19:28 ` [PATCH v4 0/8] Add a panel API to return panel orientation Sam Ravnborg
2022-06-06 19:28   ` Sam Ravnborg
2022-06-06 19:28   ` Sam Ravnborg
2022-06-06 19:28   ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220606152431.1889185-5-hsinyi@chromium.org \
    --to=hsinyi@chromium.org \
    --cc=airlied@linux.ie \
    --cc=chunkuang.hu@kernel.org \
    --cc=dianders@chromium.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hdegoede@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=robdclark@chromium.org \
    --cc=robh+dt@kernel.org \
    --cc=sam@ravnborg.org \
    --cc=swboyd@chromium.org \
    --cc=thierry.reding@gmail.com \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.