All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bo-Chen Chen <rex-bc.chen@mediatek.com>
To: <chunkuang.hu@kernel.org>, <p.zabel@pengutronix.de>,
	<daniel@ffwll.ch>, <robh+dt@kernel.org>,
	<krzysztof.kozlowski+dt@linaro.org>, <matthias.bgg@gmail.com>,
	<airlied@linux.ie>
Cc: <msp@baylibre.com>, <granquet@baylibre.com>,
	<jitao.shi@mediatek.com>, <wenst@chromium.org>,
	<angelogioacchino.delregno@collabora.com>, <ck.hu@mediatek.com>,
	<dri-devel@lists.freedesktop.org>,
	<linux-mediatek@lists.infradead.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<Project_Global_Chrome_Upstream_Group@mediatek.com>,
	Bo-Chen Chen <rex-bc.chen@mediatek.com>
Subject: [PATCH v12 08/14] drm/mediatek: dpi: move the yuv422_en_bit to SoC config
Date: Mon, 20 Jun 2022 20:10:22 +0800	[thread overview]
Message-ID: <20220620121028.29234-9-rex-bc.chen@mediatek.com> (raw)
In-Reply-To: <20220620121028.29234-1-rex-bc.chen@mediatek.com>

From: Guillaume Ranquet <granquet@baylibre.com>

Add flexibility by moving the yuv422 en bit to SoC specific config

Signed-off-by: Guillaume Ranquet <granquet@baylibre.com>
Signed-off-by: Bo-Chen Chen <rex-bc.chen@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Reviewed-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
Reviewed-by: CK Hu <ck.hu@mediatek.com>
---
 drivers/gpu/drm/mediatek/mtk_dpi.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c
index fcd3941f8003..c0ee6b18a057 100644
--- a/drivers/gpu/drm/mediatek/mtk_dpi.c
+++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
@@ -132,6 +132,7 @@ struct mtk_dpi_conf {
 	/* HSIZE and VSIZE mask (no shift) */
 	u32 hvsize_mask;
 	u32 channel_swap_shift;
+	u32 yuv422_en_bit;
 };
 
 static void mtk_dpi_mask(struct mtk_dpi *dpi, u32 offset, u32 val, u32 mask)
@@ -369,7 +370,8 @@ static void mtk_dpi_config_channel_swap(struct mtk_dpi *dpi,
 
 static void mtk_dpi_config_yuv422_enable(struct mtk_dpi *dpi, bool enable)
 {
-	mtk_dpi_mask(dpi, DPI_CON, enable ? YUV422_EN : 0, YUV422_EN);
+	mtk_dpi_mask(dpi, DPI_CON, enable ? dpi->conf->yuv422_en_bit : 0,
+		     dpi->conf->yuv422_en_bit);
 }
 
 static void mtk_dpi_config_csc_enable(struct mtk_dpi *dpi, bool enable)
@@ -833,6 +835,7 @@ static const struct mtk_dpi_conf mt8173_conf = {
 	.dimension_mask = HPW_MASK,
 	.hvsize_mask = HSIZE_MASK,
 	.channel_swap_shift = CH_SWAP,
+	.yuv422_en_bit = YUV422_EN,
 };
 
 static const struct mtk_dpi_conf mt2701_conf = {
@@ -847,6 +850,7 @@ static const struct mtk_dpi_conf mt2701_conf = {
 	.dimension_mask = HPW_MASK,
 	.hvsize_mask = HSIZE_MASK,
 	.channel_swap_shift = CH_SWAP,
+	.yuv422_en_bit = YUV422_EN,
 };
 
 static const struct mtk_dpi_conf mt8183_conf = {
@@ -860,6 +864,7 @@ static const struct mtk_dpi_conf mt8183_conf = {
 	.dimension_mask = HPW_MASK,
 	.hvsize_mask = HSIZE_MASK,
 	.channel_swap_shift = CH_SWAP,
+	.yuv422_en_bit = YUV422_EN,
 };
 
 static const struct mtk_dpi_conf mt8192_conf = {
@@ -873,6 +878,7 @@ static const struct mtk_dpi_conf mt8192_conf = {
 	.dimension_mask = HPW_MASK,
 	.hvsize_mask = HSIZE_MASK,
 	.channel_swap_shift = CH_SWAP,
+	.yuv422_en_bit = YUV422_EN,
 };
 
 static int mtk_dpi_probe(struct platform_device *pdev)
-- 
2.18.0


WARNING: multiple messages have this Message-ID (diff)
From: Bo-Chen Chen <rex-bc.chen@mediatek.com>
To: <chunkuang.hu@kernel.org>, <p.zabel@pengutronix.de>,
	<daniel@ffwll.ch>, <robh+dt@kernel.org>,
	<krzysztof.kozlowski+dt@linaro.org>, <matthias.bgg@gmail.com>,
	<airlied@linux.ie>
Cc: devicetree@vger.kernel.org, granquet@baylibre.com,
	jitao.shi@mediatek.com, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org, msp@baylibre.com,
	Project_Global_Chrome_Upstream_Group@mediatek.com,
	Bo-Chen Chen <rex-bc.chen@mediatek.com>,
	linux-mediatek@lists.infradead.org, wenst@chromium.org,
	linux-arm-kernel@lists.infradead.org,
	angelogioacchino.delregno@collabora.com
Subject: [PATCH v12 08/14] drm/mediatek: dpi: move the yuv422_en_bit to SoC config
Date: Mon, 20 Jun 2022 20:10:22 +0800	[thread overview]
Message-ID: <20220620121028.29234-9-rex-bc.chen@mediatek.com> (raw)
In-Reply-To: <20220620121028.29234-1-rex-bc.chen@mediatek.com>

From: Guillaume Ranquet <granquet@baylibre.com>

Add flexibility by moving the yuv422 en bit to SoC specific config

Signed-off-by: Guillaume Ranquet <granquet@baylibre.com>
Signed-off-by: Bo-Chen Chen <rex-bc.chen@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Reviewed-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
Reviewed-by: CK Hu <ck.hu@mediatek.com>
---
 drivers/gpu/drm/mediatek/mtk_dpi.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c
index fcd3941f8003..c0ee6b18a057 100644
--- a/drivers/gpu/drm/mediatek/mtk_dpi.c
+++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
@@ -132,6 +132,7 @@ struct mtk_dpi_conf {
 	/* HSIZE and VSIZE mask (no shift) */
 	u32 hvsize_mask;
 	u32 channel_swap_shift;
+	u32 yuv422_en_bit;
 };
 
 static void mtk_dpi_mask(struct mtk_dpi *dpi, u32 offset, u32 val, u32 mask)
@@ -369,7 +370,8 @@ static void mtk_dpi_config_channel_swap(struct mtk_dpi *dpi,
 
 static void mtk_dpi_config_yuv422_enable(struct mtk_dpi *dpi, bool enable)
 {
-	mtk_dpi_mask(dpi, DPI_CON, enable ? YUV422_EN : 0, YUV422_EN);
+	mtk_dpi_mask(dpi, DPI_CON, enable ? dpi->conf->yuv422_en_bit : 0,
+		     dpi->conf->yuv422_en_bit);
 }
 
 static void mtk_dpi_config_csc_enable(struct mtk_dpi *dpi, bool enable)
@@ -833,6 +835,7 @@ static const struct mtk_dpi_conf mt8173_conf = {
 	.dimension_mask = HPW_MASK,
 	.hvsize_mask = HSIZE_MASK,
 	.channel_swap_shift = CH_SWAP,
+	.yuv422_en_bit = YUV422_EN,
 };
 
 static const struct mtk_dpi_conf mt2701_conf = {
@@ -847,6 +850,7 @@ static const struct mtk_dpi_conf mt2701_conf = {
 	.dimension_mask = HPW_MASK,
 	.hvsize_mask = HSIZE_MASK,
 	.channel_swap_shift = CH_SWAP,
+	.yuv422_en_bit = YUV422_EN,
 };
 
 static const struct mtk_dpi_conf mt8183_conf = {
@@ -860,6 +864,7 @@ static const struct mtk_dpi_conf mt8183_conf = {
 	.dimension_mask = HPW_MASK,
 	.hvsize_mask = HSIZE_MASK,
 	.channel_swap_shift = CH_SWAP,
+	.yuv422_en_bit = YUV422_EN,
 };
 
 static const struct mtk_dpi_conf mt8192_conf = {
@@ -873,6 +878,7 @@ static const struct mtk_dpi_conf mt8192_conf = {
 	.dimension_mask = HPW_MASK,
 	.hvsize_mask = HSIZE_MASK,
 	.channel_swap_shift = CH_SWAP,
+	.yuv422_en_bit = YUV422_EN,
 };
 
 static int mtk_dpi_probe(struct platform_device *pdev)
-- 
2.18.0


WARNING: multiple messages have this Message-ID (diff)
From: Bo-Chen Chen <rex-bc.chen@mediatek.com>
To: <chunkuang.hu@kernel.org>, <p.zabel@pengutronix.de>,
	<daniel@ffwll.ch>, <robh+dt@kernel.org>,
	<krzysztof.kozlowski+dt@linaro.org>, <matthias.bgg@gmail.com>,
	<airlied@linux.ie>
Cc: <msp@baylibre.com>, <granquet@baylibre.com>,
	<jitao.shi@mediatek.com>, <wenst@chromium.org>,
	<angelogioacchino.delregno@collabora.com>, <ck.hu@mediatek.com>,
	<dri-devel@lists.freedesktop.org>,
	<linux-mediatek@lists.infradead.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<Project_Global_Chrome_Upstream_Group@mediatek.com>,
	Bo-Chen Chen <rex-bc.chen@mediatek.com>
Subject: [PATCH v12 08/14] drm/mediatek: dpi: move the yuv422_en_bit to SoC config
Date: Mon, 20 Jun 2022 20:10:22 +0800	[thread overview]
Message-ID: <20220620121028.29234-9-rex-bc.chen@mediatek.com> (raw)
In-Reply-To: <20220620121028.29234-1-rex-bc.chen@mediatek.com>

From: Guillaume Ranquet <granquet@baylibre.com>

Add flexibility by moving the yuv422 en bit to SoC specific config

Signed-off-by: Guillaume Ranquet <granquet@baylibre.com>
Signed-off-by: Bo-Chen Chen <rex-bc.chen@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Reviewed-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
Reviewed-by: CK Hu <ck.hu@mediatek.com>
---
 drivers/gpu/drm/mediatek/mtk_dpi.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c
index fcd3941f8003..c0ee6b18a057 100644
--- a/drivers/gpu/drm/mediatek/mtk_dpi.c
+++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
@@ -132,6 +132,7 @@ struct mtk_dpi_conf {
 	/* HSIZE and VSIZE mask (no shift) */
 	u32 hvsize_mask;
 	u32 channel_swap_shift;
+	u32 yuv422_en_bit;
 };
 
 static void mtk_dpi_mask(struct mtk_dpi *dpi, u32 offset, u32 val, u32 mask)
@@ -369,7 +370,8 @@ static void mtk_dpi_config_channel_swap(struct mtk_dpi *dpi,
 
 static void mtk_dpi_config_yuv422_enable(struct mtk_dpi *dpi, bool enable)
 {
-	mtk_dpi_mask(dpi, DPI_CON, enable ? YUV422_EN : 0, YUV422_EN);
+	mtk_dpi_mask(dpi, DPI_CON, enable ? dpi->conf->yuv422_en_bit : 0,
+		     dpi->conf->yuv422_en_bit);
 }
 
 static void mtk_dpi_config_csc_enable(struct mtk_dpi *dpi, bool enable)
@@ -833,6 +835,7 @@ static const struct mtk_dpi_conf mt8173_conf = {
 	.dimension_mask = HPW_MASK,
 	.hvsize_mask = HSIZE_MASK,
 	.channel_swap_shift = CH_SWAP,
+	.yuv422_en_bit = YUV422_EN,
 };
 
 static const struct mtk_dpi_conf mt2701_conf = {
@@ -847,6 +850,7 @@ static const struct mtk_dpi_conf mt2701_conf = {
 	.dimension_mask = HPW_MASK,
 	.hvsize_mask = HSIZE_MASK,
 	.channel_swap_shift = CH_SWAP,
+	.yuv422_en_bit = YUV422_EN,
 };
 
 static const struct mtk_dpi_conf mt8183_conf = {
@@ -860,6 +864,7 @@ static const struct mtk_dpi_conf mt8183_conf = {
 	.dimension_mask = HPW_MASK,
 	.hvsize_mask = HSIZE_MASK,
 	.channel_swap_shift = CH_SWAP,
+	.yuv422_en_bit = YUV422_EN,
 };
 
 static const struct mtk_dpi_conf mt8192_conf = {
@@ -873,6 +878,7 @@ static const struct mtk_dpi_conf mt8192_conf = {
 	.dimension_mask = HPW_MASK,
 	.hvsize_mask = HSIZE_MASK,
 	.channel_swap_shift = CH_SWAP,
+	.yuv422_en_bit = YUV422_EN,
 };
 
 static int mtk_dpi_probe(struct platform_device *pdev)
-- 
2.18.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2022-06-20 12:11 UTC|newest]

Thread overview: 108+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-20 12:10 [PATCH v12 00/14] drm/mediatek: Add MT8195 dp_intf driver Bo-Chen Chen
2022-06-20 12:10 ` Bo-Chen Chen
2022-06-20 12:10 ` Bo-Chen Chen
2022-06-20 12:10 ` [PATCH v12 01/14] dt-bindings: mediatek,dpi: Add DP_INTF compatible Bo-Chen Chen
2022-06-20 12:10   ` Bo-Chen Chen
2022-06-20 12:10   ` Bo-Chen Chen
2022-06-20 12:25   ` Maxime Ripard
2022-06-20 12:25     ` Maxime Ripard
2022-06-20 12:25     ` Maxime Ripard
2022-06-20 12:33     ` Rex-BC Chen
2022-06-20 12:33       ` Rex-BC Chen
2022-06-20 12:33       ` Rex-BC Chen
2022-06-20 12:10 ` [PATCH v12 02/14] drm/mediatek: dpi: Add support for quantization range Bo-Chen Chen
2022-06-20 12:10   ` Bo-Chen Chen
2022-06-20 12:10   ` Bo-Chen Chen
2022-06-21  1:40   ` CK Hu
2022-06-21  1:40     ` CK Hu
2022-06-21  1:40     ` CK Hu
2022-06-20 12:10 ` [PATCH v12 03/14] drm/mediatek: dpi: implement a CK/DE pol toggle in SoC config Bo-Chen Chen
2022-06-20 12:10   ` Bo-Chen Chen
2022-06-20 12:10   ` Bo-Chen Chen
2022-06-20 12:10 ` [PATCH v12 04/14] drm/mediatek: dpi: implement a swap_input " Bo-Chen Chen
2022-06-20 12:10   ` Bo-Chen Chen
2022-06-20 12:10   ` Bo-Chen Chen
2022-06-21  1:44   ` CK Hu
2022-06-21  1:44     ` CK Hu
2022-06-21  1:44     ` CK Hu
2022-06-20 12:10 ` [PATCH v12 05/14] drm/mediatek: dpi: move dimension mask to " Bo-Chen Chen
2022-06-20 12:10   ` Bo-Chen Chen
2022-06-20 12:10   ` Bo-Chen Chen
2022-06-20 12:10 ` [PATCH v12 06/14] drm/mediatek: dpi: move hvsize_mask " Bo-Chen Chen
2022-06-20 12:10   ` Bo-Chen Chen
2022-06-20 12:10   ` Bo-Chen Chen
2022-06-20 12:10 ` [PATCH v12 07/14] drm/mediatek: dpi: move swap_shift " Bo-Chen Chen
2022-06-20 12:10   ` Bo-Chen Chen
2022-06-20 12:10   ` Bo-Chen Chen
2022-06-20 12:10 ` Bo-Chen Chen [this message]
2022-06-20 12:10   ` [PATCH v12 08/14] drm/mediatek: dpi: move the yuv422_en_bit " Bo-Chen Chen
2022-06-20 12:10   ` Bo-Chen Chen
2022-06-20 12:10 ` [PATCH v12 09/14] drm/mediatek: dpi: move the csc_enable bit " Bo-Chen Chen
2022-06-20 12:10   ` Bo-Chen Chen
2022-06-20 12:10   ` Bo-Chen Chen
2022-06-20 12:10 ` [PATCH v12 10/14] drm/mediatek: dpi: Add dpintf support Bo-Chen Chen
2022-06-20 12:10   ` Bo-Chen Chen
2022-06-20 12:10   ` Bo-Chen Chen
2022-06-21  2:32   ` CK Hu
2022-06-21  2:32     ` CK Hu
2022-06-21  2:32     ` CK Hu
2022-06-21  8:46     ` Rex-BC Chen
2022-06-21  8:46       ` Rex-BC Chen
2022-06-21  8:46       ` Rex-BC Chen
2022-06-20 12:10 ` [PATCH v12 11/14] drm/mediatek: dpi: Add tvd_clk enable/disable flow Bo-Chen Chen
2022-06-20 12:10   ` Bo-Chen Chen
2022-06-20 12:10   ` Bo-Chen Chen
2022-06-21  2:55   ` CK Hu
2022-06-21  2:55     ` CK Hu
2022-06-21  2:55     ` CK Hu
2022-06-21  3:11     ` Rex-BC Chen
2022-06-21  3:11       ` Rex-BC Chen
2022-06-21  3:11       ` Rex-BC Chen
2022-06-21  3:45       ` CK Hu
2022-06-21  3:45         ` CK Hu
2022-06-21  3:45         ` CK Hu
2022-06-21  3:50         ` Rex-BC Chen
2022-06-21  3:50           ` Rex-BC Chen
2022-06-21  3:50           ` Rex-BC Chen
2022-06-21  4:08           ` CK Hu
2022-06-21  4:08             ` CK Hu
2022-06-21  4:08             ` CK Hu
2022-06-21  5:47             ` Rex-BC Chen
2022-06-21  5:47               ` Rex-BC Chen
2022-06-21  5:47               ` Rex-BC Chen
2022-06-21  5:54               ` CK Hu
2022-06-21  5:54                 ` CK Hu
2022-06-21  5:54                 ` CK Hu
2022-06-21  5:59                 ` Rex-BC Chen
2022-06-21  5:59                   ` Rex-BC Chen
2022-06-21  5:59                   ` Rex-BC Chen
2022-06-20 12:10 ` [PATCH v12 12/14] drm/mediatek: dpi: Add YUV422 output support Bo-Chen Chen
2022-06-20 12:10   ` Bo-Chen Chen
2022-06-20 12:10   ` Bo-Chen Chen
2022-06-21  3:04   ` CK Hu
2022-06-21  3:04     ` CK Hu
2022-06-21  3:04     ` CK Hu
2022-06-21  8:39     ` Rex-BC Chen
2022-06-21  8:39       ` Rex-BC Chen
2022-06-21  8:39       ` Rex-BC Chen
2022-06-20 12:10 ` [PATCH v12 13/14] drm/mediatek: dpi: Only enable dpi after the bridge is enabled Bo-Chen Chen
2022-06-20 12:10   ` Bo-Chen Chen
2022-06-20 12:10   ` Bo-Chen Chen
2022-06-21  3:18   ` CK Hu
2022-06-21  3:18     ` CK Hu
2022-06-21  3:18     ` CK Hu
2022-06-21  6:02     ` Rex-BC Chen
2022-06-21  6:02       ` Rex-BC Chen
2022-06-21  6:02       ` Rex-BC Chen
2022-06-20 12:10 ` [PATCH v12 14/14] drm/mediatek: dpi: Add matrix_sel helper Bo-Chen Chen
2022-06-20 12:10   ` Bo-Chen Chen
2022-06-20 12:10   ` Bo-Chen Chen
2022-06-21  3:33   ` CK Hu
2022-06-21  3:33     ` CK Hu
2022-06-21  3:33     ` CK Hu
2022-06-21  8:41     ` Rex-BC Chen
2022-06-21  8:41       ` Rex-BC Chen
2022-06-21  8:41       ` Rex-BC Chen
2022-06-21  9:12       ` CK Hu
2022-06-21  9:12         ` CK Hu
2022-06-21  9:12         ` CK Hu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220620121028.29234-9-rex-bc.chen@mediatek.com \
    --to=rex-bc.chen@mediatek.com \
    --cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
    --cc=airlied@linux.ie \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=chunkuang.hu@kernel.org \
    --cc=ck.hu@mediatek.com \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=granquet@baylibre.com \
    --cc=jitao.shi@mediatek.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=msp@baylibre.com \
    --cc=p.zabel@pengutronix.de \
    --cc=robh+dt@kernel.org \
    --cc=wenst@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.