From: Allison Henderson <allison.henderson@oracle.com>
To: linux-xfs@vger.kernel.org
Subject: [PATCH RESEND v2 00/18] Parent Pointers
Date: Thu, 4 Aug 2022 12:39:55 -0700 [thread overview]
Message-ID: <20220804194013.99237-1-allison.henderson@oracle.com> (raw)
Hi all,
This is a rebase and resend of the latest parent pointer attributes for xfs.
The goal of this patch set is to add a parent pointer attribute to each inode.
The attribute name containing the parent inode, generation, and directory
offset, while the attribute value contains the file name. This feature will
enable future optimizations for online scrub, or any other feature that could
make use of quickly deriving an inodes path from the mount point.
This set can be viewed on github here
https://github.com/allisonhenderson/xfs/tree/xfs_new_pptrsv2_rebase
And the corresponding xfsprogs code is here
https://github.com/allisonhenderson/xfsprogs/tree/xfsprogs_new_pptrsv2
This set has been tested with the below parent pointers tests
https://www.spinics.net/lists/fstests/msg19963.html
Updates since v1:
xfs: Fix multi-transaction larp replay
Resend (from stand alone patch)
xfs: Increase XFS_DEFER_OPS_NR_INODES to 5
Increased XFS_DEFER_OPS_NR_INODES from 4 to 5
Moved to beginning of the set
Added code in xfs_defer_ops_continue to sort the inodes
Added commentary about which inodes are locked
xfs: Hold inode locks in xfs_trans_alloc_dir
New patch
xfs: add parent pointer support to attribute code
Typo fix
xfs: extend transaction reservations for parent attribute
Made xfs_calc_parent_ptr_reservations static
Whitespace fixes
xfs: parent pointer attribute creation
Fixed SPDX License Headers
Updated xfs_sb_version_hasparent to xfs_has_parent
Type def conversions
Whitespace
Added helper functions: xfs_parent_init, xfs_parent_defer_add,
xfs_parent_cancel
Investigated mount option that overrides larp option:
The larp global itself isnt used with in the delayed ops machinery due
to race conditions with the syscall being toggled. Pptrs dont toggle
so we can just set XFS_DA_OP_LOGGED to log the pptr with out requireing
all attrs be logged
xfs: add parent attributes to link
Rebase to use new helpers: xfs_parent_init, xfs_parent_defer_add,
xfs_parent_cancel, xfs_has_parent
xfs: add parent attributes to unlink
rebase to use new helpers
added helper function xfs_parent_defer_remove
xfs: Add parent pointers to rename
added extra parent remove for target_ip unlinks
rebase to use new helpers
xfs: Add the parent pointer support to the superblock version 5.
changed XFS_SB_FEAT_RO_COMPAT_PARENT to XFS_SB_FEAT_INCOMPAT_PARENT
xfs: Add parent pointer ioctl
Added pi_parents[] to struct xfs_parent_ptr
Changed pptr helper defines into inline functions
White space/indentation
Reordered flag check in xfs_ioc_get_parent_pointer to be before the alloc
Added gen number check in xfs_ioc_get_parent_pointer
Init args in loop body of xfs_attr_get_parent_pointer
Questions comments and feedback appreciated!
Thanks all!
Allison
Allison Henderson (18):
xfs: Fix multi-transaction larp replay
xfs: Increase XFS_DEFER_OPS_NR_INODES to 5
xfs: Hold inode locks in xfs_ialloc
xfs: Hold inode locks in xfs_trans_alloc_dir
xfs: get directory offset when adding directory name
xfs: get directory offset when removing directory name
xfs: get directory offset when replacing a directory name
xfs: add parent pointer support to attribute code
xfs: define parent pointer xattr format
xfs: Add xfs_verify_pptr
xfs: extend transaction reservations for parent attributes
xfs: parent pointer attribute creation
xfs: add parent attributes to link
xfs: remove parent pointers in unlink
xfs: Add parent pointers to rename
xfs: Add the parent pointer support to the superblock version 5.
xfs: Add helper function xfs_attr_list_context_init
xfs: Add parent pointer ioctl
fs/xfs/Makefile | 2 +
fs/xfs/libxfs/xfs_attr.c | 53 ++++++-
fs/xfs/libxfs/xfs_attr.h | 8 +-
fs/xfs/libxfs/xfs_da_btree.h | 1 +
fs/xfs/libxfs/xfs_da_format.h | 30 +++-
fs/xfs/libxfs/xfs_defer.c | 28 +++-
fs/xfs/libxfs/xfs_defer.h | 8 +-
fs/xfs/libxfs/xfs_dir2.c | 21 ++-
fs/xfs/libxfs/xfs_dir2.h | 7 +-
fs/xfs/libxfs/xfs_dir2_block.c | 9 +-
fs/xfs/libxfs/xfs_dir2_leaf.c | 8 +-
fs/xfs/libxfs/xfs_dir2_node.c | 8 +-
fs/xfs/libxfs/xfs_dir2_sf.c | 6 +
fs/xfs/libxfs/xfs_format.h | 4 +-
fs/xfs/libxfs/xfs_fs.h | 58 +++++++
fs/xfs/libxfs/xfs_log_format.h | 1 +
fs/xfs/libxfs/xfs_parent.c | 159 +++++++++++++++++++
fs/xfs/libxfs/xfs_parent.h | 39 +++++
fs/xfs/libxfs/xfs_sb.c | 4 +
fs/xfs/libxfs/xfs_trans_resv.c | 105 ++++++++++---
fs/xfs/scrub/attr.c | 2 +-
fs/xfs/xfs_attr_item.c | 41 ++---
fs/xfs/xfs_attr_list.c | 17 ++-
fs/xfs/xfs_file.c | 1 +
fs/xfs/xfs_inode.c | 271 +++++++++++++++++++++++++--------
fs/xfs/xfs_inode.h | 1 +
fs/xfs/xfs_ioctl.c | 149 +++++++++++++++---
fs/xfs/xfs_ioctl.h | 2 +
fs/xfs/xfs_ondisk.h | 4 +
fs/xfs/xfs_parent_utils.c | 134 ++++++++++++++++
fs/xfs/xfs_parent_utils.h | 22 +++
fs/xfs/xfs_qm.c | 4 +-
fs/xfs/xfs_super.c | 4 +
fs/xfs/xfs_symlink.c | 6 +-
fs/xfs/xfs_trans.c | 6 +-
fs/xfs/xfs_xattr.c | 2 +-
fs/xfs/xfs_xattr.h | 1 +
37 files changed, 1056 insertions(+), 170 deletions(-)
create mode 100644 fs/xfs/libxfs/xfs_parent.c
create mode 100644 fs/xfs/libxfs/xfs_parent.h
create mode 100644 fs/xfs/xfs_parent_utils.c
create mode 100644 fs/xfs/xfs_parent_utils.h
--
2.25.1
next reply other threads:[~2022-08-04 19:40 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-04 19:39 Allison Henderson [this message]
2022-08-04 19:39 ` [PATCH RESEND v2 01/18] xfs: Fix multi-transaction larp replay Allison Henderson
2022-08-09 16:52 ` Darrick J. Wong
2022-08-10 1:58 ` Dave Chinner
2022-08-10 5:01 ` Alli
2022-08-10 6:12 ` Dave Chinner
2022-08-10 15:52 ` Darrick J. Wong
2022-08-10 19:28 ` Alli
2022-08-12 1:55 ` Alli
2022-08-12 3:05 ` Darrick J. Wong
2022-08-16 0:54 ` Dave Chinner
2022-08-16 5:07 ` Darrick J. Wong
2022-08-16 20:41 ` Alli
2022-08-19 1:05 ` Alli
2022-08-23 15:07 ` Darrick J. Wong
2022-08-24 18:47 ` Alli
2022-08-10 3:08 ` Alli
2022-08-04 19:39 ` [PATCH RESEND v2 02/18] xfs: Increase XFS_DEFER_OPS_NR_INODES to 5 Allison Henderson
2022-08-09 16:38 ` Darrick J. Wong
2022-08-10 3:07 ` Alli
2022-08-04 19:39 ` [PATCH RESEND v2 03/18] xfs: Hold inode locks in xfs_ialloc Allison Henderson
2022-08-04 19:39 ` [PATCH RESEND v2 04/18] xfs: Hold inode locks in xfs_trans_alloc_dir Allison Henderson
2022-08-04 19:40 ` [PATCH RESEND v2 05/18] xfs: get directory offset when adding directory name Allison Henderson
2022-08-04 19:40 ` [PATCH RESEND v2 06/18] xfs: get directory offset when removing " Allison Henderson
2022-08-04 19:40 ` [PATCH RESEND v2 07/18] xfs: get directory offset when replacing a " Allison Henderson
2022-08-04 19:40 ` [PATCH RESEND v2 08/18] xfs: add parent pointer support to attribute code Allison Henderson
2022-08-09 16:54 ` Darrick J. Wong
2022-08-10 3:08 ` Alli
2022-08-04 19:40 ` [PATCH RESEND v2 09/18] xfs: define parent pointer xattr format Allison Henderson
2022-08-04 19:40 ` [PATCH RESEND v2 10/18] xfs: Add xfs_verify_pptr Allison Henderson
2022-08-09 16:59 ` Darrick J. Wong
2022-08-10 3:08 ` Alli
2022-08-04 19:40 ` [PATCH RESEND v2 11/18] xfs: extend transaction reservations for parent attributes Allison Henderson
2022-08-09 17:48 ` Darrick J. Wong
2022-08-10 3:08 ` Alli
2022-08-04 19:40 ` [PATCH RESEND v2 12/18] xfs: parent pointer attribute creation Allison Henderson
2022-08-09 18:01 ` Darrick J. Wong
2022-08-09 18:13 ` Darrick J. Wong
2022-08-10 3:09 ` Alli
2022-08-10 3:08 ` Alli
2022-08-04 19:40 ` [PATCH RESEND v2 13/18] xfs: add parent attributes to link Allison Henderson
2022-08-09 18:43 ` Darrick J. Wong
2022-08-10 3:09 ` Alli
2022-09-23 20:25 ` Darrick J. Wong
2022-08-04 19:40 ` [PATCH RESEND v2 14/18] xfs: remove parent pointers in unlink Allison Henderson
2022-08-09 18:45 ` Darrick J. Wong
2022-08-10 3:09 ` Alli
2022-08-04 19:40 ` [PATCH RESEND v2 15/18] xfs: Add parent pointers to rename Allison Henderson
2022-08-09 18:49 ` Darrick J. Wong
2022-08-10 3:09 ` Alli
2022-08-04 19:40 ` [PATCH RESEND v2 16/18] xfs: Add the parent pointer support to the superblock version 5 Allison Henderson
2022-08-04 19:40 ` [PATCH RESEND v2 17/18] xfs: Add helper function xfs_attr_list_context_init Allison Henderson
2022-08-04 19:40 ` [PATCH RESEND v2 18/18] xfs: Add parent pointer ioctl Allison Henderson
2022-08-09 19:26 ` Darrick J. Wong
2022-08-10 3:09 ` Alli
2022-09-24 0:01 ` Darrick J. Wong
2022-08-09 22:55 ` [RFC PATCH 19/18] xfs: fix unit conversion error in xfs_log_calc_max_attrsetm_res Darrick J. Wong
2022-08-09 22:56 ` [RFC PATCH 20/18] xfs: drop compatibility minimum log size computations for reflink Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220804194013.99237-1-allison.henderson@oracle.com \
--to=allison.henderson@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.