All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maxime Ripard <maxime@cerno.tech>
To: linux-clk@vger.kernel.org,
	Mike Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>
Cc: Tony Lindgren <tony@atomide.com>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Neil Armstrong <narmstrong@baylibre.com>,
	Yassine Oudjana <y.oudjana@protonmail.com>,
	Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Naresh Kamboju <naresh.kamboju@linaro.org>,
	Alexander Stein <alexander.stein@ew.tq-group.com>,
	Maxime Ripard <maxime@cerno.tech>
Subject: [PATCH v8 17/25] clk: Add our request boundaries in clk_core_init_rate_req
Date: Mon, 15 Aug 2022 17:41:39 +0200	[thread overview]
Message-ID: <20220815154147.1631441-18-maxime@cerno.tech> (raw)
In-Reply-To: <20220815154147.1631441-1-maxime@cerno.tech>

The expectation is that a new clk_rate_request is initialized through a
call to clk_core_init_rate_req().

However, at the moment it only fills the parent rate and clk_hw pointer,
but omits the other fields such as the clock rate boundaries.

Some users of that function will update them after calling it, but most
don't.

As we are passed the clk_core pointer, we have access to those
boundaries in clk_core_init_rate_req() however, so let's just fill it
there and remove it from the few callers that do it right.

Tested-by: Alexander Stein <alexander.stein@ew.tq-group.com> # imx8mp
Tested-by: Marek Szyprowski <m.szyprowski@samsung.com> # exynos4210, meson g12b
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
---
 drivers/clk/clk.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index 195f051ee536..cd5b298f445e 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -1389,6 +1389,7 @@ static void clk_core_init_rate_req(struct clk_core * const core,
 		return;
 
 	req->rate = rate;
+	clk_core_get_boundaries(core, &req->min_rate, &req->max_rate);
 
 	parent = core->parent;
 	if (parent) {
@@ -1483,7 +1484,6 @@ unsigned long clk_hw_round_rate(struct clk_hw *hw, unsigned long rate)
 	struct clk_rate_request req;
 
 	clk_core_init_rate_req(hw->core, &req, rate);
-	clk_core_get_boundaries(hw->core, &req.min_rate, &req.max_rate);
 
 	ret = clk_core_round_rate_nolock(hw->core, &req);
 	if (ret)
@@ -1516,7 +1516,6 @@ long clk_round_rate(struct clk *clk, unsigned long rate)
 		clk_core_rate_unprotect(clk->core);
 
 	clk_core_init_rate_req(clk->core, &req, rate);
-	clk_core_get_boundaries(clk->core, &req.min_rate, &req.max_rate);
 
 	ret = clk_core_round_rate_nolock(clk->core, &req);
 
@@ -2022,9 +2021,6 @@ static struct clk_core *clk_calc_new_rates(struct clk_core *core,
 	if (clk_core_can_round(core)) {
 		struct clk_rate_request req;
 
-		req.min_rate = min_rate;
-		req.max_rate = max_rate;
-
 		clk_core_init_rate_req(core, &req, rate);
 
 		ret = clk_core_determine_round_nolock(core, &req);
@@ -2225,7 +2221,6 @@ static unsigned long clk_core_req_round_rate_nolock(struct clk_core *core,
 		return cnt;
 
 	clk_core_init_rate_req(core, &req, req_rate);
-	clk_core_get_boundaries(core, &req.min_rate, &req.max_rate);
 
 	ret = clk_core_round_rate_nolock(core, &req);
 
-- 
2.37.1


  parent reply	other threads:[~2022-08-15 15:43 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-15 15:41 [PATCH v8 00/25] clk: More clock rate fixes and tests Maxime Ripard
2022-08-15 15:41 ` [PATCH v8 01/25] clk: test: Switch to clk_hw_get_clk Maxime Ripard
2022-08-15 15:41 ` [PATCH v8 02/25] clk: Drop the rate range on clk_put() Maxime Ripard
2022-08-15 15:41 ` [PATCH v8 03/25] clk: Skip clamping when rounding if there's no boundaries Maxime Ripard
2022-08-15 15:41 ` [PATCH v8 04/25] clk: Mention that .recalc_rate can return 0 on error Maxime Ripard
2022-08-15 15:41 ` [PATCH v8 05/25] clk: Clarify clk_get_rate() expectations Maxime Ripard
2022-08-15 15:41 ` [PATCH v8 06/25] clk: tests: Add test suites description Maxime Ripard
2022-08-15 15:41 ` [PATCH v8 07/25] clk: tests: Add reference to the orphan mux bug report Maxime Ripard
2022-08-15 15:41 ` [PATCH v8 08/25] clk: tests: Add tests for uncached clock Maxime Ripard
2022-08-15 15:41 ` [PATCH v8 09/25] clk: tests: Add tests for single parent mux Maxime Ripard
2022-08-15 15:41 ` [PATCH v8 10/25] clk: tests: Add tests for mux with multiple parents Maxime Ripard
2022-08-15 15:41 ` [PATCH v8 11/25] clk: tests: Add some tests for orphan " Maxime Ripard
2022-08-15 15:41 ` [PATCH v8 12/25] clk: Take into account uncached clocks in clk_set_rate_range() Maxime Ripard
2022-08-15 15:41 ` [PATCH v8 13/25] clk: Set req_rate on reparenting Maxime Ripard
2022-08-16  8:30   ` Alexander Stein
2022-08-16  9:24     ` Maxime Ripard
2022-08-16  9:57       ` Alexander Stein
2022-08-16 11:14         ` Maxime Ripard
2022-08-15 15:41 ` [PATCH v8 14/25] clk: Change clk_core_init_rate_req prototype Maxime Ripard
2022-08-15 15:41 ` [PATCH v8 15/25] clk: Move clk_core_init_rate_req() from clk_core_round_rate_nolock() to its caller Maxime Ripard
2022-08-15 15:41 ` [PATCH v8 16/25] clk: Introduce clk_hw_init_rate_request() Maxime Ripard
2022-08-15 15:41 ` Maxime Ripard [this message]
2022-08-15 15:41 ` [PATCH v8 18/25] clk: Switch from __clk_determine_rate to clk_core_round_rate_nolock Maxime Ripard
2022-08-15 15:41 ` [PATCH v8 19/25] clk: Introduce clk_core_has_parent() Maxime Ripard
2022-08-15 15:41 ` [PATCH v8 20/25] clk: Constify clk_has_parent() Maxime Ripard
2022-08-15 15:41 ` [PATCH v8 21/25] clk: Stop forwarding clk_rate_requests to the parent Maxime Ripard
2022-08-15 15:41 ` [PATCH v8 22/25] clk: Zero the clk_rate_request structure Maxime Ripard
2022-08-15 15:41 ` [PATCH v8 23/25] clk: Introduce the clk_hw_get_rate_range function Maxime Ripard
2022-08-15 15:41 ` [PATCH v8 24/25] clk: qcom: clk-rcg2: Take clock boundaries into consideration for gfx3d Maxime Ripard
2022-08-15 15:41 ` [PATCH v8 25/25] clk: tests: Add missing test case for ranges Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220815154147.1631441-18-maxime@cerno.tech \
    --to=maxime@cerno.tech \
    --cc=alexander.stein@ew.tq-group.com \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=jbrunet@baylibre.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=mturquette@baylibre.com \
    --cc=naresh.kamboju@linaro.org \
    --cc=narmstrong@baylibre.com \
    --cc=sboyd@kernel.org \
    --cc=tony@atomide.com \
    --cc=y.oudjana@protonmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.