All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chunfeng Yun <chunfeng.yun@mediatek.com>
To: Vinod Koul <vkoul@kernel.org>, Rob Herring <robh+dt@kernel.org>
Cc: Chunfeng Yun <chunfeng.yun@mediatek.com>,
	Kishon Vijay Abraham I <kishon@ti.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-mediatek@lists.infradead.org>,
	<linux-phy@lists.infradead.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Eddie Hung <eddie.hung@mediatek.com>
Subject: [PATCH v2 7/7] phy: phy-mtk-tphy: fix the phy type setting issue
Date: Mon, 29 Aug 2022 16:08:30 +0800	[thread overview]
Message-ID: <20220829080830.5378-7-chunfeng.yun@mediatek.com> (raw)
In-Reply-To: <20220829080830.5378-1-chunfeng.yun@mediatek.com>

The PHY type is not set if the index is non zero, prepare type
value according to the index, like as mask value.

Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
v2: no changes
---
 drivers/phy/mediatek/phy-mtk-tphy.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/phy/mediatek/phy-mtk-tphy.c b/drivers/phy/mediatek/phy-mtk-tphy.c
index e0f227a0d3cc..cc10298bc70d 100644
--- a/drivers/phy/mediatek/phy-mtk-tphy.c
+++ b/drivers/phy/mediatek/phy-mtk-tphy.c
@@ -915,7 +915,7 @@ static int phy_type_syscon_get(struct mtk_phy_instance *instance,
 static int phy_type_set(struct mtk_phy_instance *instance)
 {
 	int type;
-	u32 mask;
+	u32 offset;
 
 	if (!instance->type_sw)
 		return 0;
@@ -938,8 +938,9 @@ static int phy_type_set(struct mtk_phy_instance *instance)
 		return 0;
 	}
 
-	mask = RG_PHY_SW_TYPE << (instance->type_sw_index * BITS_PER_BYTE);
-	regmap_update_bits(instance->type_sw, instance->type_sw_reg, mask, type);
+	offset = instance->type_sw_index * BITS_PER_BYTE;
+	regmap_update_bits(instance->type_sw, instance->type_sw_reg,
+			   RG_PHY_SW_TYPE << offset, type << offset);
 
 	return 0;
 }
-- 
2.18.0


WARNING: multiple messages have this Message-ID (diff)
From: Chunfeng Yun <chunfeng.yun@mediatek.com>
To: Vinod Koul <vkoul@kernel.org>, Rob Herring <robh+dt@kernel.org>
Cc: Chunfeng Yun <chunfeng.yun@mediatek.com>,
	Kishon Vijay Abraham I <kishon@ti.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-mediatek@lists.infradead.org>,
	<linux-phy@lists.infradead.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Eddie Hung <eddie.hung@mediatek.com>
Subject: [PATCH v2 7/7] phy: phy-mtk-tphy: fix the phy type setting issue
Date: Mon, 29 Aug 2022 16:08:30 +0800	[thread overview]
Message-ID: <20220829080830.5378-7-chunfeng.yun@mediatek.com> (raw)
In-Reply-To: <20220829080830.5378-1-chunfeng.yun@mediatek.com>

The PHY type is not set if the index is non zero, prepare type
value according to the index, like as mask value.

Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
v2: no changes
---
 drivers/phy/mediatek/phy-mtk-tphy.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/phy/mediatek/phy-mtk-tphy.c b/drivers/phy/mediatek/phy-mtk-tphy.c
index e0f227a0d3cc..cc10298bc70d 100644
--- a/drivers/phy/mediatek/phy-mtk-tphy.c
+++ b/drivers/phy/mediatek/phy-mtk-tphy.c
@@ -915,7 +915,7 @@ static int phy_type_syscon_get(struct mtk_phy_instance *instance,
 static int phy_type_set(struct mtk_phy_instance *instance)
 {
 	int type;
-	u32 mask;
+	u32 offset;
 
 	if (!instance->type_sw)
 		return 0;
@@ -938,8 +938,9 @@ static int phy_type_set(struct mtk_phy_instance *instance)
 		return 0;
 	}
 
-	mask = RG_PHY_SW_TYPE << (instance->type_sw_index * BITS_PER_BYTE);
-	regmap_update_bits(instance->type_sw, instance->type_sw_reg, mask, type);
+	offset = instance->type_sw_index * BITS_PER_BYTE;
+	regmap_update_bits(instance->type_sw, instance->type_sw_reg,
+			   RG_PHY_SW_TYPE << offset, type << offset);
 
 	return 0;
 }
-- 
2.18.0


-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

WARNING: multiple messages have this Message-ID (diff)
From: Chunfeng Yun <chunfeng.yun@mediatek.com>
To: Vinod Koul <vkoul@kernel.org>, Rob Herring <robh+dt@kernel.org>
Cc: Chunfeng Yun <chunfeng.yun@mediatek.com>,
	Kishon Vijay Abraham I <kishon@ti.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-mediatek@lists.infradead.org>,
	<linux-phy@lists.infradead.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Eddie Hung <eddie.hung@mediatek.com>
Subject: [PATCH v2 7/7] phy: phy-mtk-tphy: fix the phy type setting issue
Date: Mon, 29 Aug 2022 16:08:30 +0800	[thread overview]
Message-ID: <20220829080830.5378-7-chunfeng.yun@mediatek.com> (raw)
In-Reply-To: <20220829080830.5378-1-chunfeng.yun@mediatek.com>

The PHY type is not set if the index is non zero, prepare type
value according to the index, like as mask value.

Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
v2: no changes
---
 drivers/phy/mediatek/phy-mtk-tphy.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/phy/mediatek/phy-mtk-tphy.c b/drivers/phy/mediatek/phy-mtk-tphy.c
index e0f227a0d3cc..cc10298bc70d 100644
--- a/drivers/phy/mediatek/phy-mtk-tphy.c
+++ b/drivers/phy/mediatek/phy-mtk-tphy.c
@@ -915,7 +915,7 @@ static int phy_type_syscon_get(struct mtk_phy_instance *instance,
 static int phy_type_set(struct mtk_phy_instance *instance)
 {
 	int type;
-	u32 mask;
+	u32 offset;
 
 	if (!instance->type_sw)
 		return 0;
@@ -938,8 +938,9 @@ static int phy_type_set(struct mtk_phy_instance *instance)
 		return 0;
 	}
 
-	mask = RG_PHY_SW_TYPE << (instance->type_sw_index * BITS_PER_BYTE);
-	regmap_update_bits(instance->type_sw, instance->type_sw_reg, mask, type);
+	offset = instance->type_sw_index * BITS_PER_BYTE;
+	regmap_update_bits(instance->type_sw, instance->type_sw_reg,
+			   RG_PHY_SW_TYPE << offset, type << offset);
 
 	return 0;
 }
-- 
2.18.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2022-08-29  8:09 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-29  8:08 [PATCH v2 1/7] dt-bindings: phy: mediatek,tphy: add support type of SGMII Chunfeng Yun
2022-08-29  8:08 ` Chunfeng Yun
2022-08-29  8:08 ` Chunfeng Yun
2022-08-29  8:08 ` [PATCH v2 2/7] dt-bindings: phy: mediatek,tphy: add property to set pre-emphasis Chunfeng Yun
2022-08-29  8:08   ` Chunfeng Yun
2022-08-29  8:08   ` Chunfeng Yun
2022-08-30 17:38   ` Krzysztof Kozlowski
2022-08-30 17:38     ` Krzysztof Kozlowski
2022-08-30 17:38     ` Krzysztof Kozlowski
2022-08-31  3:14     ` Chunfeng Yun
2022-08-31  3:14       ` Chunfeng Yun
2022-08-31  3:14       ` Chunfeng Yun
2022-08-31  6:02       ` Krzysztof Kozlowski
2022-08-31  6:02         ` Krzysztof Kozlowski
2022-08-31  6:02         ` Krzysztof Kozlowski
2022-09-09  3:07         ` Chunfeng Yun
2022-09-09  3:07           ` Chunfeng Yun
2022-09-09  3:07           ` Chunfeng Yun
2022-09-09  7:11           ` Krzysztof Kozlowski
2022-09-09  7:11             ` Krzysztof Kozlowski
2022-09-09  7:11             ` Krzysztof Kozlowski
2022-09-09  8:27   ` Krzysztof Kozlowski
2022-09-09  8:27     ` Krzysztof Kozlowski
2022-09-09  8:27     ` Krzysztof Kozlowski
2022-08-29  8:08 ` [PATCH v2 3/7] phy: phy-mtk-tphy: " Chunfeng Yun
2022-08-29  8:08   ` Chunfeng Yun
2022-08-29  8:08   ` Chunfeng Yun
2022-08-31  8:14   ` AngeloGioacchino Del Regno
2022-08-31  8:14     ` AngeloGioacchino Del Regno
2022-08-31  8:14     ` AngeloGioacchino Del Regno
2022-09-08  1:39     ` Chunfeng Yun
2022-09-08  1:39       ` Chunfeng Yun
2022-09-08  1:39       ` Chunfeng Yun
2022-09-08  8:05       ` AngeloGioacchino Del Regno
2022-09-08  8:05         ` AngeloGioacchino Del Regno
2022-09-08  8:05         ` AngeloGioacchino Del Regno
2022-09-14  3:22         ` Chunfeng Yun
2022-09-14  3:22           ` Chunfeng Yun
2022-09-14  3:22           ` Chunfeng Yun
2022-08-29  8:08 ` [PATCH v2 4/7] phy: phy-mtk-tphy: disable hardware efuse when set INTR Chunfeng Yun
2022-08-29  8:08   ` Chunfeng Yun
2022-08-29  8:08   ` Chunfeng Yun
2022-08-31  8:22   ` AngeloGioacchino Del Regno
2022-08-31  8:22     ` AngeloGioacchino Del Regno
2022-08-31  8:22     ` AngeloGioacchino Del Regno
2022-08-29  8:08 ` [PATCH v2 5/7] phy: phy-mtk-tphy: disable gpio mode for all usb2 phys Chunfeng Yun
2022-08-29  8:08   ` Chunfeng Yun
2022-08-29  8:08   ` Chunfeng Yun
2022-08-29  8:08 ` [PATCH v2 6/7] phy: phy-mtk-tphy: set utmi 0 register in init() ops Chunfeng Yun
2022-08-29  8:08   ` Chunfeng Yun
2022-08-29  8:08   ` Chunfeng Yun
2022-08-29  8:08 ` Chunfeng Yun [this message]
2022-08-29  8:08   ` [PATCH v2 7/7] phy: phy-mtk-tphy: fix the phy type setting issue Chunfeng Yun
2022-08-29  8:08   ` Chunfeng Yun
2022-08-31  8:31   ` AngeloGioacchino Del Regno
2022-08-31  8:31     ` AngeloGioacchino Del Regno
2022-08-31  8:31     ` AngeloGioacchino Del Regno
2022-09-08  1:27     ` Chunfeng Yun
2022-09-08  1:27       ` Chunfeng Yun
2022-09-08  1:27       ` Chunfeng Yun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220829080830.5378-7-chunfeng.yun@mediatek.com \
    --to=chunfeng.yun@mediatek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=eddie.hung@mediatek.com \
    --cc=kishon@ti.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@canonical.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.