From: Amjad Ouled-Ameur <aouledameur@baylibre.com>
To: Mark Brown <broonie@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Kevin Hilman <khilman@baylibre.com>,
Rob Herring <robh+dt@kernel.org>
Cc: Da Xue <da@libre.computer>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-amlogic@lists.infradead.org,
Neil Armstrong <neil.armstrong@linaro.org>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
Amjad Ouled-Ameur <aouledameur@baylibre.com>
Subject: [PATCH v3 0/2] spi: amlogic: meson-spicc: Use pinctrl to drive CLK line when idle
Date: Wed, 19 Oct 2022 16:01:02 +0200 [thread overview]
Message-ID: <20221004-up-aml-fix-spi-v3-0-89de126fd163@baylibre.com> (raw)
Between SPI transactions, all SPI pins are in HiZ state. When using the SS
signal from the SPICC controller it's not an issue because when the
transaction resumes all pins come back to the right state at the same time
as SS.
The problem is when we use CS as a GPIO. In fact, between the GPIO CS
state change and SPI pins state change from idle, you can have a missing or
spurious clock transition.
Set a bias on the clock depending on the clock polarity requested before CS
goes active, by passing a special "idle-low" and "idle-high" pinctrl state
and setting the right state at a start of a message.
Signed-off-by: Amjad Ouled-Ameur <aouledameur@baylibre.com>
---
Changes in v3:
- Fixed documentation by removing pinctrl states as they are not mandatory.
- Link to v2: https://lore.kernel.org/r/20221004-up-aml-fix-spi-v2-0-3e8ae91a1925@baylibre.com
---
Amjad Ouled-Ameur (2):
spi: dt-bindings: amlogic, meson-gx-spicc: Add pinctrl names for SPI signal states
spi: meson-spicc: Use pinctrl to drive CLK line when idle
.../bindings/spi/amlogic,meson-gx-spicc.yaml | 67 ++++++++++++++--------
arch/arm64/boot/dts/amlogic/meson-gxl.dtsi | 14 +++++
drivers/spi/spi-meson-spicc.c | 39 ++++++++++++-
3 files changed, 94 insertions(+), 26 deletions(-)
---
base-commit: aae703b02f92bde9264366c545e87cec451de471
change-id: 20221004-up-aml-fix-spi-c2bb7e78e603
Best regards,
--
Amjad Ouled-Ameur <aouledameur@baylibre.com>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
WARNING: multiple messages have this Message-ID (diff)
From: Amjad Ouled-Ameur <aouledameur@baylibre.com>
To: Mark Brown <broonie@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Kevin Hilman <khilman@baylibre.com>,
Rob Herring <robh+dt@kernel.org>
Cc: Da Xue <da@libre.computer>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-amlogic@lists.infradead.org,
Neil Armstrong <neil.armstrong@linaro.org>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
Amjad Ouled-Ameur <aouledameur@baylibre.com>
Subject: [PATCH v3 0/2] spi: amlogic: meson-spicc: Use pinctrl to drive CLK line when idle
Date: Wed, 19 Oct 2022 16:01:02 +0200 [thread overview]
Message-ID: <20221004-up-aml-fix-spi-v3-0-89de126fd163@baylibre.com> (raw)
Between SPI transactions, all SPI pins are in HiZ state. When using the SS
signal from the SPICC controller it's not an issue because when the
transaction resumes all pins come back to the right state at the same time
as SS.
The problem is when we use CS as a GPIO. In fact, between the GPIO CS
state change and SPI pins state change from idle, you can have a missing or
spurious clock transition.
Set a bias on the clock depending on the clock polarity requested before CS
goes active, by passing a special "idle-low" and "idle-high" pinctrl state
and setting the right state at a start of a message.
Signed-off-by: Amjad Ouled-Ameur <aouledameur@baylibre.com>
---
Changes in v3:
- Fixed documentation by removing pinctrl states as they are not mandatory.
- Link to v2: https://lore.kernel.org/r/20221004-up-aml-fix-spi-v2-0-3e8ae91a1925@baylibre.com
---
Amjad Ouled-Ameur (2):
spi: dt-bindings: amlogic, meson-gx-spicc: Add pinctrl names for SPI signal states
spi: meson-spicc: Use pinctrl to drive CLK line when idle
.../bindings/spi/amlogic,meson-gx-spicc.yaml | 67 ++++++++++++++--------
arch/arm64/boot/dts/amlogic/meson-gxl.dtsi | 14 +++++
drivers/spi/spi-meson-spicc.c | 39 ++++++++++++-
3 files changed, 94 insertions(+), 26 deletions(-)
---
base-commit: aae703b02f92bde9264366c545e87cec451de471
change-id: 20221004-up-aml-fix-spi-c2bb7e78e603
Best regards,
--
Amjad Ouled-Ameur <aouledameur@baylibre.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Amjad Ouled-Ameur <aouledameur@baylibre.com>
To: Mark Brown <broonie@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Kevin Hilman <khilman@baylibre.com>,
Rob Herring <robh+dt@kernel.org>
Cc: Da Xue <da@libre.computer>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-amlogic@lists.infradead.org,
Neil Armstrong <neil.armstrong@linaro.org>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
Amjad Ouled-Ameur <aouledameur@baylibre.com>
Subject: [PATCH v3 0/2] spi: amlogic: meson-spicc: Use pinctrl to drive CLK line when idle
Date: Wed, 19 Oct 2022 16:01:02 +0200 [thread overview]
Message-ID: <20221004-up-aml-fix-spi-v3-0-89de126fd163@baylibre.com> (raw)
Between SPI transactions, all SPI pins are in HiZ state. When using the SS
signal from the SPICC controller it's not an issue because when the
transaction resumes all pins come back to the right state at the same time
as SS.
The problem is when we use CS as a GPIO. In fact, between the GPIO CS
state change and SPI pins state change from idle, you can have a missing or
spurious clock transition.
Set a bias on the clock depending on the clock polarity requested before CS
goes active, by passing a special "idle-low" and "idle-high" pinctrl state
and setting the right state at a start of a message.
Signed-off-by: Amjad Ouled-Ameur <aouledameur@baylibre.com>
---
Changes in v3:
- Fixed documentation by removing pinctrl states as they are not mandatory.
- Link to v2: https://lore.kernel.org/r/20221004-up-aml-fix-spi-v2-0-3e8ae91a1925@baylibre.com
---
Amjad Ouled-Ameur (2):
spi: dt-bindings: amlogic, meson-gx-spicc: Add pinctrl names for SPI signal states
spi: meson-spicc: Use pinctrl to drive CLK line when idle
.../bindings/spi/amlogic,meson-gx-spicc.yaml | 67 ++++++++++++++--------
arch/arm64/boot/dts/amlogic/meson-gxl.dtsi | 14 +++++
drivers/spi/spi-meson-spicc.c | 39 ++++++++++++-
3 files changed, 94 insertions(+), 26 deletions(-)
---
base-commit: aae703b02f92bde9264366c545e87cec451de471
change-id: 20221004-up-aml-fix-spi-c2bb7e78e603
Best regards,
--
Amjad Ouled-Ameur <aouledameur@baylibre.com>
next reply other threads:[~2022-10-19 14:03 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-19 14:01 Amjad Ouled-Ameur [this message]
2022-10-19 14:01 ` [PATCH v3 0/2] spi: amlogic: meson-spicc: Use pinctrl to drive CLK line when idle Amjad Ouled-Ameur
2022-10-19 14:01 ` Amjad Ouled-Ameur
2022-10-19 14:01 ` [PATCH v3 1/2] spi: dt-bindings: amlogic, meson-gx-spicc: Add pinctrl names for SPI signal states Amjad Ouled-Ameur
2022-10-19 14:01 ` Amjad Ouled-Ameur
2022-10-19 14:01 ` Amjad Ouled-Ameur
2022-10-19 14:29 ` Krzysztof Kozlowski
2022-10-19 14:29 ` Krzysztof Kozlowski
2022-10-19 14:29 ` Krzysztof Kozlowski
2022-10-19 16:53 ` Neil Armstrong
2022-10-19 16:53 ` Neil Armstrong
2022-10-19 16:53 ` Neil Armstrong
2022-10-20 12:49 ` Krzysztof Kozlowski
2022-10-20 12:49 ` Krzysztof Kozlowski
2022-10-20 12:49 ` Krzysztof Kozlowski
2022-10-21 12:54 ` Amjad Ouled-Ameur
2022-10-21 12:54 ` Amjad Ouled-Ameur
2022-10-21 12:54 ` Amjad Ouled-Ameur
2022-10-21 12:59 ` Krzysztof Kozlowski
2022-10-21 12:59 ` Krzysztof Kozlowski
2022-10-21 12:59 ` Krzysztof Kozlowski
2022-10-19 23:31 ` Rob Herring
2022-10-19 23:31 ` Rob Herring
2022-10-19 23:31 ` Rob Herring
2022-10-19 14:01 ` [PATCH v3 2/2] spi: meson-spicc: Use pinctrl to drive CLK line when idle Amjad Ouled-Ameur
2022-10-19 14:01 ` Amjad Ouled-Ameur
2022-10-19 14:01 ` Amjad Ouled-Ameur
2022-10-19 20:50 ` Martin Blumenstingl
2022-10-19 20:50 ` Martin Blumenstingl
2022-10-19 20:50 ` Martin Blumenstingl
2022-10-20 8:18 ` Neil Armstrong
2022-10-20 8:18 ` Neil Armstrong
2022-10-20 8:18 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221004-up-aml-fix-spi-v3-0-89de126fd163@baylibre.com \
--to=aouledameur@baylibre.com \
--cc=broonie@kernel.org \
--cc=da@libre.computer \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.