All of lore.kernel.org
 help / color / mirror / Atom feed
From: Colin Foster <colin.foster@in-advantage.com>
To: linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Cc: "Tony Lindgren" <tony@atomide.com>,
	"Benoît Cousson" <bcousson@baylibre.com>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	soc@kernel.org, "Olof Johansson" <olof@lixom.net>,
	"Arnd Bergmann" <arnd@arndb.de>
Subject: [RFC v1 0/1] add support for Phytec PCM-049 and PCM-959
Date: Mon,  3 Oct 2022 19:40:11 -0700	[thread overview]
Message-ID: <20221004024012.1386218-1-colin.foster@in-advantage.com> (raw)

As should be clear for the title and patch title, this is adding initial
support for the OMAP 4460 SOM and dev kit for Phytec's PCM959 evaluation
kit.

The PCM049 is a legacy SOM offered by Phytec:
https://www.phytec.com/legacy-soms/
There was a vendor BSP offered by Phytec, but that never entered the
Device Tree era. This patch is meant to change that.

This devicetree boots into a stable state from mainline Barebox, where
the devices are supported. I used the Pandaboard as my Buildroot
template to make a bootable SD card. MDEV loads all modules. I'm doing
verification with omap2plus_defconfig.


I'm submitting this as an RFC for two reasons. First, because we're now
in the 6.1 window, but second because there are some uncertainties that
came up while upgrading everything. Particularly around GPMC.

As far as I can tell, the flash and ethernet both work as expected. The
timings from omap-gpmc-smsc9221.dtsi are what is needed (even though
they don't match Barebox). I also used the timings from omap3-ldp.dts as
my guide for the flash timings, as it seemed to be the only OMAP2+ GPMC
device that has Micron NAND.

The main difference that I came across was NAND Flash ECC settings.
Initially I could run `dd if=/dev/mtd0 of=foo count=1` and read the
flash, but see ECC errors. It wasn't until I added
ti,elm-id = <&elm>;
that I saw these errors go away. Seemingly none of this code existed at
the time of the last vendor BSP update (3.4.41) so I'm hopeful that this
is correct - or at least not a "red flag, you're doing it completely
wrong and your flash is going to corrupt itself tomorrow" scenario.



Colin Foster (1):
  arm: dts: omap4: pcm959: add initial support for phytec pcm959

 arch/arm/boot/dts/Makefile                  |   1 +
 arch/arm/boot/dts/omap4-phytec-pcm-049.dtsi | 352 ++++++++++++++++++++
 arch/arm/boot/dts/omap4-phytec-pcm-959.dts  | 130 ++++++++
 3 files changed, 483 insertions(+)
 create mode 100644 arch/arm/boot/dts/omap4-phytec-pcm-049.dtsi
 create mode 100644 arch/arm/boot/dts/omap4-phytec-pcm-959.dts

-- 
2.25.1


WARNING: multiple messages have this Message-ID (diff)
From: Colin Foster <colin.foster@in-advantage.com>
To: linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Cc: "Tony Lindgren" <tony@atomide.com>,
	"Benoît Cousson" <bcousson@baylibre.com>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	soc@kernel.org, "Olof Johansson" <olof@lixom.net>,
	"Arnd Bergmann" <arnd@arndb.de>
Subject: [RFC v1 0/1] add support for Phytec PCM-049 and PCM-959
Date: Mon,  3 Oct 2022 19:40:11 -0700	[thread overview]
Message-ID: <20221004024012.1386218-1-colin.foster@in-advantage.com> (raw)

As should be clear for the title and patch title, this is adding initial
support for the OMAP 4460 SOM and dev kit for Phytec's PCM959 evaluation
kit.

The PCM049 is a legacy SOM offered by Phytec:
https://www.phytec.com/legacy-soms/
There was a vendor BSP offered by Phytec, but that never entered the
Device Tree era. This patch is meant to change that.

This devicetree boots into a stable state from mainline Barebox, where
the devices are supported. I used the Pandaboard as my Buildroot
template to make a bootable SD card. MDEV loads all modules. I'm doing
verification with omap2plus_defconfig.


I'm submitting this as an RFC for two reasons. First, because we're now
in the 6.1 window, but second because there are some uncertainties that
came up while upgrading everything. Particularly around GPMC.

As far as I can tell, the flash and ethernet both work as expected. The
timings from omap-gpmc-smsc9221.dtsi are what is needed (even though
they don't match Barebox). I also used the timings from omap3-ldp.dts as
my guide for the flash timings, as it seemed to be the only OMAP2+ GPMC
device that has Micron NAND.

The main difference that I came across was NAND Flash ECC settings.
Initially I could run `dd if=/dev/mtd0 of=foo count=1` and read the
flash, but see ECC errors. It wasn't until I added
ti,elm-id = <&elm>;
that I saw these errors go away. Seemingly none of this code existed at
the time of the last vendor BSP update (3.4.41) so I'm hopeful that this
is correct - or at least not a "red flag, you're doing it completely
wrong and your flash is going to corrupt itself tomorrow" scenario.



Colin Foster (1):
  arm: dts: omap4: pcm959: add initial support for phytec pcm959

 arch/arm/boot/dts/Makefile                  |   1 +
 arch/arm/boot/dts/omap4-phytec-pcm-049.dtsi | 352 ++++++++++++++++++++
 arch/arm/boot/dts/omap4-phytec-pcm-959.dts  | 130 ++++++++
 3 files changed, 483 insertions(+)
 create mode 100644 arch/arm/boot/dts/omap4-phytec-pcm-049.dtsi
 create mode 100644 arch/arm/boot/dts/omap4-phytec-pcm-959.dts

-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

             reply	other threads:[~2022-10-04  2:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-04  2:40 Colin Foster [this message]
2022-10-04  2:40 ` [RFC v1 0/1] add support for Phytec PCM-049 and PCM-959 Colin Foster
2022-10-04  2:40 ` [RFC v1 1/1] arm: dts: omap4: pcm959: add initial support for phytec pcm959 Colin Foster
2022-10-04  2:40   ` Colin Foster
2022-10-04  7:04   ` Krzysztof Kozlowski
2022-10-04  7:04     ` Krzysztof Kozlowski
2022-10-04 23:01     ` Colin Foster
2022-10-04 23:01       ` Colin Foster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221004024012.1386218-1-colin.foster@in-advantage.com \
    --to=colin.foster@in-advantage.com \
    --cc=arnd@arndb.de \
    --cc=bcousson@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=olof@lixom.net \
    --cc=robh+dt@kernel.org \
    --cc=soc@kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.