All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jianmin Lv <lvjianmin@loongson.cn>
To: Thomas Gleixner <tglx@linutronix.de>, Marc Zyngier <maz@kernel.org>
Cc: linux-kernel@vger.kernel.org, loongarch@lists.linux.dev,
	Jiaxun Yang <jiaxun.yang@flygoat.com>,
	Huacai Chen <chenhuacai@loongson.cn>,
	Bjorn Helgaas <bhelgaas@google.com>, Len Brown <lenb@kernel.org>,
	rafael@kernel.org, linux-pci@vger.kernel.org,
	linux-acpi@vger.kernel.org
Subject: [PATCH V5 2/4] irqchip/loongson-pch-pic: fix translate callback for DT path
Date: Sat, 22 Oct 2022 15:59:53 +0800	[thread overview]
Message-ID: <20221022075955.11726-3-lvjianmin@loongson.cn> (raw)
In-Reply-To: <20221022075955.11726-1-lvjianmin@loongson.cn>

In DT path of translate callback, if fwspec->param_count==1
and of_node is non-null, fwspec->param[1] will be accessed,
which is introduced from previous commit bcdd75c596c8
(irqchip/loongson-pch-pic: Add ACPI init support).

Before the patch, for non-null of_node, translate callback
(use irq_domain_translate_twocell()) will return -EINVAL if
fwspec->param_count < 2, so the check in the patch is added.

Fixes: bcdd75c596c8 ("irqchip/loongson-pch-pic: Add ACPI init support")
Signed-off-by: Jianmin Lv <lvjianmin@loongson.cn>
---
 drivers/irqchip/irq-loongson-pch-pic.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/irqchip/irq-loongson-pch-pic.c b/drivers/irqchip/irq-loongson-pch-pic.c
index c01b9c257005..03493cda65a3 100644
--- a/drivers/irqchip/irq-loongson-pch-pic.c
+++ b/drivers/irqchip/irq-loongson-pch-pic.c
@@ -159,6 +159,9 @@ static int pch_pic_domain_translate(struct irq_domain *d,
 		return -EINVAL;
 
 	if (of_node) {
+		if (fwspec->param_count < 2)
+			return -EINVAL;
+
 		*hwirq = fwspec->param[0] + priv->ht_vec_base;
 		*type = fwspec->param[1] & IRQ_TYPE_SENSE_MASK;
 	} else {
-- 
2.31.1


  parent reply	other threads:[~2022-10-22  8:00 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-22  7:59 [PATCH V5 0/4] irqchip: Support to set irq type for ACPI path Jianmin Lv
2022-10-22  7:59 ` [PATCH V5 1/4] ACPI / PCI: fix LPIC IRQ model default PCI IRQ polarity Jianmin Lv
2022-11-26 13:34   ` [irqchip: irq/irqchip-next] " irqchip-bot for Jianmin Lv
2022-10-22  7:59 ` Jianmin Lv [this message]
2022-11-26 13:34   ` [irqchip: irq/irqchip-next] irqchip/loongson-pch-pic: Fix translate callback for DT path irqchip-bot for Jianmin Lv
2022-10-22  7:59 ` [PATCH V5 3/4] irqchip/loongson-pch-pic: Support to set IRQ type for ACPI path Jianmin Lv
2022-11-26 13:34   ` [irqchip: irq/irqchip-next] " irqchip-bot for Jianmin Lv
2022-10-22  7:59 ` [PATCH V5 4/4] irqchip/loongson-liointc: " Jianmin Lv
2022-11-26 13:34   ` [irqchip: irq/irqchip-next] " irqchip-bot for Jianmin Lv
2022-10-22  8:05 ` [PATCH V5 0/4] irqchip: Support to set irq " Huacai Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221022075955.11726-3-lvjianmin@loongson.cn \
    --to=lvjianmin@loongson.cn \
    --cc=bhelgaas@google.com \
    --cc=chenhuacai@loongson.cn \
    --cc=jiaxun.yang@flygoat.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=loongarch@lists.linux.dev \
    --cc=maz@kernel.org \
    --cc=rafael@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.