All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Cercueil <paul@crapouillou.net>
To: David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>
Cc: linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org,
	Paul Cercueil <paul@crapouillou.net>,
	Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: [PATCH v2 17/26] drm: rcar-du: Remove #ifdef guards for PM related functions
Date: Tue, 29 Nov 2022 19:19:33 +0000	[thread overview]
Message-ID: <20221129191942.138244-4-paul@crapouillou.net> (raw)
In-Reply-To: <20221129191942.138244-1-paul@crapouillou.net>

Use the DEFINE_SIMPLE_DEV_PM_OPS() and pm_sleep_ptr() macros to handle
the .suspend/.resume callbacks.

These macros allow the suspend and resume functions to be automatically
dropped by the compiler when CONFIG_SUSPEND is disabled, without having
to use #ifdef guards.

This has the advantage of always compiling these functions in,
independently of any Kconfig option. Thanks to that, bugs and other
regressions are subsequently easier to catch.

Signed-off-by: Paul Cercueil <paul@crapouillou.net>
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
---
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Cc: linux-renesas-soc@vger.kernel.org
---
 drivers/gpu/drm/rcar-du/rcar_du_drv.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
index d003e8d9e7a2..eeec1e02446f 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
@@ -599,7 +599,6 @@ static const struct drm_driver rcar_du_driver = {
  * Power management
  */
 
-#ifdef CONFIG_PM_SLEEP
 static int rcar_du_pm_suspend(struct device *dev)
 {
 	struct rcar_du_device *rcdu = dev_get_drvdata(dev);
@@ -613,11 +612,9 @@ static int rcar_du_pm_resume(struct device *dev)
 
 	return drm_mode_config_helper_resume(&rcdu->ddev);
 }
-#endif
 
-static const struct dev_pm_ops rcar_du_pm_ops = {
-	SET_SYSTEM_SLEEP_PM_OPS(rcar_du_pm_suspend, rcar_du_pm_resume)
-};
+static DEFINE_SIMPLE_DEV_PM_OPS(rcar_du_pm_ops,
+				rcar_du_pm_suspend, rcar_du_pm_resume);
 
 /* -----------------------------------------------------------------------------
  * Platform driver
@@ -712,7 +709,7 @@ static struct platform_driver rcar_du_platform_driver = {
 	.shutdown	= rcar_du_shutdown,
 	.driver		= {
 		.name	= "rcar-du",
-		.pm	= &rcar_du_pm_ops,
+		.pm	= pm_sleep_ptr(&rcar_du_pm_ops),
 		.of_match_table = rcar_du_of_table,
 	},
 };
-- 
2.35.1


WARNING: multiple messages have this Message-ID (diff)
From: Paul Cercueil <paul@crapouillou.net>
To: David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	Paul Cercueil <paul@crapouillou.net>,
	Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	linux-renesas-soc@vger.kernel.org
Subject: [PATCH v2 17/26] drm: rcar-du: Remove #ifdef guards for PM related functions
Date: Tue, 29 Nov 2022 19:19:33 +0000	[thread overview]
Message-ID: <20221129191942.138244-4-paul@crapouillou.net> (raw)
In-Reply-To: <20221129191942.138244-1-paul@crapouillou.net>

Use the DEFINE_SIMPLE_DEV_PM_OPS() and pm_sleep_ptr() macros to handle
the .suspend/.resume callbacks.

These macros allow the suspend and resume functions to be automatically
dropped by the compiler when CONFIG_SUSPEND is disabled, without having
to use #ifdef guards.

This has the advantage of always compiling these functions in,
independently of any Kconfig option. Thanks to that, bugs and other
regressions are subsequently easier to catch.

Signed-off-by: Paul Cercueil <paul@crapouillou.net>
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
---
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Cc: linux-renesas-soc@vger.kernel.org
---
 drivers/gpu/drm/rcar-du/rcar_du_drv.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
index d003e8d9e7a2..eeec1e02446f 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
@@ -599,7 +599,6 @@ static const struct drm_driver rcar_du_driver = {
  * Power management
  */
 
-#ifdef CONFIG_PM_SLEEP
 static int rcar_du_pm_suspend(struct device *dev)
 {
 	struct rcar_du_device *rcdu = dev_get_drvdata(dev);
@@ -613,11 +612,9 @@ static int rcar_du_pm_resume(struct device *dev)
 
 	return drm_mode_config_helper_resume(&rcdu->ddev);
 }
-#endif
 
-static const struct dev_pm_ops rcar_du_pm_ops = {
-	SET_SYSTEM_SLEEP_PM_OPS(rcar_du_pm_suspend, rcar_du_pm_resume)
-};
+static DEFINE_SIMPLE_DEV_PM_OPS(rcar_du_pm_ops,
+				rcar_du_pm_suspend, rcar_du_pm_resume);
 
 /* -----------------------------------------------------------------------------
  * Platform driver
@@ -712,7 +709,7 @@ static struct platform_driver rcar_du_platform_driver = {
 	.shutdown	= rcar_du_shutdown,
 	.driver		= {
 		.name	= "rcar-du",
-		.pm	= &rcar_du_pm_ops,
+		.pm	= pm_sleep_ptr(&rcar_du_pm_ops),
 		.of_match_table = rcar_du_of_table,
 	},
 };
-- 
2.35.1


  parent reply	other threads:[~2022-11-29 19:20 UTC|newest]

Thread overview: 90+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-29 19:17 [PATCH v2 00/26] drm: Get rid of #ifdef CONFIG_PM* guards Paul Cercueil
2022-11-29 19:17 ` Paul Cercueil
2022-11-29 19:17 ` [PATCH v2 01/26] drm: modeset-helper: Add DEFINE_DRM_MODE_CONFIG_HELPER_PM_OPS macro Paul Cercueil
2022-11-29 19:17   ` Paul Cercueil
2022-11-29 19:17 ` [PATCH v2 02/26] drm: bochs: Define and use generic PM ops Paul Cercueil
2022-11-29 19:17   ` Paul Cercueil
2022-11-29 19:17 ` [PATCH v2 03/26] drm: imx: " Paul Cercueil
2022-11-29 19:17   ` Paul Cercueil
2022-11-29 19:17   ` Paul Cercueil
2022-11-29 19:17 ` [PATCH v2 04/26] drm: rockchip: " Paul Cercueil
2022-11-29 19:17   ` Paul Cercueil
2022-11-29 19:17   ` Paul Cercueil
2022-11-29 19:17   ` Paul Cercueil
2022-11-29 19:17 ` [PATCH v2 05/26] drm: tegra: " Paul Cercueil
2022-11-29 19:17   ` Paul Cercueil
2022-11-29 19:17 ` [PATCH v2 06/26] drm: sun4i: " Paul Cercueil
2022-11-29 19:17   ` Paul Cercueil
2022-11-29 19:17   ` Paul Cercueil
2022-11-30  4:08   ` Samuel Holland
2022-11-30  4:08     ` Samuel Holland
2022-11-30  4:08     ` Samuel Holland
2022-11-29 19:17 ` [PATCH v2 07/26] drm: mxsfb: " Paul Cercueil
2022-11-29 19:17   ` Paul Cercueil
2022-11-29 19:17   ` Paul Cercueil
2022-11-29 21:48   ` Marek Vasut
2022-11-29 21:48     ` Marek Vasut
2022-11-29 21:48     ` Marek Vasut
2022-11-29 19:17 ` [PATCH v2 08/26] drm: atmel-hlcdc: Remove #ifdef guards for PM related functions Paul Cercueil
2022-11-29 19:17   ` Paul Cercueil
2022-11-29 19:17   ` Paul Cercueil
2022-11-29 19:17 ` [PATCH v2 09/26] drm: exynos: " Paul Cercueil
2022-11-29 19:17   ` Paul Cercueil
2022-11-29 19:17   ` Paul Cercueil
2022-11-29 19:17 ` [PATCH v2 10/26] drm: imx/dcss: " Paul Cercueil
2022-11-29 19:17   ` Paul Cercueil
2022-11-29 19:17   ` Paul Cercueil
2022-11-29 19:17 ` [PATCH v2 11/26] drm: bridge/dw-hdmi: " Paul Cercueil
2022-11-29 19:17   ` Paul Cercueil
2022-11-29 19:17 ` [PATCH v2 12/26] drm: etnaviv: " Paul Cercueil
2022-11-29 19:17   ` Paul Cercueil
2022-12-15 19:22   ` Lucas Stach
2022-12-15 19:22     ` Lucas Stach
2022-11-29 19:17 ` [PATCH v2 13/26] drm: fsl-dcu: " Paul Cercueil
2022-11-29 19:17   ` Paul Cercueil
2022-11-29 19:17 ` [PATCH v2 14/26] drm: mediatek: " Paul Cercueil
2022-11-29 19:17   ` Paul Cercueil
2022-11-29 19:17   ` Paul Cercueil
2022-11-29 19:19 ` Paul Cercueil
2022-11-29 19:19   ` Paul Cercueil
2022-11-29 19:19   ` Paul Cercueil
2022-11-29 19:19   ` [PATCH v2 15/26] drm: omap: " Paul Cercueil
2022-11-29 19:19     ` Paul Cercueil
2022-11-29 19:19   ` [PATCH v2 16/26] drm: panfrost: " Paul Cercueil
2022-11-29 19:19     ` Paul Cercueil
2022-11-29 19:54     ` Alyssa Rosenzweig
2022-11-29 19:54       ` Alyssa Rosenzweig
2022-11-29 19:19   ` Paul Cercueil [this message]
2022-11-29 19:19     ` [PATCH v2 17/26] drm: rcar-du: " Paul Cercueil
2022-11-29 19:43     ` Laurent Pinchart
2022-11-29 19:43       ` Laurent Pinchart
2022-11-29 21:05       ` Paul Cercueil
2022-11-29 21:05         ` Paul Cercueil
2022-11-29 21:24         ` Laurent Pinchart
2022-11-29 21:24           ` Laurent Pinchart
2022-11-29 19:19   ` [PATCH v2 18/26] drm: rockchip: " Paul Cercueil
2022-11-29 19:19     ` Paul Cercueil
2022-11-29 19:19     ` Paul Cercueil
2022-11-29 19:19     ` Paul Cercueil
2022-11-29 19:19   ` [PATCH v2 19/26] drm: shmobile: " Paul Cercueil
2022-11-29 19:19     ` Paul Cercueil
2022-11-29 19:44     ` Laurent Pinchart
2022-11-29 19:44       ` Laurent Pinchart
2022-11-29 19:19   ` [PATCH v2 20/26] drm: tegra: " Paul Cercueil
2022-11-29 19:19     ` Paul Cercueil
2022-11-29 19:19   ` [PATCH v2 21/26] drm: tilcdc: " Paul Cercueil
2022-11-29 19:19     ` Paul Cercueil
2022-11-29 19:19   ` [PATCH v2 22/26] drm: vboxvideo: " Paul Cercueil
2022-11-29 19:19     ` Paul Cercueil
2022-11-29 19:19   ` [PATCH v2 23/26] drm: vc4: " Paul Cercueil
2022-11-29 19:19     ` Paul Cercueil
2022-11-29 19:19   ` [PATCH v2 24/26] drm: gm12u320: " Paul Cercueil
2022-11-29 19:19     ` Paul Cercueil
2022-11-29 19:19   ` [PATCH v2 25/26] drm: tidss: " Paul Cercueil
2022-11-29 19:19     ` Paul Cercueil
2022-11-29 19:19   ` [PATCH v2 26/26] drm/i915/gt: " Paul Cercueil
2022-11-29 19:19     ` Paul Cercueil
2022-11-29 19:19     ` [Intel-gfx] " Paul Cercueil
2022-12-07 15:56     ` Rodrigo Vivi
2022-12-07 15:56       ` Rodrigo Vivi
2022-12-07 15:56       ` Rodrigo Vivi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221129191942.138244-4-paul@crapouillou.net \
    --to=paul@crapouillou.net \
    --cc=airlied@gmail.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kieran.bingham+renesas@ideasonboard.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.