All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: linux-integrity@vger.kernel.org
Cc: Ard Biesheuvel <ardb@kernel.org>,
	Jarkko Sakkinen <jarkko@kernel.org>,
	keyrings@vger.kernel.org
Subject: [PATCH 10/11] tpm: add the null key name as a sysfs export
Date: Fri,  9 Dec 2022 11:06:10 -0500	[thread overview]
Message-ID: <20221209160611.30207-11-James.Bottomley@HansenPartnership.com> (raw)
In-Reply-To: <20221209160611.30207-1-James.Bottomley@HansenPartnership.com>

This is the last component of encrypted tpm2 session handling that
allows us to verify from userspace that the key derived from the NULL
seed genuinely belongs to the TPM and has not been spoofed.

The procedure for doing this involves creating an attestation identity
key (which requires verification of the TPM EK certificate) and then
using that AIK to sign a certification of the Elliptic Curve key over
the NULL seed.  Userspace must create this EC Key using the parameters
prescribed in TCG TPM v2.0 Provisioning Guidance for the SRK ECC; if
this is done correctly the names will match and the TPM can then run a
TPM2_Certify operation on this derived primary key using the newly
created AIK.

Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
---
 drivers/char/tpm/tpm-sysfs.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/drivers/char/tpm/tpm-sysfs.c b/drivers/char/tpm/tpm-sysfs.c
index 54c71473aa29..27a16addab93 100644
--- a/drivers/char/tpm/tpm-sysfs.c
+++ b/drivers/char/tpm/tpm-sysfs.c
@@ -309,6 +309,19 @@ static ssize_t tpm_version_major_show(struct device *dev,
 }
 static DEVICE_ATTR_RO(tpm_version_major);
 
+static ssize_t null_name_show(struct device *dev, struct device_attribute *attr,
+			      char *buf)
+{
+	struct tpm_chip *chip = to_tpm_chip(dev);
+	int size = TPM2_NAME_SIZE;
+
+	bin2hex(buf, chip->tpmkeyname, size);
+	size *= 2;
+	buf[size++] = '\n';
+	return size;
+}
+static DEVICE_ATTR_RO(null_name);
+
 static struct attribute *tpm1_dev_attrs[] = {
 	&dev_attr_pubek.attr,
 	&dev_attr_pcrs.attr,
@@ -326,6 +339,7 @@ static struct attribute *tpm1_dev_attrs[] = {
 
 static struct attribute *tpm2_dev_attrs[] = {
 	&dev_attr_tpm_version_major.attr,
+	&dev_attr_null_name.attr,
 	NULL
 };
 
-- 
2.35.3


  parent reply	other threads:[~2022-12-09 16:11 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-09 16:06 [PATCH 00/11] add integrity and security to TPM2 transactions James Bottomley
2022-12-09 16:06 ` [PATCH 01/11] tpm: move buffer handling from static inlines to real functions James Bottomley
2022-12-09 19:11   ` kernel test robot
2022-12-09 19:42   ` kernel test robot
2022-12-10  2:09   ` Jarkko Sakkinen
2022-12-11 20:01     ` James Bottomley
2022-12-12  0:52       ` Jarkko Sakkinen
2022-12-12  3:16         ` James Bottomley
2022-12-26 20:03           ` Jarkko Sakkinen
2022-12-09 16:06 ` [PATCH 02/11] tpm: add buffer handling for TPM2B types James Bottomley
2022-12-09 16:06 ` [PATCH 03/11] tpm: add cursor based buffer functions for response parsing James Bottomley
2022-12-12  0:50   ` Jarkko Sakkinen
2022-12-12  3:13     ` James Bottomley
2022-12-26 20:06       ` Jarkko Sakkinen
2022-12-09 16:06 ` [PATCH 04/11] tpm: add buffer function to point to returned parameters James Bottomley
2022-12-09 16:06 ` [PATCH 05/11] tpm: export the context save and load commands James Bottomley
2022-12-09 16:06 ` [PATCH 06/11] tpm: Add full HMAC and encrypt/decrypt session handling code James Bottomley
2022-12-09 16:15   ` James Bottomley
2022-12-09 19:42   ` kernel test robot
2022-12-09 20:32   ` kernel test robot
2022-12-09 16:06 ` [PATCH 07/11] tpm: add hmac checks to tpm2_pcr_extend() James Bottomley
2022-12-09 16:06 ` [PATCH 08/11] tpm: add session encryption protection to tpm2_get_random() James Bottomley
2022-12-09 16:06 ` [PATCH 09/11] KEYS: trusted: Add session encryption protection to the seal/unseal path James Bottomley
2022-12-09 16:06 ` James Bottomley [this message]
2022-12-09 16:06 ` [PATCH 11/11] Documentation: add tpm-security.rst James Bottomley
2022-12-10  4:27 [PATCH 06/11] tpm: Add full HMAC and encrypt/decrypt session handling code kernel test robot
2022-12-10  5:17 ` Dan Carpenter
2022-12-11 20:05 ` James Bottomley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221209160611.30207-11-James.Bottomley@HansenPartnership.com \
    --to=james.bottomley@hansenpartnership.com \
    --cc=ardb@kernel.org \
    --cc=jarkko@kernel.org \
    --cc=keyrings@vger.kernel.org \
    --cc=linux-integrity@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.