All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel.vetter@ffwll.ch>
To: DRI Development <dri-devel@lists.freedesktop.org>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	Daniel Vetter <daniel.vetter@intel.com>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Javier Martinez Canillas <javierm@redhat.com>,
	Helge Deller <deller@gmx.de>,
	linux-fbdev@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
	linux-pci@vger.kernel.org
Subject: [PATCH 04/11] video/aperture: use generic code to figure out the vga default device
Date: Wed, 11 Jan 2023 16:41:05 +0100	[thread overview]
Message-ID: <20230111154112.90575-4-daniel.vetter@ffwll.ch> (raw)
In-Reply-To: <20230111154112.90575-1-daniel.vetter@ffwll.ch>

Since vgaarb has been promoted to be a core piece of the pci subsystem
we don't have to open code random guesses anymore, we actually know
this in a platform agnostic way, and there's no need for an x86
specific hack. See also 1d38fe6ee6a8 ("PCI/VGA: Move vgaarb to
drivers/pci")

This should not result in any functional change, and the non-x86
multi-gpu pci systems are probably rare enough to not matter (I don't
know of any tbh). But it's a nice cleanup, so let's do it.

Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Javier Martinez Canillas <javierm@redhat.com>
Cc: Helge Deller <deller@gmx.de>
Cc: linux-fbdev@vger.kernel.org
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-pci@vger.kernel.org
---
 drivers/video/aperture.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/video/aperture.c b/drivers/video/aperture.c
index 41e77de1ea82..3d8c925c7365 100644
--- a/drivers/video/aperture.c
+++ b/drivers/video/aperture.c
@@ -324,13 +324,11 @@ EXPORT_SYMBOL(aperture_remove_conflicting_devices);
  */
 int aperture_remove_conflicting_pci_devices(struct pci_dev *pdev, const char *name)
 {
-	bool primary = false;
+	bool primary;
 	resource_size_t base, size;
 	int bar, ret;
 
-#ifdef CONFIG_X86
-	primary = pdev->resource[PCI_ROM_RESOURCE].flags & IORESOURCE_ROM_SHADOW;
-#endif
+	primary = pdev == vga_default_device();
 
 	for (bar = 0; bar < PCI_STD_NUM_BARS; ++bar) {
 		if (!(pci_resource_flags(pdev, bar) & IORESOURCE_MEM))
-- 
2.39.0


WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel.vetter@ffwll.ch>
To: DRI Development <dri-devel@lists.freedesktop.org>
Cc: linux-fbdev@vger.kernel.org,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
	Javier Martinez Canillas <javierm@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
	Daniel Vetter <daniel.vetter@intel.com>,
	Helge Deller <deller@gmx.de>
Subject: [PATCH 04/11] video/aperture: use generic code to figure out the vga default device
Date: Wed, 11 Jan 2023 16:41:05 +0100	[thread overview]
Message-ID: <20230111154112.90575-4-daniel.vetter@ffwll.ch> (raw)
In-Reply-To: <20230111154112.90575-1-daniel.vetter@ffwll.ch>

Since vgaarb has been promoted to be a core piece of the pci subsystem
we don't have to open code random guesses anymore, we actually know
this in a platform agnostic way, and there's no need for an x86
specific hack. See also 1d38fe6ee6a8 ("PCI/VGA: Move vgaarb to
drivers/pci")

This should not result in any functional change, and the non-x86
multi-gpu pci systems are probably rare enough to not matter (I don't
know of any tbh). But it's a nice cleanup, so let's do it.

Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Javier Martinez Canillas <javierm@redhat.com>
Cc: Helge Deller <deller@gmx.de>
Cc: linux-fbdev@vger.kernel.org
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-pci@vger.kernel.org
---
 drivers/video/aperture.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/video/aperture.c b/drivers/video/aperture.c
index 41e77de1ea82..3d8c925c7365 100644
--- a/drivers/video/aperture.c
+++ b/drivers/video/aperture.c
@@ -324,13 +324,11 @@ EXPORT_SYMBOL(aperture_remove_conflicting_devices);
  */
 int aperture_remove_conflicting_pci_devices(struct pci_dev *pdev, const char *name)
 {
-	bool primary = false;
+	bool primary;
 	resource_size_t base, size;
 	int bar, ret;
 
-#ifdef CONFIG_X86
-	primary = pdev->resource[PCI_ROM_RESOURCE].flags & IORESOURCE_ROM_SHADOW;
-#endif
+	primary = pdev == vga_default_device();
 
 	for (bar = 0; bar < PCI_STD_NUM_BARS; ++bar) {
 		if (!(pci_resource_flags(pdev, bar) & IORESOURCE_MEM))
-- 
2.39.0


WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel.vetter@ffwll.ch>
To: DRI Development <dri-devel@lists.freedesktop.org>
Cc: linux-fbdev@vger.kernel.org,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
	Javier Martinez Canillas <javierm@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
	Daniel Vetter <daniel.vetter@intel.com>,
	Helge Deller <deller@gmx.de>
Subject: [Intel-gfx] [PATCH 04/11] video/aperture: use generic code to figure out the vga default device
Date: Wed, 11 Jan 2023 16:41:05 +0100	[thread overview]
Message-ID: <20230111154112.90575-4-daniel.vetter@ffwll.ch> (raw)
In-Reply-To: <20230111154112.90575-1-daniel.vetter@ffwll.ch>

Since vgaarb has been promoted to be a core piece of the pci subsystem
we don't have to open code random guesses anymore, we actually know
this in a platform agnostic way, and there's no need for an x86
specific hack. See also 1d38fe6ee6a8 ("PCI/VGA: Move vgaarb to
drivers/pci")

This should not result in any functional change, and the non-x86
multi-gpu pci systems are probably rare enough to not matter (I don't
know of any tbh). But it's a nice cleanup, so let's do it.

Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Javier Martinez Canillas <javierm@redhat.com>
Cc: Helge Deller <deller@gmx.de>
Cc: linux-fbdev@vger.kernel.org
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-pci@vger.kernel.org
---
 drivers/video/aperture.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/video/aperture.c b/drivers/video/aperture.c
index 41e77de1ea82..3d8c925c7365 100644
--- a/drivers/video/aperture.c
+++ b/drivers/video/aperture.c
@@ -324,13 +324,11 @@ EXPORT_SYMBOL(aperture_remove_conflicting_devices);
  */
 int aperture_remove_conflicting_pci_devices(struct pci_dev *pdev, const char *name)
 {
-	bool primary = false;
+	bool primary;
 	resource_size_t base, size;
 	int bar, ret;
 
-#ifdef CONFIG_X86
-	primary = pdev->resource[PCI_ROM_RESOURCE].flags & IORESOURCE_ROM_SHADOW;
-#endif
+	primary = pdev == vga_default_device();
 
 	for (bar = 0; bar < PCI_STD_NUM_BARS; ++bar) {
 		if (!(pci_resource_flags(pdev, bar) & IORESOURCE_MEM))
-- 
2.39.0


  parent reply	other threads:[~2023-01-11 15:42 UTC|newest]

Thread overview: 115+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-11 15:41 [PATCH 01/11] drm/ast: Use drm_aperture_remove_conflicting_pci_framebuffers Daniel Vetter
2023-01-11 15:41 ` [Intel-gfx] " Daniel Vetter
2023-01-11 15:41 ` Daniel Vetter
2023-01-11 15:41 ` [PATCH 02/11] drm/gma500: " Daniel Vetter
2023-01-11 15:41   ` [Intel-gfx] " Daniel Vetter
2023-01-11 15:41   ` Daniel Vetter
2023-01-12  9:04   ` Thomas Zimmermann
2023-01-12  9:04     ` Thomas Zimmermann
2023-01-12  9:04     ` [Intel-gfx] " Thomas Zimmermann
2023-01-12  9:59     ` Daniel Vetter
2023-01-12  9:59       ` Daniel Vetter
2023-01-12  9:59       ` [Intel-gfx] " Daniel Vetter
2023-01-12 10:24       ` Thomas Zimmermann
2023-01-12 10:24         ` [Intel-gfx] " Thomas Zimmermann
2023-01-12 10:45         ` Daniel Vetter
2023-01-12 10:45           ` Daniel Vetter
2023-01-12 10:45           ` [Intel-gfx] " Daniel Vetter
2023-01-12 12:15           ` Thomas Zimmermann
2023-01-12 12:15             ` [Intel-gfx] " Thomas Zimmermann
2023-01-12 15:32             ` Daniel Vetter
2023-01-12 15:32               ` Daniel Vetter
2023-01-12 15:32               ` [Intel-gfx] " Daniel Vetter
2023-01-11 15:41 ` [PATCH 03/11] drm/aperture: Remove primary argument Daniel Vetter
2023-01-11 15:41   ` Daniel Vetter
2023-01-11 15:41   ` Daniel Vetter
2023-01-11 15:41   ` [Intel-gfx] " Daniel Vetter
2023-01-11 15:41   ` Daniel Vetter
2023-01-11 15:49   ` [Intel-gfx] " Thomas Zimmermann
2023-01-11 15:49     ` Thomas Zimmermann
2023-01-11 15:49     ` Thomas Zimmermann
2023-01-11 15:49     ` Thomas Zimmermann
2023-01-11 15:49     ` Thomas Zimmermann
2023-01-11 15:41 ` Daniel Vetter [this message]
2023-01-11 15:41   ` [Intel-gfx] [PATCH 04/11] video/aperture: use generic code to figure out the vga default device Daniel Vetter
2023-01-11 15:41   ` Daniel Vetter
2023-01-11 15:59   ` Thomas Zimmermann
2023-01-11 15:59     ` [Intel-gfx] " Thomas Zimmermann
2023-01-11 15:59     ` Thomas Zimmermann
2023-01-11 16:51     ` Daniel Vetter
2023-01-11 16:51       ` [Intel-gfx] " Daniel Vetter
2023-01-11 16:51       ` Daniel Vetter
2023-01-11 15:41 ` [PATCH 05/11] video/aperture: Only kick vgacon when the pdev is decoding vga Daniel Vetter
2023-01-11 15:41   ` [Intel-gfx] " Daniel Vetter
2023-01-11 15:41   ` Daniel Vetter
2023-01-11 16:03   ` Thomas Zimmermann
2023-01-11 16:03     ` [Intel-gfx] " Thomas Zimmermann
2023-01-11 16:03     ` Thomas Zimmermann
2023-01-11 16:55     ` Daniel Vetter
2023-01-11 16:55       ` [Intel-gfx] " Daniel Vetter
2023-01-11 16:55       ` Daniel Vetter
2023-01-11 15:41 ` [PATCH 06/11] staging/lynxfb: Use pci aperture helper Daniel Vetter
2023-01-11 15:41   ` [Intel-gfx] " Daniel Vetter
2023-01-11 15:41   ` Daniel Vetter
2023-01-11 16:05   ` Thomas Zimmermann
2023-01-11 16:05     ` Thomas Zimmermann
2023-01-11 16:05     ` [Intel-gfx] " Thomas Zimmermann
2023-01-11 15:41 ` [PATCH 07/11] fbdev/radeon: use pci aperture helpers Daniel Vetter
2023-01-11 15:41   ` [Intel-gfx] " Daniel Vetter
2023-01-11 15:41   ` Daniel Vetter
2023-01-11 15:41 ` [PATCH 08/11] fbdev/hyperv: " Daniel Vetter
2023-01-11 15:41   ` [Intel-gfx] " Daniel Vetter
2023-01-11 15:41   ` Daniel Vetter
2023-01-17 18:42   ` Dexuan Cui
2023-01-17 18:42     ` Dexuan Cui
2023-01-11 15:41 ` [PATCH 09/11] video/aperture: Move vga handling to pci function Daniel Vetter
2023-01-11 15:41   ` [Intel-gfx] " Daniel Vetter
2023-01-11 15:41   ` Daniel Vetter
2023-01-11 15:41 ` [PATCH 10/11] video/aperture: Drop primary argument Daniel Vetter
2023-01-11 15:41   ` [Intel-gfx] " Daniel Vetter
2023-01-11 15:41   ` Daniel Vetter
2023-01-11 16:09   ` Thomas Zimmermann
2023-01-11 16:09     ` [Intel-gfx] " Thomas Zimmermann
2023-01-11 16:09     ` Thomas Zimmermann
2023-01-11 15:41 ` [PATCH 11/11] video/aperture: Only remove sysfb on the default vga pci device Daniel Vetter
2023-01-11 15:41   ` Daniel Vetter
2023-01-11 15:41   ` [Intel-gfx] " Daniel Vetter
2023-01-11 16:20   ` Thomas Zimmermann
2023-01-11 16:20     ` Thomas Zimmermann
2023-01-11 16:20     ` [Intel-gfx] " Thomas Zimmermann
2023-01-11 16:37     ` Daniel Vetter
2023-01-11 16:37       ` Daniel Vetter
2023-01-11 16:37       ` [Intel-gfx] " Daniel Vetter
2023-01-12  7:48       ` Thomas Zimmermann
2023-01-12  7:48         ` [Intel-gfx] " Thomas Zimmermann
2023-01-11 16:43     ` Javier Martinez Canillas
2023-01-11 16:43       ` [Intel-gfx] " Javier Martinez Canillas
2023-01-11 16:58   ` Javier Martinez Canillas
2023-01-11 16:58     ` Javier Martinez Canillas
2023-01-11 16:58     ` [Intel-gfx] " Javier Martinez Canillas
2023-01-11 19:21     ` Aaron Plattner
2023-01-11 19:21       ` Aaron Plattner
2023-01-11 19:21       ` [Intel-gfx] " Aaron Plattner
2023-01-12  7:55       ` Thomas Zimmermann
2023-01-12  7:55         ` [Intel-gfx] " Thomas Zimmermann
2023-01-12  7:55         ` Thomas Zimmermann
2023-01-12  8:44         ` Javier Martinez Canillas
2023-01-12  8:44           ` Javier Martinez Canillas
2023-01-12  8:44           ` [Intel-gfx] " Javier Martinez Canillas
2023-01-11 15:48 ` [PATCH 01/11] drm/ast: Use drm_aperture_remove_conflicting_pci_framebuffers Thomas Zimmermann
2023-01-11 15:48   ` [Intel-gfx] " Thomas Zimmermann
2023-01-11 15:48   ` Thomas Zimmermann
2023-01-11 17:02   ` Daniel Vetter
2023-01-11 17:02     ` Daniel Vetter
2023-01-11 17:02     ` [Intel-gfx] " Daniel Vetter
2023-01-11 16:10 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/11] " Patchwork
2023-01-11 16:38 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2023-01-12  9:41 ` [PATCH 01/11] " Thomas Zimmermann
2023-01-12  9:41   ` Thomas Zimmermann
2023-01-12  9:41   ` [Intel-gfx] " Thomas Zimmermann
2023-04-04 14:45 ` Thomas Zimmermann
2023-04-04 14:45   ` [Intel-gfx] " Thomas Zimmermann
2023-04-04 14:45   ` Thomas Zimmermann
2023-04-18  0:53   ` Jammy Huang
2023-04-18  0:53     ` [Intel-gfx] " Jammy Huang
2023-04-18  0:53     ` Jammy Huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230111154112.90575-4-daniel.vetter@ffwll.ch \
    --to=daniel.vetter@ffwll.ch \
    --cc=bhelgaas@google.com \
    --cc=daniel.vetter@intel.com \
    --cc=deller@gmx.de \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=javierm@redhat.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.