From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: [ardb:efi-x86-nx 10/24] drivers/firmware/efi/libstub/mem.c:170 efi_adjust_memory_range_protection() error: uninitialized symbol 'rounded_start'.
Date: Thu, 9 Mar 2023 00:03:20 +0800 [thread overview]
Message-ID: <202303090050.RhPPJRPD-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
TO: Evgeniy Baskov <baskov@ispras.ru>
CC: Ard Biesheuvel <ardb@kernel.org>
tree: git://git.kernel.org/pub/scm/linux/kernel/git/ardb/linux.git efi-x86-nx
head: 8171142f3e4c96f6be75a6195de59d1607f1bd4b
commit: 6b4ae58e7147165ec019e3899a5d4d14e0396110 [10/24] efi/libstub: Move helper function to related file
:::::: branch date: 17 hours ago
:::::: commit date: 17 hours ago
config: loongarch-randconfig-m041-20230305 (https://download.01.org/0day-ci/archive/20230309/202303090050.RhPPJRPD-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 12.1.0
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Link: https://lore.kernel.org/r/202303090050.RhPPJRPD-lkp@intel.com/
smatch warnings:
drivers/firmware/efi/libstub/mem.c:170 efi_adjust_memory_range_protection() error: uninitialized symbol 'rounded_start'.
drivers/firmware/efi/libstub/mem.c:170 efi_adjust_memory_range_protection() error: uninitialized symbol 'rounded_end'.
vim +/rounded_start +170 drivers/firmware/efi/libstub/mem.c
6b4ae58e714716 Evgeniy Baskov 2022-10-25 131
6b4ae58e714716 Evgeniy Baskov 2022-10-25 132 /**
6b4ae58e714716 Evgeniy Baskov 2022-10-25 133 * efi_adjust_memory_range_protection() - change memory range protection attributes
6b4ae58e714716 Evgeniy Baskov 2022-10-25 134 * @start: memory range start address
6b4ae58e714716 Evgeniy Baskov 2022-10-25 135 * @size: memory range size
6b4ae58e714716 Evgeniy Baskov 2022-10-25 136 *
6b4ae58e714716 Evgeniy Baskov 2022-10-25 137 * Actual memory range for which memory attributes are modified is
6b4ae58e714716 Evgeniy Baskov 2022-10-25 138 * the smallest ranged with start address and size aligned to EFI_PAGE_SIZE
6b4ae58e714716 Evgeniy Baskov 2022-10-25 139 * that includes [start, start + size].
6b4ae58e714716 Evgeniy Baskov 2022-10-25 140 *
6b4ae58e714716 Evgeniy Baskov 2022-10-25 141 * @return: status code
6b4ae58e714716 Evgeniy Baskov 2022-10-25 142 */
6b4ae58e714716 Evgeniy Baskov 2022-10-25 143 efi_status_t efi_adjust_memory_range_protection(unsigned long start,
6b4ae58e714716 Evgeniy Baskov 2022-10-25 144 unsigned long size,
6b4ae58e714716 Evgeniy Baskov 2022-10-25 145 unsigned long attributes)
6b4ae58e714716 Evgeniy Baskov 2022-10-25 146 {
6b4ae58e714716 Evgeniy Baskov 2022-10-25 147 efi_status_t status;
6b4ae58e714716 Evgeniy Baskov 2022-10-25 148 efi_gcd_memory_space_desc_t desc;
6b4ae58e714716 Evgeniy Baskov 2022-10-25 149 efi_physical_addr_t end, next;
6b4ae58e714716 Evgeniy Baskov 2022-10-25 150 efi_physical_addr_t rounded_start, rounded_end;
6b4ae58e714716 Evgeniy Baskov 2022-10-25 151 efi_physical_addr_t unprotect_start, unprotect_size;
6b4ae58e714716 Evgeniy Baskov 2022-10-25 152
6b4ae58e714716 Evgeniy Baskov 2022-10-25 153 if (efi_dxe_table == NULL)
6b4ae58e714716 Evgeniy Baskov 2022-10-25 154 return EFI_UNSUPPORTED;
6b4ae58e714716 Evgeniy Baskov 2022-10-25 155
6b4ae58e714716 Evgeniy Baskov 2022-10-25 156 /*
6b4ae58e714716 Evgeniy Baskov 2022-10-25 157 * This function should not be used to modify attributes
6b4ae58e714716 Evgeniy Baskov 2022-10-25 158 * other than writable/executable.
6b4ae58e714716 Evgeniy Baskov 2022-10-25 159 */
6b4ae58e714716 Evgeniy Baskov 2022-10-25 160
6b4ae58e714716 Evgeniy Baskov 2022-10-25 161 if ((attributes & ~(EFI_MEMORY_RO | EFI_MEMORY_XP)) != 0)
6b4ae58e714716 Evgeniy Baskov 2022-10-25 162 return EFI_INVALID_PARAMETER;
6b4ae58e714716 Evgeniy Baskov 2022-10-25 163
6b4ae58e714716 Evgeniy Baskov 2022-10-25 164 /*
6b4ae58e714716 Evgeniy Baskov 2022-10-25 165 * Disallow simultaniously executable and writable memory
6b4ae58e714716 Evgeniy Baskov 2022-10-25 166 * to inforce W^X policy if direct extraction code is enabled.
6b4ae58e714716 Evgeniy Baskov 2022-10-25 167 */
6b4ae58e714716 Evgeniy Baskov 2022-10-25 168
6b4ae58e714716 Evgeniy Baskov 2022-10-25 169 if ((attributes & (EFI_MEMORY_RO | EFI_MEMORY_XP)) == 0) {
6b4ae58e714716 Evgeniy Baskov 2022-10-25 @170 efi_warn("W^X violation at [%08lx,%08lx]\n",
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
next reply other threads:[~2023-03-08 16:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-08 16:03 kernel test robot [this message]
2023-03-08 16:21 [ardb:efi-x86-nx 10/24] drivers/firmware/efi/libstub/mem.c:170 efi_adjust_memory_range_protection() error: uninitialized symbol 'rounded_start' Dan Carpenter
2023-03-08 16:30 ` Evgeniy Baskov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202303090050.RhPPJRPD-lkp@intel.com \
--to=lkp@intel.com \
--cc=error27@gmail.com \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.