All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: netdev@vger.kernel.org
Cc: linux-renesas-soc@vger.kernel.org, kernel@pengutronix.de,
	Wolfram Sang <wsa+renesas@sang-engineering.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH net 0/4] net: set 'mac_managed_pm' at probe time
Date: Tue, 14 Mar 2023 14:14:38 +0100	[thread overview]
Message-ID: <20230314131443.46342-1-wsa+renesas@sang-engineering.com> (raw)

When suspending/resuming an interface which was not up, we saw mdiobus
related PM handling despite 'mac_managed_pm' being set for RAVB/SH_ETH.
Heiner kindly suggested the fix to set this flag at probe time, not at
init/open time. I implemented his suggestion and it works fine on these
two Renesas drivers. These are patches 1+2.

I then looked which other drivers could be affected by the same problem.
I could only identify two where I am quite sure. Because I don't have
any HW, I opted to at least add a FIXME and send this out as patches
3+4. Ideally, they will never need to go upstream because the relevant
people will see their patch and do something like I did for patches 1+2.

Looking forward to comments. Thanks and happy hacking!


Wolfram Sang (4):
  ravb: avoid PHY being resumed when interface is not up
  sh_eth: avoid PHY being resumed when interface is not up
  fec: add FIXME to move 'mac_managed_pm' to probe
  smsc911x: add FIXME to move 'mac_managed_pm' to probe

 drivers/net/ethernet/freescale/fec_main.c |  1 +
 drivers/net/ethernet/renesas/ravb_main.c  | 12 ++++++++++--
 drivers/net/ethernet/renesas/sh_eth.c     | 12 ++++++++++--
 drivers/net/ethernet/smsc/smsc911x.c      |  1 +
 4 files changed, 22 insertions(+), 4 deletions(-)

-- 
2.30.2


             reply	other threads:[~2023-03-14 13:38 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-14 13:14 Wolfram Sang [this message]
2023-03-14 13:14 ` [PATCH net 1/4] ravb: avoid PHY being resumed when interface is not up Wolfram Sang
2023-03-14 13:14 ` [PATCH net 2/4] sh_eth: " Wolfram Sang
2023-03-14 13:14 ` [PATCH net-next 3/4] fec: add FIXME to move 'mac_managed_pm' to probe Wolfram Sang
2023-03-15  5:48   ` Wei Fang
2023-03-15  7:27     ` Wolfram Sang
2023-03-16  8:02       ` Wolfram Sang
2023-03-16  9:10         ` Wei Fang
2023-03-16 13:53           ` Wolfram Sang
2023-03-14 13:14 ` [PATCH net-next 4/4] smsc911x: " Wolfram Sang
2023-03-15  8:50   ` Geert Uytterhoeven
2023-03-15  8:52     ` Wolfram Sang
2023-03-14 15:56 ` [PATCH net 0/4] net: set 'mac_managed_pm' at probe time Michal Kubiak
2023-03-14 16:40 ` Simon Horman
2023-03-15  7:26   ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230314131443.46342-1-wsa+renesas@sang-engineering.com \
    --to=wsa+renesas@sang-engineering.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.