From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH v2 2/2] remoteproc: enhance rproc_put() for clusters
Date: Wed, 22 Mar 2023 19:28:09 +0800 [thread overview]
Message-ID: <202303221916.LgKkr8Gk-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20230322040933.924813-3-tanmay.shah@amd.com>
References: <20230322040933.924813-3-tanmay.shah@amd.com>
TO: Tanmay Shah <tanmay.shah@amd.com>
TO: andersson@kernel.org
TO: mathieu.poirier@linaro.org
CC: linux-remoteproc@vger.kernel.org
CC: linux-kernel@vger.kernel.org
CC: Tanmay Shah <tanmay.shah@amd.com>
CC: Tarak Reddy <tarak.reddy@amd.com>
Hi Tanmay,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on e19967994d342a5986d950a1bfddf19d7e1191b7]
url: https://github.com/intel-lab-lkp/linux/commits/Tanmay-Shah/remoteproc-Make-rproc_get_by_phandle-work-for-clusters/20230322-121102
base: e19967994d342a5986d950a1bfddf19d7e1191b7
patch link: https://lore.kernel.org/r/20230322040933.924813-3-tanmay.shah%40amd.com
patch subject: [PATCH v2 2/2] remoteproc: enhance rproc_put() for clusters
:::::: branch date: 7 hours ago
:::::: commit date: 7 hours ago
config: powerpc-randconfig-m041-20230322 (https://download.01.org/0day-ci/archive/20230322/202303221916.LgKkr8Gk-lkp@intel.com/config)
compiler: powerpc-linux-gcc (GCC) 12.1.0
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Link: https://lore.kernel.org/r/202303221916.LgKkr8Gk-lkp@intel.com/
smatch warnings:
drivers/remoteproc/remoteproc_core.c:2565 rproc_put() warn: variable dereferenced before check 'rproc->dev.parent' (see line 2562)
drivers/remoteproc/remoteproc_core.c:2566 rproc_put() warn: variable dereferenced before check 'rproc->dev.parent->driver' (see line 2562)
vim +2565 drivers/remoteproc/remoteproc_core.c
433c0e04bc06da Bjorn Andersson 2016-10-02 2550
433c0e04bc06da Bjorn Andersson 2016-10-02 2551 /**
433c0e04bc06da Bjorn Andersson 2016-10-02 2552 * rproc_put() - release rproc reference
400e64df6b237e Ohad Ben-Cohen 2011-10-20 2553 * @rproc: the remote processor handle
400e64df6b237e Ohad Ben-Cohen 2011-10-20 2554 *
c6b5a27628faf6 Ohad Ben-Cohen 2012-07-02 2555 * This function decrements the rproc dev refcount.
400e64df6b237e Ohad Ben-Cohen 2011-10-20 2556 *
c6b5a27628faf6 Ohad Ben-Cohen 2012-07-02 2557 * If no one holds any reference to rproc anymore, then its refcount would
c6b5a27628faf6 Ohad Ben-Cohen 2012-07-02 2558 * now drop to zero, and it would be freed.
400e64df6b237e Ohad Ben-Cohen 2011-10-20 2559 */
160e7c840fe858 Ohad Ben-Cohen 2012-07-04 2560 void rproc_put(struct rproc *rproc)
400e64df6b237e Ohad Ben-Cohen 2011-10-20 2561 {
fbb6aacb078285 Bjorn Andersson 2016-10-02 @2562 module_put(rproc->dev.parent->driver->owner);
573d22d13a6970 Tanmay Shah 2023-03-21 2563 struct platform_device *cluster_pdev;
573d22d13a6970 Tanmay Shah 2023-03-21 2564
573d22d13a6970 Tanmay Shah 2023-03-21 @2565 if (rproc->dev.parent) {
573d22d13a6970 Tanmay Shah 2023-03-21 @2566 if (rproc->dev.parent->driver) {
573d22d13a6970 Tanmay Shah 2023-03-21 2567 module_put(rproc->dev.parent->driver->owner);
573d22d13a6970 Tanmay Shah 2023-03-21 2568 } else {
573d22d13a6970 Tanmay Shah 2023-03-21 2569 cluster_pdev = of_find_device_by_node(rproc->dev.parent->of_node->parent);
573d22d13a6970 Tanmay Shah 2023-03-21 2570 if (cluster_pdev) {
573d22d13a6970 Tanmay Shah 2023-03-21 2571 module_put(cluster_pdev->dev.driver->owner);
573d22d13a6970 Tanmay Shah 2023-03-21 2572 put_device(&cluster_pdev->dev);
573d22d13a6970 Tanmay Shah 2023-03-21 2573 }
573d22d13a6970 Tanmay Shah 2023-03-21 2574 }
573d22d13a6970 Tanmay Shah 2023-03-21 2575 }
b5ab5e24e960b9 Ohad Ben-Cohen 2012-05-30 2576 put_device(&rproc->dev);
400e64df6b237e Ohad Ben-Cohen 2011-10-20 2577 }
160e7c840fe858 Ohad Ben-Cohen 2012-07-04 2578 EXPORT_SYMBOL(rproc_put);
400e64df6b237e Ohad Ben-Cohen 2011-10-20 2579
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
next reply other threads:[~2023-03-22 11:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 11:28 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-03-22 4:09 [PATCH v2 0/2] remoteproc: get rproc devices for clusters Tanmay Shah
2023-03-22 4:09 ` [PATCH v2 2/2] remoteproc: enhance rproc_put() " Tanmay Shah
2023-03-22 6:20 ` kernel test robot
2023-03-22 7:31 ` kernel test robot
2023-03-22 11:52 ` Dan Carpenter
2023-03-22 16:05 ` Mathieu Poirier
2023-03-22 17:34 ` Tanmay Shah
2023-03-23 22:45 ` Mathieu Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202303221916.LgKkr8Gk-lkp@intel.com \
--to=lkp@intel.com \
--cc=error27@gmail.com \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.