From: Andy Chiu <andy.chiu@sifive.com> To: linux-riscv@lists.infradead.org, palmer@dabbelt.com, anup@brainfault.org, atishp@atishpatra.org, kvm-riscv@lists.infradead.org, kvm@vger.kernel.org Cc: vineetg@rivosinc.com, greentime.hu@sifive.com, guoren@linux.alibaba.com, Andy Chiu <andy.chiu@sifive.com>, Paul Walmsley <paul.walmsley@sifive.com>, Albert Ou <aou@eecs.berkeley.edu>, Conor Dooley <conor.dooley@microchip.com>, Guo Ren <guoren@kernel.org>, Vincent Chen <vincent.chen@sifive.com>, Andrew Bresticker <abrestic@rivosinc.com> Subject: [PATCH -next v17 15/20] riscv: signal: validate altstack to reflect Vector Date: Mon, 27 Mar 2023 16:49:35 +0000 [thread overview] Message-ID: <20230327164941.20491-16-andy.chiu@sifive.com> (raw) In-Reply-To: <20230327164941.20491-1-andy.chiu@sifive.com> Some extensions, such as Vector, dynamically change footprint on a signal frame, so MINSIGSTKSZ is no longer accurate. For example, an RV64V implementation with vlen = 512 may occupy 2K + 40 + 12 Bytes of a signal frame with the upcoming support. And processes that do not execute any vector instructions do not need to reserve the extra sigframe. So we need a way to guard the allocation size of the sigframe at process runtime according to current status of V. Thus, provide the function sigaltstack_size_valid() to validate its size based on current allocation status of supported extensions. Signed-off-by: Andy Chiu <andy.chiu@sifive.com> Reviewed-by: Conor Dooley <conor.dooley@microchip.com> --- arch/riscv/kernel/signal.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/arch/riscv/kernel/signal.c b/arch/riscv/kernel/signal.c index 40f740183768..11411e113f0e 100644 --- a/arch/riscv/kernel/signal.c +++ b/arch/riscv/kernel/signal.c @@ -469,3 +469,10 @@ void __init init_rt_signal_env(void) */ signal_minsigstksz = get_rt_frame_size(true); } + +#ifdef CONFIG_DYNAMIC_SIGFRAME +bool sigaltstack_size_valid(size_t ss_size) +{ + return ss_size > get_rt_frame_size(false); +} +#endif /* CONFIG_DYNAMIC_SIGFRAME */ -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Andy Chiu <andy.chiu@sifive.com> To: linux-riscv@lists.infradead.org, palmer@dabbelt.com, anup@brainfault.org, atishp@atishpatra.org, kvm-riscv@lists.infradead.org, kvm@vger.kernel.org Cc: vineetg@rivosinc.com, greentime.hu@sifive.com, guoren@linux.alibaba.com, Andy Chiu <andy.chiu@sifive.com>, Paul Walmsley <paul.walmsley@sifive.com>, Albert Ou <aou@eecs.berkeley.edu>, Conor Dooley <conor.dooley@microchip.com>, Guo Ren <guoren@kernel.org>, Vincent Chen <vincent.chen@sifive.com>, Andrew Bresticker <abrestic@rivosinc.com> Subject: [PATCH -next v17 15/20] riscv: signal: validate altstack to reflect Vector Date: Mon, 27 Mar 2023 16:49:35 +0000 [thread overview] Message-ID: <20230327164941.20491-16-andy.chiu@sifive.com> (raw) In-Reply-To: <20230327164941.20491-1-andy.chiu@sifive.com> Some extensions, such as Vector, dynamically change footprint on a signal frame, so MINSIGSTKSZ is no longer accurate. For example, an RV64V implementation with vlen = 512 may occupy 2K + 40 + 12 Bytes of a signal frame with the upcoming support. And processes that do not execute any vector instructions do not need to reserve the extra sigframe. So we need a way to guard the allocation size of the sigframe at process runtime according to current status of V. Thus, provide the function sigaltstack_size_valid() to validate its size based on current allocation status of supported extensions. Signed-off-by: Andy Chiu <andy.chiu@sifive.com> Reviewed-by: Conor Dooley <conor.dooley@microchip.com> --- arch/riscv/kernel/signal.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/arch/riscv/kernel/signal.c b/arch/riscv/kernel/signal.c index 40f740183768..11411e113f0e 100644 --- a/arch/riscv/kernel/signal.c +++ b/arch/riscv/kernel/signal.c @@ -469,3 +469,10 @@ void __init init_rt_signal_env(void) */ signal_minsigstksz = get_rt_frame_size(true); } + +#ifdef CONFIG_DYNAMIC_SIGFRAME +bool sigaltstack_size_valid(size_t ss_size) +{ + return ss_size > get_rt_frame_size(false); +} +#endif /* CONFIG_DYNAMIC_SIGFRAME */ -- 2.17.1 _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2023-03-27 16:51 UTC|newest] Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-03-27 16:49 [PATCH -next v17 00/20] riscv: Add vector ISA support Andy Chiu 2023-03-27 16:49 ` Andy Chiu 2023-03-27 16:49 ` [PATCH -next v17 01/20] riscv: Rename __switch_to_aux() -> fpu Andy Chiu 2023-03-27 16:49 ` Andy Chiu 2023-03-27 16:49 ` [PATCH -next v17 02/20] riscv: Extending cpufeature.c to detect V-extension Andy Chiu 2023-03-27 16:49 ` Andy Chiu 2023-03-31 10:45 ` Heiko Stübner 2023-03-31 10:45 ` Heiko Stübner 2023-03-27 16:49 ` [PATCH -next v17 03/20] riscv: Add new csr defines related to vector extension Andy Chiu 2023-03-27 16:49 ` Andy Chiu 2023-03-31 16:03 ` Heiko Stübner 2023-03-31 16:03 ` Heiko Stübner 2023-03-27 16:49 ` [PATCH -next v17 04/20] riscv: Clear vector regfile on bootup Andy Chiu 2023-03-27 16:49 ` Andy Chiu 2023-03-31 10:53 ` Heiko Stübner 2023-03-31 10:53 ` Heiko Stübner 2023-03-27 16:49 ` [PATCH -next v17 05/20] riscv: Disable Vector Instructions for kernel itself Andy Chiu 2023-03-27 16:49 ` Andy Chiu 2023-03-31 10:56 ` Heiko Stübner 2023-03-31 10:56 ` Heiko Stübner 2023-03-27 16:49 ` [PATCH -next v17 06/20] riscv: Introduce Vector enable/disable helpers Andy Chiu 2023-03-27 16:49 ` Andy Chiu 2023-03-31 10:56 ` Heiko Stübner 2023-03-31 10:56 ` Heiko Stübner 2023-03-27 16:49 ` [PATCH -next v17 07/20] riscv: Introduce riscv_v_vsize to record size of Vector context Andy Chiu 2023-03-27 16:49 ` Andy Chiu 2023-03-31 11:02 ` Heiko Stübner 2023-03-31 11:02 ` Heiko Stübner 2023-03-27 16:49 ` [PATCH -next v17 08/20] riscv: Introduce struct/helpers to save/restore per-task Vector state Andy Chiu 2023-03-27 16:49 ` Andy Chiu 2023-03-31 11:05 ` Heiko Stübner 2023-03-31 11:05 ` Heiko Stübner 2023-03-27 16:49 ` [PATCH -next v17 09/20] riscv: Add task switch support for vector Andy Chiu 2023-03-27 16:49 ` Andy Chiu 2023-03-31 11:19 ` Heiko Stübner 2023-03-31 11:19 ` Heiko Stübner 2023-03-27 16:49 ` [PATCH -next v17 10/20] riscv: Allocate user's vector context in the first-use trap Andy Chiu 2023-03-27 16:49 ` Andy Chiu 2023-03-28 17:22 ` Conor Dooley 2023-03-28 17:22 ` Conor Dooley 2023-03-31 14:38 ` Andy Chiu 2023-03-31 14:38 ` Andy Chiu 2023-03-31 13:08 ` Heiko Stübner 2023-03-31 13:08 ` Heiko Stübner 2023-03-27 16:49 ` [PATCH -next v17 11/20] riscv: Add ptrace vector support Andy Chiu 2023-03-27 16:49 ` Andy Chiu 2023-03-28 5:53 ` Rolf Eike Beer 2023-03-28 5:53 ` Rolf Eike Beer 2023-03-28 6:46 ` Andy Chiu 2023-03-28 6:46 ` Andy Chiu 2023-03-27 16:49 ` [PATCH -next v17 12/20] riscv: signal: check fp-reserved words unconditionally Andy Chiu 2023-03-27 16:49 ` Andy Chiu 2023-04-01 22:21 ` Heiko Stübner 2023-04-01 22:21 ` Heiko Stübner 2023-03-27 16:49 ` [PATCH -next v17 13/20] riscv: signal: Add sigcontext save/restore for vector Andy Chiu 2023-03-27 16:49 ` Andy Chiu 2023-04-01 22:20 ` Heiko Stübner 2023-04-01 22:20 ` Heiko Stübner 2023-03-27 16:49 ` [PATCH -next v17 14/20] riscv: signal: Report signal frame size to userspace via auxv Andy Chiu 2023-03-27 16:49 ` Andy Chiu 2023-04-01 22:19 ` Heiko Stübner 2023-04-01 22:19 ` Heiko Stübner 2023-03-27 16:49 ` Andy Chiu [this message] 2023-03-27 16:49 ` [PATCH -next v17 15/20] riscv: signal: validate altstack to reflect Vector Andy Chiu 2023-03-31 13:43 ` Heiko Stübner 2023-03-31 13:43 ` Heiko Stübner 2023-03-27 16:49 ` [PATCH -next v17 16/20] riscv: prevent stack corruption by reserving task_pt_regs(p) early Andy Chiu 2023-03-27 16:49 ` Andy Chiu 2023-03-31 13:38 ` Heiko Stübner 2023-03-31 13:38 ` Heiko Stübner 2023-03-27 16:49 ` [PATCH -next v17 17/20] riscv: kvm: Add V extension to KVM ISA Andy Chiu 2023-03-27 16:49 ` Andy Chiu 2023-03-31 13:36 ` Heiko Stübner 2023-03-31 13:36 ` Heiko Stübner 2023-03-27 16:49 ` [PATCH -next v17 18/20] riscv: KVM: Add vector lazy save/restore support Andy Chiu 2023-03-27 16:49 ` Andy Chiu 2023-03-27 17:36 ` Anup Patel 2023-03-27 17:36 ` Anup Patel 2023-03-27 16:49 ` [PATCH -next v17 19/20] riscv: detect assembler support for .option arch Andy Chiu 2023-03-27 16:49 ` Andy Chiu 2023-03-31 13:33 ` Heiko Stübner 2023-03-31 13:33 ` Heiko Stübner 2023-03-27 16:49 ` [PATCH -next v17 20/20] riscv: Enable Vector code to be built Andy Chiu 2023-03-27 16:49 ` Andy Chiu 2023-03-31 13:32 ` Heiko Stübner 2023-03-31 13:32 ` Heiko Stübner
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230327164941.20491-16-andy.chiu@sifive.com \ --to=andy.chiu@sifive.com \ --cc=abrestic@rivosinc.com \ --cc=anup@brainfault.org \ --cc=aou@eecs.berkeley.edu \ --cc=atishp@atishpatra.org \ --cc=conor.dooley@microchip.com \ --cc=greentime.hu@sifive.com \ --cc=guoren@kernel.org \ --cc=guoren@linux.alibaba.com \ --cc=kvm-riscv@lists.infradead.org \ --cc=kvm@vger.kernel.org \ --cc=linux-riscv@lists.infradead.org \ --cc=palmer@dabbelt.com \ --cc=paul.walmsley@sifive.com \ --cc=vincent.chen@sifive.com \ --cc=vineetg@rivosinc.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.