From: Daniel Vetter <daniel.vetter@ffwll.ch> To: DRI Development <dri-devel@lists.freedesktop.org> Cc: x86@kernel.org, Thomas Zimmermann <tzimmermann@suse.de>, Daniel Vetter <daniel.vetter@ffwll.ch>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>, Dave Hansen <dave.hansen@linux.intel.com>, Javier Martinez Canillas <javierm@redhat.com>, Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>, Daniel Vetter <daniel.vetter@intel.com>, Thomas Gleixner <tglx@linutronix.de>, Helge Deller <deller@gmx.de> Subject: [PATCH 8/8] fbdev: Simplify fb_is_primary_device for x86 Date: Tue, 4 Apr 2023 22:18:42 +0200 [thread overview] Message-ID: <20230404201842.567344-8-daniel.vetter@ffwll.ch> (raw) In-Reply-To: <20230404201842.567344-1-daniel.vetter@ffwll.ch> vga_default_device really is supposed to cover all corners, at least for x86. Additionally checking for rom shadowing should be redundant, because the bios/fw only does that for the boot vga device. If this turns out to be wrong, then most likely that's a special case which should be added to the vgaarb code, not replicated all over. Patch motived by changes to the aperture helpers, which also have this open code in a bunch of places, and which are all removed in a clean-up series. This function here is just for selecting the default fbdev device for fbcon, but I figured for consistency it might be good to throw this patch in on top. Note that the shadow rom check predates vgaarb, which was only wired up in 88674088d10c ("x86: Use vga_default_device() when determining whether an fb is primary"). That patch doesn't explain why we still fall back to the shadow rom check. Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> Cc: Daniel Vetter <daniel.vetter@ffwll.ch> Cc: Helge Deller <deller@gmx.de> Cc: Daniel Vetter <daniel@ffwll.ch> Cc: Javier Martinez Canillas <javierm@redhat.com> Cc: Thomas Zimmermann <tzimmermann@suse.de> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Ingo Molnar <mingo@redhat.com> Cc: Borislav Petkov <bp@alien8.de> Cc: Dave Hansen <dave.hansen@linux.intel.com> Cc: x86@kernel.org Cc: "H. Peter Anvin" <hpa@zytor.com> --- arch/x86/video/fbdev.c | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/arch/x86/video/fbdev.c b/arch/x86/video/fbdev.c index 9fd24846d094..5ec4eafbb981 100644 --- a/arch/x86/video/fbdev.c +++ b/arch/x86/video/fbdev.c @@ -14,26 +14,15 @@ int fb_is_primary_device(struct fb_info *info) { struct device *device = info->device; - struct pci_dev *default_device = vga_default_device(); struct pci_dev *pci_dev; - struct resource *res; if (!device || !dev_is_pci(device)) return 0; pci_dev = to_pci_dev(device); - if (default_device) { - if (pci_dev == default_device) - return 1; - return 0; - } - - res = pci_dev->resource + PCI_ROM_RESOURCE; - - if (res->flags & IORESOURCE_ROM_SHADOW) + if (pci_dev == vga_default_device()) return 1; - return 0; } EXPORT_SYMBOL(fb_is_primary_device); -- 2.40.0
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel.vetter@ffwll.ch> To: DRI Development <dri-devel@lists.freedesktop.org> Cc: x86@kernel.org, Thomas Zimmermann <tzimmermann@suse.de>, Daniel Vetter <daniel.vetter@ffwll.ch>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>, Dave Hansen <dave.hansen@linux.intel.com>, Javier Martinez Canillas <javierm@redhat.com>, Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>, Daniel Vetter <daniel@ffwll.ch>, "H. Peter Anvin" <hpa@zytor.com>, Daniel Vetter <daniel.vetter@intel.com>, Thomas Gleixner <tglx@linutronix.de>, Helge Deller <deller@gmx.de> Subject: [Intel-gfx] [PATCH 8/8] fbdev: Simplify fb_is_primary_device for x86 Date: Tue, 4 Apr 2023 22:18:42 +0200 [thread overview] Message-ID: <20230404201842.567344-8-daniel.vetter@ffwll.ch> (raw) In-Reply-To: <20230404201842.567344-1-daniel.vetter@ffwll.ch> vga_default_device really is supposed to cover all corners, at least for x86. Additionally checking for rom shadowing should be redundant, because the bios/fw only does that for the boot vga device. If this turns out to be wrong, then most likely that's a special case which should be added to the vgaarb code, not replicated all over. Patch motived by changes to the aperture helpers, which also have this open code in a bunch of places, and which are all removed in a clean-up series. This function here is just for selecting the default fbdev device for fbcon, but I figured for consistency it might be good to throw this patch in on top. Note that the shadow rom check predates vgaarb, which was only wired up in 88674088d10c ("x86: Use vga_default_device() when determining whether an fb is primary"). That patch doesn't explain why we still fall back to the shadow rom check. Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> Cc: Daniel Vetter <daniel.vetter@ffwll.ch> Cc: Helge Deller <deller@gmx.de> Cc: Daniel Vetter <daniel@ffwll.ch> Cc: Javier Martinez Canillas <javierm@redhat.com> Cc: Thomas Zimmermann <tzimmermann@suse.de> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Ingo Molnar <mingo@redhat.com> Cc: Borislav Petkov <bp@alien8.de> Cc: Dave Hansen <dave.hansen@linux.intel.com> Cc: x86@kernel.org Cc: "H. Peter Anvin" <hpa@zytor.com> --- arch/x86/video/fbdev.c | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/arch/x86/video/fbdev.c b/arch/x86/video/fbdev.c index 9fd24846d094..5ec4eafbb981 100644 --- a/arch/x86/video/fbdev.c +++ b/arch/x86/video/fbdev.c @@ -14,26 +14,15 @@ int fb_is_primary_device(struct fb_info *info) { struct device *device = info->device; - struct pci_dev *default_device = vga_default_device(); struct pci_dev *pci_dev; - struct resource *res; if (!device || !dev_is_pci(device)) return 0; pci_dev = to_pci_dev(device); - if (default_device) { - if (pci_dev == default_device) - return 1; - return 0; - } - - res = pci_dev->resource + PCI_ROM_RESOURCE; - - if (res->flags & IORESOURCE_ROM_SHADOW) + if (pci_dev == vga_default_device()) return 1; - return 0; } EXPORT_SYMBOL(fb_is_primary_device); -- 2.40.0
next prev parent reply other threads:[~2023-04-04 20:19 UTC|newest] Thread overview: 112+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-04-04 20:18 [PATCH 1/8] drm/gma500: Use drm_aperture_remove_conflicting_pci_framebuffers Daniel Vetter 2023-04-04 20:18 ` [Intel-gfx] " Daniel Vetter 2023-04-04 20:18 ` [PATCH 2/8] video/aperture: use generic code to figure out the vga default device Daniel Vetter 2023-04-04 20:18 ` [Intel-gfx] " Daniel Vetter 2023-04-04 20:18 ` Daniel Vetter 2023-04-05 11:27 ` Javier Martinez Canillas 2023-04-05 11:27 ` Javier Martinez Canillas 2023-04-05 11:27 ` [Intel-gfx] " Javier Martinez Canillas 2023-04-04 20:18 ` [PATCH 3/8] drm/aperture: Remove primary argument Daniel Vetter 2023-04-04 20:18 ` Daniel Vetter 2023-04-04 20:18 ` Daniel Vetter 2023-04-04 20:18 ` [Intel-gfx] " Daniel Vetter 2023-04-04 20:18 ` Daniel Vetter 2023-04-04 21:20 ` Martin Blumenstingl 2023-04-04 21:20 ` [Intel-gfx] " Martin Blumenstingl 2023-04-04 21:20 ` Martin Blumenstingl 2023-04-04 21:20 ` Martin Blumenstingl 2023-04-04 21:20 ` Martin Blumenstingl 2023-04-05 9:25 ` Thierry Reding 2023-04-05 9:25 ` Thierry Reding 2023-04-05 9:25 ` Thierry Reding 2023-04-05 9:25 ` Thierry Reding 2023-04-05 9:25 ` [Intel-gfx] " Thierry Reding 2023-04-05 11:30 ` Javier Martinez Canillas 2023-04-05 11:30 ` Javier Martinez Canillas 2023-04-05 11:30 ` Javier Martinez Canillas 2023-04-05 11:30 ` Javier Martinez Canillas 2023-04-05 11:30 ` Javier Martinez Canillas 2023-04-04 20:18 ` [PATCH 4/8] video/aperture: Only kick vgacon when the pdev is decoding vga Daniel Vetter 2023-04-04 20:18 ` [Intel-gfx] " Daniel Vetter 2023-04-04 20:18 ` Daniel Vetter 2023-04-05 11:31 ` Javier Martinez Canillas 2023-04-05 11:31 ` [Intel-gfx] " Javier Martinez Canillas 2023-04-05 11:31 ` Javier Martinez Canillas 2023-04-04 20:18 ` [PATCH 5/8] video/aperture: Move vga handling to pci function Daniel Vetter 2023-04-04 20:18 ` [Intel-gfx] " Daniel Vetter 2023-04-04 20:18 ` Daniel Vetter 2023-04-05 11:34 ` Javier Martinez Canillas 2023-04-05 11:34 ` Javier Martinez Canillas 2023-04-05 11:34 ` [Intel-gfx] " Javier Martinez Canillas 2023-04-04 20:18 ` [PATCH 6/8] video/aperture: Drop primary argument Daniel Vetter 2023-04-04 20:18 ` [Intel-gfx] " Daniel Vetter 2023-04-04 20:18 ` Daniel Vetter 2023-04-05 11:36 ` Javier Martinez Canillas 2023-04-05 11:36 ` Javier Martinez Canillas 2023-04-05 11:36 ` [Intel-gfx] " Javier Martinez Canillas 2023-04-04 20:18 ` [PATCH 7/8] video/aperture: Only remove sysfb on the default vga pci device Daniel Vetter 2023-04-04 20:18 ` [Intel-gfx] " Daniel Vetter 2023-04-04 20:18 ` Daniel Vetter 2023-04-04 20:59 ` Aaron Plattner 2023-04-04 20:59 ` Aaron Plattner 2023-04-04 20:59 ` [Intel-gfx] " Aaron Plattner 2023-04-05 8:48 ` Daniel Vetter 2023-04-05 8:48 ` [Intel-gfx] " Daniel Vetter 2023-04-05 8:48 ` Daniel Vetter 2023-04-05 11:37 ` Javier Martinez Canillas 2023-04-05 11:37 ` Javier Martinez Canillas 2023-04-05 11:37 ` [Intel-gfx] " Javier Martinez Canillas 2023-04-04 20:18 ` Daniel Vetter [this message] 2023-04-04 20:18 ` [Intel-gfx] [PATCH 8/8] fbdev: Simplify fb_is_primary_device for x86 Daniel Vetter 2023-04-05 11:40 ` Javier Martinez Canillas 2023-04-05 11:40 ` [Intel-gfx] " Javier Martinez Canillas 2023-04-04 23:44 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/8] drm/gma500: Use drm_aperture_remove_conflicting_pci_framebuffers Patchwork 2023-04-04 23:44 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork 2023-04-04 23:51 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2023-04-05 7:49 ` [PATCH 1/8] " Thomas Zimmermann 2023-04-05 7:49 ` [Intel-gfx] " Thomas Zimmermann 2023-04-05 8:05 ` Patrik Jakobsson 2023-04-05 8:05 ` [Intel-gfx] " Patrik Jakobsson 2023-04-05 8:15 ` Thomas Zimmermann 2023-04-05 8:15 ` [Intel-gfx] " Thomas Zimmermann 2023-04-05 8:07 ` Thomas Zimmermann 2023-04-05 8:07 ` [Intel-gfx] " Thomas Zimmermann 2023-04-05 8:59 ` Daniel Vetter 2023-04-05 8:59 ` [Intel-gfx] " Daniel Vetter 2023-04-05 9:26 ` Thomas Zimmermann 2023-04-05 9:26 ` [Intel-gfx] " Thomas Zimmermann 2023-04-05 9:38 ` Daniel Vetter 2023-04-05 9:38 ` [Intel-gfx] " Daniel Vetter 2023-04-05 11:00 ` Thomas Zimmermann 2023-04-05 11:00 ` [Intel-gfx] " Thomas Zimmermann 2023-04-05 11:16 ` Javier Martinez Canillas 2023-04-05 11:16 ` [Intel-gfx] " Javier Martinez Canillas 2023-04-05 13:18 ` Daniel Vetter 2023-04-05 13:18 ` [Intel-gfx] " Daniel Vetter 2023-04-05 14:32 ` Thomas Zimmermann 2023-04-05 14:32 ` [Intel-gfx] " Thomas Zimmermann 2023-04-05 16:02 ` Daniel Vetter 2023-04-05 16:02 ` [Intel-gfx] " Daniel Vetter 2023-04-05 16:54 ` Javier Martinez Canillas 2023-04-05 16:54 ` [Intel-gfx] " Javier Martinez Canillas 2023-04-05 17:14 ` Daniel Vetter 2023-04-05 17:14 ` [Intel-gfx] " Daniel Vetter 2023-04-05 17:43 ` Javier Martinez Canillas 2023-04-05 17:43 ` [Intel-gfx] " Javier Martinez Canillas 2023-04-05 17:46 ` Patrik Jakobsson 2023-04-06 7:31 ` Daniel Vetter 2023-04-06 11:16 ` Patrik Jakobsson 2023-04-05 8:19 ` Thomas Zimmermann 2023-04-05 8:19 ` [Intel-gfx] " Thomas Zimmermann 2023-04-05 9:09 ` Daniel Vetter 2023-04-05 9:09 ` [Intel-gfx] " Daniel Vetter 2023-04-05 10:10 ` [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/8] " Patchwork 2023-04-06 7:14 ` [PATCH 1/8] " Thomas Zimmermann 2023-04-06 7:14 ` [Intel-gfx] " Thomas Zimmermann 2023-04-06 8:38 ` Javier Martinez Canillas 2023-04-06 8:38 ` [Intel-gfx] " Javier Martinez Canillas 2023-04-06 8:49 ` Thomas Zimmermann 2023-04-06 8:49 ` [Intel-gfx] " Thomas Zimmermann 2023-04-06 9:05 ` Javier Martinez Canillas 2023-04-06 9:05 ` [Intel-gfx] " Javier Martinez Canillas 2023-04-06 9:05 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [1/8] drm/gma500: Use drm_aperture_remove_conflicting_pci_framebuffers (rev2) Patchwork
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230404201842.567344-8-daniel.vetter@ffwll.ch \ --to=daniel.vetter@ffwll.ch \ --cc=bp@alien8.de \ --cc=daniel.vetter@intel.com \ --cc=dave.hansen@linux.intel.com \ --cc=deller@gmx.de \ --cc=dri-devel@lists.freedesktop.org \ --cc=hpa@zytor.com \ --cc=intel-gfx@lists.freedesktop.org \ --cc=javierm@redhat.com \ --cc=mingo@redhat.com \ --cc=tglx@linutronix.de \ --cc=tzimmermann@suse.de \ --cc=x86@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.