All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Yu Zhao <yuzhao@google.com>, Minchan Kim <minchan@kernel.org>,
	Yosry Ahmed <yosryahmed@google.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Sergey Senozhatsky <senozhatsky@chromium.org>
Subject: [PATCH] zsmalloc: reset compaction source zspage pointer after putback_zspage()
Date: Mon, 17 Apr 2023 14:01:40 +0900	[thread overview]
Message-ID: <20230417050140.1653593-1-senozhatsky@chromium.org> (raw)
In-Reply-To: <20230304034835.2082479-4-senozhatsky@chromium.org>

Fixup.

Reported-by: Yu Zhao <yuzhao@google.com>
Signed-off-by: Sergey Senozhatsky <senozhatsky@chromium.org>
---
 mm/zsmalloc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
index aea50e2aa350..cc81dfba05a0 100644
--- a/mm/zsmalloc.c
+++ b/mm/zsmalloc.c
@@ -2239,8 +2239,8 @@ static unsigned long __zs_compact(struct zs_pool *pool,
 		if (fg == ZS_INUSE_RATIO_0) {
 			free_zspage(pool, class, src_zspage);
 			pages_freed += class->pages_per_zspage;
-			src_zspage = NULL;
 		}
+		src_zspage = NULL;
 
 		if (get_fullness_group(class, dst_zspage) == ZS_INUSE_RATIO_100
 		    || spin_is_contended(&pool->lock)) {
-- 
2.40.0.634.g4ca3ef3211-goog


  reply	other threads:[~2023-04-17  5:01 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-04  3:48 [PATCHv4 0/4] zsmalloc: fine-grained fullness and new compaction algorithm Sergey Senozhatsky
2023-03-04  3:48 ` [PATCHv4 1/4] zsmalloc: remove insert_zspage() ->inuse optimization Sergey Senozhatsky
2023-03-04  3:48 ` [PATCHv4 2/4] zsmalloc: fine-grained inuse ratio based fullness grouping Sergey Senozhatsky
2023-03-04  3:48 ` [PATCHv4 3/4] zsmalloc: rework compaction algorithm Sergey Senozhatsky
2023-04-17  5:01   ` Sergey Senozhatsky [this message]
2023-04-17  5:11     ` [PATCH] zsmalloc: reset compaction source zspage pointer after putback_zspage() Yu Zhao
2023-04-17 11:43     ` Yosry Ahmed
2023-04-17 13:07       ` Sergey Senozhatsky
2023-04-17 13:08   ` Sergey Senozhatsky
2023-03-04  3:48 ` [PATCHv4 4/4] zsmalloc: show per fullness group class stats Sergey Senozhatsky
2023-03-10 21:10 ` [PATCHv4 0/4] zsmalloc: fine-grained fullness and new compaction algorithm Minchan Kim
2023-03-11  8:30   ` Sergey Senozhatsky
2023-04-16  7:20 ` Yu Zhao
2023-04-16 15:18   ` Sergey Senozhatsky
2023-04-16 19:27     ` Yu Zhao
2023-04-17  2:44       ` Sergey Senozhatsky
2023-04-17  2:55         ` Yu Zhao
2023-04-17  3:52           ` Sergey Senozhatsky
2023-04-17  8:29             ` Yosry Ahmed
2023-04-17 11:12               ` Sergey Senozhatsky
2023-04-17 11:16                 ` Yosry Ahmed
2023-04-17 11:24                   ` Sergey Senozhatsky
2023-04-17 11:31                     ` Yosry Ahmed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230417050140.1653593-1-senozhatsky@chromium.org \
    --to=senozhatsky@chromium.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=minchan@kernel.org \
    --cc=yosryahmed@google.com \
    --cc=yuzhao@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.