From: Sarthak Kukreti <sarthakkukreti@chromium.org> To: dm-devel@redhat.com, linux-block@vger.kernel.org, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Cc: Jens Axboe <axboe@kernel.dk>, "Michael S. Tsirkin" <mst@redhat.com>, Jason Wang <jasowang@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, Alasdair Kergon <agk@redhat.com>, Mike Snitzer <snitzer@kernel.org>, Christoph Hellwig <hch@infradead.org>, Brian Foster <bfoster@redhat.com>, Theodore Ts'o <tytso@mit.edu>, Andreas Dilger <adilger.kernel@dilger.ca>, Bart Van Assche <bvanassche@google.com>, Daniil Lunev <dlunev@google.com>, "Darrick J. Wong" <djwong@kernel.org> Subject: [PATCH v5 1/5] block: Don't invalidate pagecache for invalid falloc modes Date: Wed, 19 Apr 2023 17:48:46 -0700 [thread overview] Message-ID: <20230420004850.297045-2-sarthakkukreti@chromium.org> (raw) In-Reply-To: <20230420004850.297045-1-sarthakkukreti@chromium.org> Only call truncate_bdev_range() if the fallocate mode is supported. This fixes a bug where data in the pagecache could be invalidated if the fallocate() was called on the block device with an invalid mode. Fixes: 25f4c41415e5 ("block: implement (some of) fallocate for block devices") Signed-off-by: Sarthak Kukreti <sarthakkukreti@chromium.org> --- block/fops.c | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/block/fops.c b/block/fops.c index d2e6be4e3d1c..2fd7e8b9ab48 100644 --- a/block/fops.c +++ b/block/fops.c @@ -648,25 +648,27 @@ static long blkdev_fallocate(struct file *file, int mode, loff_t start, filemap_invalidate_lock(inode->i_mapping); - /* Invalidate the page cache, including dirty pages. */ - error = truncate_bdev_range(bdev, file->f_mode, start, end); - if (error) - goto fail; - + /* + * Invalidate the page cache, including dirty pages, for valid + * de-allocate mode calls to fallocate(). + */ switch (mode) { case FALLOC_FL_ZERO_RANGE: case FALLOC_FL_ZERO_RANGE | FALLOC_FL_KEEP_SIZE: - error = blkdev_issue_zeroout(bdev, start >> SECTOR_SHIFT, + error = truncate_bdev_range(bdev, file->f_mode, start, end) || + blkdev_issue_zeroout(bdev, start >> SECTOR_SHIFT, len >> SECTOR_SHIFT, GFP_KERNEL, BLKDEV_ZERO_NOUNMAP); break; case FALLOC_FL_PUNCH_HOLE | FALLOC_FL_KEEP_SIZE: - error = blkdev_issue_zeroout(bdev, start >> SECTOR_SHIFT, + error = truncate_bdev_range(bdev, file->f_mode, start, end) || + blkdev_issue_zeroout(bdev, start >> SECTOR_SHIFT, len >> SECTOR_SHIFT, GFP_KERNEL, BLKDEV_ZERO_NOFALLBACK); break; case FALLOC_FL_PUNCH_HOLE | FALLOC_FL_KEEP_SIZE | FALLOC_FL_NO_HIDE_STALE: - error = blkdev_issue_discard(bdev, start >> SECTOR_SHIFT, + error = truncate_bdev_range(bdev, file->f_mode, start, end) || + blkdev_issue_discard(bdev, start >> SECTOR_SHIFT, len >> SECTOR_SHIFT, GFP_KERNEL); break; default: -- 2.40.0.634.g4ca3ef3211-goog
WARNING: multiple messages have this Message-ID (diff)
From: Sarthak Kukreti <sarthakkukreti@chromium.org> To: dm-devel@redhat.com, linux-block@vger.kernel.org, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Cc: Jens Axboe <axboe@kernel.dk>, Theodore Ts'o <tytso@mit.edu>, "Michael S. Tsirkin" <mst@redhat.com>, "Darrick J. Wong" <djwong@kernel.org>, Jason Wang <jasowang@redhat.com>, Bart Van Assche <bvanassche@google.com>, Mike Snitzer <snitzer@kernel.org>, Christoph Hellwig <hch@infradead.org>, Andreas Dilger <adilger.kernel@dilger.ca>, Daniil Lunev <dlunev@google.com>, Stefan Hajnoczi <stefanha@redhat.com>, Brian Foster <bfoster@redhat.com>, Alasdair Kergon <agk@redhat.com> Subject: [dm-devel] [PATCH v5 1/5] block: Don't invalidate pagecache for invalid falloc modes Date: Wed, 19 Apr 2023 17:48:46 -0700 [thread overview] Message-ID: <20230420004850.297045-2-sarthakkukreti@chromium.org> (raw) In-Reply-To: <20230420004850.297045-1-sarthakkukreti@chromium.org> Only call truncate_bdev_range() if the fallocate mode is supported. This fixes a bug where data in the pagecache could be invalidated if the fallocate() was called on the block device with an invalid mode. Fixes: 25f4c41415e5 ("block: implement (some of) fallocate for block devices") Signed-off-by: Sarthak Kukreti <sarthakkukreti@chromium.org> --- block/fops.c | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/block/fops.c b/block/fops.c index d2e6be4e3d1c..2fd7e8b9ab48 100644 --- a/block/fops.c +++ b/block/fops.c @@ -648,25 +648,27 @@ static long blkdev_fallocate(struct file *file, int mode, loff_t start, filemap_invalidate_lock(inode->i_mapping); - /* Invalidate the page cache, including dirty pages. */ - error = truncate_bdev_range(bdev, file->f_mode, start, end); - if (error) - goto fail; - + /* + * Invalidate the page cache, including dirty pages, for valid + * de-allocate mode calls to fallocate(). + */ switch (mode) { case FALLOC_FL_ZERO_RANGE: case FALLOC_FL_ZERO_RANGE | FALLOC_FL_KEEP_SIZE: - error = blkdev_issue_zeroout(bdev, start >> SECTOR_SHIFT, + error = truncate_bdev_range(bdev, file->f_mode, start, end) || + blkdev_issue_zeroout(bdev, start >> SECTOR_SHIFT, len >> SECTOR_SHIFT, GFP_KERNEL, BLKDEV_ZERO_NOUNMAP); break; case FALLOC_FL_PUNCH_HOLE | FALLOC_FL_KEEP_SIZE: - error = blkdev_issue_zeroout(bdev, start >> SECTOR_SHIFT, + error = truncate_bdev_range(bdev, file->f_mode, start, end) || + blkdev_issue_zeroout(bdev, start >> SECTOR_SHIFT, len >> SECTOR_SHIFT, GFP_KERNEL, BLKDEV_ZERO_NOFALLBACK); break; case FALLOC_FL_PUNCH_HOLE | FALLOC_FL_KEEP_SIZE | FALLOC_FL_NO_HIDE_STALE: - error = blkdev_issue_discard(bdev, start >> SECTOR_SHIFT, + error = truncate_bdev_range(bdev, file->f_mode, start, end) || + blkdev_issue_discard(bdev, start >> SECTOR_SHIFT, len >> SECTOR_SHIFT, GFP_KERNEL); break; default: -- 2.40.0.634.g4ca3ef3211-goog -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2023-04-20 0:49 UTC|newest] Thread overview: 118+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <20221229071647.437095-1-sarthakkukreti@chromium.org> 2023-04-14 0:02 ` [PATCH v3 0/3] Introduce provisioning primitives for thinly provisioned storage Sarthak Kukreti 2023-04-14 0:02 ` [dm-devel] " Sarthak Kukreti 2023-04-14 0:02 ` [PATCH v3 1/3] block: Introduce provisioning primitives Sarthak Kukreti 2023-04-14 0:02 ` [dm-devel] " Sarthak Kukreti 2023-04-17 17:35 ` Brian Foster 2023-04-17 17:35 ` Brian Foster 2023-04-18 22:13 ` Sarthak Kukreti 2023-04-18 22:13 ` [dm-devel] " Sarthak Kukreti 2023-04-14 0:02 ` [PATCH v3 2/3] dm: Add support for block provisioning Sarthak Kukreti 2023-04-14 0:02 ` [dm-devel] " Sarthak Kukreti 2023-04-14 13:32 ` Joe Thornber 2023-04-14 18:14 ` Mike Snitzer 2023-04-14 18:14 ` [dm-devel] " Mike Snitzer 2023-04-14 21:58 ` Mike Snitzer 2023-04-14 21:58 ` Mike Snitzer 2023-04-18 22:13 ` Sarthak Kukreti 2023-04-18 22:13 ` [dm-devel] " Sarthak Kukreti 2023-04-14 0:02 ` [PATCH v3 3/3] loop: Add support for provision requests Sarthak Kukreti 2023-04-14 0:02 ` [dm-devel] " Sarthak Kukreti 2023-04-18 22:12 ` [PATCH v4 0/4] Introduce provisioning primitives for thinly provisioned storage Sarthak Kukreti 2023-04-18 22:12 ` [dm-devel] " Sarthak Kukreti 2023-04-18 22:12 ` [PATCH v4 1/4] block: Introduce provisioning primitives Sarthak Kukreti 2023-04-18 22:12 ` [dm-devel] " Sarthak Kukreti 2023-04-18 22:43 ` Bart Van Assche 2023-04-18 22:43 ` [dm-devel] " Bart Van Assche 2023-04-20 17:41 ` Sarthak Kukreti 2023-04-20 17:41 ` [dm-devel] " Sarthak Kukreti 2023-04-19 15:36 ` Darrick J. Wong 2023-04-19 15:36 ` Darrick J. Wong 2023-04-19 16:17 ` Mike Snitzer 2023-04-19 16:17 ` [dm-devel] " Mike Snitzer 2023-04-19 17:26 ` Darrick J. Wong 2023-04-19 17:26 ` [dm-devel] " Darrick J. Wong 2023-04-19 23:21 ` Dave Chinner 2023-04-19 23:21 ` [dm-devel] " Dave Chinner 2023-04-20 0:53 ` Sarthak Kukreti 2023-04-20 0:53 ` [dm-devel] " Sarthak Kukreti 2023-04-18 22:12 ` [PATCH v4 2/4] dm: Add block provisioning support Sarthak Kukreti 2023-04-18 22:12 ` [dm-devel] " Sarthak Kukreti 2023-04-18 22:12 ` [PATCH v4 3/4] dm-thin: Add REQ_OP_PROVISION support Sarthak Kukreti 2023-04-18 22:12 ` [dm-devel] " Sarthak Kukreti 2023-04-18 22:12 ` [PATCH v4 4/4] loop: Add support for provision requests Sarthak Kukreti 2023-04-18 22:12 ` [dm-devel] " Sarthak Kukreti 2023-04-20 0:48 ` [PATCH v5 0/5] Introduce block provisioning primitives Sarthak Kukreti 2023-04-20 0:48 ` [dm-devel] " Sarthak Kukreti 2023-04-20 0:48 ` Sarthak Kukreti [this message] 2023-04-20 0:48 ` [dm-devel] [PATCH v5 1/5] block: Don't invalidate pagecache for invalid falloc modes Sarthak Kukreti 2023-04-20 1:22 ` Darrick J. Wong 2023-04-20 1:22 ` [dm-devel] " Darrick J. Wong 2023-04-20 1:48 ` Sarthak Kukreti 2023-04-20 1:48 ` [dm-devel] " Sarthak Kukreti 2023-04-20 1:47 ` [PATCH v5-fix " Sarthak Kukreti 2023-04-20 1:47 ` [dm-devel] " Sarthak Kukreti 2023-04-20 16:20 ` Mike Snitzer 2023-04-20 16:20 ` [dm-devel] " Mike Snitzer 2023-04-20 17:28 ` Sarthak Kukreti 2023-04-20 17:28 ` [dm-devel] " Sarthak Kukreti 2023-04-20 18:17 ` Sarthak Kukreti 2023-04-20 18:17 ` [dm-devel] " Sarthak Kukreti 2023-04-20 18:15 ` Sarthak Kukreti 2023-04-20 18:15 ` [dm-devel] " Sarthak Kukreti 2023-04-24 15:54 ` [PATCH v5 " kernel test robot 2023-04-24 15:54 ` [dm-devel] " kernel test robot 2023-05-04 8:50 ` kernel test robot 2023-05-04 8:50 ` [dm-devel] " kernel test robot 2023-04-20 0:48 ` [PATCH v5 2/5] block: Introduce provisioning primitives Sarthak Kukreti 2023-04-20 0:48 ` [dm-devel] " Sarthak Kukreti 2023-04-20 0:48 ` [PATCH v5 3/5] dm: Add block provisioning support Sarthak Kukreti 2023-04-20 0:48 ` [dm-devel] " Sarthak Kukreti 2023-04-20 0:48 ` [PATCH v5 4/5] dm-thin: Add REQ_OP_PROVISION support Sarthak Kukreti 2023-04-20 0:48 ` [dm-devel] " Sarthak Kukreti 2023-05-01 19:15 ` Mike Snitzer 2023-05-01 19:15 ` [dm-devel] " Mike Snitzer 2023-05-06 6:32 ` Sarthak Kukreti 2023-05-06 6:32 ` [dm-devel] " Sarthak Kukreti 2023-04-20 0:48 ` [PATCH v5 5/5] loop: Add support for provision requests Sarthak Kukreti 2023-04-20 0:48 ` [dm-devel] " Sarthak Kukreti 2023-05-06 6:29 ` [PATCH v6 0/5] Introduce block provisioning primitives Sarthak Kukreti 2023-05-06 6:29 ` [dm-devel] " Sarthak Kukreti 2023-05-06 6:29 ` [PATCH v6 1/5] block: Don't invalidate pagecache for invalid falloc modes Sarthak Kukreti 2023-05-06 6:29 ` [dm-devel] " Sarthak Kukreti 2023-05-09 16:51 ` Mike Snitzer 2023-05-09 16:51 ` [dm-devel] " Mike Snitzer 2023-05-12 18:31 ` Darrick J. Wong 2023-05-12 18:31 ` Darrick J. Wong 2023-05-06 6:29 ` [PATCH v6 2/5] block: Introduce provisioning primitives Sarthak Kukreti 2023-05-06 6:29 ` [dm-devel] " Sarthak Kukreti 2023-05-09 16:52 ` Mike Snitzer 2023-05-09 16:52 ` Mike Snitzer 2023-05-12 18:37 ` Darrick J. Wong 2023-05-12 18:37 ` [dm-devel] " Darrick J. Wong 2023-05-15 21:55 ` Sarthak Kukreti 2023-05-15 21:55 ` [dm-devel] " Sarthak Kukreti 2023-05-06 6:29 ` [PATCH v6 3/5] dm: Add block provisioning support Sarthak Kukreti 2023-05-06 6:29 ` [dm-devel] " Sarthak Kukreti 2023-05-09 16:52 ` Mike Snitzer 2023-05-09 16:52 ` [dm-devel] " Mike Snitzer 2023-05-06 6:29 ` [PATCH v6 4/5] dm-thin: Add REQ_OP_PROVISION support Sarthak Kukreti 2023-05-06 6:29 ` [dm-devel] " Sarthak Kukreti 2023-05-09 16:58 ` Mike Snitzer 2023-05-09 16:58 ` Mike Snitzer 2023-05-11 20:03 ` Sarthak Kukreti 2023-05-11 20:03 ` [dm-devel] " Sarthak Kukreti 2023-05-12 14:34 ` Mike Snitzer 2023-05-12 14:34 ` Mike Snitzer 2023-05-12 17:32 ` [dm-devel] " Mike Snitzer 2023-05-12 17:32 ` Mike Snitzer 2023-05-15 21:19 ` Sarthak Kukreti 2023-05-15 21:19 ` [dm-devel] " Sarthak Kukreti 2023-05-06 6:29 ` [PATCH v6 5/5] loop: Add support for provision requests Sarthak Kukreti 2023-05-06 6:29 ` [dm-devel] " Sarthak Kukreti 2023-05-15 12:40 ` Brian Foster 2023-05-15 12:40 ` Brian Foster 2023-05-15 21:31 ` Sarthak Kukreti 2023-05-15 21:31 ` [dm-devel] " Sarthak Kukreti 2023-05-12 18:28 ` [dm-devel] [PATCH v6 0/5] Introduce block provisioning primitives Darrick J. Wong 2023-05-12 18:28 ` Darrick J. Wong 2023-04-24 18:29 [PATCH v5 1/5] block: Don't invalidate pagecache for invalid falloc modes kernel test robot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230420004850.297045-2-sarthakkukreti@chromium.org \ --to=sarthakkukreti@chromium.org \ --cc=adilger.kernel@dilger.ca \ --cc=agk@redhat.com \ --cc=axboe@kernel.dk \ --cc=bfoster@redhat.com \ --cc=bvanassche@google.com \ --cc=djwong@kernel.org \ --cc=dlunev@google.com \ --cc=dm-devel@redhat.com \ --cc=hch@infradead.org \ --cc=jasowang@redhat.com \ --cc=linux-block@vger.kernel.org \ --cc=linux-ext4@vger.kernel.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mst@redhat.com \ --cc=snitzer@kernel.org \ --cc=stefanha@redhat.com \ --cc=tytso@mit.edu \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.