From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: Geert Uytterhoeven <geert+renesas@glider.be> Cc: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>, David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, Thomas Zimmermann <tzimmermann@suse.de>, Magnus Damm <magnus.damm@gmail.com>, dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 20/39] drm: renesas: shmobile: Replace .dev_private with container_of() Date: Fri, 23 Jun 2023 18:50:52 +0300 [thread overview] Message-ID: <20230623155052.GX2112@pendragon.ideasonboard.com> (raw) In-Reply-To: <48a0d1dcdf18ca07b97e2813ba26f9e52198a716.1687423204.git.geert+renesas@glider.be> Hi Geert, Thank you for the patch. On Thu, Jun 22, 2023 at 11:21:32AM +0200, Geert Uytterhoeven wrote: > Now that drm_device is embedded in shmob_drm_device, we can use > a container_of()-based helper to get the shmob_drm_device pointer from > the drm_device, instead of using the deprecated drm_device.dev_private > field. > > While at it, restore reverse Xmas tree ordering of local variable > declarations. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > --- > .../gpu/drm/renesas/shmobile/shmob_drm_crtc.c | 20 +++++++++---------- > .../gpu/drm/renesas/shmobile/shmob_drm_drv.c | 4 +--- > .../gpu/drm/renesas/shmobile/shmob_drm_drv.h | 5 +++++ > .../drm/renesas/shmobile/shmob_drm_plane.c | 6 +++--- > 4 files changed, 19 insertions(+), 16 deletions(-) > > diff --git a/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c b/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c > index 40948b56017ff2df..291b3a5014c24f08 100644 > --- a/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c > +++ b/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c > @@ -63,7 +63,7 @@ static void shmob_drm_clk_off(struct shmob_drm_device *sdev) > static void shmob_drm_crtc_setup_geometry(struct shmob_drm_crtc *scrtc) > { > struct drm_crtc *crtc = &scrtc->crtc; > - struct shmob_drm_device *sdev = crtc->dev->dev_private; > + struct shmob_drm_device *sdev = to_shmob_device(crtc->dev); > const struct shmob_drm_interface_data *idata = &sdev->pdata->iface; > const struct drm_display_mode *mode = &crtc->mode; > u32 value; > @@ -102,7 +102,7 @@ static void shmob_drm_crtc_setup_geometry(struct shmob_drm_crtc *scrtc) > > static void shmob_drm_crtc_start_stop(struct shmob_drm_crtc *scrtc, bool start) > { > - struct shmob_drm_device *sdev = scrtc->crtc.dev->dev_private; > + struct shmob_drm_device *sdev = to_shmob_device(scrtc->crtc.dev); > u32 value; > > value = lcdc_read(sdev, LDCNT2R); > @@ -136,7 +136,7 @@ static void shmob_drm_crtc_start_stop(struct shmob_drm_crtc *scrtc, bool start) > static void shmob_drm_crtc_start(struct shmob_drm_crtc *scrtc) > { > struct drm_crtc *crtc = &scrtc->crtc; > - struct shmob_drm_device *sdev = crtc->dev->dev_private; > + struct shmob_drm_device *sdev = to_shmob_device(crtc->dev); > const struct shmob_drm_interface_data *idata = &sdev->pdata->iface; > const struct shmob_drm_format_info *format; > struct drm_device *dev = &sdev->ddev; > @@ -223,7 +223,7 @@ static void shmob_drm_crtc_start(struct shmob_drm_crtc *scrtc) > static void shmob_drm_crtc_stop(struct shmob_drm_crtc *scrtc) > { > struct drm_crtc *crtc = &scrtc->crtc; > - struct shmob_drm_device *sdev = crtc->dev->dev_private; > + struct shmob_drm_device *sdev = to_shmob_device(crtc->dev); > > if (!scrtc->started) > return; > @@ -280,7 +280,7 @@ static void shmob_drm_crtc_compute_base(struct shmob_drm_crtc *scrtc, > static void shmob_drm_crtc_update_base(struct shmob_drm_crtc *scrtc) > { > struct drm_crtc *crtc = &scrtc->crtc; > - struct shmob_drm_device *sdev = crtc->dev->dev_private; > + struct shmob_drm_device *sdev = to_shmob_device(crtc->dev); > > shmob_drm_crtc_compute_base(scrtc, crtc->x, crtc->y); > > @@ -322,8 +322,8 @@ static int shmob_drm_crtc_mode_set(struct drm_crtc *crtc, > int x, int y, > struct drm_framebuffer *old_fb) > { > + struct shmob_drm_device *sdev = to_shmob_device(crtc->dev); > struct shmob_drm_crtc *scrtc = to_shmob_crtc(crtc); > - struct shmob_drm_device *sdev = crtc->dev->dev_private; > const struct shmob_drm_format_info *format; > > format = shmob_drm_format_info(crtc->primary->fb->format->format); > @@ -428,7 +428,7 @@ static void shmob_drm_crtc_enable_vblank(struct shmob_drm_device *sdev, > > static int shmob_drm_enable_vblank(struct drm_crtc *crtc) > { > - struct shmob_drm_device *sdev = crtc->dev->dev_private; > + struct shmob_drm_device *sdev = to_shmob_device(crtc->dev); > > shmob_drm_crtc_enable_vblank(sdev, true); > > @@ -437,7 +437,7 @@ static int shmob_drm_enable_vblank(struct drm_crtc *crtc) > > static void shmob_drm_disable_vblank(struct drm_crtc *crtc) > { > - struct shmob_drm_device *sdev = crtc->dev->dev_private; > + struct shmob_drm_device *sdev = to_shmob_device(crtc->dev); > > shmob_drm_crtc_enable_vblank(sdev, false); > } > @@ -511,7 +511,7 @@ static bool shmob_drm_encoder_mode_fixup(struct drm_encoder *encoder, > struct drm_display_mode *adjusted_mode) > { > struct drm_device *dev = encoder->dev; > - struct shmob_drm_device *sdev = dev->dev_private; > + struct shmob_drm_device *sdev = to_shmob_device(dev); > struct drm_connector *connector = &sdev->connector.connector; > const struct drm_display_mode *panel_mode; > > @@ -581,7 +581,7 @@ static inline struct shmob_drm_connector *to_shmob_connector(struct drm_connecto > > static int shmob_drm_connector_get_modes(struct drm_connector *connector) > { > - struct shmob_drm_device *sdev = connector->dev->dev_private; > + struct shmob_drm_device *sdev = to_shmob_device(connector->dev); > struct drm_display_mode *mode; > > mode = drm_mode_create(connector->dev); > diff --git a/drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.c b/drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.c > index 2b77af3a8c97ef8c..1a1d66c6e817e227 100644 > --- a/drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.c > +++ b/drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.c > @@ -95,7 +95,7 @@ static int shmob_drm_setup_clocks(struct shmob_drm_device *sdev, > static irqreturn_t shmob_drm_irq(int irq, void *arg) > { > struct drm_device *dev = arg; > - struct shmob_drm_device *sdev = dev->dev_private; > + struct shmob_drm_device *sdev = to_shmob_device(dev); > unsigned long flags; > u32 status; > > @@ -217,8 +217,6 @@ static int shmob_drm_probe(struct platform_device *pdev) > if (ret < 0) > return ret; > > - ddev->dev_private = sdev; > - > ret = shmob_drm_modeset_init(sdev); > if (ret < 0) > return dev_err_probe(&pdev->dev, ret, > diff --git a/drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.h b/drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.h > index 77bb0da48f37ace8..5e55ba7a207865bd 100644 > --- a/drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.h > +++ b/drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.h > @@ -39,4 +39,9 @@ struct shmob_drm_device { > struct shmob_drm_connector connector; > }; > > +static inline struct shmob_drm_device *to_shmob_device(struct drm_device *dev) > +{ > + return container_of(dev, struct shmob_drm_device, ddev); > +} > + > #endif /* __SHMOB_DRM_DRV_H__ */ > diff --git a/drivers/gpu/drm/renesas/shmobile/shmob_drm_plane.c b/drivers/gpu/drm/renesas/shmobile/shmob_drm_plane.c > index 258288c80756bf16..c58b9dca34736342 100644 > --- a/drivers/gpu/drm/renesas/shmobile/shmob_drm_plane.c > +++ b/drivers/gpu/drm/renesas/shmobile/shmob_drm_plane.c > @@ -63,7 +63,7 @@ static void shmob_drm_plane_compute_base(struct shmob_drm_plane *splane, > static void __shmob_drm_plane_setup(struct shmob_drm_plane *splane, > struct drm_framebuffer *fb) > { > - struct shmob_drm_device *sdev = splane->plane.dev->dev_private; > + struct shmob_drm_device *sdev = to_shmob_device(splane->plane.dev); > u32 format; > > /* TODO: Support ROP3 mode */ > @@ -135,8 +135,8 @@ shmob_drm_plane_update(struct drm_plane *plane, struct drm_crtc *crtc, > uint32_t src_w, uint32_t src_h, > struct drm_modeset_acquire_ctx *ctx) > { > + struct shmob_drm_device *sdev = to_shmob_device(plane->dev); > struct shmob_drm_plane *splane = to_shmob_plane(plane); > - struct shmob_drm_device *sdev = plane->dev->dev_private; > const struct shmob_drm_format_info *format; > > format = shmob_drm_format_info(fb->format->format); > @@ -167,8 +167,8 @@ shmob_drm_plane_update(struct drm_plane *plane, struct drm_crtc *crtc, > static int shmob_drm_plane_disable(struct drm_plane *plane, > struct drm_modeset_acquire_ctx *ctx) > { > + struct shmob_drm_device *sdev = to_shmob_device(plane->dev); > struct shmob_drm_plane *splane = to_shmob_plane(plane); > - struct shmob_drm_device *sdev = plane->dev->dev_private; > > splane->format = NULL; > -- Regards, Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: Geert Uytterhoeven <geert+renesas@glider.be> Cc: Magnus Damm <magnus.damm@gmail.com>, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>, Thomas Zimmermann <tzimmermann@suse.de> Subject: Re: [PATCH 20/39] drm: renesas: shmobile: Replace .dev_private with container_of() Date: Fri, 23 Jun 2023 18:50:52 +0300 [thread overview] Message-ID: <20230623155052.GX2112@pendragon.ideasonboard.com> (raw) In-Reply-To: <48a0d1dcdf18ca07b97e2813ba26f9e52198a716.1687423204.git.geert+renesas@glider.be> Hi Geert, Thank you for the patch. On Thu, Jun 22, 2023 at 11:21:32AM +0200, Geert Uytterhoeven wrote: > Now that drm_device is embedded in shmob_drm_device, we can use > a container_of()-based helper to get the shmob_drm_device pointer from > the drm_device, instead of using the deprecated drm_device.dev_private > field. > > While at it, restore reverse Xmas tree ordering of local variable > declarations. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > --- > .../gpu/drm/renesas/shmobile/shmob_drm_crtc.c | 20 +++++++++---------- > .../gpu/drm/renesas/shmobile/shmob_drm_drv.c | 4 +--- > .../gpu/drm/renesas/shmobile/shmob_drm_drv.h | 5 +++++ > .../drm/renesas/shmobile/shmob_drm_plane.c | 6 +++--- > 4 files changed, 19 insertions(+), 16 deletions(-) > > diff --git a/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c b/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c > index 40948b56017ff2df..291b3a5014c24f08 100644 > --- a/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c > +++ b/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c > @@ -63,7 +63,7 @@ static void shmob_drm_clk_off(struct shmob_drm_device *sdev) > static void shmob_drm_crtc_setup_geometry(struct shmob_drm_crtc *scrtc) > { > struct drm_crtc *crtc = &scrtc->crtc; > - struct shmob_drm_device *sdev = crtc->dev->dev_private; > + struct shmob_drm_device *sdev = to_shmob_device(crtc->dev); > const struct shmob_drm_interface_data *idata = &sdev->pdata->iface; > const struct drm_display_mode *mode = &crtc->mode; > u32 value; > @@ -102,7 +102,7 @@ static void shmob_drm_crtc_setup_geometry(struct shmob_drm_crtc *scrtc) > > static void shmob_drm_crtc_start_stop(struct shmob_drm_crtc *scrtc, bool start) > { > - struct shmob_drm_device *sdev = scrtc->crtc.dev->dev_private; > + struct shmob_drm_device *sdev = to_shmob_device(scrtc->crtc.dev); > u32 value; > > value = lcdc_read(sdev, LDCNT2R); > @@ -136,7 +136,7 @@ static void shmob_drm_crtc_start_stop(struct shmob_drm_crtc *scrtc, bool start) > static void shmob_drm_crtc_start(struct shmob_drm_crtc *scrtc) > { > struct drm_crtc *crtc = &scrtc->crtc; > - struct shmob_drm_device *sdev = crtc->dev->dev_private; > + struct shmob_drm_device *sdev = to_shmob_device(crtc->dev); > const struct shmob_drm_interface_data *idata = &sdev->pdata->iface; > const struct shmob_drm_format_info *format; > struct drm_device *dev = &sdev->ddev; > @@ -223,7 +223,7 @@ static void shmob_drm_crtc_start(struct shmob_drm_crtc *scrtc) > static void shmob_drm_crtc_stop(struct shmob_drm_crtc *scrtc) > { > struct drm_crtc *crtc = &scrtc->crtc; > - struct shmob_drm_device *sdev = crtc->dev->dev_private; > + struct shmob_drm_device *sdev = to_shmob_device(crtc->dev); > > if (!scrtc->started) > return; > @@ -280,7 +280,7 @@ static void shmob_drm_crtc_compute_base(struct shmob_drm_crtc *scrtc, > static void shmob_drm_crtc_update_base(struct shmob_drm_crtc *scrtc) > { > struct drm_crtc *crtc = &scrtc->crtc; > - struct shmob_drm_device *sdev = crtc->dev->dev_private; > + struct shmob_drm_device *sdev = to_shmob_device(crtc->dev); > > shmob_drm_crtc_compute_base(scrtc, crtc->x, crtc->y); > > @@ -322,8 +322,8 @@ static int shmob_drm_crtc_mode_set(struct drm_crtc *crtc, > int x, int y, > struct drm_framebuffer *old_fb) > { > + struct shmob_drm_device *sdev = to_shmob_device(crtc->dev); > struct shmob_drm_crtc *scrtc = to_shmob_crtc(crtc); > - struct shmob_drm_device *sdev = crtc->dev->dev_private; > const struct shmob_drm_format_info *format; > > format = shmob_drm_format_info(crtc->primary->fb->format->format); > @@ -428,7 +428,7 @@ static void shmob_drm_crtc_enable_vblank(struct shmob_drm_device *sdev, > > static int shmob_drm_enable_vblank(struct drm_crtc *crtc) > { > - struct shmob_drm_device *sdev = crtc->dev->dev_private; > + struct shmob_drm_device *sdev = to_shmob_device(crtc->dev); > > shmob_drm_crtc_enable_vblank(sdev, true); > > @@ -437,7 +437,7 @@ static int shmob_drm_enable_vblank(struct drm_crtc *crtc) > > static void shmob_drm_disable_vblank(struct drm_crtc *crtc) > { > - struct shmob_drm_device *sdev = crtc->dev->dev_private; > + struct shmob_drm_device *sdev = to_shmob_device(crtc->dev); > > shmob_drm_crtc_enable_vblank(sdev, false); > } > @@ -511,7 +511,7 @@ static bool shmob_drm_encoder_mode_fixup(struct drm_encoder *encoder, > struct drm_display_mode *adjusted_mode) > { > struct drm_device *dev = encoder->dev; > - struct shmob_drm_device *sdev = dev->dev_private; > + struct shmob_drm_device *sdev = to_shmob_device(dev); > struct drm_connector *connector = &sdev->connector.connector; > const struct drm_display_mode *panel_mode; > > @@ -581,7 +581,7 @@ static inline struct shmob_drm_connector *to_shmob_connector(struct drm_connecto > > static int shmob_drm_connector_get_modes(struct drm_connector *connector) > { > - struct shmob_drm_device *sdev = connector->dev->dev_private; > + struct shmob_drm_device *sdev = to_shmob_device(connector->dev); > struct drm_display_mode *mode; > > mode = drm_mode_create(connector->dev); > diff --git a/drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.c b/drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.c > index 2b77af3a8c97ef8c..1a1d66c6e817e227 100644 > --- a/drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.c > +++ b/drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.c > @@ -95,7 +95,7 @@ static int shmob_drm_setup_clocks(struct shmob_drm_device *sdev, > static irqreturn_t shmob_drm_irq(int irq, void *arg) > { > struct drm_device *dev = arg; > - struct shmob_drm_device *sdev = dev->dev_private; > + struct shmob_drm_device *sdev = to_shmob_device(dev); > unsigned long flags; > u32 status; > > @@ -217,8 +217,6 @@ static int shmob_drm_probe(struct platform_device *pdev) > if (ret < 0) > return ret; > > - ddev->dev_private = sdev; > - > ret = shmob_drm_modeset_init(sdev); > if (ret < 0) > return dev_err_probe(&pdev->dev, ret, > diff --git a/drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.h b/drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.h > index 77bb0da48f37ace8..5e55ba7a207865bd 100644 > --- a/drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.h > +++ b/drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.h > @@ -39,4 +39,9 @@ struct shmob_drm_device { > struct shmob_drm_connector connector; > }; > > +static inline struct shmob_drm_device *to_shmob_device(struct drm_device *dev) > +{ > + return container_of(dev, struct shmob_drm_device, ddev); > +} > + > #endif /* __SHMOB_DRM_DRV_H__ */ > diff --git a/drivers/gpu/drm/renesas/shmobile/shmob_drm_plane.c b/drivers/gpu/drm/renesas/shmobile/shmob_drm_plane.c > index 258288c80756bf16..c58b9dca34736342 100644 > --- a/drivers/gpu/drm/renesas/shmobile/shmob_drm_plane.c > +++ b/drivers/gpu/drm/renesas/shmobile/shmob_drm_plane.c > @@ -63,7 +63,7 @@ static void shmob_drm_plane_compute_base(struct shmob_drm_plane *splane, > static void __shmob_drm_plane_setup(struct shmob_drm_plane *splane, > struct drm_framebuffer *fb) > { > - struct shmob_drm_device *sdev = splane->plane.dev->dev_private; > + struct shmob_drm_device *sdev = to_shmob_device(splane->plane.dev); > u32 format; > > /* TODO: Support ROP3 mode */ > @@ -135,8 +135,8 @@ shmob_drm_plane_update(struct drm_plane *plane, struct drm_crtc *crtc, > uint32_t src_w, uint32_t src_h, > struct drm_modeset_acquire_ctx *ctx) > { > + struct shmob_drm_device *sdev = to_shmob_device(plane->dev); > struct shmob_drm_plane *splane = to_shmob_plane(plane); > - struct shmob_drm_device *sdev = plane->dev->dev_private; > const struct shmob_drm_format_info *format; > > format = shmob_drm_format_info(fb->format->format); > @@ -167,8 +167,8 @@ shmob_drm_plane_update(struct drm_plane *plane, struct drm_crtc *crtc, > static int shmob_drm_plane_disable(struct drm_plane *plane, > struct drm_modeset_acquire_ctx *ctx) > { > + struct shmob_drm_device *sdev = to_shmob_device(plane->dev); > struct shmob_drm_plane *splane = to_shmob_plane(plane); > - struct shmob_drm_device *sdev = plane->dev->dev_private; > > splane->format = NULL; > -- Regards, Laurent Pinchart
next prev parent reply other threads:[~2023-06-23 15:51 UTC|newest] Thread overview: 199+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-06-22 9:21 [PATCH 00/39] drm: renesas: shmobile: Atomic conversion + DT support Geert Uytterhoeven 2023-06-22 9:21 ` Geert Uytterhoeven 2023-06-22 9:21 ` [PATCH 01/39] dt-bindings: display: Add Renesas SH-Mobile LCDC bindings Geert Uytterhoeven 2023-06-22 9:21 ` Geert Uytterhoeven 2023-06-22 14:52 ` Rob Herring 2023-06-22 14:52 ` Rob Herring 2023-07-17 13:57 ` Geert Uytterhoeven 2023-07-17 13:57 ` Geert Uytterhoeven 2023-06-23 14:43 ` Laurent Pinchart 2023-06-23 14:43 ` Laurent Pinchart 2023-06-23 15:19 ` Geert Uytterhoeven 2023-06-23 15:19 ` Geert Uytterhoeven 2023-06-23 15:33 ` Laurent Pinchart 2023-06-23 15:33 ` Laurent Pinchart 2023-06-22 9:21 ` [PATCH 02/39] media: uapi: Add MEDIA_BUS_FMT_RGB666_2X9 variants Geert Uytterhoeven 2023-06-22 9:21 ` Geert Uytterhoeven 2023-06-23 14:56 ` Laurent Pinchart 2023-06-23 14:56 ` Laurent Pinchart 2023-06-22 9:21 ` [PATCH 03/39] drm: renesas: shmobile: Fix overlay plane disable Geert Uytterhoeven 2023-06-22 9:21 ` Geert Uytterhoeven 2023-06-23 14:59 ` Laurent Pinchart 2023-06-23 14:59 ` Laurent Pinchart 2023-06-22 9:21 ` [PATCH 04/39] drm: renesas: shmobile: Fix ARGB32 overlay format typo Geert Uytterhoeven 2023-06-22 9:21 ` Geert Uytterhoeven 2023-06-22 10:11 ` Sergei Shtylyov 2023-06-22 10:11 ` Sergei Shtylyov 2023-06-23 14:58 ` Laurent Pinchart 2023-06-23 14:58 ` Laurent Pinchart 2023-06-22 9:21 ` [PATCH 05/39] drm: renesas: shmobile: Correct encoder/connector types Geert Uytterhoeven 2023-06-22 9:21 ` Geert Uytterhoeven 2023-06-23 15:03 ` Laurent Pinchart 2023-06-23 15:03 ` Laurent Pinchart 2023-06-22 9:21 ` [PATCH 06/39] drm: renesas: shmobile: Add support for Runtime PM Geert Uytterhoeven 2023-06-22 9:21 ` Geert Uytterhoeven 2023-06-23 15:07 ` Laurent Pinchart 2023-06-23 15:07 ` Laurent Pinchart 2023-06-23 15:11 ` Laurent Pinchart 2023-06-23 15:11 ` Laurent Pinchart 2023-06-23 15:22 ` Geert Uytterhoeven 2023-06-23 15:22 ` Geert Uytterhoeven 2023-06-23 15:34 ` Laurent Pinchart 2023-06-23 15:34 ` Laurent Pinchart 2023-06-23 17:41 ` Geert Uytterhoeven 2023-06-23 17:41 ` Geert Uytterhoeven 2023-06-23 17:52 ` Laurent Pinchart 2023-06-23 17:52 ` Laurent Pinchart 2023-06-22 9:21 ` [PATCH 07/39] drm: renesas: shmobile: Restore indentation of shmob_drm_setup_clocks() Geert Uytterhoeven 2023-06-22 9:21 ` Geert Uytterhoeven 2023-06-23 15:04 ` Laurent Pinchart 2023-06-23 15:04 ` Laurent Pinchart 2023-06-22 9:21 ` [PATCH 08/39] drm: renesas: shmobile: Use %p4cc to print fourcc code Geert Uytterhoeven 2023-06-22 9:21 ` Geert Uytterhoeven 2023-06-23 15:04 ` Laurent Pinchart 2023-06-23 15:04 ` Laurent Pinchart 2023-06-22 9:21 ` [PATCH 09/39] drm: renesas: shmobile: Add missing YCbCr formats Geert Uytterhoeven 2023-06-22 9:21 ` Geert Uytterhoeven 2023-06-23 15:13 ` Laurent Pinchart 2023-06-23 15:13 ` Laurent Pinchart 2023-06-22 9:21 ` [PATCH 10/39] drm: renesas: shmobile: Improve shmob_drm_format_info table Geert Uytterhoeven 2023-06-22 9:21 ` Geert Uytterhoeven 2023-06-23 15:30 ` Laurent Pinchart 2023-06-23 15:30 ` Laurent Pinchart 2023-06-22 9:21 ` [PATCH 11/39] drm: renesas: shmobile: Remove backlight support Geert Uytterhoeven 2023-06-22 9:21 ` Geert Uytterhoeven 2023-06-23 15:36 ` Laurent Pinchart 2023-06-23 15:36 ` Laurent Pinchart 2023-06-22 9:21 ` [PATCH 12/39] drm: renesas: shmobile: Don't set display info width and height twice Geert Uytterhoeven 2023-06-22 9:21 ` Geert Uytterhoeven 2023-06-28 1:46 ` [12/39] " Sui Jingfeng 2023-06-22 9:21 ` [PATCH 13/39] drm: renesas: shmobile: Rename input clocks Geert Uytterhoeven 2023-06-22 9:21 ` Geert Uytterhoeven 2023-06-28 1:50 ` [13/39] " Sui Jingfeng 2023-06-22 9:21 ` [PATCH 14/39] drm: renesas: shmobile: Remove support for SYS panels Geert Uytterhoeven 2023-06-22 9:21 ` Geert Uytterhoeven 2023-06-22 9:21 ` [PATCH 15/39] drm: renesas: shmobile: Improve error handling Geert Uytterhoeven 2023-06-22 9:21 ` Geert Uytterhoeven 2023-06-23 15:41 ` Laurent Pinchart 2023-06-23 15:41 ` Laurent Pinchart 2023-06-22 9:21 ` [PATCH 16/39] drm: renesas: shmobile: Convert to use devm_request_irq() Geert Uytterhoeven 2023-06-22 9:21 ` Geert Uytterhoeven 2023-06-23 15:41 ` Laurent Pinchart 2023-06-23 15:41 ` Laurent Pinchart 2023-06-22 9:21 ` [PATCH 17/39] drm: renesas: shmobile: Use drmm_universal_plane_alloc() Geert Uytterhoeven 2023-06-22 9:21 ` Geert Uytterhoeven 2023-06-23 15:46 ` Laurent Pinchart 2023-06-23 15:46 ` Laurent Pinchart 2023-06-22 9:21 ` [PATCH 18/39] drm: renesas: shmobile: Embed drm_device in shmob_drm_device Geert Uytterhoeven 2023-06-22 9:21 ` Geert Uytterhoeven 2023-06-23 15:48 ` Laurent Pinchart 2023-06-23 15:48 ` Laurent Pinchart 2023-06-22 9:21 ` [PATCH 19/39] drm: renesas: shmobile: Convert container helpers to static inline functions Geert Uytterhoeven 2023-06-22 9:21 ` Geert Uytterhoeven 2023-06-23 15:49 ` Laurent Pinchart 2023-06-23 15:49 ` Laurent Pinchart 2023-06-22 9:21 ` [PATCH 20/39] drm: renesas: shmobile: Replace .dev_private with container_of() Geert Uytterhoeven 2023-06-22 9:21 ` Geert Uytterhoeven 2023-06-23 15:50 ` Laurent Pinchart [this message] 2023-06-23 15:50 ` Laurent Pinchart 2023-06-24 9:49 ` [20/39] " Sui Jingfeng 2023-06-22 9:21 ` [PATCH 21/39] drm: renesas: shmobile: Use struct videomode in platform data Geert Uytterhoeven 2023-06-22 9:21 ` Geert Uytterhoeven 2023-06-23 15:53 ` Laurent Pinchart 2023-06-23 15:53 ` Laurent Pinchart 2023-06-22 9:21 ` [PATCH 22/39] drm: renesas: shmobile: Use media bus formats " Geert Uytterhoeven 2023-06-22 9:21 ` Geert Uytterhoeven 2023-06-23 15:54 ` Laurent Pinchart 2023-06-23 15:54 ` Laurent Pinchart 2023-06-22 9:21 ` [PATCH 23/39] drm: renesas: shmobile: Move interface handling to connector setup Geert Uytterhoeven 2023-06-22 9:21 ` Geert Uytterhoeven 2023-06-23 16:39 ` Laurent Pinchart 2023-06-23 16:39 ` Laurent Pinchart 2023-06-23 17:51 ` Geert Uytterhoeven 2023-06-23 17:51 ` Geert Uytterhoeven 2023-06-23 17:53 ` Laurent Pinchart 2023-06-23 17:53 ` Laurent Pinchart 2023-06-22 9:21 ` [PATCH 24/39] drm: renesas: shmobile: Unify plane allocation Geert Uytterhoeven 2023-06-22 9:21 ` Geert Uytterhoeven 2023-06-23 16:50 ` Laurent Pinchart 2023-06-23 16:50 ` Laurent Pinchart 2023-06-23 17:55 ` Geert Uytterhoeven 2023-06-23 17:55 ` Geert Uytterhoeven 2023-06-23 18:50 ` Laurent Pinchart 2023-06-23 18:50 ` Laurent Pinchart 2023-06-25 8:58 ` Geert Uytterhoeven 2023-06-25 8:58 ` Geert Uytterhoeven 2023-06-25 16:56 ` Laurent Pinchart 2023-06-25 16:56 ` Laurent Pinchart 2023-06-22 9:21 ` [PATCH 25/39] drm: renesas: shmobile: Rename shmob_drm_crtc.crtc Geert Uytterhoeven 2023-06-22 9:21 ` Geert Uytterhoeven 2023-06-23 16:51 ` Laurent Pinchart 2023-06-23 16:51 ` Laurent Pinchart 2023-06-27 14:38 ` [25/39] " Sui Jingfeng 2023-06-22 9:21 ` [PATCH 26/39] drm: renesas: shmobile: Rename shmob_drm_connector.connector Geert Uytterhoeven 2023-06-22 9:21 ` Geert Uytterhoeven 2023-06-23 16:51 ` Laurent Pinchart 2023-06-23 16:51 ` Laurent Pinchart 2023-06-27 14:40 ` [26/39] " Sui Jingfeng 2023-06-22 9:21 ` [PATCH 27/39] drm: renesas: shmobile: Rename shmob_drm_plane.plane Geert Uytterhoeven 2023-06-22 9:21 ` Geert Uytterhoeven 2023-06-23 16:52 ` Laurent Pinchart 2023-06-23 16:52 ` Laurent Pinchart 2023-06-27 14:40 ` [27/39] " Sui Jingfeng 2023-06-22 9:21 ` [PATCH 28/39] drm: renesas: shmobile: Use drm_crtc_handle_vblank() Geert Uytterhoeven 2023-06-22 9:21 ` Geert Uytterhoeven 2023-06-23 16:53 ` Laurent Pinchart 2023-06-23 16:53 ` Laurent Pinchart 2023-06-24 9:33 ` [28/39] " Sui Jingfeng 2023-06-25 8:55 ` Geert Uytterhoeven 2023-06-25 8:55 ` Geert Uytterhoeven 2023-06-22 9:21 ` [PATCH 29/39] drm: renesas: shmobile: Move shmob_drm_crtc_finish_page_flip() Geert Uytterhoeven 2023-06-22 9:21 ` Geert Uytterhoeven 2023-06-23 16:53 ` Laurent Pinchart 2023-06-23 16:53 ` Laurent Pinchart 2023-06-22 9:21 ` [PATCH 30/39] drm: renesas: shmobile: Wait for page flip when turning CRTC off Geert Uytterhoeven 2023-06-22 9:21 ` Geert Uytterhoeven 2023-06-23 17:08 ` Laurent Pinchart 2023-06-23 17:08 ` Laurent Pinchart 2023-06-22 9:21 ` [PATCH 31/39] drm: renesas: shmobile: Turn vblank on/off when enabling/disabling CRTC Geert Uytterhoeven 2023-06-22 9:21 ` Geert Uytterhoeven 2023-06-23 17:09 ` Laurent Pinchart 2023-06-23 17:09 ` Laurent Pinchart 2023-06-22 9:21 ` [PATCH 32/39] drm: renesas: shmobile: Shutdown the display on remove Geert Uytterhoeven 2023-06-22 9:21 ` Geert Uytterhoeven 2023-06-23 17:10 ` Laurent Pinchart 2023-06-23 17:10 ` Laurent Pinchart 2023-06-27 14:57 ` [32/39] " Sui Jingfeng 2023-07-05 10:29 ` Geert Uytterhoeven 2023-07-05 10:29 ` Geert Uytterhoeven 2023-07-06 3:51 ` suijingfeng 2023-06-22 9:21 ` [PATCH 33/39] drm: renesas: shmobile: Cleanup encoder Geert Uytterhoeven 2023-06-22 9:21 ` Geert Uytterhoeven 2023-06-23 17:12 ` Laurent Pinchart 2023-06-23 17:12 ` Laurent Pinchart 2023-06-22 9:21 ` [PATCH 34/39] drm: renesas: shmobile: Atomic conversion part 1 Geert Uytterhoeven 2023-06-22 9:21 ` Geert Uytterhoeven 2023-06-22 9:21 ` [PATCH 35/39] drm: renesas: shmobile: Atomic conversion part 2 Geert Uytterhoeven 2023-06-22 9:21 ` Geert Uytterhoeven 2023-06-22 9:21 ` [PATCH 36/39] drm: renesas: shmobile: Use suspend/resume helpers Geert Uytterhoeven 2023-06-22 9:21 ` Geert Uytterhoeven 2023-06-23 17:14 ` Laurent Pinchart 2023-06-23 17:14 ` Laurent Pinchart 2023-06-22 9:21 ` [PATCH 37/39] drm: renesas: shmobile: Remove internal CRTC state tracking Geert Uytterhoeven 2023-06-22 9:21 ` Geert Uytterhoeven 2023-06-23 17:15 ` Laurent Pinchart 2023-06-23 17:15 ` Laurent Pinchart 2023-06-22 9:21 ` [PATCH 38/39] drm: renesas: shmobile: Atomic conversion part 3 Geert Uytterhoeven 2023-06-22 9:21 ` Geert Uytterhoeven 2023-06-23 17:18 ` Laurent Pinchart 2023-06-23 17:18 ` Laurent Pinchart 2023-06-22 9:21 ` [PATCH 39/39] drm: renesas: shmobile: Add DT support Geert Uytterhoeven 2023-06-22 9:21 ` Geert Uytterhoeven 2023-06-23 17:50 ` Laurent Pinchart 2023-06-23 17:50 ` Laurent Pinchart 2023-06-23 17:54 ` Sam Ravnborg 2023-06-23 17:54 ` Sam Ravnborg 2023-06-23 18:09 ` Geert Uytterhoeven 2023-06-23 18:09 ` Geert Uytterhoeven 2023-06-23 18:52 ` Laurent Pinchart 2023-06-23 18:52 ` Laurent Pinchart
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230623155052.GX2112@pendragon.ideasonboard.com \ --to=laurent.pinchart@ideasonboard.com \ --cc=airlied@gmail.com \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=geert+renesas@glider.be \ --cc=kieran.bingham+renesas@ideasonboard.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=magnus.damm@gmail.com \ --cc=tzimmermann@suse.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.