All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Layton <jlayton@kernel.org>
To: Alexander Viro <viro@zeniv.linux.org.uk>,
	Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>
Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org, Jeff Layton <jlayton@kernel.org>,
	kernel test robot <oliver.sang@intel.com>
Subject: [PATCH 1/2] fs: initialize inode->__i_ctime to the epoch
Date: Thu, 07 Sep 2023 12:33:47 -0400	[thread overview]
Message-ID: <20230907-ctime-fixes-v1-1-3b74c970d934@kernel.org> (raw)
In-Reply-To: <20230907-ctime-fixes-v1-0-3b74c970d934@kernel.org>

With the advent of multigrain timestamps, we use inode_set_ctime_current
to set the ctime, which can skip updating if the existing ctime appears
to be in the future. Because we don't initialize this field at
allocation time, that could prevent the ctime from being initialized
properly when the inode is instantiated.

Always initialize the ctime field to the epoch so that the filesystem
can set the timestamps properly later.

Reported-by: kernel test robot <oliver.sang@intel.com>
Closes: https://lore.kernel.org/oe-lkp/202309071017.a64aca5e-oliver.sang@intel.com
Signed-off-by: Jeff Layton <jlayton@kernel.org>
---
 fs/inode.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/fs/inode.c b/fs/inode.c
index 35fd688168c5..54237f4242ff 100644
--- a/fs/inode.c
+++ b/fs/inode.c
@@ -168,6 +168,8 @@ int inode_init_always(struct super_block *sb, struct inode *inode)
 	inode->i_fop = &no_open_fops;
 	inode->i_ino = 0;
 	inode->__i_nlink = 1;
+	inode->__i_ctime.tv_sec = 0;
+	inode->__i_ctime.tv_nsec = 0;
 	inode->i_opflags = 0;
 	if (sb->s_xattr)
 		inode->i_opflags |= IOP_XATTR;

-- 
2.41.0


  reply	other threads:[~2023-09-07 16:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-07 16:33 [PATCH 0/2] fs: fixes for multigrain ctime code Jeff Layton
2023-09-07 16:33 ` Jeff Layton [this message]
2023-09-08 10:42   ` [PATCH 1/2] fs: initialize inode->__i_ctime to the epoch Jan Kara
2023-09-08 11:41     ` Jeff Layton
2023-09-08 12:10       ` Jan Kara
2023-09-07 16:33 ` [PATCH 2/2] fs: don't update the atime if existing atime is newer than "now" Jeff Layton
2023-09-08 12:11   ` Jan Kara
2023-09-08 12:10 ` [PATCH 0/2] fs: fixes for multigrain ctime code Christian Brauner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230907-ctime-fixes-v1-1-3b74c970d934@kernel.org \
    --to=jlayton@kernel.org \
    --cc=brauner@kernel.org \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=oliver.sang@intel.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.