From: Mateusz Majewski <m.majewski2@samsung.com> To: linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Mateusz Majewski <m.majewski2@samsung.com>, Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, "Rafael J. Wysocki" <rafael@kernel.org>, Daniel Lezcano <daniel.lezcano@linaro.org>, Amit Kucheria <amitk@kernel.org>, Zhang Rui <rui.zhang@intel.com>, Alim Akhtar <alim.akhtar@samsung.com>, Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Marek Szyprowski <m.szyprowski@samsung.com> Subject: [PATCH v2 2/7] thermal: exynos: drop id field Date: Mon, 11 Sep 2023 15:34:26 +0200 [thread overview] Message-ID: <20230911133435.14061-3-m.majewski2@samsung.com> (raw) In-Reply-To: <20230911133435.14061-1-m.majewski2@samsung.com> We do not use the value, and only Exynos 7 defines this alias anyway. Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Signed-off-by: Mateusz Majewski <m.majewski2@samsung.com> --- v1 -> v2: minor commit message rewording. drivers/thermal/samsung/exynos_tmu.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c index 2c1cfb8c4b33..90c33e8017af 100644 --- a/drivers/thermal/samsung/exynos_tmu.c +++ b/drivers/thermal/samsung/exynos_tmu.c @@ -138,7 +138,6 @@ enum soc_type { /** * struct exynos_tmu_data : A structure to hold the private data of the TMU * driver - * @id: identifier of the one instance of the TMU controller. * @base: base address of the single instance of the TMU controller. * @base_second: base address of the common registers of the TMU controller. * @irq: irq number of the TMU controller. @@ -172,7 +171,6 @@ enum soc_type { * @tmu_clear_irqs: SoC specific TMU interrupts clearing method */ struct exynos_tmu_data { - int id; void __iomem *base; void __iomem *base_second; int irq; @@ -865,10 +863,6 @@ static int exynos_map_dt_data(struct platform_device *pdev) if (!data || !pdev->dev.of_node) return -ENODEV; - data->id = of_alias_get_id(pdev->dev.of_node, "tmuctrl"); - if (data->id < 0) - data->id = 0; - data->irq = irq_of_parse_and_map(pdev->dev.of_node, 0); if (data->irq <= 0) { dev_err(&pdev->dev, "failed to get IRQ\n"); -- 2.41.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Mateusz Majewski <m.majewski2@samsung.com> To: linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Mateusz Majewski <m.majewski2@samsung.com>, Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, "Rafael J. Wysocki" <rafael@kernel.org>, Daniel Lezcano <daniel.lezcano@linaro.org>, Amit Kucheria <amitk@kernel.org>, Zhang Rui <rui.zhang@intel.com>, Alim Akhtar <alim.akhtar@samsung.com>, Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Marek Szyprowski <m.szyprowski@samsung.com> Subject: [PATCH v2 2/7] thermal: exynos: drop id field Date: Mon, 11 Sep 2023 15:34:26 +0200 [thread overview] Message-ID: <20230911133435.14061-3-m.majewski2@samsung.com> (raw) In-Reply-To: <20230911133435.14061-1-m.majewski2@samsung.com> We do not use the value, and only Exynos 7 defines this alias anyway. Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Signed-off-by: Mateusz Majewski <m.majewski2@samsung.com> --- v1 -> v2: minor commit message rewording. drivers/thermal/samsung/exynos_tmu.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c index 2c1cfb8c4b33..90c33e8017af 100644 --- a/drivers/thermal/samsung/exynos_tmu.c +++ b/drivers/thermal/samsung/exynos_tmu.c @@ -138,7 +138,6 @@ enum soc_type { /** * struct exynos_tmu_data : A structure to hold the private data of the TMU * driver - * @id: identifier of the one instance of the TMU controller. * @base: base address of the single instance of the TMU controller. * @base_second: base address of the common registers of the TMU controller. * @irq: irq number of the TMU controller. @@ -172,7 +171,6 @@ enum soc_type { * @tmu_clear_irqs: SoC specific TMU interrupts clearing method */ struct exynos_tmu_data { - int id; void __iomem *base; void __iomem *base_second; int irq; @@ -865,10 +863,6 @@ static int exynos_map_dt_data(struct platform_device *pdev) if (!data || !pdev->dev.of_node) return -ENODEV; - data->id = of_alias_get_id(pdev->dev.of_node, "tmuctrl"); - if (data->id < 0) - data->id = 0; - data->irq = irq_of_parse_and_map(pdev->dev.of_node, 0); if (data->irq <= 0) { dev_err(&pdev->dev, "failed to get IRQ\n"); -- 2.41.0
next prev parent reply other threads:[~2023-09-11 13:36 UTC|newest] Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <CGME20230911133607eucas1p2c9a5b6c3bd785a5d03d78a1db872b188@eucas1p2.samsung.com> 2023-09-11 13:34 ` [PATCH v2 0/7] Improve Exynos thermal driver Mateusz Majewski 2023-09-11 13:34 ` Mateusz Majewski [not found] ` <CGME20230911133611eucas1p286e43809a6ca785911c0bbdce15dc15d@eucas1p2.samsung.com> 2023-09-11 13:34 ` [PATCH v2 1/7] thermal: exynos: remove an unnecessary field description Mateusz Majewski 2023-09-11 13:34 ` Mateusz Majewski 2023-09-13 8:00 ` Krzysztof Kozlowski 2023-09-13 8:00 ` Krzysztof Kozlowski [not found] ` <CGME20230911133613eucas1p1671b7d154e1d567b02516d8c4d8074ab@eucas1p1.samsung.com> 2023-09-11 13:34 ` Mateusz Majewski [this message] 2023-09-11 13:34 ` [PATCH v2 2/7] thermal: exynos: drop id field Mateusz Majewski [not found] ` <CGME20230911133615eucas1p123b3bed5bfa998bda65196d425f9b49d@eucas1p1.samsung.com> 2023-09-11 13:34 ` [PATCH v2 3/7] thermal: exynos: switch from workqueue-driven interrupt handling to threaded interrupts Mateusz Majewski 2023-09-11 13:34 ` Mateusz Majewski 2023-09-13 8:03 ` Krzysztof Kozlowski 2023-09-13 8:03 ` Krzysztof Kozlowski [not found] ` <CGME20230911133616eucas1p10c5eeb0f0240dde975ccc5935cb5c311@eucas1p1.samsung.com> 2023-09-11 13:34 ` [PATCH v2 4/7] thermal: exynos: simplify regulator (de)initialization Mateusz Majewski 2023-09-11 13:34 ` Mateusz Majewski 2023-09-13 8:11 ` Krzysztof Kozlowski 2023-09-13 8:11 ` Krzysztof Kozlowski [not found] ` <CGME20230911133616eucas1p10c5eeb0f0240dde975ccc5935cb5c311@eucms1p2> 2023-09-26 11:02 ` Mateusz Majewski 2023-09-26 11:02 ` Mateusz Majewski 2023-09-29 10:46 ` Daniel Lezcano 2023-09-29 10:46 ` Daniel Lezcano 2023-09-29 11:03 ` Marek Szyprowski 2023-09-29 11:03 ` Marek Szyprowski 2023-09-29 11:45 ` Daniel Lezcano 2023-09-29 11:45 ` Daniel Lezcano 2023-09-29 12:00 ` Marek Szyprowski 2023-09-29 12:00 ` Marek Szyprowski 2023-10-03 9:06 ` Krzysztof Kozlowski 2023-10-03 9:06 ` Krzysztof Kozlowski [not found] ` <CGME20230911133618eucas1p2d40b075ee6baebbec9f991eb01f21d89@eucas1p2.samsung.com> 2023-09-11 13:34 ` [PATCH v2 5/7] thermal: exynos: stop using the threshold mechanism on Exynos 4210 Mateusz Majewski 2023-09-11 13:34 ` Mateusz Majewski [not found] ` <CGME20230911133620eucas1p27a0d0f480638c97fa59bf9c4f34a02cb@eucas1p2.samsung.com> 2023-09-11 13:34 ` [PATCH v2 6/7] thermal: exynos: split initialization of TMU and the thermal zone Mateusz Majewski 2023-09-11 13:34 ` Mateusz Majewski [not found] ` <CGME20230911133622eucas1p2d27118647d37fa2fe2973773f70359c4@eucas1p2.samsung.com> 2023-09-11 13:34 ` [PATCH v2 7/7] thermal: exynos: use set_trips Mateusz Majewski 2023-09-11 13:34 ` Mateusz Majewski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230911133435.14061-3-m.majewski2@samsung.com \ --to=m.majewski2@samsung.com \ --cc=alim.akhtar@samsung.com \ --cc=amitk@kernel.org \ --cc=broonie@kernel.org \ --cc=bzolnier@gmail.com \ --cc=daniel.lezcano@linaro.org \ --cc=krzysztof.kozlowski@linaro.org \ --cc=lgirdwood@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=m.szyprowski@samsung.com \ --cc=rafael@kernel.org \ --cc=rui.zhang@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.