All of lore.kernel.org
 help / color / mirror / Atom feed
From: Li Zhijian <lizhijian@fujitsu.com>
To: quintela@redhat.com, peterx@redhat.com, leobras@redhat.com
Cc: qemu-devel@nongnu.org, Li Zhijian <lizhijian@cn.fujitsu.com>
Subject: [PATCH 2/2] migration/rdma: zore out head.repeat to make the error more clear
Date: Wed, 20 Sep 2023 17:04:12 +0800	[thread overview]
Message-ID: <20230920090412.726725-2-lizhijian@fujitsu.com> (raw)
In-Reply-To: <20230920090412.726725-1-lizhijian@fujitsu.com>

From: Li Zhijian <lizhijian@cn.fujitsu.com>

Previously, we got a confusion error that complains
the RDMAControlHeader.repeat:
qemu-system-x86_64: rdma: Too many requests in this message (3638950032).Bailing.

Actually, it's caused by an unexpected RDMAControlHeader.type.
After this patch, error will become:
qemu-system-x86_64: Unknown control message QEMU FILE

Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
---
 migration/rdma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/migration/rdma.c b/migration/rdma.c
index a2a3db35b1..3073d9953c 100644
--- a/migration/rdma.c
+++ b/migration/rdma.c
@@ -2812,7 +2812,7 @@ static ssize_t qio_channel_rdma_writev(QIOChannel *ioc,
         size_t remaining = iov[i].iov_len;
         uint8_t * data = (void *)iov[i].iov_base;
         while (remaining) {
-            RDMAControlHeader head;
+            RDMAControlHeader head = {};
 
             len = MIN(remaining, RDMA_SEND_INCREMENT);
             remaining -= len;
-- 
2.31.1



  reply	other threads:[~2023-09-20  9:08 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-20  9:04 [PATCH 1/2] migration: Fix rdma migration failed Li Zhijian
2023-09-20  9:04 ` Li Zhijian [this message]
2023-09-20 13:01   ` [PATCH 2/2] migration/rdma: zore out head.repeat to make the error more clear Fabiano Rosas
2023-09-21  1:36     ` Zhijian Li (Fujitsu)
2023-09-21 12:29       ` Fabiano Rosas
2023-09-22 15:44   ` Peter Xu
2023-09-20 12:46 ` [PATCH 1/2] migration: Fix rdma migration failed Fabiano Rosas
2023-09-22  7:42   ` Zhijian Li (Fujitsu)
2023-09-21  1:40 ` Zhijian Li (Fujitsu)
2023-09-22 15:42 ` Peter Xu
2023-09-22 15:59   ` Fabiano Rosas
2023-09-22 16:09     ` Peter Xu
2023-09-25  8:59   ` Zhijian Li (Fujitsu)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230920090412.726725-2-lizhijian@fujitsu.com \
    --to=lizhijian@fujitsu.com \
    --cc=leobras@redhat.com \
    --cc=lizhijian@cn.fujitsu.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.