From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH] profile: Remove unnecessary ‘0’ values from err
Date: Thu, 12 Oct 2023 10:10:37 +0800 [thread overview]
Message-ID: <202310120931.henXte1M-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20230919014126.8168-1-zeming@nfschina.com>
References: <20230919014126.8168-1-zeming@nfschina.com>
TO: Li zeming <zeming@nfschina.com>
TO: linux-kernel@vger.kernel.org
CC: Li zeming <zeming@nfschina.com>
Hi Li,
kernel test robot noticed the following build warnings:
[auto build test WARNING on linus/master]
[also build test WARNING on v6.6-rc5 next-20231011]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Li-zeming/profile-Remove-unnecessary-0-values-from-err/20230919-094202
base: linus/master
patch link: https://lore.kernel.org/r/20230919014126.8168-1-zeming%40nfschina.com
patch subject: [PATCH] profile: Remove unnecessary ‘0’ values from err
:::::: branch date: 3 weeks ago
:::::: commit date: 3 weeks ago
config: i386-randconfig-141-20230921 (https://download.01.org/0day-ci/archive/20231012/202310120931.henXte1M-lkp@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce: (https://download.01.org/0day-ci/archive/20231012/202310120931.henXte1M-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202310120931.henXte1M-lkp@intel.com/
smatch warnings:
kernel/profile.c:491 create_proc_profile() error: uninitialized symbol 'err'.
vim +/err +491 kernel/profile.c
^1da177e4c3f41 Linus Torvalds 2005-04-16 467
1997ab2b2a8d46 Li zeming 2023-09-19 468 int err;
^1da177e4c3f41 Linus Torvalds 2005-04-16 469
^1da177e4c3f41 Linus Torvalds 2005-04-16 470 if (!prof_on)
^1da177e4c3f41 Linus Torvalds 2005-04-16 471 return 0;
e722d8daafb974 Sebastian Andrzej Siewior 2016-07-13 472 #ifdef CONFIG_SMP
e722d8daafb974 Sebastian Andrzej Siewior 2016-07-13 473 err = cpuhp_setup_state(CPUHP_PROFILE_PREPARE, "PROFILE_PREPARE",
e722d8daafb974 Sebastian Andrzej Siewior 2016-07-13 474 profile_prepare_cpu, profile_dead_cpu);
e722d8daafb974 Sebastian Andrzej Siewior 2016-07-13 475 if (err)
e722d8daafb974 Sebastian Andrzej Siewior 2016-07-13 476 return err;
c270a817196a93 Srivatsa S. Bhat 2014-03-11 477
e722d8daafb974 Sebastian Andrzej Siewior 2016-07-13 478 err = cpuhp_setup_state(CPUHP_AP_ONLINE_DYN, "AP_PROFILE_ONLINE",
e722d8daafb974 Sebastian Andrzej Siewior 2016-07-13 479 profile_online_cpu, NULL);
e722d8daafb974 Sebastian Andrzej Siewior 2016-07-13 480 if (err < 0)
e722d8daafb974 Sebastian Andrzej Siewior 2016-07-13 481 goto err_state_prep;
e722d8daafb974 Sebastian Andrzej Siewior 2016-07-13 482 online_state = err;
e722d8daafb974 Sebastian Andrzej Siewior 2016-07-13 483 err = 0;
e722d8daafb974 Sebastian Andrzej Siewior 2016-07-13 484 #endif
c33fff0afbef4f Denis V. Lunev 2008-04-29 485 entry = proc_create("profile", S_IWUSR | S_IRUGO,
97a32539b9568b Alexey Dobriyan 2020-02-03 486 NULL, &profile_proc_ops);
1ad82fd547c716 Paolo Ciarrocchi 2008-01-25 487 if (!entry)
e722d8daafb974 Sebastian Andrzej Siewior 2016-07-13 488 goto err_state_onl;
271a15eabe0945 David Howells 2013-04-12 489 proc_set_size(entry, (1 + prof_len) * sizeof(atomic_t));
c270a817196a93 Srivatsa S. Bhat 2014-03-11 490
e722d8daafb974 Sebastian Andrzej Siewior 2016-07-13 @491 return err;
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2023-10-12 2:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-12 2:10 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-10-13 2:20 [PATCH] profile: Remove unnecessary ‘0’ values from err kernel test robot
2023-09-19 1:41 Li zeming
2023-10-12 6:27 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202310120931.henXte1M-lkp@intel.com \
--to=lkp@intel.com \
--cc=error27@gmail.com \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.