From: Amir Goldstein <amir73il@gmail.com>
To: Jan Kara <jack@suse.cz>
Cc: Christian Brauner <brauner@kernel.org>, Chris Mason <clm@fb.com>,
Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>,
linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: [PATCH v2 0/3] fanotify support for btrfs sub-volumes
Date: Thu, 26 Oct 2023 18:52:21 +0300 [thread overview]
Message-ID: <20231026155224.129326-1-amir73il@gmail.com> (raw)
Jan,
As agreed on the review of v1 [1], we do not need any vfs changes
to support fanotify on btrfs sub-volumes and we can enable setting
marks on btrfs sub-volumes simply by caching the fsid in the mark
object instead of the connector.
This is the would be man page update to clarify the meaning of fsid
as it is reflected in this patch set:
fsid
This is a unique identifier of the filesystem containing the object
associated with the event. It is a structure of type __kernel_fsid_t
and contains the same value reported in f_fsid when calling
statfs(2) with the same pathname argument that was used for
fanotify_mark(2). Note that some filesystems (e.g., btrfs(5)) report
non-uniform values of f_fsid on different objects of the same filesystem.
In these cases, if fanotify_mark(2) is called several times with different
pathname values, the fsid value reported in events will match f_fsid
associated with at least one of those pathname values.
Thanks,
Amir.
[1] https://lore.kernel.org/r/CAOQ4uxg9wjESoCFNDADbneF0-nW4xVHHV3Rhhp=gJwAs=S83dQ@mail.gmail.com/
Amir Goldstein (3):
fanotify: store fsid in mark instead of in connector
fanotify: report the most specific fsid for btrfs
fanotify: support setting marks in btrfs sub-volumes
fs/notify/fanotify/fanotify.c | 21 ++++--------
fs/notify/fanotify/fanotify.h | 10 ++++++
fs/notify/fanotify/fanotify_user.c | 31 ++++++++----------
fs/notify/mark.c | 52 +++++-------------------------
include/linux/fsnotify_backend.h | 18 +++++------
5 files changed, 47 insertions(+), 85 deletions(-)
--
2.34.1
next reply other threads:[~2023-10-26 15:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-26 15:52 Amir Goldstein [this message]
2023-10-26 15:52 ` [PATCH v2 1/3] fanotify: store fsid in mark instead of in connector Amir Goldstein
2023-10-26 15:52 ` [PATCH v2 2/3] fanotify: report the most specific fsid for btrfs Amir Goldstein
2023-10-26 15:52 ` [PATCH v2 3/3] fanotify: support setting marks in btrfs sub-volumes Amir Goldstein
2023-10-26 16:09 ` [PATCH v2 0/3] fanotify support for " Jan Kara
2023-10-27 5:46 ` Christoph Hellwig
2023-10-27 6:03 ` Amir Goldstein
2023-10-27 6:08 ` Christoph Hellwig
2023-10-27 6:33 ` Amir Goldstein
2023-10-27 7:30 ` Christoph Hellwig
2023-10-27 15:47 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231026155224.129326-1-amir73il@gmail.com \
--to=amir73il@gmail.com \
--cc=brauner@kernel.org \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=jack@suse.cz \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.