All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Yan <andyshrk@163.com>
To: heiko@sntech.de
Cc: hjc@rock-chips.com, dri-devel@lists.freedesktop.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org,
	devicetree@vger.kernel.org, sebastian.reichel@collabora.com,
	kever.yang@rock-chips.com, chris.obbard@collabora.com,
	s.hauer@pengutronix.de, Andy Yan <andy.yan@rock-chips.com>
Subject: [PATCH 04/11] drm/rockchip: vop2: clear afbc en and transform bit for cluster window at linear mode
Date: Tue, 14 Nov 2023 19:27:42 +0800	[thread overview]
Message-ID: <20231114112742.1771060-1-andyshrk@163.com> (raw)
In-Reply-To: <20231114112534.1770731-1-andyshrk@163.com>

From: Andy Yan <andy.yan@rock-chips.com>

The enable bit and transform offset of cluster windows should be
cleared when it work at linear mode, or we may have a iommu fault
issue.

Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
---

 drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
index 0f7b68c5fdf2..02b76a85f22f 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
@@ -1307,6 +1307,11 @@ static void vop2_plane_atomic_update(struct drm_plane *plane,
 		vop2_win_write(win, VOP2_WIN_AFBC_ROTATE_270, rotate_270);
 		vop2_win_write(win, VOP2_WIN_AFBC_ROTATE_90, rotate_90);
 	} else {
+		if (vop2_cluster_window(win)) {
+			vop2_win_write(win, VOP2_WIN_AFBC_ENABLE, 0);
+			vop2_win_write(win, VOP2_WIN_AFBC_TRANSFORM_OFFSET, 0);
+		}
+
 		vop2_win_write(win, VOP2_WIN_YRGB_VIR, DIV_ROUND_UP(fb->pitches[0], 4));
 	}
 
-- 
2.34.1


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

WARNING: multiple messages have this Message-ID (diff)
From: Andy Yan <andyshrk@163.com>
To: heiko@sntech.de
Cc: devicetree@vger.kernel.org, s.hauer@pengutronix.de,
	chris.obbard@collabora.com, hjc@rock-chips.com,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	kever.yang@rock-chips.com, linux-rockchip@lists.infradead.org,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	Andy Yan <andy.yan@rock-chips.com>,
	sebastian.reichel@collabora.com
Subject: [PATCH 04/11] drm/rockchip: vop2: clear afbc en and transform bit for cluster window at linear mode
Date: Tue, 14 Nov 2023 19:27:42 +0800	[thread overview]
Message-ID: <20231114112742.1771060-1-andyshrk@163.com> (raw)
In-Reply-To: <20231114112534.1770731-1-andyshrk@163.com>

From: Andy Yan <andy.yan@rock-chips.com>

The enable bit and transform offset of cluster windows should be
cleared when it work at linear mode, or we may have a iommu fault
issue.

Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
---

 drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
index 0f7b68c5fdf2..02b76a85f22f 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
@@ -1307,6 +1307,11 @@ static void vop2_plane_atomic_update(struct drm_plane *plane,
 		vop2_win_write(win, VOP2_WIN_AFBC_ROTATE_270, rotate_270);
 		vop2_win_write(win, VOP2_WIN_AFBC_ROTATE_90, rotate_90);
 	} else {
+		if (vop2_cluster_window(win)) {
+			vop2_win_write(win, VOP2_WIN_AFBC_ENABLE, 0);
+			vop2_win_write(win, VOP2_WIN_AFBC_TRANSFORM_OFFSET, 0);
+		}
+
 		vop2_win_write(win, VOP2_WIN_YRGB_VIR, DIV_ROUND_UP(fb->pitches[0], 4));
 	}
 
-- 
2.34.1


WARNING: multiple messages have this Message-ID (diff)
From: Andy Yan <andyshrk@163.com>
To: heiko@sntech.de
Cc: hjc@rock-chips.com, dri-devel@lists.freedesktop.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org,
	devicetree@vger.kernel.org, sebastian.reichel@collabora.com,
	kever.yang@rock-chips.com, chris.obbard@collabora.com,
	s.hauer@pengutronix.de, Andy Yan <andy.yan@rock-chips.com>
Subject: [PATCH 04/11] drm/rockchip: vop2: clear afbc en and transform bit for cluster window at linear mode
Date: Tue, 14 Nov 2023 19:27:42 +0800	[thread overview]
Message-ID: <20231114112742.1771060-1-andyshrk@163.com> (raw)
In-Reply-To: <20231114112534.1770731-1-andyshrk@163.com>

From: Andy Yan <andy.yan@rock-chips.com>

The enable bit and transform offset of cluster windows should be
cleared when it work at linear mode, or we may have a iommu fault
issue.

Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
---

 drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
index 0f7b68c5fdf2..02b76a85f22f 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
@@ -1307,6 +1307,11 @@ static void vop2_plane_atomic_update(struct drm_plane *plane,
 		vop2_win_write(win, VOP2_WIN_AFBC_ROTATE_270, rotate_270);
 		vop2_win_write(win, VOP2_WIN_AFBC_ROTATE_90, rotate_90);
 	} else {
+		if (vop2_cluster_window(win)) {
+			vop2_win_write(win, VOP2_WIN_AFBC_ENABLE, 0);
+			vop2_win_write(win, VOP2_WIN_AFBC_TRANSFORM_OFFSET, 0);
+		}
+
 		vop2_win_write(win, VOP2_WIN_YRGB_VIR, DIV_ROUND_UP(fb->pitches[0], 4));
 	}
 
-- 
2.34.1


  parent reply	other threads:[~2023-11-14 11:28 UTC|newest]

Thread overview: 90+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-14 11:25 [PATCH 00/11] Add VOP2 support on rk3588 Andy Yan
2023-11-14 11:25 ` Andy Yan
2023-11-14 11:25 ` Andy Yan
2023-11-14 11:27 ` [PATCH 01/11] drm/rockchip: move output interface related definition to rockchip_drm_drv.h Andy Yan
2023-11-14 11:27   ` Andy Yan
2023-11-14 11:27   ` Andy Yan
2023-11-14 11:27 ` [PATCH 02/11] Revert "drm/rockchip: vop2: Use regcache_sync() to fix suspend/resume" Andy Yan
2023-11-14 11:27   ` Andy Yan
2023-11-14 11:27   ` Andy Yan
2023-11-14 11:27 ` [PATCH 03/11] drm/rockchip: vop2: set half_block_en bit in all mode Andy Yan
2023-11-14 11:27   ` Andy Yan
2023-11-14 11:27   ` Andy Yan
2023-11-14 11:27 ` Andy Yan [this message]
2023-11-14 11:27   ` [PATCH 04/11] drm/rockchip: vop2: clear afbc en and transform bit for cluster window at linear mode Andy Yan
2023-11-14 11:27   ` Andy Yan
2023-11-14 11:27 ` [PATCH 05/11] drm/rockchip: vop2: Set YUV/RGB overlay mode Andy Yan
2023-11-14 11:27   ` Andy Yan
2023-11-14 11:27   ` Andy Yan
2023-11-14 11:28 ` [PATCH 06/11] drm/rockchip: vop2: rename grf to sys_grf Andy Yan
2023-11-14 11:28   ` Andy Yan
2023-11-14 11:28   ` Andy Yan
2023-11-14 11:28 ` [PATCH 07/11] dt-bindings: soc: rockchip: add rk3588 vop/vo syscon Andy Yan
2023-11-14 11:28   ` Andy Yan
2023-11-14 11:28   ` Andy Yan
2023-11-16 19:26   ` Rob Herring
2023-11-16 19:26     ` Rob Herring
2023-11-16 19:26     ` Rob Herring
2023-11-14 11:28 ` [PATCH 08/11] dt-bindings: display: vop2: Add rk3588 support Andy Yan
2023-11-14 11:28   ` Andy Yan
2023-11-14 11:28   ` Andy Yan
2023-11-14 13:44   ` Rob Herring
2023-11-14 13:44     ` Rob Herring
2023-11-14 13:44     ` Rob Herring
2023-11-14 21:54   ` Heiko Stübner
2023-11-14 21:54     ` Heiko Stübner
2023-11-14 21:54     ` Heiko Stübner
2023-11-15  2:45     ` Andy Yan
2023-11-15  2:45       ` Andy Yan
2023-11-15  2:45       ` Andy Yan
2023-11-14 11:28 ` [PATCH 09/11] drm/rockchip: vop2: Add support for rk3588 Andy Yan
2023-11-14 11:28   ` Andy Yan
2023-11-14 11:28   ` Andy Yan
2023-11-14 23:34   ` Heiko Stübner
2023-11-14 23:34     ` Heiko Stübner
2023-11-14 23:34     ` Heiko Stübner
2023-11-15  2:02     ` Andy Yan
2023-11-15  2:02       ` Andy Yan
2023-11-15  2:02       ` Andy Yan
2023-11-15  8:24       ` Heiko Stübner
2023-11-15  8:24         ` Heiko Stübner
2023-11-15  8:24         ` Heiko Stübner
2023-11-15  9:08   ` Sascha Hauer
2023-11-15  9:08     ` Sascha Hauer
2023-11-15  9:08     ` Sascha Hauer
2023-11-16  7:24     ` Andy Yan
2023-11-16  7:24       ` Andy Yan
2023-11-16  7:24       ` Andy Yan
2023-11-16  7:50       ` Sascha Hauer
2023-11-16  7:50         ` Sascha Hauer
2023-11-16  7:50         ` Sascha Hauer
2023-11-16  8:00         ` Andy Yan
2023-11-16  8:00           ` Andy Yan
2023-11-16  8:00           ` Andy Yan
2023-11-16 10:39     ` Andy Yan
2023-11-16 10:39       ` Andy Yan
2023-11-16 10:39       ` Andy Yan
2023-11-16 13:47       ` Sebastian Reichel
2023-11-16 13:47         ` Sebastian Reichel
2023-11-16 13:47         ` Sebastian Reichel
2023-11-17  7:06         ` Andy Yan
2023-11-17  7:06           ` Andy Yan
2023-11-17  7:06           ` Andy Yan
2023-11-17  9:39           ` Sascha Hauer
2023-11-17  9:39             ` Sascha Hauer
2023-11-17  9:39             ` Sascha Hauer
2023-11-16 19:27   ` Rob Herring
2023-11-16 19:27     ` Rob Herring
2023-11-16 19:27     ` Rob Herring
2023-11-17 23:46   ` Jonas Karlman
2023-11-17 23:46     ` Jonas Karlman
2023-11-17 23:46     ` Jonas Karlman
2023-11-18  0:31     ` Andy Yan
2023-11-18  0:31       ` Andy Yan
2023-11-18  0:31       ` Andy Yan
2023-11-14 11:29 ` [PATCH 10/11] drm/rockchip: vop2: Add debugfs support Andy Yan
2023-11-14 11:29   ` Andy Yan
2023-11-14 11:29   ` Andy Yan
2023-11-14 11:29 ` [PATCH 11/11] arm64: dts: rockchip: Add vop on rk3588 Andy Yan
2023-11-14 11:29   ` Andy Yan
2023-11-14 11:29   ` Andy Yan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231114112742.1771060-1-andyshrk@163.com \
    --to=andyshrk@163.com \
    --cc=andy.yan@rock-chips.com \
    --cc=chris.obbard@collabora.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=heiko@sntech.de \
    --cc=hjc@rock-chips.com \
    --cc=kever.yang@rock-chips.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=sebastian.reichel@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.