All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com
Subject: drivers/gpu/drm/loongson/lsdc_plane.c:268:42: sparse: sparse: self-comparison always evaluates to false
Date: Thu, 16 Nov 2023 00:03:36 +0800	[thread overview]
Message-ID: <202311152357.4KFS0M8f-lkp@intel.com> (raw)

:::::: 
:::::: Manual check reason: "low confidence static check warning: drivers/gpu/drm/loongson/lsdc_plane.c:268:42: sparse: sparse: self-comparison always evaluates to false"
:::::: 

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Sui Jingfeng <suijingfeng@loongson.cn>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   c42d9eeef8e5ba9292eda36fd8e3c11f35ee065c
commit: f39db26c54281da6a785259498ca74b5e470476f drm: Add kms driver for loongson display controller
date:   4 months ago
:::::: branch date: 11 hours ago
:::::: commit date: 4 months ago
config: loongarch-randconfig-r111-20231115 (https://download.01.org/0day-ci/archive/20231115/202311152357.4KFS0M8f-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 13.2.0
reproduce: (https://download.01.org/0day-ci/archive/20231115/202311152357.4KFS0M8f-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/r/202311152357.4KFS0M8f-lkp@intel.com/

sparse warnings: (new ones prefixed by >>)
>> drivers/gpu/drm/loongson/lsdc_plane.c:268:42: sparse: sparse: self-comparison always evaluates to false

vim +268 drivers/gpu/drm/loongson/lsdc_plane.c

f39db26c54281d Sui Jingfeng 2023-06-15  225  
f39db26c54281d Sui Jingfeng 2023-06-15  226  static void lsdc_cursor_plane_atomic_async_update(struct drm_plane *plane,
f39db26c54281d Sui Jingfeng 2023-06-15  227  						  struct drm_atomic_state *state)
f39db26c54281d Sui Jingfeng 2023-06-15  228  {
f39db26c54281d Sui Jingfeng 2023-06-15  229  	struct lsdc_cursor *cursor = to_lsdc_cursor(plane);
f39db26c54281d Sui Jingfeng 2023-06-15  230  	const struct lsdc_cursor_plane_ops *ops = cursor->ops;
f39db26c54281d Sui Jingfeng 2023-06-15  231  	struct drm_framebuffer *old_fb = plane->state->fb;
f39db26c54281d Sui Jingfeng 2023-06-15  232  	struct drm_framebuffer *new_fb;
f39db26c54281d Sui Jingfeng 2023-06-15  233  	struct drm_plane_state *new_state;
f39db26c54281d Sui Jingfeng 2023-06-15  234  
f39db26c54281d Sui Jingfeng 2023-06-15  235  	new_state = drm_atomic_get_new_plane_state(state, plane);
f39db26c54281d Sui Jingfeng 2023-06-15  236  
f39db26c54281d Sui Jingfeng 2023-06-15  237  	new_fb = plane->state->fb;
f39db26c54281d Sui Jingfeng 2023-06-15  238  
f39db26c54281d Sui Jingfeng 2023-06-15  239  	plane->state->crtc_x = new_state->crtc_x;
f39db26c54281d Sui Jingfeng 2023-06-15  240  	plane->state->crtc_y = new_state->crtc_y;
f39db26c54281d Sui Jingfeng 2023-06-15  241  	plane->state->crtc_h = new_state->crtc_h;
f39db26c54281d Sui Jingfeng 2023-06-15  242  	plane->state->crtc_w = new_state->crtc_w;
f39db26c54281d Sui Jingfeng 2023-06-15  243  	plane->state->src_x = new_state->src_x;
f39db26c54281d Sui Jingfeng 2023-06-15  244  	plane->state->src_y = new_state->src_y;
f39db26c54281d Sui Jingfeng 2023-06-15  245  	plane->state->src_h = new_state->src_h;
f39db26c54281d Sui Jingfeng 2023-06-15  246  	plane->state->src_w = new_state->src_w;
f39db26c54281d Sui Jingfeng 2023-06-15  247  	swap(plane->state->fb, new_state->fb);
f39db26c54281d Sui Jingfeng 2023-06-15  248  
f39db26c54281d Sui Jingfeng 2023-06-15  249  	if (new_state->visible) {
f39db26c54281d Sui Jingfeng 2023-06-15  250  		enum lsdc_cursor_size cursor_size;
f39db26c54281d Sui Jingfeng 2023-06-15  251  
f39db26c54281d Sui Jingfeng 2023-06-15  252  		switch (new_state->crtc_w) {
f39db26c54281d Sui Jingfeng 2023-06-15  253  		case 64:
f39db26c54281d Sui Jingfeng 2023-06-15  254  			cursor_size = CURSOR_SIZE_64X64;
f39db26c54281d Sui Jingfeng 2023-06-15  255  			break;
f39db26c54281d Sui Jingfeng 2023-06-15  256  		case 32:
f39db26c54281d Sui Jingfeng 2023-06-15  257  			cursor_size = CURSOR_SIZE_32X32;
f39db26c54281d Sui Jingfeng 2023-06-15  258  			break;
f39db26c54281d Sui Jingfeng 2023-06-15  259  		default:
f39db26c54281d Sui Jingfeng 2023-06-15  260  			cursor_size = CURSOR_SIZE_32X32;
f39db26c54281d Sui Jingfeng 2023-06-15  261  			break;
f39db26c54281d Sui Jingfeng 2023-06-15  262  		}
f39db26c54281d Sui Jingfeng 2023-06-15  263  
f39db26c54281d Sui Jingfeng 2023-06-15  264  		ops->update_position(cursor, new_state->crtc_x, new_state->crtc_y);
f39db26c54281d Sui Jingfeng 2023-06-15  265  
f39db26c54281d Sui Jingfeng 2023-06-15  266  		ops->update_cfg(cursor, cursor_size, CURSOR_FORMAT_ARGB8888);
f39db26c54281d Sui Jingfeng 2023-06-15  267  
f39db26c54281d Sui Jingfeng 2023-06-15 @268  		if (!old_fb || old_fb != new_fb)
f39db26c54281d Sui Jingfeng 2023-06-15  269  			ops->update_bo_addr(cursor, lsdc_fb_base_addr(new_fb));
f39db26c54281d Sui Jingfeng 2023-06-15  270  	}
f39db26c54281d Sui Jingfeng 2023-06-15  271  }
f39db26c54281d Sui Jingfeng 2023-06-15  272  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

             reply	other threads:[~2023-11-15 16:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-15 16:03 kernel test robot [this message]
2023-11-16  3:35 drivers/gpu/drm/loongson/lsdc_plane.c:268:42: sparse: sparse: self-comparison always evaluates to false kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202311152357.4KFS0M8f-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=oe-kbuild@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.