From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH v3] scsi: ufs: core: fix racing issue during ufshcd_mcq_abort
Date: Wed, 22 Nov 2023 06:52:15 +0800 [thread overview]
Message-ID: <202311220618.OnEhSic6-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20231121071128.7743-1-hy50.seo@samsung.com>
References: <20231121071128.7743-1-hy50.seo@samsung.com>
TO: SEO HOYOUNG <hy50.seo@samsung.com>
TO: linux-scsi@vger.kernel.org
TO: linux-kernel@vger.kernel.org
TO: alim.akhtar@samsung.com
TO: avri.altman@wdc.com
TO: jejb@linux.ibm.com
TO: martin.petersen@oracle.com
TO: beanhuo@micron.com
TO: bvanassche@acm.org
TO: kwangwon.min@samsung.com
TO: kwmad.kim@samsung.com
TO: sh425.lee@samsung.com
TO: sc.suh@samsung.com
TO: quic_nguyenb@quicinc.com
TO: cpgs@samsung.com
TO: grant.jung@samsung.com
TO: junwoo80.lee@samsung.com
CC: SEO HOYOUNG <hy50.seo@samsung.com>
Hi SEO,
kernel test robot noticed the following build warnings:
[auto build test WARNING on jejb-scsi/for-next]
[also build test WARNING on mkp-scsi/for-next linus/master v6.7-rc2 next-20231121]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/SEO-HOYOUNG/scsi-ufs-core-fix-racing-issue-during-ufshcd_mcq_abort/20231121-151923
base: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next
patch link: https://lore.kernel.org/r/20231121071128.7743-1-hy50.seo%40samsung.com
patch subject: [PATCH v3] scsi: ufs: core: fix racing issue during ufshcd_mcq_abort
:::::: branch date: 15 hours ago
:::::: commit date: 15 hours ago
config: powerpc-randconfig-r071-20231122 (https://download.01.org/0day-ci/archive/20231122/202311220618.OnEhSic6-lkp@intel.com/config)
compiler: powerpc-linux-gcc (GCC) 13.2.0
reproduce: (https://download.01.org/0day-ci/archive/20231122/202311220618.OnEhSic6-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202311220618.OnEhSic6-lkp@intel.com/
smatch warnings:
drivers/ufs/core/ufs-mcq.c:515 ufshcd_mcq_sq_cleanup() warn: variable dereferenced before check 'cmd' (see line 511)
vim +/cmd +515 drivers/ufs/core/ufs-mcq.c
8d7290348992f2 Bao D. Nguyen 2023-05-29 489
8d7290348992f2 Bao D. Nguyen 2023-05-29 490 /**
8d7290348992f2 Bao D. Nguyen 2023-05-29 491 * ufshcd_mcq_sq_cleanup - Clean up submission queue resources
8d7290348992f2 Bao D. Nguyen 2023-05-29 492 * associated with the pending command.
317a38045ab763 Yang Li 2023-07-12 493 * @hba: per adapter instance.
317a38045ab763 Yang Li 2023-07-12 494 * @task_tag: The command's task tag.
8d7290348992f2 Bao D. Nguyen 2023-05-29 495 *
3a17fefe0f1960 Bart Van Assche 2023-07-27 496 * Return: 0 for success; error code otherwise.
8d7290348992f2 Bao D. Nguyen 2023-05-29 497 */
8d7290348992f2 Bao D. Nguyen 2023-05-29 498 int ufshcd_mcq_sq_cleanup(struct ufs_hba *hba, int task_tag)
8d7290348992f2 Bao D. Nguyen 2023-05-29 499 {
8d7290348992f2 Bao D. Nguyen 2023-05-29 500 struct ufshcd_lrb *lrbp = &hba->lrb[task_tag];
8d7290348992f2 Bao D. Nguyen 2023-05-29 501 struct scsi_cmnd *cmd = lrbp->cmd;
8d7290348992f2 Bao D. Nguyen 2023-05-29 502 struct ufs_hw_queue *hwq;
8d7290348992f2 Bao D. Nguyen 2023-05-29 503 void __iomem *reg, *opr_sqd_base;
8d7290348992f2 Bao D. Nguyen 2023-05-29 504 u32 nexus, id, val;
8d7290348992f2 Bao D. Nguyen 2023-05-29 505 int err;
8d7290348992f2 Bao D. Nguyen 2023-05-29 506
aa9d5d0015a8b7 Po-Wen Kao 2023-06-12 507 if (hba->quirks & UFSHCD_QUIRK_MCQ_BROKEN_RTC)
aa9d5d0015a8b7 Po-Wen Kao 2023-06-12 508 return -ETIMEDOUT;
aa9d5d0015a8b7 Po-Wen Kao 2023-06-12 509
5363c9d813101c SEO HOYOUNG 2023-11-21 510 if (!ufshcd_cmd_inflight(cmd) ||
5363c9d813101c SEO HOYOUNG 2023-11-21 @511 test_bit(SCMD_STATE_COMPLETE, &cmd->state))
5363c9d813101c SEO HOYOUNG 2023-11-21 512 return 0;
5363c9d813101c SEO HOYOUNG 2023-11-21 513
8d7290348992f2 Bao D. Nguyen 2023-05-29 514 if (task_tag != hba->nutrs - UFSHCD_NUM_RESERVED) {
8d7290348992f2 Bao D. Nguyen 2023-05-29 @515 if (!cmd)
8d7290348992f2 Bao D. Nguyen 2023-05-29 516 return -EINVAL;
8d7290348992f2 Bao D. Nguyen 2023-05-29 517 hwq = ufshcd_mcq_req_to_hwq(hba, scsi_cmd_to_rq(cmd));
8d7290348992f2 Bao D. Nguyen 2023-05-29 518 } else {
8d7290348992f2 Bao D. Nguyen 2023-05-29 519 hwq = hba->dev_cmd_queue;
8d7290348992f2 Bao D. Nguyen 2023-05-29 520 }
8d7290348992f2 Bao D. Nguyen 2023-05-29 521
8d7290348992f2 Bao D. Nguyen 2023-05-29 522 id = hwq->id;
8d7290348992f2 Bao D. Nguyen 2023-05-29 523
8d7290348992f2 Bao D. Nguyen 2023-05-29 524 mutex_lock(&hwq->sq_mutex);
8d7290348992f2 Bao D. Nguyen 2023-05-29 525
8d7290348992f2 Bao D. Nguyen 2023-05-29 526 /* stop the SQ fetching before working on it */
8d7290348992f2 Bao D. Nguyen 2023-05-29 527 err = ufshcd_mcq_sq_stop(hba, hwq);
8d7290348992f2 Bao D. Nguyen 2023-05-29 528 if (err)
8d7290348992f2 Bao D. Nguyen 2023-05-29 529 goto unlock;
8d7290348992f2 Bao D. Nguyen 2023-05-29 530
8d7290348992f2 Bao D. Nguyen 2023-05-29 531 /* SQCTI = EXT_IID, IID, LUN, Task Tag */
8d7290348992f2 Bao D. Nguyen 2023-05-29 532 nexus = lrbp->lun << 8 | task_tag;
8d7290348992f2 Bao D. Nguyen 2023-05-29 533 opr_sqd_base = mcq_opr_base(hba, OPR_SQD, id);
8d7290348992f2 Bao D. Nguyen 2023-05-29 534 writel(nexus, opr_sqd_base + REG_SQCTI);
8d7290348992f2 Bao D. Nguyen 2023-05-29 535
8d7290348992f2 Bao D. Nguyen 2023-05-29 536 /* SQRTCy.ICU = 1 */
8d7290348992f2 Bao D. Nguyen 2023-05-29 537 writel(SQ_ICU, opr_sqd_base + REG_SQRTC);
8d7290348992f2 Bao D. Nguyen 2023-05-29 538
8d7290348992f2 Bao D. Nguyen 2023-05-29 539 /* Poll SQRTSy.CUS = 1. Return result from SQRTSy.RTC */
8d7290348992f2 Bao D. Nguyen 2023-05-29 540 reg = opr_sqd_base + REG_SQRTS;
8d7290348992f2 Bao D. Nguyen 2023-05-29 541 err = read_poll_timeout(readl, val, val & SQ_CUS, 20,
8d7290348992f2 Bao D. Nguyen 2023-05-29 542 MCQ_POLL_US, false, reg);
8d7290348992f2 Bao D. Nguyen 2023-05-29 543 if (err)
8d7290348992f2 Bao D. Nguyen 2023-05-29 544 dev_err(hba->dev, "%s: failed. hwq=%d, tag=%d err=%ld\n",
8d7290348992f2 Bao D. Nguyen 2023-05-29 545 __func__, id, task_tag,
8d7290348992f2 Bao D. Nguyen 2023-05-29 546 FIELD_GET(SQ_ICU_ERR_CODE_MASK, readl(reg)));
8d7290348992f2 Bao D. Nguyen 2023-05-29 547
8d7290348992f2 Bao D. Nguyen 2023-05-29 548 if (ufshcd_mcq_sq_start(hba, hwq))
8d7290348992f2 Bao D. Nguyen 2023-05-29 549 err = -ETIMEDOUT;
8d7290348992f2 Bao D. Nguyen 2023-05-29 550
8d7290348992f2 Bao D. Nguyen 2023-05-29 551 unlock:
8d7290348992f2 Bao D. Nguyen 2023-05-29 552 mutex_unlock(&hwq->sq_mutex);
8d7290348992f2 Bao D. Nguyen 2023-05-29 553 return err;
8d7290348992f2 Bao D. Nguyen 2023-05-29 554 }
8d7290348992f2 Bao D. Nguyen 2023-05-29 555
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2023-11-21 22:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 22:52 kernel test robot [this message]
[not found] <CGME20231121070851epcas2p2ba11977edde23d3dcb87581e410806c8@epcas2p2.samsung.com>
2023-11-21 7:11 ` [PATCH v3] scsi: ufs: core: fix racing issue during ufshcd_mcq_abort SEO HOYOUNG
2023-11-21 17:57 ` Bart Van Assche
2023-11-22 9:23 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202311220618.OnEhSic6-lkp@intel.com \
--to=lkp@intel.com \
--cc=error27@gmail.com \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.