From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH v6 3/4] clk: sophgo: Add SG2042 clock generator driver
Date: Fri, 8 Dec 2023 19:45:15 +0800 [thread overview]
Message-ID: <202312081933.MUdHNASt-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <d1aa4f76f360ebd7b790a4786641f1b0188dbba8.1701997033.git.unicorn_wang@outlook.com>
References: <d1aa4f76f360ebd7b790a4786641f1b0188dbba8.1701997033.git.unicorn_wang@outlook.com>
TO: Chen Wang <unicornxw@gmail.com>
TO: aou@eecs.berkeley.edu
TO: chao.wei@sophgo.com
TO: conor@kernel.org
TO: krzysztof.kozlowski+dt@linaro.org
TO: mturquette@baylibre.com
TO: palmer@dabbelt.com
TO: paul.walmsley@sifive.com
TO: richardcochran@gmail.com
TO: robh+dt@kernel.org
TO: sboyd@kernel.org
TO: devicetree@vger.kernel.org
TO: linux-clk@vger.kernel.org
TO: linux-kernel@vger.kernel.org
TO: linux-riscv@lists.infradead.org
TO: haijiao.liu@sophgo.com
TO: xiaoguang.xing@sophgo.com
TO: guoren@kernel.org
TO: jszhang@kernel.org
TO: inochiama@outlook.com
TO: samuel.holland@sifive.com
CC: Chen Wang <unicorn_wang@outlook.com>
Hi Chen,
kernel test robot noticed the following build warnings:
[auto build test WARNING on b85ea95d086471afb4ad062012a4d73cd328fa86]
url: https://github.com/intel-lab-lkp/linux/commits/Chen-Wang/dt-bindings-soc-sophgo-Add-Sophgo-system-control-module/20231208-091702
base: b85ea95d086471afb4ad062012a4d73cd328fa86
patch link: https://lore.kernel.org/r/d1aa4f76f360ebd7b790a4786641f1b0188dbba8.1701997033.git.unicorn_wang%40outlook.com
patch subject: [PATCH v6 3/4] clk: sophgo: Add SG2042 clock generator driver
:::::: branch date: 10 hours ago
:::::: commit date: 10 hours ago
config: xtensa-randconfig-r071-20231208 (https://download.01.org/0day-ci/archive/20231208/202312081933.MUdHNASt-lkp@intel.com/config)
compiler: xtensa-linux-gcc (GCC) 13.2.0
reproduce: (https://download.01.org/0day-ci/archive/20231208/202312081933.MUdHNASt-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202312081933.MUdHNASt-lkp@intel.com/
smatch warnings:
drivers/clk/sophgo/clk-sophgo-sg2042.c:1282 sg2042_clk_init_clk_data() warn: passing zero to 'PTR_ERR'
vim +/PTR_ERR +1282 drivers/clk/sophgo/clk-sophgo-sg2042.c
7c68ebea1041f9 Chen Wang 2023-12-08 1257
7c68ebea1041f9 Chen Wang 2023-12-08 1258 static int __init sg2042_clk_init_clk_data(
7c68ebea1041f9 Chen Wang 2023-12-08 1259 struct device_node *node,
7c68ebea1041f9 Chen Wang 2023-12-08 1260 int num_clks,
7c68ebea1041f9 Chen Wang 2023-12-08 1261 struct sg2042_clk_data **pp_clk_data)
7c68ebea1041f9 Chen Wang 2023-12-08 1262 {
7c68ebea1041f9 Chen Wang 2023-12-08 1263 int ret = 0;
7c68ebea1041f9 Chen Wang 2023-12-08 1264 struct sg2042_clk_data *clk_data = NULL;
7c68ebea1041f9 Chen Wang 2023-12-08 1265 struct device_node *np_syscon;
7c68ebea1041f9 Chen Wang 2023-12-08 1266
7c68ebea1041f9 Chen Wang 2023-12-08 1267 np_syscon = of_parse_phandle(node, "sophgo,system-ctrl", 0);
7c68ebea1041f9 Chen Wang 2023-12-08 1268 if (!np_syscon) {
7c68ebea1041f9 Chen Wang 2023-12-08 1269 pr_err("failed to get system-ctrl node\n");
7c68ebea1041f9 Chen Wang 2023-12-08 1270 ret = -EINVAL;
7c68ebea1041f9 Chen Wang 2023-12-08 1271 goto error_out;
7c68ebea1041f9 Chen Wang 2023-12-08 1272 }
7c68ebea1041f9 Chen Wang 2023-12-08 1273
7c68ebea1041f9 Chen Wang 2023-12-08 1274 clk_data = kzalloc(struct_size(clk_data, onecell_data.hws, num_clks), GFP_KERNEL);
7c68ebea1041f9 Chen Wang 2023-12-08 1275 if (!clk_data) {
7c68ebea1041f9 Chen Wang 2023-12-08 1276 ret = -ENOMEM;
7c68ebea1041f9 Chen Wang 2023-12-08 1277 goto error_out;
7c68ebea1041f9 Chen Wang 2023-12-08 1278 }
7c68ebea1041f9 Chen Wang 2023-12-08 1279
7c68ebea1041f9 Chen Wang 2023-12-08 1280 clk_data->regmap_syscon = device_node_to_regmap(np_syscon);
7c68ebea1041f9 Chen Wang 2023-12-08 1281 if (IS_ERR_OR_NULL(clk_data->regmap_syscon)) {
7c68ebea1041f9 Chen Wang 2023-12-08 @1282 pr_err("cannot get regmap_syscon %ld\n", PTR_ERR(clk_data->regmap_syscon));
7c68ebea1041f9 Chen Wang 2023-12-08 1283 ret = -ENODEV;
7c68ebea1041f9 Chen Wang 2023-12-08 1284 goto cleanup;
7c68ebea1041f9 Chen Wang 2023-12-08 1285 }
7c68ebea1041f9 Chen Wang 2023-12-08 1286 clk_data->iobase_syscon = of_iomap(np_syscon, 0);
7c68ebea1041f9 Chen Wang 2023-12-08 1287 clk_data->iobase = of_iomap(node, 0);
7c68ebea1041f9 Chen Wang 2023-12-08 1288 clk_data->onecell_data.num = num_clks;
7c68ebea1041f9 Chen Wang 2023-12-08 1289
7c68ebea1041f9 Chen Wang 2023-12-08 1290 *pp_clk_data = clk_data;
7c68ebea1041f9 Chen Wang 2023-12-08 1291 return ret;
7c68ebea1041f9 Chen Wang 2023-12-08 1292
7c68ebea1041f9 Chen Wang 2023-12-08 1293 cleanup:
7c68ebea1041f9 Chen Wang 2023-12-08 1294 kfree(clk_data);
7c68ebea1041f9 Chen Wang 2023-12-08 1295
7c68ebea1041f9 Chen Wang 2023-12-08 1296 error_out:
7c68ebea1041f9 Chen Wang 2023-12-08 1297 return ret;
7c68ebea1041f9 Chen Wang 2023-12-08 1298 }
7c68ebea1041f9 Chen Wang 2023-12-08 1299
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2023-12-08 11:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-08 11:45 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-12-08 1:13 [PATCH v6 0/4] riscv: sophgo: add clock support for sg2042 Chen Wang
2023-12-08 1:14 ` [PATCH v6 3/4] clk: sophgo: Add SG2042 clock generator driver Chen Wang
2023-12-08 1:14 ` Chen Wang
2023-12-08 16:47 ` Conor Dooley
2023-12-08 16:47 ` Conor Dooley
2023-12-12 2:22 ` Chen Wang
2023-12-12 2:22 ` Chen Wang
2023-12-12 8:37 ` Conor Dooley
2023-12-12 8:37 ` Conor Dooley
2023-12-14 0:15 ` Stephen Boyd
2023-12-14 0:15 ` Stephen Boyd
2023-12-18 9:01 ` Chen Wang
2023-12-18 9:01 ` Chen Wang
2023-12-09 6:22 ` Dan Carpenter
2023-12-09 6:22 ` Dan Carpenter
2023-12-12 0:05 ` Chen Wang
2023-12-12 0:05 ` Chen Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202312081933.MUdHNASt-lkp@intel.com \
--to=lkp@intel.com \
--cc=error27@gmail.com \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.