All of lore.kernel.org
 help / color / mirror / Atom feed
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Subject: [PATCH v4 02/12] xen/spinlock: make spinlock initializers more readable
Date: Tue, 12 Dec 2023 10:47:15 +0100	[thread overview]
Message-ID: <20231212094725.22184-3-jgross@suse.com> (raw)
In-Reply-To: <20231212094725.22184-1-jgross@suse.com>

Use named member initializers instead of positional ones for the macros
used to initialize structures.

Signed-off-by: Juergen Gross <jgross@suse.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
V2:
- new patch
---
 xen/include/xen/spinlock.h | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

diff --git a/xen/include/xen/spinlock.h b/xen/include/xen/spinlock.h
index c44e7d4929..1cd9120eac 100644
--- a/xen/include/xen/spinlock.h
+++ b/xen/include/xen/spinlock.h
@@ -21,7 +21,7 @@ union lock_debug {
         bool unseen:1;
     };
 };
-#define _LOCK_DEBUG { LOCK_DEBUG_INITVAL }
+#define _LOCK_DEBUG { .val = LOCK_DEBUG_INITVAL }
 void check_lock(union lock_debug *debug, bool try);
 void lock_enter(const union lock_debug *debug);
 void lock_exit(const union lock_debug *debug);
@@ -94,12 +94,16 @@ struct lock_profile_qhead {
     int32_t                   idx;     /* index for printout */
 };
 
-#define _LOCK_PROFILE(name) { NULL, #name, &name, 0, 0, 0, 0, 0 }
+#define _LOCK_PROFILE(lockname) { .name = #lockname, .lock = &lockname, }
 #define _LOCK_PROFILE_PTR(name)                                               \
     static struct lock_profile * const __lock_profile_##name                  \
     __used_section(".lockprofile.data") =                                     \
     &__lock_profile_data_##name
-#define _SPIN_LOCK_UNLOCKED(x) { { 0 }, SPINLOCK_NO_CPU, 0, _LOCK_DEBUG, x }
+#define _SPIN_LOCK_UNLOCKED(x) {                                              \
+    .recurse_cpu = SPINLOCK_NO_CPU,                                           \
+    .debug =_LOCK_DEBUG,                                                      \
+    .profile = x,                                                             \
+}
 #define SPIN_LOCK_UNLOCKED _SPIN_LOCK_UNLOCKED(NULL)
 #define DEFINE_SPINLOCK(l)                                                    \
     spinlock_t l = _SPIN_LOCK_UNLOCKED(NULL);                                 \
@@ -142,7 +146,10 @@ extern void cf_check spinlock_profile_reset(unsigned char key);
 
 struct lock_profile_qhead { };
 
-#define SPIN_LOCK_UNLOCKED { { 0 }, SPINLOCK_NO_CPU, 0, _LOCK_DEBUG }
+#define SPIN_LOCK_UNLOCKED {                                                  \
+    .recurse_cpu = SPINLOCK_NO_CPU,                                           \
+    .debug =_LOCK_DEBUG,                                                      \
+}
 #define DEFINE_SPINLOCK(l) spinlock_t l = SPIN_LOCK_UNLOCKED
 
 #define spin_lock_init_prof(s, l) spin_lock_init(&((s)->l))
-- 
2.35.3



  parent reply	other threads:[~2023-12-12  9:47 UTC|newest]

Thread overview: 73+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-12  9:47 [PATCH v4 00/12] xen/spinlock: make recursive spinlocks a dedicated type Juergen Gross
2023-12-12  9:47 ` [PATCH v4 01/12] xen/spinlock: reduce lock profile ifdefs Juergen Gross
2023-12-12 12:44   ` Julien Grall
2023-12-12  9:47 ` Juergen Gross [this message]
2023-12-12  9:47 ` [PATCH v4 03/12] xen/spinlock: introduce new type for recursive spinlocks Juergen Gross
2023-12-12 12:57   ` Julien Grall
2023-12-12 13:04     ` Juergen Gross
2023-12-12 13:07       ` Julien Grall
2023-12-21 10:34     ` Jan Beulich
2023-12-21 11:06       ` Juergen Gross
2023-12-21 11:07         ` Jan Beulich
2023-12-12  9:47 ` [PATCH v4 04/12] xen/spinlock: rename recursive lock functions Juergen Gross
2023-12-12 12:59   ` Julien Grall
2024-02-28 14:59   ` Jan Beulich
2023-12-12  9:47 ` [PATCH v4 05/12] xen/spinlock: add rspin_[un]lock_irq[save|restore]() Juergen Gross
2023-12-12 13:03   ` Julien Grall
2023-12-12 14:16     ` Juergen Gross
2024-02-28 15:09   ` Jan Beulich
2024-02-28 15:21     ` Jürgen Groß
2023-12-12  9:47 ` [PATCH v4 06/12] xen/spinlock: make struct lock_profile rspinlock_t aware Juergen Gross
2023-12-12 18:42   ` Julien Grall
2023-12-13  6:05     ` Juergen Gross
2023-12-13  8:32       ` Julien Grall
2023-12-13  8:36       ` Jan Beulich
2023-12-13  9:07         ` Juergen Gross
2024-02-28 15:19   ` Jan Beulich
2024-02-28 15:43     ` Jürgen Groß
2024-02-28 16:02       ` Jan Beulich
2024-02-28 16:22         ` Jürgen Groß
2023-12-12  9:47 ` [PATCH v4 07/12] xen/spinlock: add explicit non-recursive locking functions Juergen Gross
2023-12-12 18:49   ` Julien Grall
2023-12-13  6:17     ` Juergen Gross
2023-12-13  8:36       ` Julien Grall
2023-12-13  9:11         ` Juergen Gross
2024-02-29 13:49   ` Jan Beulich
2024-02-29 13:56     ` Juergen Gross
2023-12-12  9:47 ` [PATCH v4 08/12] xen/spinlock: add another function level Juergen Gross
2023-12-12 19:10   ` Julien Grall
2023-12-13  6:23     ` Juergen Gross
2023-12-13  8:43       ` Julien Grall
2023-12-13  9:17         ` Juergen Gross
2023-12-13  9:48           ` Julien Grall
2023-12-13  9:55             ` Juergen Gross
2023-12-13 10:06               ` Jan Beulich
2023-12-13 10:04             ` Jan Beulich
2024-02-29 13:59   ` Jan Beulich
2023-12-12  9:47 ` [PATCH v4 09/12] xen/spinlock: add missing rspin_is_locked() and rspin_barrier() Juergen Gross
2024-02-29 14:14   ` Jan Beulich
2024-02-29 14:18     ` Jürgen Groß
2023-12-12  9:47 ` [PATCH v4 10/12] xen/spinlock: split recursive spinlocks from normal ones Juergen Gross
2024-02-29 15:32   ` Jan Beulich
2024-02-29 15:45     ` Jürgen Groß
2024-03-01 14:37     ` Juergen Gross
2024-03-04  7:25       ` Jan Beulich
2024-03-04  7:43         ` Jürgen Groß
2023-12-12  9:47 ` [PATCH v4 11/12] xen/spinlock: remove indirection through macros for spin_*() functions Juergen Gross
2024-02-29 15:35   ` Jan Beulich
2023-12-12  9:47 ` [PATCH v4 12/12] xen/spinlock: support higher number of cpus Juergen Gross
2023-12-12 10:10   ` Julien Grall
2023-12-12 11:09     ` Juergen Gross
2023-12-12 11:40       ` Julien Grall
2023-12-12 12:11         ` Juergen Gross
2023-12-12 12:22           ` Julien Grall
2023-12-12 12:39   ` Julien Grall
2023-12-12 13:08     ` Juergen Gross
2023-12-12 14:04       ` Julien Grall
2024-02-29 15:46   ` Jan Beulich
2024-02-29 16:29     ` Jürgen Groß
2024-02-29 16:31       ` Jan Beulich
2024-02-29 16:45         ` Juergen Gross
2024-02-29 16:54           ` Jan Beulich
2024-02-29 17:04             ` Jürgen Groß
2024-02-29 17:07               ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231212094725.22184-3-jgross@suse.com \
    --to=jgross@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=george.dunlap@citrix.com \
    --cc=jbeulich@suse.com \
    --cc=julien@xen.org \
    --cc=sstabellini@kernel.org \
    --cc=wl@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.