All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Layton <jlayton@kernel.org>
To: Anna Schumaker <anna@kernel.org>,
	 Trond Myklebust <trondmy@hammerspace.com>,
	 Chuck Lever <chuck.lever@oracle.com>,
	Yongcheng Yang <yoyang@redhat.com>,
	 linux-nfs@vger.kernel.org, fstests@vger.kernel.org,
	 Jeff Layton <jlayton@kernel.org>
Subject: [PATCH fstests 2/2] generic/732: don't run it on NFS
Date: Wed, 10 Jan 2024 13:27:28 -0500	[thread overview]
Message-ID: <20240110-fixes-v1-2-69f5ddd95656@kernel.org> (raw)
In-Reply-To: <20240110-fixes-v1-0-69f5ddd95656@kernel.org>

This test sets up two independent superblocks with the same backend
server, and then does RENAMES of the same files in the two servers. This
is basically trying to simulate the case where two clients are competing
to rename files in the same directory on the same server.

This test would usually pass vs. an NFSv4 server that doesn't have
dfdd2630a7398 ("nfsd: fix change_info in NFSv4 RENAME replies"), because
the client would end up improperly invalidating the dcache for the whole
dir after most RENAMEs.

However, this test doesn't (and shouldn't) pass on NFS, because the
client has no idea that a rename has happened on the second mount. The
expected behavior for the NFS client is for it to use the cache timeouts
in this case, which is what it now does with the above server bug fixed.

Exempt NFS from running this test, since we don't expect it to pass.

Cc: Yongcheng Yang <yoyang@redhat.com>
Signed-off-by: Jeff Layton <jlayton@kernel.org>
---
 tests/generic/732 | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/tests/generic/732 b/tests/generic/732
index 785aac58f361..5b5087d5accd 100755
--- a/tests/generic/732
+++ b/tests/generic/732
@@ -22,9 +22,7 @@ _cleanup()
 }
 
 # real QA test starts here
-_supported_fs generic
-[ "$FSTYP" = "nfs" ] && _fixed_by_kernel_commit fdd2630a739819 \
-	"nfsd: fix change_info in NFSv4 RENAME replies"
+_supported_fs ^nfs
 
 _require_test
 _require_scratch

-- 
2.43.0


  parent reply	other threads:[~2024-01-10 18:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-10 18:27 [PATCH fstests 0/2] generic: skip a couple more tests on NFS Jeff Layton
2024-01-10 18:27 ` [PATCH fstests 1/2] generic/465: don't run it " Jeff Layton
2024-01-11 20:47   ` Zorro Lang
2024-01-10 18:27 ` Jeff Layton [this message]
2024-01-11 20:49   ` [PATCH fstests 2/2] generic/732: " Zorro Lang
2024-01-11 21:13     ` Jeff Layton
2024-01-12 13:35       ` Zorro Lang
2024-01-12 13:36       ` Zorro Lang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240110-fixes-v1-2-69f5ddd95656@kernel.org \
    --to=jlayton@kernel.org \
    --cc=anna@kernel.org \
    --cc=chuck.lever@oracle.com \
    --cc=fstests@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=trondmy@hammerspace.com \
    --cc=yoyang@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.