From: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>
To: AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: kernel@collabora.com,
"Nícolas F. R. A. Prado" <nfraprado@collabora.com>,
"Conor Dooley" <conor+dt@kernel.org>,
"Enric Balletbo i Serra" <eballetbo@kernel.org>,
"Ikjoon Jang" <ikjn@chromium.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Stephen Boyd" <swboyd@chromium.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org
Subject: [PATCH] arm64: dts: mt8183: juniper: Remove CrosEC base detection node
Date: Thu, 11 Jan 2024 16:53:12 -0300 [thread overview]
Message-ID: <20240111195335.871096-1-nfraprado@collabora.com> (raw)
The cbas node is used to describe base detection functionality in the
ChromeOS EC, which is used for units that have a detachable keyboard and
thus rely on this functionality to switch between tablet and laptop
mode.
The juniper-sku16 machine is a convertible, meaning the keyboard can be
flipped but not detached. The detection for the keyboard getting
flipped is handled by the driver bound to the keyboard-controller
node in the EC.
Since there is no base detection in this machine, and the device backed
by this node fails to probe and goes unused, delete the node from the
DT.
Fixes: 4fa8492d1e5b ("arm64: dts: mt8183: add cbas node under cros_ec")
Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
---
.../boot/dts/mediatek/mt8183-kukui-jacuzzi-juniper-sku16.dts | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-juniper-sku16.dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-juniper-sku16.dts
index 8ac6bf5b17f9..8096ca215258 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-juniper-sku16.dts
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-juniper-sku16.dts
@@ -13,3 +13,6 @@ / {
compatible = "google,juniper-sku16", "google,juniper", "mediatek,mt8183";
};
+&cros_ec {
+ /delete-node/ cbas;
+};
--
2.43.0
WARNING: multiple messages have this Message-ID (diff)
From: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>
To: AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: kernel@collabora.com,
"Nícolas F. R. A. Prado" <nfraprado@collabora.com>,
"Conor Dooley" <conor+dt@kernel.org>,
"Enric Balletbo i Serra" <eballetbo@kernel.org>,
"Ikjoon Jang" <ikjn@chromium.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Stephen Boyd" <swboyd@chromium.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org
Subject: [PATCH] arm64: dts: mt8183: juniper: Remove CrosEC base detection node
Date: Thu, 11 Jan 2024 16:53:12 -0300 [thread overview]
Message-ID: <20240111195335.871096-1-nfraprado@collabora.com> (raw)
The cbas node is used to describe base detection functionality in the
ChromeOS EC, which is used for units that have a detachable keyboard and
thus rely on this functionality to switch between tablet and laptop
mode.
The juniper-sku16 machine is a convertible, meaning the keyboard can be
flipped but not detached. The detection for the keyboard getting
flipped is handled by the driver bound to the keyboard-controller
node in the EC.
Since there is no base detection in this machine, and the device backed
by this node fails to probe and goes unused, delete the node from the
DT.
Fixes: 4fa8492d1e5b ("arm64: dts: mt8183: add cbas node under cros_ec")
Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
---
.../boot/dts/mediatek/mt8183-kukui-jacuzzi-juniper-sku16.dts | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-juniper-sku16.dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-juniper-sku16.dts
index 8ac6bf5b17f9..8096ca215258 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-juniper-sku16.dts
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-juniper-sku16.dts
@@ -13,3 +13,6 @@ / {
compatible = "google,juniper-sku16", "google,juniper", "mediatek,mt8183";
};
+&cros_ec {
+ /delete-node/ cbas;
+};
--
2.43.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2024-01-11 19:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-11 19:53 Nícolas F. R. A. Prado [this message]
2024-01-11 19:53 ` [PATCH] arm64: dts: mt8183: juniper: Remove CrosEC base detection node Nícolas F. R. A. Prado
2024-01-12 7:10 ` Chen-Yu Tsai
2024-01-12 7:10 ` Chen-Yu Tsai
2024-01-12 12:19 ` Nícolas F. R. A. Prado
2024-01-12 12:19 ` Nícolas F. R. A. Prado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240111195335.871096-1-nfraprado@collabora.com \
--to=nfraprado@collabora.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eballetbo@kernel.org \
--cc=ikjn@chromium.org \
--cc=kernel@collabora.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.