From: Chen-Yu Tsai <wens@kernel.org> To: Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Jernej Skrabec <jernej.skrabec@gmail.com>, Samuel Holland <samuel@sholland.org>, Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>, Vinod Koul <vkoul@kernel.org> Cc: Chen-Yu Tsai <wens@csie.org>, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-sound@vger.kernel.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/7] dt-bindings: sound: sun4i-spdif: Fix requirements for H6 Date: Tue, 23 Jan 2024 01:05:12 +0800 [thread overview] Message-ID: <20240122170518.3090814-2-wens@kernel.org> (raw) In-Reply-To: <20240122170518.3090814-1-wens@kernel.org> From: Chen-Yu Tsai <wens@csie.org> When the H6 was added to the bindings, only the TX DMA channel was added. As the hardware supports both transmit and receive functions, the binding is missing the RX DMA channel and is thus incorrect. Also, the reset control was not made mandatory. Add the RX DMA channel for SPDIF on H6 by removing the compatible from the list of compatibles that should only have a TX DMA channel. And add the H6 compatible to the list of compatibles that require the reset control to be present. Fixes: b20453031472 ("dt-bindings: sound: sun4i-spdif: Add Allwinner H6 compatible") Signed-off-by: Chen-Yu Tsai <wens@csie.org> --- .../devicetree/bindings/sound/allwinner,sun4i-a10-spdif.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/sound/allwinner,sun4i-a10-spdif.yaml b/Documentation/devicetree/bindings/sound/allwinner,sun4i-a10-spdif.yaml index 8108c564dd78..98e2e053fa19 100644 --- a/Documentation/devicetree/bindings/sound/allwinner,sun4i-a10-spdif.yaml +++ b/Documentation/devicetree/bindings/sound/allwinner,sun4i-a10-spdif.yaml @@ -62,6 +62,7 @@ allOf: enum: - allwinner,sun6i-a31-spdif - allwinner,sun8i-h3-spdif + - allwinner,sun50i-h6-spdif then: required: @@ -73,7 +74,6 @@ allOf: contains: enum: - allwinner,sun8i-h3-spdif - - allwinner,sun50i-h6-spdif then: properties: -- 2.39.2
WARNING: multiple messages have this Message-ID (diff)
From: Chen-Yu Tsai <wens@kernel.org> To: Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Jernej Skrabec <jernej.skrabec@gmail.com>, Samuel Holland <samuel@sholland.org>, Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>, Vinod Koul <vkoul@kernel.org> Cc: Chen-Yu Tsai <wens@csie.org>, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-sound@vger.kernel.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/7] dt-bindings: sound: sun4i-spdif: Fix requirements for H6 Date: Tue, 23 Jan 2024 01:05:12 +0800 [thread overview] Message-ID: <20240122170518.3090814-2-wens@kernel.org> (raw) In-Reply-To: <20240122170518.3090814-1-wens@kernel.org> From: Chen-Yu Tsai <wens@csie.org> When the H6 was added to the bindings, only the TX DMA channel was added. As the hardware supports both transmit and receive functions, the binding is missing the RX DMA channel and is thus incorrect. Also, the reset control was not made mandatory. Add the RX DMA channel for SPDIF on H6 by removing the compatible from the list of compatibles that should only have a TX DMA channel. And add the H6 compatible to the list of compatibles that require the reset control to be present. Fixes: b20453031472 ("dt-bindings: sound: sun4i-spdif: Add Allwinner H6 compatible") Signed-off-by: Chen-Yu Tsai <wens@csie.org> --- .../devicetree/bindings/sound/allwinner,sun4i-a10-spdif.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/sound/allwinner,sun4i-a10-spdif.yaml b/Documentation/devicetree/bindings/sound/allwinner,sun4i-a10-spdif.yaml index 8108c564dd78..98e2e053fa19 100644 --- a/Documentation/devicetree/bindings/sound/allwinner,sun4i-a10-spdif.yaml +++ b/Documentation/devicetree/bindings/sound/allwinner,sun4i-a10-spdif.yaml @@ -62,6 +62,7 @@ allOf: enum: - allwinner,sun6i-a31-spdif - allwinner,sun8i-h3-spdif + - allwinner,sun50i-h6-spdif then: required: @@ -73,7 +74,6 @@ allOf: contains: enum: - allwinner,sun8i-h3-spdif - - allwinner,sun50i-h6-spdif then: properties: -- 2.39.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-01-22 17:05 UTC|newest] Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-01-22 17:05 [PATCH 0/7] arm64: sun50i-h616: Add DMA and SPDIF controllers Chen-Yu Tsai 2024-01-22 17:05 ` Chen-Yu Tsai 2024-01-22 17:05 ` Chen-Yu Tsai [this message] 2024-01-22 17:05 ` [PATCH 1/7] dt-bindings: sound: sun4i-spdif: Fix requirements for H6 Chen-Yu Tsai 2024-01-22 18:18 ` Conor Dooley 2024-01-22 18:18 ` Conor Dooley 2024-01-23 17:48 ` Jernej Škrabec 2024-01-23 17:48 ` Jernej Škrabec 2024-01-22 17:05 ` [PATCH 2/7] dt-bindings: sound: sun4i-spdif: Add Allwinner H616 compatible Chen-Yu Tsai 2024-01-22 17:05 ` Chen-Yu Tsai 2024-01-22 18:19 ` Conor Dooley 2024-01-22 18:19 ` Conor Dooley 2024-01-23 17:49 ` Jernej Škrabec 2024-01-23 17:49 ` Jernej Škrabec 2024-01-22 17:05 ` [PATCH 3/7] ASoC: sunxi: sun4i-spdif: Add support for Allwinner H616 Chen-Yu Tsai 2024-01-22 17:05 ` Chen-Yu Tsai 2024-01-23 0:38 ` Andre Przywara 2024-01-23 0:38 ` Andre Przywara 2024-01-23 17:50 ` Jernej Škrabec 2024-01-23 17:50 ` Jernej Škrabec 2024-01-22 17:05 ` [PATCH 4/7] dt-bindings: dma: allwinner,sun50i-a64-dma: Add compatible for H616 Chen-Yu Tsai 2024-01-22 17:05 ` Chen-Yu Tsai 2024-01-22 18:18 ` Conor Dooley 2024-01-22 18:18 ` Conor Dooley 2024-01-25 14:31 ` Chen-Yu Tsai 2024-01-25 14:31 ` Chen-Yu Tsai 2024-01-23 0:40 ` Andre Przywara 2024-01-23 0:40 ` Andre Przywara 2024-01-25 14:37 ` Chen-Yu Tsai 2024-01-25 14:37 ` Chen-Yu Tsai 2024-01-25 15:09 ` Andre Przywara 2024-01-25 15:09 ` Andre Przywara 2024-01-25 15:45 ` Chen-Yu Tsai 2024-01-25 15:45 ` Chen-Yu Tsai 2024-01-22 17:05 ` [PATCH 5/7] arm64: dts: allwinner: h6: Add RX DMA channel for SPDIF Chen-Yu Tsai 2024-01-22 17:05 ` Chen-Yu Tsai 2024-01-23 0:39 ` Andre Przywara 2024-01-23 0:39 ` Andre Przywara 2024-01-23 17:52 ` Jernej Škrabec 2024-01-23 17:52 ` Jernej Škrabec 2024-01-22 17:05 ` [PATCH 6/7] arm64: dts: allwinner: h616: Add DMA controller and DMA channels Chen-Yu Tsai 2024-01-22 17:05 ` Chen-Yu Tsai 2024-01-23 0:41 ` Andre Przywara 2024-01-23 0:41 ` Andre Przywara 2024-01-22 17:05 ` [PATCH 7/7] arm64: dts: allwinner: h616: Add SPDIF device node Chen-Yu Tsai 2024-01-22 17:05 ` Chen-Yu Tsai 2024-01-23 0:43 ` Andre Przywara 2024-01-23 0:43 ` Andre Przywara 2024-01-23 17:53 ` Jernej Škrabec 2024-01-23 17:53 ` Jernej Škrabec
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20240122170518.3090814-2-wens@kernel.org \ --to=wens@kernel.org \ --cc=broonie@kernel.org \ --cc=conor+dt@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=dmaengine@vger.kernel.org \ --cc=jernej.skrabec@gmail.com \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=lgirdwood@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-sound@vger.kernel.org \ --cc=linux-sunxi@lists.linux.dev \ --cc=perex@perex.cz \ --cc=robh+dt@kernel.org \ --cc=samuel@sholland.org \ --cc=tiwai@suse.com \ --cc=vkoul@kernel.org \ --cc=wens@csie.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.