From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH v12 4/5] iommu/vt-d: pass pdev parameter for qi_check_fault() and refactor callers
Date: Thu, 8 Feb 2024 03:36:39 +0800 [thread overview]
Message-ID: <202402080321.n77hu71Y-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20240129034924.817005-5-haifeng.zhao@linux.intel.com>
References: <20240129034924.817005-5-haifeng.zhao@linux.intel.com>
TO: Ethan Zhao <haifeng.zhao@linux.intel.com>
TO: baolu.lu@linux.intel.com
TO: bhelgaas@google.com
TO: robin.murphy@arm.com
TO: jgg@ziepe.ca
CC: kevin.tian@intel.com
CC: dwmw2@infradead.org
CC: will@kernel.org
CC: lukas@wunner.de
CC: yi.l.liu@intel.com
CC: iommu@lists.linux.dev
CC: linux-kernel@vger.kernel.org
CC: linux-pci@vger.kernel.org
CC: Ethan Zhao <haifeng.zhao@linux.intel.com>
Hi Ethan,
kernel test robot noticed the following build warnings:
[auto build test WARNING on 41bccc98fb7931d63d03f326a746ac4d429c1dd3]
url: https://github.com/intel-lab-lkp/linux/commits/Ethan-Zhao/PCI-make-pci_dev_is_disconnected-helper-public-for-other-drivers/20240129-115259
base: 41bccc98fb7931d63d03f326a746ac4d429c1dd3
patch link: https://lore.kernel.org/r/20240129034924.817005-5-haifeng.zhao%40linux.intel.com
patch subject: [PATCH v12 4/5] iommu/vt-d: pass pdev parameter for qi_check_fault() and refactor callers
:::::: branch date: 10 days ago
:::::: commit date: 10 days ago
config: x86_64-randconfig-161-20240207 (https://download.01.org/0day-ci/archive/20240208/202402080321.n77hu71Y-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202402080321.n77hu71Y-lkp@intel.com/
smatch warnings:
drivers/iommu/intel/dmar.c:1533 qi_flush_dev_iotlb() error: we previously assumed 'info->dev' could be null (see line 1533)
vim +1533 drivers/iommu/intel/dmar.c
3481f21097cb56 drivers/pci/dmar.c Youquan Song 2008-10-16 1521
20da7293134024 drivers/iommu/intel/dmar.c Ethan Zhao 2024-01-28 1522 void qi_flush_dev_iotlb(struct intel_iommu *iommu,
20da7293134024 drivers/iommu/intel/dmar.c Ethan Zhao 2024-01-28 1523 struct device_domain_info *info, u64 addr,
20da7293134024 drivers/iommu/intel/dmar.c Ethan Zhao 2024-01-28 1524 unsigned int mask)
6ba6c3a4cacfd6 drivers/pci/dmar.c Yu Zhao 2009-05-18 1525 {
c830e699e08a6c drivers/iommu/intel/dmar.c Ethan Zhao 2024-01-28 1526 struct pci_dev *pdev = NULL;
20da7293134024 drivers/iommu/intel/dmar.c Ethan Zhao 2024-01-28 1527 u16 sid, qdep, pfsid;
6ba6c3a4cacfd6 drivers/pci/dmar.c Yu Zhao 2009-05-18 1528 struct qi_desc desc;
6ba6c3a4cacfd6 drivers/pci/dmar.c Yu Zhao 2009-05-18 1529
20da7293134024 drivers/iommu/intel/dmar.c Ethan Zhao 2024-01-28 1530 if (!info || !info->ats_enabled)
20da7293134024 drivers/iommu/intel/dmar.c Ethan Zhao 2024-01-28 1531 return;
20da7293134024 drivers/iommu/intel/dmar.c Ethan Zhao 2024-01-28 1532
c830e699e08a6c drivers/iommu/intel/dmar.c Ethan Zhao 2024-01-28 @1533 if (info->dev || !dev_is_pci(info->dev))
c830e699e08a6c drivers/iommu/intel/dmar.c Ethan Zhao 2024-01-28 1534 return;
c830e699e08a6c drivers/iommu/intel/dmar.c Ethan Zhao 2024-01-28 1535
c830e699e08a6c drivers/iommu/intel/dmar.c Ethan Zhao 2024-01-28 1536 pdev = to_pci_dev(info->dev);
20da7293134024 drivers/iommu/intel/dmar.c Ethan Zhao 2024-01-28 1537 sid = info->bus << 8 | info->devfn;
20da7293134024 drivers/iommu/intel/dmar.c Ethan Zhao 2024-01-28 1538 qdep = info->ats_qdep;
20da7293134024 drivers/iommu/intel/dmar.c Ethan Zhao 2024-01-28 1539 pfsid = info->pfsid;
0f5432a9b83984 drivers/iommu/intel/dmar.c Lu Baolu 2023-11-22 1540 /*
0f5432a9b83984 drivers/iommu/intel/dmar.c Lu Baolu 2023-11-22 1541 * VT-d spec, section 4.3:
0f5432a9b83984 drivers/iommu/intel/dmar.c Lu Baolu 2023-11-22 1542 *
0f5432a9b83984 drivers/iommu/intel/dmar.c Lu Baolu 2023-11-22 1543 * Software is recommended to not submit any Device-TLB invalidation
0f5432a9b83984 drivers/iommu/intel/dmar.c Lu Baolu 2023-11-22 1544 * requests while address remapping hardware is disabled.
0f5432a9b83984 drivers/iommu/intel/dmar.c Lu Baolu 2023-11-22 1545 */
0f5432a9b83984 drivers/iommu/intel/dmar.c Lu Baolu 2023-11-22 1546 if (!(iommu->gcmd & DMA_GCMD_TE))
0f5432a9b83984 drivers/iommu/intel/dmar.c Lu Baolu 2023-11-22 1547 return;
0f5432a9b83984 drivers/iommu/intel/dmar.c Lu Baolu 2023-11-22 1548
6ba6c3a4cacfd6 drivers/pci/dmar.c Yu Zhao 2009-05-18 1549 if (mask) {
c8acb28b331364 drivers/iommu/dmar.c Joerg Roedel 2017-08-11 1550 addr |= (1ULL << (VTD_PAGE_SHIFT + mask - 1)) - 1;
5d308fc1ecf535 drivers/iommu/dmar.c Lu Baolu 2018-12-10 1551 desc.qw1 = QI_DEV_IOTLB_ADDR(addr) | QI_DEV_IOTLB_SIZE;
6ba6c3a4cacfd6 drivers/pci/dmar.c Yu Zhao 2009-05-18 1552 } else
5d308fc1ecf535 drivers/iommu/dmar.c Lu Baolu 2018-12-10 1553 desc.qw1 = QI_DEV_IOTLB_ADDR(addr);
6ba6c3a4cacfd6 drivers/pci/dmar.c Yu Zhao 2009-05-18 1554
6ba6c3a4cacfd6 drivers/pci/dmar.c Yu Zhao 2009-05-18 1555 if (qdep >= QI_DEV_IOTLB_MAX_INVS)
6ba6c3a4cacfd6 drivers/pci/dmar.c Yu Zhao 2009-05-18 1556 qdep = 0;
6ba6c3a4cacfd6 drivers/pci/dmar.c Yu Zhao 2009-05-18 1557
5d308fc1ecf535 drivers/iommu/dmar.c Lu Baolu 2018-12-10 1558 desc.qw0 = QI_DEV_IOTLB_SID(sid) | QI_DEV_IOTLB_QDEP(qdep) |
1c48db44924298 drivers/iommu/dmar.c Jacob Pan 2018-06-07 1559 QI_DIOTLB_TYPE | QI_DEV_IOTLB_PFSID(pfsid);
5d308fc1ecf535 drivers/iommu/dmar.c Lu Baolu 2018-12-10 1560 desc.qw2 = 0;
5d308fc1ecf535 drivers/iommu/dmar.c Lu Baolu 2018-12-10 1561 desc.qw3 = 0;
6ba6c3a4cacfd6 drivers/pci/dmar.c Yu Zhao 2009-05-18 1562
c830e699e08a6c drivers/iommu/intel/dmar.c Ethan Zhao 2024-01-28 1563 qi_submit_sync(iommu, &desc, 1, 0, pdev);
6ba6c3a4cacfd6 drivers/pci/dmar.c Yu Zhao 2009-05-18 1564 }
6ba6c3a4cacfd6 drivers/pci/dmar.c Yu Zhao 2009-05-18 1565
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2024-02-07 19:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-07 19:36 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-01-29 3:49 [PATCH v12 0/5] fix vt-d hard lockup when hotplug ATS capable device Ethan Zhao
2024-01-29 3:49 ` [PATCH v12 4/5] iommu/vt-d: pass pdev parameter for qi_check_fault() and refactor callers Ethan Zhao
2024-01-29 8:58 ` Tian, Kevin
2024-01-30 7:30 ` Ethan Zhao
2024-02-08 7:15 ` Dan Carpenter
2024-02-09 2:08 ` Ethan Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202402080321.n77hu71Y-lkp@intel.com \
--to=lkp@intel.com \
--cc=error27@gmail.com \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.