From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH 4/4] Enable Driver compilation in crypto Kconfig and Makefile file
Date: Mon, 11 Mar 2024 10:38:13 +0800 [thread overview]
Message-ID: <202403111044.eqxBgcDl-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20240305112831.3380896-5-pavitrakumarm@vayavyalabs.com>
References: <20240305112831.3380896-5-pavitrakumarm@vayavyalabs.com>
TO: Pavitrakumar M <pavitrakumarm@vayavyalabs.com>
TO: herbert@gondor.apana.org.au
TO: linux-crypto@vger.kernel.org
CC: Ruud.Derwig@synopsys.com
CC: manjunath.hadli@vayavyalabs.com
CC: Pavitrakumar M <pavitrakumarm@vayavyalabs.com>
Hi Pavitrakumar,
kernel test robot noticed the following build warnings:
[auto build test WARNING on herbert-cryptodev-2.6/master]
[also build test WARNING on herbert-crypto-2.6/master linus/master v6.8 next-20240308]
[cannot apply to xilinx-xlnx/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Pavitrakumar-M/Add-SPAcc-driver-to-Linux-kernel/20240305-193337
base: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
patch link: https://lore.kernel.org/r/20240305112831.3380896-5-pavitrakumarm%40vayavyalabs.com
patch subject: [PATCH 4/4] Enable Driver compilation in crypto Kconfig and Makefile file
:::::: branch date: 6 days ago
:::::: commit date: 6 days ago
config: i386-randconfig-141-20240308 (https://download.01.org/0day-ci/archive/20240311/202403111044.eqxBgcDl-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202403111044.eqxBgcDl-lkp@intel.com/
New smatch warnings:
drivers/crypto/dwc-spacc/spacc_skcipher.c:176 spacc_cipher_cb() warn: was && intended here instead of ||?
drivers/crypto/dwc-spacc/spacc_aead.c:1131 spacc_aead_process() error: uninitialized symbol 'ptaadsize'.
Old smatch warnings:
drivers/crypto/dwc-spacc/spacc_skcipher.c:528 spacc_cipher_process() warn: bitwise AND condition is false here
drivers/crypto/dwc-spacc/spacc_skcipher.c:751 probe_ciphers() warn: inconsistent indenting
drivers/crypto/dwc-spacc/spacc_skcipher.c:762 probe_ciphers() warn: possible memory leak of 'salg'
drivers/crypto/dwc-spacc/spacc_aead.c:1165 spacc_aead_process() error: uninitialized symbol 'ptaadsize'.
vim +176 drivers/crypto/dwc-spacc/spacc_skcipher.c
6ad822cec22644 Pavitrakumar M 2024-03-05 145
6ad822cec22644 Pavitrakumar M 2024-03-05 146 static void spacc_cipher_cb(void *spacc, void *tfm)
6ad822cec22644 Pavitrakumar M 2024-03-05 147 {
6ad822cec22644 Pavitrakumar M 2024-03-05 148 struct cipher_cb_data *cb = tfm;
6ad822cec22644 Pavitrakumar M 2024-03-05 149 int err = -1, rc;
6ad822cec22644 Pavitrakumar M 2024-03-05 150 int total_len;
6ad822cec22644 Pavitrakumar M 2024-03-05 151 struct spacc_crypto_reqctx *ctx = skcipher_request_ctx(cb->req);
6ad822cec22644 Pavitrakumar M 2024-03-05 152
6ad822cec22644 Pavitrakumar M 2024-03-05 153 u32 status_reg = readl(cb->spacc->regmap + SPACC_REG_STATUS);
6ad822cec22644 Pavitrakumar M 2024-03-05 154 u32 status_ret = (status_reg >> 24) & 0x03;
6ad822cec22644 Pavitrakumar M 2024-03-05 155
6ad822cec22644 Pavitrakumar M 2024-03-05 156 if (ctx->mode == CRYPTO_MODE_DES_CBC ||
6ad822cec22644 Pavitrakumar M 2024-03-05 157 ctx->mode == CRYPTO_MODE_3DES_CBC) {
6ad822cec22644 Pavitrakumar M 2024-03-05 158 rc = spacc_read_context(cb->spacc, cb->tctx->handle,
6ad822cec22644 Pavitrakumar M 2024-03-05 159 SPACC_CRYPTO_OPERATION, NULL, 0,
6ad822cec22644 Pavitrakumar M 2024-03-05 160 cb->req->iv, 8);
6ad822cec22644 Pavitrakumar M 2024-03-05 161 } else if (ctx->mode != CRYPTO_MODE_DES_ECB &&
6ad822cec22644 Pavitrakumar M 2024-03-05 162 ctx->mode != CRYPTO_MODE_3DES_ECB &&
6ad822cec22644 Pavitrakumar M 2024-03-05 163 ctx->mode != CRYPTO_MODE_SM4_ECB &&
6ad822cec22644 Pavitrakumar M 2024-03-05 164 ctx->mode != CRYPTO_MODE_AES_ECB &&
6ad822cec22644 Pavitrakumar M 2024-03-05 165 ctx->mode != CRYPTO_MODE_SM4_XTS &&
6ad822cec22644 Pavitrakumar M 2024-03-05 166 ctx->mode != CRYPTO_MODE_KASUMI_ECB) {
6ad822cec22644 Pavitrakumar M 2024-03-05 167 if (status_ret == 0x3) {
6ad822cec22644 Pavitrakumar M 2024-03-05 168 err = -EINVAL;
6ad822cec22644 Pavitrakumar M 2024-03-05 169 goto REQ_DST_CP_SKIP;
6ad822cec22644 Pavitrakumar M 2024-03-05 170 }
6ad822cec22644 Pavitrakumar M 2024-03-05 171 rc = spacc_read_context(cb->spacc, cb->tctx->handle,
6ad822cec22644 Pavitrakumar M 2024-03-05 172 SPACC_CRYPTO_OPERATION, NULL, 0,
6ad822cec22644 Pavitrakumar M 2024-03-05 173 cb->req->iv, 16);
6ad822cec22644 Pavitrakumar M 2024-03-05 174 }
6ad822cec22644 Pavitrakumar M 2024-03-05 175
6ad822cec22644 Pavitrakumar M 2024-03-05 @176 if (ctx->mode != CRYPTO_MODE_DES_ECB ||
6ad822cec22644 Pavitrakumar M 2024-03-05 177 ctx->mode != CRYPTO_MODE_DES_CBC ||
6ad822cec22644 Pavitrakumar M 2024-03-05 178 ctx->mode != CRYPTO_MODE_3DES_ECB ||
6ad822cec22644 Pavitrakumar M 2024-03-05 179 ctx->mode != CRYPTO_MODE_3DES_CBC) {
6ad822cec22644 Pavitrakumar M 2024-03-05 180 if (status_ret == 0x03) {
6ad822cec22644 Pavitrakumar M 2024-03-05 181 err = -EINVAL;
6ad822cec22644 Pavitrakumar M 2024-03-05 182 goto REQ_DST_CP_SKIP;
6ad822cec22644 Pavitrakumar M 2024-03-05 183 }
6ad822cec22644 Pavitrakumar M 2024-03-05 184 }
6ad822cec22644 Pavitrakumar M 2024-03-05 185
6ad822cec22644 Pavitrakumar M 2024-03-05 186 if (ctx->mode == CRYPTO_MODE_SM4_ECB && status_ret == 0x03) {
6ad822cec22644 Pavitrakumar M 2024-03-05 187 err = -EINVAL;
6ad822cec22644 Pavitrakumar M 2024-03-05 188 goto REQ_DST_CP_SKIP;
6ad822cec22644 Pavitrakumar M 2024-03-05 189 }
6ad822cec22644 Pavitrakumar M 2024-03-05 190
6ad822cec22644 Pavitrakumar M 2024-03-05 191 total_len = cb->req->cryptlen;
6ad822cec22644 Pavitrakumar M 2024-03-05 192 if (ctx->mode == CRYPTO_MODE_SM4_XTS && total_len != 16) {
6ad822cec22644 Pavitrakumar M 2024-03-05 193 if (status_ret == 0x03) {
6ad822cec22644 Pavitrakumar M 2024-03-05 194 err = -EINVAL;
6ad822cec22644 Pavitrakumar M 2024-03-05 195 goto REQ_DST_CP_SKIP;
6ad822cec22644 Pavitrakumar M 2024-03-05 196 }
6ad822cec22644 Pavitrakumar M 2024-03-05 197 }
6ad822cec22644 Pavitrakumar M 2024-03-05 198
6ad822cec22644 Pavitrakumar M 2024-03-05 199 dma_sync_sg_for_cpu(cb->tctx->dev, cb->req->dst, ctx->dst_nents,
6ad822cec22644 Pavitrakumar M 2024-03-05 200 DMA_FROM_DEVICE);
6ad822cec22644 Pavitrakumar M 2024-03-05 201
6ad822cec22644 Pavitrakumar M 2024-03-05 202 err = cb->spacc->job[cb->new_handle].job_err;
6ad822cec22644 Pavitrakumar M 2024-03-05 203 REQ_DST_CP_SKIP:
6ad822cec22644 Pavitrakumar M 2024-03-05 204 spacc_cipher_cleanup_dma(cb->tctx->dev, cb->req);
6ad822cec22644 Pavitrakumar M 2024-03-05 205 spacc_close(cb->spacc, cb->new_handle);
6ad822cec22644 Pavitrakumar M 2024-03-05 206
6ad822cec22644 Pavitrakumar M 2024-03-05 207 /* call complete */
6ad822cec22644 Pavitrakumar M 2024-03-05 208 skcipher_request_complete(cb->req, err);
6ad822cec22644 Pavitrakumar M 2024-03-05 209 }
6ad822cec22644 Pavitrakumar M 2024-03-05 210
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2024-03-11 2:39 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-11 2:38 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-03-13 5:08 [PATCH 4/4] Enable Driver compilation in crypto Kconfig and Makefile file kernel test robot
2024-03-10 15:40 kernel test robot
2024-03-07 14:17 kernel test robot
2024-03-05 11:28 [PATCH 0/4] Add spacc crypto driver support Pavitrakumar M
2024-03-05 11:28 ` [PATCH 4/4] Enable Driver compilation in crypto Kconfig and Makefile file Pavitrakumar M
2024-03-06 4:08 ` kernel test robot
2024-03-06 6:43 ` kernel test robot
2024-03-06 6:43 ` kernel test robot
2024-03-06 7:26 ` kernel test robot
2024-03-07 14:24 ` Dan Carpenter
2024-03-11 7:40 ` Dan Carpenter
2024-03-13 10:43 ` kernel test robot
2023-11-14 5:05 [PATCH 0/4] Add crypto spacc driver to support cipher, hash and aead Pavitrakumar M
2023-11-14 5:05 ` [PATCH 4/4] Enable Driver compilation in crypto Kconfig and Makefile file Pavitrakumar M
2023-11-15 1:57 ` kernel test robot
2023-11-14 10:40 ` kernel test robot
2023-11-15 1:58 ` kernel test robot
2023-11-14 11:45 ` kernel test robot
2023-11-15 2:00 ` kernel test robot
2023-11-14 13:42 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202403111044.eqxBgcDl-lkp@intel.com \
--to=lkp@intel.com \
--cc=error27@gmail.com \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.