All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 15/22] drm/i915: Introduce intel_crtc_joined_pipe_mask()
Date: Fri, 29 Mar 2024 03:12:47 +0200	[thread overview]
Message-ID: <20240329011254.24160-16-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20240329011254.24160-1-ville.syrjala@linux.intel.com>

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Add a small helper to compute the set of pipes that the current
crtc is using.

And we have at least one trivial place in
intel_ddi_update_active_dpll() where we can use it
immediately, so let's do that.

v2: Use the name 'pipe_crtc' for the per-pipe crtc pointer

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_ddi.c     | 11 +++++------
 drivers/gpu/drm/i915/display/intel_display.c |  7 +++++++
 drivers/gpu/drm/i915/display/intel_display.h |  1 +
 3 files changed, 13 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
index fa6fe9ec8027..24a9be2a217f 100644
--- a/drivers/gpu/drm/i915/display/intel_ddi.c
+++ b/drivers/gpu/drm/i915/display/intel_ddi.c
@@ -3463,18 +3463,17 @@ void intel_ddi_update_active_dpll(struct intel_atomic_state *state,
 				  struct intel_crtc *crtc)
 {
 	struct drm_i915_private *i915 = to_i915(encoder->base.dev);
-	struct intel_crtc_state *crtc_state =
+	const struct intel_crtc_state *crtc_state =
 		intel_atomic_get_new_crtc_state(state, crtc);
-	struct intel_crtc *slave_crtc;
+	struct intel_crtc *pipe_crtc;
 
 	/* FIXME: Add MTL pll_mgr */
 	if (DISPLAY_VER(i915) >= 14 || !intel_encoder_is_tc(encoder))
 		return;
 
-	intel_update_active_dpll(state, crtc, encoder);
-	for_each_intel_crtc_in_pipe_mask(&i915->drm, slave_crtc,
-					 intel_crtc_bigjoiner_slave_pipes(crtc_state))
-		intel_update_active_dpll(state, slave_crtc, encoder);
+	for_each_intel_crtc_in_pipe_mask(&i915->drm, pipe_crtc,
+					 intel_crtc_joined_pipe_mask(crtc_state))
+		intel_update_active_dpll(state, pipe_crtc, encoder);
 }
 
 static void
diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index 6197b62dac55..58ee40786d5c 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -275,6 +275,13 @@ static int intel_bigjoiner_num_pipes(const struct intel_crtc_state *crtc_state)
 	return hweight8(crtc_state->bigjoiner_pipes);
 }
 
+u8 intel_crtc_joined_pipe_mask(const struct intel_crtc_state *crtc_state)
+{
+	struct intel_crtc *crtc = to_intel_crtc(crtc_state->uapi.crtc);
+
+	return BIT(crtc->pipe) | crtc_state->bigjoiner_pipes;
+}
+
 struct intel_crtc *intel_master_crtc(const struct intel_crtc_state *crtc_state)
 {
 	struct drm_i915_private *i915 = to_i915(crtc_state->uapi.crtc->dev);
diff --git a/drivers/gpu/drm/i915/display/intel_display.h b/drivers/gpu/drm/i915/display/intel_display.h
index 986ec77490de..31ee34c59844 100644
--- a/drivers/gpu/drm/i915/display/intel_display.h
+++ b/drivers/gpu/drm/i915/display/intel_display.h
@@ -408,6 +408,7 @@ intel_cpu_transcoder_mode_valid(struct drm_i915_private *i915,
 enum phy intel_port_to_phy(struct drm_i915_private *i915, enum port port);
 bool is_trans_port_sync_mode(const struct intel_crtc_state *state);
 bool is_trans_port_sync_master(const struct intel_crtc_state *state);
+u8 intel_crtc_joined_pipe_mask(const struct intel_crtc_state *crtc_state);
 bool intel_crtc_is_bigjoiner_slave(const struct intel_crtc_state *crtc_state);
 bool intel_crtc_is_bigjoiner_master(const struct intel_crtc_state *crtc_state);
 u8 intel_crtc_bigjoiner_slave_pipes(const struct intel_crtc_state *crtc_state);
-- 
2.43.2


  parent reply	other threads:[~2024-03-29  1:13 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-29  1:12 [PATCH 00/22] drm/i915: Bigjoiner modeset sequence redesign and MST support Ville Syrjala
2024-03-29  1:12 ` [PATCH 01/22] drm/i915: Disable port sync when bigjoiner is used Ville Syrjala
2024-04-01  5:57   ` Kulkarni, Vandita
2024-03-29  1:12 ` [PATCH 02/22] drm/i915: Fix intel_modeset_pipe_config_late() for bigjoiner Ville Syrjala
2024-04-01  9:23   ` Kulkarni, Vandita
2024-03-29  1:12 ` [PATCH 03/22] drm/i915: Disable live M/N updates when using bigjoiner Ville Syrjala
2024-04-01 10:32   ` Murthy, Arun R
2024-03-29  1:12 ` [PATCH 04/22] drm/i915/vrr: Disable VRR " Ville Syrjala
2024-04-01 10:04   ` Kulkarni, Vandita
2024-03-29  1:12 ` [PATCH 05/22] drm/i915: Remove DRM_MODE_FLAG_DBLSCAN checks from .mode_valid() hooks Ville Syrjala
2024-04-01 11:25   ` Kulkarni, Vandita
2024-03-29  1:12 ` [PATCH 06/22] drm/i915: Shuffle DP .mode_valid() checks Ville Syrjala
2024-04-01 10:35   ` Kulkarni, Vandita
2024-03-29  1:12 ` [PATCH 07/22] drm/i915: Clean up glk_pipe_scaler_clock_gating_wa() Ville Syrjala
2024-04-01 11:08   ` Kulkarni, Vandita
2024-03-29  1:12 ` [PATCH 08/22] drm/i915: Extract glk_need_scaler_clock_gating_wa() Ville Syrjala
2024-04-01 11:09   ` Kulkarni, Vandita
2024-03-29  1:12 ` [PATCH 09/22] drm/i915: s/intel_dp_can_bigjoiner()/intel_dp_can_bigjoiner()/ Ville Syrjala
2024-04-01 10:01   ` Kulkarni, Vandita
2024-03-29  1:12 ` [PATCH 10/22] drm/i915: Extract intel_dp_joiner_needs_dsc() Ville Syrjala
2024-04-01  9:22   ` Shankar, Uma
2024-03-29  1:12 ` [PATCH 11/22] drm/i915/mst: Check intel_dp_joiner_needs_dsc() Ville Syrjala
2024-04-01  9:28   ` Shankar, Uma
2024-03-29  1:12 ` [PATCH 12/22] drm/i915: Pass connector to intel_dp_need_bigjoiner() Ville Syrjala
2024-04-01  9:39   ` Shankar, Uma
2024-03-29  1:12 ` [PATCH 13/22] drm/i915/mst: Limit MST+DSC to TGL+ Ville Syrjala
2024-04-01  9:44   ` Shankar, Uma
2024-03-29  1:12 ` [PATCH 14/22] drm/i915/mst: Reject FEC+MST on ICL Ville Syrjala
2024-04-01  9:45   ` Shankar, Uma
2024-03-29  1:12 ` Ville Syrjala [this message]
2024-04-01 10:20   ` [PATCH 15/22] drm/i915: Introduce intel_crtc_joined_pipe_mask() Murthy, Arun R
2024-03-29  1:12 ` [PATCH 16/22] drm/i915: Extract intel_ddi_post_disable_hdmi_or_sst() Ville Syrjala
2024-04-01 10:17   ` Murthy, Arun R
2024-03-29  1:12 ` [PATCH 17/22] drm/i915: Utilize intel_crtc_joined_pipe_mask() more Ville Syrjala
2024-04-01  6:52   ` Murthy, Arun R
2024-03-29  1:12 ` [PATCH 18/22] drm/i915: Handle joined pipes inside hsw_crtc_disable() Ville Syrjala
2024-04-01  6:46   ` Murthy, Arun R
2024-04-02 19:50     ` Ville Syrjälä
2024-04-03  4:32       ` Murthy, Arun R
2024-03-29  1:12 ` [PATCH 19/22] drm/i915: Handle joined pipes inside hsw_crtc_enable() Ville Syrjala
2024-03-29  1:12 ` [PATCH 20/22] drm/i915/mst: Add bigjoiner handling to MST modeset sequence Ville Syrjala
2024-04-01  6:33   ` Murthy, Arun R
2024-03-29  1:12 ` [PATCH 21/22] drm/i915: Allow bigjoiner for MST Ville Syrjala
2024-04-01  6:26   ` Murthy, Arun R
2024-03-29  1:12 ` [PATCH 22/22] drm/i915: Use debugfs_create_bool() for "i915_bigjoiner_force_enable" Ville Syrjala
2024-04-01  5:08   ` Murthy, Arun R
2024-04-02  7:37   ` Srinivas, Vidya
2024-03-29  6:36 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Bigjoiner modeset sequence redesign and MST support Patchwork
2024-03-29  6:36 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-03-29  6:49 ` ✓ Fi.CI.BAT: success " Patchwork
2024-03-30  6:58 ` ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240329011254.24160-16-ville.syrjala@linux.intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.