From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: drivers/of/unittest.c:1195 of_unittest_reg() error: uninitialized symbol 'addr'.
Date: Sun, 12 May 2024 06:04:03 +0800 [thread overview]
Message-ID: <202405120620.HFCq9U8K-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Frank Rowand <frowand.list@gmail.com>
CC: Rob Herring <robh@kernel.org>
CC: Stephen Boyd <sboyd@kernel.org>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: cf87f46fd34d6c19283d9625a7822f20d90b64a4
commit: 7b937cc243e5b1df8780a0aa743ce800df6c68d1 of: Create of_root if no dtb provided by firmware
date: 9 weeks ago
:::::: branch date: 24 hours ago
:::::: commit date: 9 weeks ago
config: sparc-randconfig-r081-20240512 (https://download.01.org/0day-ci/archive/20240512/202405120620.HFCq9U8K-lkp@intel.com/config)
compiler: sparc64-linux-gcc (GCC) 13.2.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202405120620.HFCq9U8K-lkp@intel.com/
New smatch warnings:
drivers/of/unittest.c:1195 of_unittest_reg() error: uninitialized symbol 'addr'.
Old smatch warnings:
drivers/of/unittest.c:854 of_unittest_changeset() error: potential null dereference 'n1'. (__of_node_dup returns null)
drivers/of/unittest.c:855 of_unittest_changeset() error: potential null dereference 'n2'. (__of_node_dup returns null)
drivers/of/unittest.c:856 of_unittest_changeset() error: potential null dereference 'n21'. (__of_node_dup returns null)
drivers/of/unittest.c:1283 of_unittest_parse_interrupts() warn: bitwise AND condition is false here
drivers/of/unittest.c:1360 of_unittest_parse_interrupts_extended() warn: bitwise AND condition is false here
drivers/of/unittest.c:1522 of_unittest_platform_populate() warn: bitwise AND condition is false here
vim +/addr +1195 drivers/of/unittest.c
3d5089c4263d35 Rob Herring 2023-03-28 1179
ff61bacd77f258 Rob Herring 2023-03-28 1180 static void __init of_unittest_reg(void)
ff61bacd77f258 Rob Herring 2023-03-28 1181 {
ff61bacd77f258 Rob Herring 2023-03-28 1182 struct device_node *np;
ff61bacd77f258 Rob Herring 2023-03-28 1183 int ret;
ff61bacd77f258 Rob Herring 2023-03-28 1184 u64 addr, size;
ff61bacd77f258 Rob Herring 2023-03-28 1185
ff61bacd77f258 Rob Herring 2023-03-28 1186 np = of_find_node_by_path("/testcase-data/address-tests/bus@80000000/device@1000");
ff61bacd77f258 Rob Herring 2023-03-28 1187 if (!np) {
ff61bacd77f258 Rob Herring 2023-03-28 1188 pr_err("missing testcase data\n");
ff61bacd77f258 Rob Herring 2023-03-28 1189 return;
ff61bacd77f258 Rob Herring 2023-03-28 1190 }
ff61bacd77f258 Rob Herring 2023-03-28 1191
ff61bacd77f258 Rob Herring 2023-03-28 1192 ret = of_property_read_reg(np, 0, &addr, &size);
ff61bacd77f258 Rob Herring 2023-03-28 1193 unittest(!ret, "of_property_read_reg(%pOF) returned error %d\n",
ff61bacd77f258 Rob Herring 2023-03-28 1194 np, ret);
ff61bacd77f258 Rob Herring 2023-03-28 @1195 unittest(addr == 0x1000, "of_property_read_reg(%pOF) untranslated address (%llx) incorrect\n",
ff61bacd77f258 Rob Herring 2023-03-28 1196 np, addr);
ff61bacd77f258 Rob Herring 2023-03-28 1197
ff61bacd77f258 Rob Herring 2023-03-28 1198 of_node_put(np);
ff61bacd77f258 Rob Herring 2023-03-28 1199 }
ff61bacd77f258 Rob Herring 2023-03-28 1200
:::::: The code at line 1195 was first introduced by commit
:::::: ff61bacd77f258bd2ed145efb69e5449b115d4fe of/address: Add of_property_read_reg() helper
:::::: TO: Rob Herring <robh@kernel.org>
:::::: CC: Rob Herring <robh@kernel.org>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2024-05-11 22:04 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202405120620.HFCq9U8K-lkp@intel.com \
--to=lkp@intel.com \
--cc=error27@gmail.com \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.