From: William Breathitt Gray <vilhelm.gray@gmail.com> To: jic23@kernel.org Cc: kernel@pengutronix.de, linux-stm32@st-md-mailman.stormreply.com, a.fatoum@pengutronix.de, kamel.bouhara@bootlin.com, gwendal@chromium.org, alexandre.belloni@bootlin.com, david@lechnology.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, syednwaris@gmail.com, patrick.havelange@essensium.com, fabrice.gasnier@st.com, mcoquelin.stm32@gmail.com, alexandre.torgue@st.com, o.rempel@pengutronix.de, William Breathitt Gray <vilhelm.gray@gmail.com> Subject: [PATCH v10 05/33] counter: 104-quad-8: Annotate hardware config module parameter Date: Fri, 19 Mar 2021 20:00:24 +0900 [thread overview] Message-ID: <203f1b6084ed86a6696eb422bcadc0955c6427bb.1616150619.git.vilhelm.gray@gmail.com> (raw) In-Reply-To: <cover.1616150619.git.vilhelm.gray@gmail.com> When the kernel is running in secure boot mode, we lock down the kernel to prevent userspace from modifying the running kernel image. Whilst this includes prohibiting access to things like /dev/mem, it must also prevent access by means of configuring driver modules in such a way as to cause a device to access or modify the kernel image. To this end, annotate module_param* statements that refer to hardware configuration and indicate for future reference what type of parameter they specify. The parameter parser in the core sees this information and can skip such parameters with an error message if the kernel is locked down. The module initialisation then runs as normal, but just sees whatever the default values for those parameters is. Note that we do still need to do the module initialisation because some drivers have viable defaults set in case parameters aren't specified and some drivers support automatic configuration (e.g. PNP or PCI) in addition to manually coded parameters. This patch annotates the 104-QUAD-8 driver. Cc: Syed Nayyar Waris <syednwaris@gmail.com> Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com> --- drivers/counter/104-quad-8.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/counter/104-quad-8.c b/drivers/counter/104-quad-8.c index 233a3acc1377..0fd61cc82d30 100644 --- a/drivers/counter/104-quad-8.c +++ b/drivers/counter/104-quad-8.c @@ -21,7 +21,7 @@ static unsigned int base[max_num_isa_dev(QUAD8_EXTENT)]; static unsigned int num_quad8; -module_param_array(base, uint, &num_quad8, 0); +module_param_hw_array(base, uint, ioport, &num_quad8, 0); MODULE_PARM_DESC(base, "ACCES 104-QUAD-8 base addresses"); #define QUAD8_NUM_COUNTERS 8 -- 2.30.2
WARNING: multiple messages have this Message-ID (diff)
From: William Breathitt Gray <vilhelm.gray@gmail.com> To: jic23@kernel.org Cc: kernel@pengutronix.de, linux-stm32@st-md-mailman.stormreply.com, a.fatoum@pengutronix.de, kamel.bouhara@bootlin.com, gwendal@chromium.org, alexandre.belloni@bootlin.com, david@lechnology.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, syednwaris@gmail.com, patrick.havelange@essensium.com, fabrice.gasnier@st.com, mcoquelin.stm32@gmail.com, alexandre.torgue@st.com, o.rempel@pengutronix.de, William Breathitt Gray <vilhelm.gray@gmail.com> Subject: [PATCH v10 05/33] counter: 104-quad-8: Annotate hardware config module parameter Date: Fri, 19 Mar 2021 20:00:24 +0900 [thread overview] Message-ID: <203f1b6084ed86a6696eb422bcadc0955c6427bb.1616150619.git.vilhelm.gray@gmail.com> (raw) In-Reply-To: <cover.1616150619.git.vilhelm.gray@gmail.com> When the kernel is running in secure boot mode, we lock down the kernel to prevent userspace from modifying the running kernel image. Whilst this includes prohibiting access to things like /dev/mem, it must also prevent access by means of configuring driver modules in such a way as to cause a device to access or modify the kernel image. To this end, annotate module_param* statements that refer to hardware configuration and indicate for future reference what type of parameter they specify. The parameter parser in the core sees this information and can skip such parameters with an error message if the kernel is locked down. The module initialisation then runs as normal, but just sees whatever the default values for those parameters is. Note that we do still need to do the module initialisation because some drivers have viable defaults set in case parameters aren't specified and some drivers support automatic configuration (e.g. PNP or PCI) in addition to manually coded parameters. This patch annotates the 104-QUAD-8 driver. Cc: Syed Nayyar Waris <syednwaris@gmail.com> Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com> --- drivers/counter/104-quad-8.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/counter/104-quad-8.c b/drivers/counter/104-quad-8.c index 233a3acc1377..0fd61cc82d30 100644 --- a/drivers/counter/104-quad-8.c +++ b/drivers/counter/104-quad-8.c @@ -21,7 +21,7 @@ static unsigned int base[max_num_isa_dev(QUAD8_EXTENT)]; static unsigned int num_quad8; -module_param_array(base, uint, &num_quad8, 0); +module_param_hw_array(base, uint, ioport, &num_quad8, 0); MODULE_PARM_DESC(base, "ACCES 104-QUAD-8 base addresses"); #define QUAD8_NUM_COUNTERS 8 -- 2.30.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-03-19 11:02 UTC|newest] Thread overview: 109+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-19 11:00 [PATCH v10 00/33] Introduce the Counter character device interface William Breathitt Gray 2021-03-19 11:00 ` William Breathitt Gray 2021-03-19 11:00 ` [PATCH v10 01/33] docs: counter: Consolidate Counter sysfs attributes documentation William Breathitt Gray 2021-03-19 11:00 ` William Breathitt Gray 2021-03-19 11:00 ` [PATCH v10 02/33] docs: counter: Fix spelling William Breathitt Gray 2021-03-19 11:00 ` William Breathitt Gray 2021-03-19 11:00 ` [PATCH v10 03/33] counter: 104-quad-8: Remove pointless comment William Breathitt Gray 2021-03-19 11:00 ` William Breathitt Gray 2021-04-15 15:13 ` Syed Nayyar Waris 2021-04-15 15:13 ` Syed Nayyar Waris 2021-03-19 11:00 ` [PATCH v10 04/33] counter: 104-quad-8: Return error when invalid mode during ceiling_write William Breathitt Gray 2021-03-19 11:00 ` William Breathitt Gray 2021-04-15 15:14 ` Syed Nayyar Waris 2021-04-15 15:14 ` Syed Nayyar Waris 2021-03-19 11:00 ` William Breathitt Gray [this message] 2021-03-19 11:00 ` [PATCH v10 05/33] counter: 104-quad-8: Annotate hardware config module parameter William Breathitt Gray 2021-04-15 15:15 ` Syed Nayyar Waris 2021-04-15 15:15 ` Syed Nayyar Waris 2021-03-19 11:00 ` [PATCH v10 06/33] counter: 104-quad-8: Add const qualifiers for quad8_preset_register_set William Breathitt Gray 2021-03-19 11:00 ` William Breathitt Gray 2021-04-15 15:16 ` Syed Nayyar Waris 2021-04-15 15:16 ` Syed Nayyar Waris 2021-03-19 11:00 ` [PATCH v10 07/33] counter: 104-quad-8: Add const qualifier for functions_list array William Breathitt Gray 2021-03-19 11:00 ` William Breathitt Gray 2021-04-15 15:17 ` Syed Nayyar Waris 2021-04-15 15:17 ` Syed Nayyar Waris 2021-03-19 11:00 ` [PATCH v10 08/33] counter: interrupt-cnt: " William Breathitt Gray 2021-03-19 11:00 ` William Breathitt Gray 2021-03-19 11:00 ` [PATCH v10 09/33] counter: microchip-tcb-capture: " William Breathitt Gray 2021-03-19 11:00 ` William Breathitt Gray 2021-03-19 11:00 ` [PATCH v10 10/33] counter: stm32-lptimer-cnt: " William Breathitt Gray 2021-03-19 11:00 ` William Breathitt Gray 2021-03-22 16:22 ` [Linux-stm32] " Fabrice Gasnier 2021-03-22 16:22 ` Fabrice Gasnier 2021-03-19 11:00 ` [PATCH v10 11/33] counter: stm32-timer-cnt: " William Breathitt Gray 2021-03-19 11:00 ` William Breathitt Gray 2021-03-22 16:22 ` [Linux-stm32] " Fabrice Gasnier 2021-03-22 16:22 ` Fabrice Gasnier 2021-03-19 11:00 ` [PATCH v10 12/33] counter: 104-quad-8: Add const qualifier for actions_list array William Breathitt Gray 2021-03-19 11:00 ` William Breathitt Gray 2021-04-15 15:18 ` Syed Nayyar Waris 2021-04-15 15:18 ` Syed Nayyar Waris 2021-03-19 11:00 ` [PATCH v10 13/33] counter: ftm-quaddec: " William Breathitt Gray 2021-03-19 11:00 ` William Breathitt Gray 2021-03-19 11:00 ` [PATCH v10 14/33] counter: interrupt-cnt: " William Breathitt Gray 2021-03-19 11:00 ` William Breathitt Gray 2021-03-19 11:00 ` [PATCH v10 15/33] counter: microchip-tcb-capture: " William Breathitt Gray 2021-03-19 11:00 ` William Breathitt Gray 2021-03-19 11:00 ` [PATCH v10 16/33] counter: stm32-lptimer-cnt: " William Breathitt Gray 2021-03-19 11:00 ` William Breathitt Gray 2021-03-22 16:23 ` [Linux-stm32] " Fabrice Gasnier 2021-03-22 16:23 ` Fabrice Gasnier 2021-03-19 11:00 ` [PATCH v10 17/33] counter: stm32-timer-cnt: " William Breathitt Gray 2021-03-19 11:00 ` William Breathitt Gray 2021-03-22 16:24 ` [Linux-stm32] " Fabrice Gasnier 2021-03-22 16:24 ` Fabrice Gasnier 2021-03-19 11:00 ` [PATCH v10 18/33] counter: Return error code on invalid modes William Breathitt Gray 2021-03-19 11:00 ` William Breathitt Gray 2021-03-22 16:26 ` [Linux-stm32] " Fabrice Gasnier 2021-03-22 16:26 ` Fabrice Gasnier 2021-04-15 15:19 ` Syed Nayyar Waris 2021-04-15 15:19 ` Syed Nayyar Waris 2021-03-19 11:00 ` [PATCH v10 19/33] counter: Standardize to ERANGE for limit exceeded errors William Breathitt Gray 2021-03-19 11:00 ` William Breathitt Gray 2021-03-22 16:29 ` [Linux-stm32] " Fabrice Gasnier 2021-03-22 16:29 ` Fabrice Gasnier 2021-04-15 15:20 ` Syed Nayyar Waris 2021-04-15 15:20 ` Syed Nayyar Waris 2021-03-19 11:00 ` [PATCH v10 20/33] counter: Rename counter_signal_value to counter_signal_level William Breathitt Gray 2021-03-19 11:00 ` William Breathitt Gray 2021-04-15 15:21 ` Syed Nayyar Waris 2021-04-15 15:21 ` Syed Nayyar Waris 2021-03-19 11:00 ` [PATCH v10 21/33] counter: Rename counter_count_function to counter_function William Breathitt Gray 2021-03-19 11:00 ` William Breathitt Gray 2021-03-22 16:31 ` [Linux-stm32] " Fabrice Gasnier 2021-03-22 16:31 ` Fabrice Gasnier 2021-04-15 15:22 ` Syed Nayyar Waris 2021-04-15 15:22 ` Syed Nayyar Waris 2021-03-19 11:00 ` [PATCH v10 22/33] counter: Internalize sysfs interface code William Breathitt Gray 2021-03-22 16:44 ` [Linux-stm32] " Fabrice Gasnier 2021-03-22 16:44 ` Fabrice Gasnier 2021-03-23 9:17 ` William Breathitt Gray 2021-03-23 9:17 ` William Breathitt Gray 2021-03-19 11:00 ` [PATCH v10 23/33] counter: Update counter.h comments to reflect sysfs internalization William Breathitt Gray 2021-03-19 11:00 ` William Breathitt Gray 2021-03-19 11:00 ` [PATCH v10 24/33] docs: counter: Update " William Breathitt Gray 2021-03-19 11:00 ` William Breathitt Gray 2021-03-19 11:00 ` [PATCH v10 25/33] counter: Move counter enums to uapi header William Breathitt Gray 2021-03-19 11:00 ` William Breathitt Gray 2021-03-19 11:00 ` [PATCH v10 26/33] counter: Add character device interface William Breathitt Gray 2021-03-19 11:00 ` William Breathitt Gray 2021-03-19 11:00 ` [PATCH v10 27/33] docs: counter: Document " William Breathitt Gray 2021-03-19 11:00 ` William Breathitt Gray 2021-03-19 11:00 ` [PATCH v10 28/33] tools/counter: Create Counter tools William Breathitt Gray 2021-03-19 11:00 ` William Breathitt Gray 2021-03-19 11:00 ` [PATCH v10 29/33] counter: Implement signalZ_action_component_id sysfs attribute William Breathitt Gray 2021-03-19 11:00 ` William Breathitt Gray 2021-03-19 11:00 ` [PATCH v10 30/33] counter: Implement *_component_id sysfs attributes William Breathitt Gray 2021-03-19 11:00 ` William Breathitt Gray 2021-03-19 11:00 ` [PATCH v10 31/33] counter: Implement events_queue_size sysfs attribute William Breathitt Gray 2021-03-19 11:00 ` William Breathitt Gray 2021-03-19 11:00 ` [PATCH v10 32/33] counter: 104-quad-8: Replace mutex with spinlock William Breathitt Gray 2021-03-19 11:00 ` William Breathitt Gray 2021-04-15 15:24 ` Syed Nayyar Waris 2021-04-15 15:24 ` Syed Nayyar Waris 2021-03-19 11:00 ` [PATCH v10 33/33] counter: 104-quad-8: Add IRQ support for the ACCES 104-QUAD-8 William Breathitt Gray 2021-03-19 11:00 ` William Breathitt Gray 2021-04-15 15:25 ` Syed Nayyar Waris 2021-04-15 15:25 ` Syed Nayyar Waris
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=203f1b6084ed86a6696eb422bcadc0955c6427bb.1616150619.git.vilhelm.gray@gmail.com \ --to=vilhelm.gray@gmail.com \ --cc=a.fatoum@pengutronix.de \ --cc=alexandre.belloni@bootlin.com \ --cc=alexandre.torgue@st.com \ --cc=david@lechnology.com \ --cc=fabrice.gasnier@st.com \ --cc=gwendal@chromium.org \ --cc=jic23@kernel.org \ --cc=kamel.bouhara@bootlin.com \ --cc=kernel@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-iio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-stm32@st-md-mailman.stormreply.com \ --cc=mcoquelin.stm32@gmail.com \ --cc=o.rempel@pengutronix.de \ --cc=patrick.havelange@essensium.com \ --cc=syednwaris@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.