All of lore.kernel.org
 help / color / mirror / Atom feed
From: Len Brown <lenb@kernel.org>
To: linux-pm@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Len Brown <len.brown@intel.com>,
	linux-sh@vger.kernel.org
Subject: [PATCH 03/16] sh idle: rename global pm_idle to static sh_idle
Date: Sun, 10 Feb 2013 05:58:10 +0000	[thread overview]
Message-ID: <298823d45d644cb8aab67e59f0be0ebeeaf42039.1360475150.git.len.brown@intel.com> (raw)
In-Reply-To: <1360475903-30007-1-git-send-email-lenb@kernel.org>

From: Len Brown <len.brown@intel.com>

SH idle code could use some simplification.
This patch enables that by guaranteeing
that "sh_idle" is local, and thus architecture specific.

Signed-off-by: Len Brown <len.brown@intel.com>
Cc: linux-sh@vger.kernel.org
---
 arch/sh/kernel/idle.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/sh/kernel/idle.c b/arch/sh/kernel/idle.c
index 0c91016..3d5a1b3 100644
--- a/arch/sh/kernel/idle.c
+++ b/arch/sh/kernel/idle.c
@@ -22,7 +22,7 @@
 #include <asm/smp.h>
 #include <asm/bl_bit.h>
 
-void (*pm_idle)(void);
+static void (*sh_idle)(void);
 
 static int hlt_counter;
 
@@ -103,9 +103,9 @@ void cpu_idle(void)
 			/* Don't trace irqs off for idle */
 			stop_critical_timings();
 			if (cpuidle_idle_call())
-				pm_idle();
+				sh_idle();
 			/*
-			 * Sanity check to ensure that pm_idle() returns
+			 * Sanity check to ensure that sh_idle() returns
 			 * with IRQs enabled
 			 */
 			WARN_ON(irqs_disabled());
@@ -123,13 +123,13 @@ void __init select_idle_routine(void)
 	/*
 	 * If a platform has set its own idle routine, leave it alone.
 	 */
-	if (pm_idle)
+	if (sh_idle)
 		return;
 
 	if (hlt_works())
-		pm_idle = default_idle;
+		sh_idle = default_idle;
 	else
-		pm_idle = poll_idle;
+		sh_idle = poll_idle;
 }
 
 void stop_this_cpu(void *unused)
-- 
1.8.1.3.535.ga923c31


WARNING: multiple messages have this Message-ID (diff)
From: Len Brown <lenb@kernel.org>
To: linux-pm@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Len Brown <len.brown@intel.com>,
	linux-sh@vger.kernel.org
Subject: [PATCH 03/16] sh idle: rename global pm_idle to static sh_idle
Date: Sun, 10 Feb 2013 00:58:10 -0500	[thread overview]
Message-ID: <298823d45d644cb8aab67e59f0be0ebeeaf42039.1360475150.git.len.brown@intel.com> (raw)
In-Reply-To: <1360475903-30007-1-git-send-email-lenb@kernel.org>
In-Reply-To: <2b219d07e0f287c2c713f5465fc8646158fa986e.1360475150.git.len.brown@intel.com>

From: Len Brown <len.brown@intel.com>

SH idle code could use some simplification.
This patch enables that by guaranteeing
that "sh_idle" is local, and thus architecture specific.

Signed-off-by: Len Brown <len.brown@intel.com>
Cc: linux-sh@vger.kernel.org
---
 arch/sh/kernel/idle.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/sh/kernel/idle.c b/arch/sh/kernel/idle.c
index 0c91016..3d5a1b3 100644
--- a/arch/sh/kernel/idle.c
+++ b/arch/sh/kernel/idle.c
@@ -22,7 +22,7 @@
 #include <asm/smp.h>
 #include <asm/bl_bit.h>
 
-void (*pm_idle)(void);
+static void (*sh_idle)(void);
 
 static int hlt_counter;
 
@@ -103,9 +103,9 @@ void cpu_idle(void)
 			/* Don't trace irqs off for idle */
 			stop_critical_timings();
 			if (cpuidle_idle_call())
-				pm_idle();
+				sh_idle();
 			/*
-			 * Sanity check to ensure that pm_idle() returns
+			 * Sanity check to ensure that sh_idle() returns
 			 * with IRQs enabled
 			 */
 			WARN_ON(irqs_disabled());
@@ -123,13 +123,13 @@ void __init select_idle_routine(void)
 	/*
 	 * If a platform has set its own idle routine, leave it alone.
 	 */
-	if (pm_idle)
+	if (sh_idle)
 		return;
 
 	if (hlt_works())
-		pm_idle = default_idle;
+		sh_idle = default_idle;
 	else
-		pm_idle = poll_idle;
+		sh_idle = poll_idle;
 }
 
 void stop_this_cpu(void *unused)
-- 
1.8.1.3.535.ga923c31


  parent reply	other threads:[~2013-02-10  5:58 UTC|newest]

Thread overview: 67+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-10  5:58 pm_idle cleanup patch series Len Brown
2013-02-10  5:58 ` [PATCH 01/16] APM idle: register apm_cpu_idle via cpuidle Len Brown
2013-02-10  5:58   ` [PATCH 02/16] x86 idle: rename global pm_idle to static x86_idle Len Brown
2013-02-10  5:58   ` [PATCH 04/16] sparc idle: rename pm_idle to sparc_idle Len Brown
2013-02-10  5:58     ` Len Brown
2013-02-10 23:08     ` David Miller
2013-02-10 23:08       ` David Miller
2013-02-10  5:58   ` [PATCH 05/16] blackfin idle: delete pm_idle Len Brown
2013-02-18 16:28     ` Lars-Peter Clausen
2013-02-20 17:53       ` Len Brown
2013-02-20 19:52       ` Rafael J. Wysocki
2013-02-20 19:53         ` Lars-Peter Clausen
2013-02-20 19:59           ` Rafael J. Wysocki
2013-02-20 20:21             ` Lars-Peter Clausen
2013-02-20 21:18               ` Rafael J. Wysocki
2013-02-21  9:56                 ` [PATCH] blackfin idle: Fix compile error Lars-Peter Clausen
2013-02-21 16:24                   ` Rafael J. Wysocki
2013-02-10  5:58   ` [PATCH 06/16] ARM idle: delete pm_idle Len Brown
2013-02-10  5:58     ` Len Brown
2013-02-10  5:58     ` Len Brown
2013-02-11 16:02     ` Catalin Marinas
2013-02-11 16:02       ` Catalin Marinas
2013-02-11 16:02       ` Catalin Marinas
2013-02-11 16:11       ` Russell King - ARM Linux
2013-02-11 16:11         ` Russell King - ARM Linux
2013-02-11 16:11         ` Russell King - ARM Linux
2013-02-11 22:42         ` Len Brown
2013-02-11 22:42           ` Len Brown
2013-02-11 22:42           ` Len Brown
2013-02-12 22:04     ` Kevin Hilman
2013-02-12 22:04       ` Kevin Hilman
2013-02-10  5:58   ` [PATCH 07/16] ARM64 " Len Brown
2013-02-10  5:58     ` Len Brown
2013-02-12 11:03     ` Catalin Marinas
2013-02-12 11:03       ` Catalin Marinas
2013-02-12 11:03       ` Catalin Marinas
2013-02-10  5:58   ` [PATCH 08/16] cris idle: delete idle and pm_idle Len Brown
2013-02-11  8:42     ` Jesper Nilsson
2013-02-10  5:58   ` [PATCH 09/16] ia64 idle: delete pm_idle Len Brown
2013-02-10  5:58     ` Len Brown
2013-02-21 10:15     ` Lars-Peter Clausen
2013-02-21 10:15       ` Lars-Peter Clausen
2013-03-26  3:12       ` Brown, Len
2013-03-26  4:29         ` [PATCH] ia64 idle: delete (*idle)() Len Brown
2013-03-26  4:29           ` Len Brown
2013-02-10  5:58   ` [PATCH 10/16] m32r idle: delete pm_idle, and other dead idle code Len Brown
2013-02-10  5:58   ` [PATCH 11/16] microblaze idle: delete pm_idle Len Brown
2013-02-21 10:15     ` [PATCH] microblaze idle: Fix compile error Lars-Peter Clausen
2013-02-21 16:25       ` Rafael J. Wysocki
2013-02-10  5:58   ` [PATCH 12/16] mn10300 idle: delete pm_idle Len Brown
2013-02-10  5:58   ` [PATCH 13/16] openrisc " Len Brown
2013-02-10  5:58     ` Len Brown
2013-02-10 17:31     ` [ORLinux] " Jonas Bonn
2013-02-10 17:31       ` Jonas Bonn
2013-02-10  5:58   ` [PATCH 14/16] unicore32 idle: delete stray pm_idle comment Len Brown
2013-02-10  5:58   ` [PATCH 15/16] PM idle: remove global declaration of pm_idle Len Brown
2013-02-10  5:58   ` [PATCH 16/16] xen idle: make xen-specific macro xen-specific Len Brown
2013-02-11  9:18   ` [PATCH 01/16] APM idle: register apm_cpu_idle via cpuidle Daniel Lezcano
2013-02-11 22:50     ` Len Brown
2013-02-11 23:03     ` APM: Request to Test Len Brown
2013-02-11 23:03       ` [PATCH v2] APM idle: register apm_cpu_idle via cpuidle Len Brown
2013-02-12 15:00         ` Daniel Lezcano
2013-02-12 15:00           ` Daniel Lezcano
2013-02-18 13:30         ` Jiri Kosina
2013-02-20 17:48           ` Len Brown
2013-02-10  5:58 ` Len Brown [this message]
2013-02-10  5:58   ` [PATCH 03/16] sh idle: rename global pm_idle to static sh_idle Len Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=298823d45d644cb8aab67e59f0be0ebeeaf42039.1360475150.git.len.brown@intel.com \
    --to=lenb@kernel.org \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.